HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26796 )
Change subject: src: include <assert.h> when appropriate
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/26796/7/src/soc/intel/apollolake/acpi.c
File src/soc/intel/apollolake/acpi.c:
https://review.coreboot.org/#/c/26796/7/src/soc/intel/apollolake/acpi.c@291
PS7, Line 291: assert
<assert.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/26796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Gerrit-Change-Number: 26796
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Mar 2019 16:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26796 )
Change subject: src: include <assert.h> when appropriate
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/26796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Gerrit-Change-Number: 26796
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 29 Mar 2019 16:14:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Mike Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32115
Change subject: mb/google/sarien: Make bluetooth reset_gpio active low
......................................................................
mb/google/sarien: Make bluetooth reset_gpio active low
Follow b:129375810 to set bluetooth reset_gpio as ACPI_GPIO_OUTPUT_ACTIVE_LOW
BUG=b:129375810
TEST=Verified BT function on Arcada DVT1 system.
Signed-off-by: Mike Hsieh <mike_hsieh(a)wistron.corp-partner.google.com>
Change-Id: I816eb2a76f642a2bb1702f38138bce7916334011
---
M src/mainboard/google/sarien/variants/arcada/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/32115/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb
index 6f167c2..a09d7cb 100644
--- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb
+++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb
@@ -261,7 +261,7 @@
chip drivers/usb/acpi
register "desc" = ""Bluetooth""
register "type" = "UPC_TYPE_INTERNAL"
- register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H15)"
+ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H15)"
device usb 2.9 on end
end
chip drivers/usb/acpi
--
To view, visit https://review.coreboot.org/c/coreboot/+/32115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I816eb2a76f642a2bb1702f38138bce7916334011
Gerrit-Change-Number: 32115
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Hsieh <mike_hsieh(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newchange
Hello Patrick Rudolph, Aaron Durbin, Julius Werner, Huang Jin, York Yang, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29301
to look at the new patch set (#14).
Change subject: src: Use include <reset.h> when appropriate
......................................................................
src: Use include <reset.h> when appropriate
Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/x86/cf9_reset.c
M src/cpu/amd/family_10h-family_15h/init_cpus.h
M src/cpu/intel/fsp_model_406dx/bootblock.c
M src/drivers/intel/fsp2_0/stage_cache.c
M src/ec/google/chromeec/ec.c
M src/lib/hardwaremain.c
M src/mainboard/google/foster/pmic.c
M src/mainboard/google/smaug/pmic.c
M src/mainboard/google/veyron/bootblock.c
M src/mainboard/google/veyron_mickey/bootblock.c
M src/mainboard/google/veyron_rialto/bootblock.c
M src/security/tpm/tspi/tspi.c
M src/security/vboot/common.c
M src/soc/cavium/common/bdk-coreboot.c
M src/soc/intel/braswell/romstage/romstage.c
M src/soc/intel/common/block/cpu/cpulib.c
M src/soc/intel/fsp_baytrail/bootblock/bootblock.c
M src/soc/intel/skylake/romstage/romstage.c
M src/southbridge/amd/agesa/hudson/early_setup.c
M src/southbridge/amd/pi/hudson/early_setup.c
M src/southbridge/amd/sb700/early_setup.c
M src/southbridge/nvidia/ck804/early_setup_car.c
22 files changed, 7 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/29301/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/29301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b852cae4ef84d257bf1e5486447583bdd16b441
Gerrit-Change-Number: 29301
Gerrit-PatchSet: 14
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: York Yang <yyang024(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newpatchset