Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31928 )
Change subject: soc/intel/cannonlake: enable VMX support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c
File src/soc/intel/cannonlake/cpu.c:
https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c@410
PS4, Line 410: VmxEnable is set and VtdDisable
> It will not configure Vmx as per CB:25118 Vmx should be disabled if Vtd Disabled is set.
I asked there, too and didn't get an answer so far. Why disable VT-x
if VT-d is disabled? Usually those work independently.
Also, why would we want to disable VT-d at all?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33dbffa6301afabd688080751ba3b85a43e00156
Gerrit-Change-Number: 31928
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Fri, 29 Mar 2019 17:25:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ronak Kanabar <ronak.kanabar(a)intel.com>
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: comment
Hello Patrick Rudolph, Aaron Durbin, Felix Held, Vanny E, Julius Werner, Philipp Deppenwiese, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/26796
to look at the new patch set (#10).
Change subject: src: include <assert.h> when appropriate
......................................................................
src: include <assert.h> when appropriate
Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/arm64/arm_tf.c
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/commonlib/storage/pci_sdhci.c
M src/commonlib/storage/sd.c
M src/commonlib/storage/sd_mmc.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
M src/commonlib/storage/storage.c
M src/cpu/intel/hyperthreading/intel_sibling.c
M src/cpu/intel/model_206ax/model_206ax_init.c
M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
M src/drivers/spi/winbond.c
M src/lib/gpio.c
M src/mainboard/google/dragonegg/romstage_fsp_params.c
M src/mainboard/intel/galileo/vboot.c
M src/northbridge/amd/pi/00630F01/northbridge.c
M src/security/vboot/vbnv_flash.c
M src/soc/cavium/cn81xx/ecam0.c
M src/soc/cavium/cn81xx/twsi.c
M src/soc/cavium/common/ecam.c
M src/soc/intel/apollolake/acpi.c
M src/soc/intel/apollolake/gpio_apl.c
M src/soc/intel/apollolake/gpio_glk.c
M src/soc/intel/apollolake/uart.c
M src/soc/intel/cannonlake/romstage/romstage.c
M src/soc/intel/cannonlake/uart.c
M src/soc/intel/common/block/sgx/sgx.c
M src/soc/intel/common/block/uart/uart.c
M src/soc/intel/denverton_ns/gpio.c
M src/soc/intel/icelake/romstage/romstage.c
M src/soc/intel/icelake/uart.c
M src/soc/intel/quark/spi.c
M src/soc/intel/skylake/cpu.c
M src/soc/intel/skylake/gpio.c
M src/soc/mediatek/common/include/soc/rtc_common.h
M src/soc/mediatek/common/pmic_wrap.c
M src/soc/mediatek/mt8173/dramc_pi_calibration_api.c
M src/soc/mediatek/mt8173/emi.c
M src/soc/mediatek/mt8173/pmic_wrap.c
M src/soc/mediatek/mt8183/mt6358.c
M src/soc/qualcomm/ipq40xx/i2c.c
M src/soc/qualcomm/ipq806x/i2c.c
M src/soc/rockchip/common/edp.c
M src/soc/rockchip/common/pwm.c
M src/soc/rockchip/rk3288/hdmi.c
M src/soc/rockchip/rk3288/tsadc.c
M src/soc/rockchip/rk3399/bl31_plat_params.c
M src/soc/rockchip/rk3399/mipi.c
M src/soc/rockchip/rk3399/tsadc.c
M src/soc/samsung/exynos5250/alternate_cbfs.c
M src/soc/samsung/exynos5250/pinmux.c
M src/soc/samsung/exynos5420/alternate_cbfs.c
M src/soc/samsung/exynos5420/pinmux.c
M src/superio/renesas/m3885x/superio.c
M src/superio/smsc/lpc47n227/early_serial.c
56 files changed, 4 insertions(+), 53 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/26796/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/26796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Gerrit-Change-Number: 26796
Gerrit-PatchSet: 10
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Aaron Durbin, Felix Held, Vanny E, Julius Werner, Philipp Deppenwiese, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/26796
to look at the new patch set (#9).
Change subject: src: include <assert.h> when appropriate
......................................................................
src: include <assert.h> when appropriate
Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/arm64/arm_tf.c
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/commonlib/storage/pci_sdhci.c
M src/commonlib/storage/sd.c
M src/commonlib/storage/sd_mmc.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
M src/commonlib/storage/storage.c
M src/cpu/intel/hyperthreading/intel_sibling.c
M src/cpu/intel/model_206ax/model_206ax_init.c
M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
M src/drivers/spi/winbond.c
M src/lib/gpio.c
M src/mainboard/google/dragonegg/romstage_fsp_params.c
M src/mainboard/intel/galileo/vboot.c
M src/northbridge/amd/pi/00630F01/northbridge.c
M src/security/vboot/vbnv_flash.c
M src/soc/cavium/cn81xx/ecam0.c
M src/soc/cavium/cn81xx/twsi.c
M src/soc/cavium/common/ecam.c
M src/soc/intel/apollolake/acpi.c
M src/soc/intel/apollolake/gpio_apl.c
M src/soc/intel/apollolake/gpio_glk.c
M src/soc/intel/apollolake/uart.c
M src/soc/intel/cannonlake/romstage/romstage.c
M src/soc/intel/cannonlake/uart.c
M src/soc/intel/common/block/sgx/sgx.c
M src/soc/intel/common/block/uart/uart.c
M src/soc/intel/denverton_ns/gpio.c
M src/soc/intel/icelake/romstage/romstage.c
M src/soc/intel/icelake/uart.c
M src/soc/intel/quark/spi.c
M src/soc/intel/skylake/cpu.c
M src/soc/intel/skylake/gpio.c
M src/soc/mediatek/common/include/soc/rtc_common.h
M src/soc/mediatek/common/pmic_wrap.c
M src/soc/mediatek/mt8173/dramc_pi_calibration_api.c
M src/soc/mediatek/mt8173/emi.c
M src/soc/mediatek/mt8173/pmic_wrap.c
M src/soc/mediatek/mt8183/mt6358.c
M src/soc/qualcomm/ipq40xx/i2c.c
M src/soc/qualcomm/ipq806x/i2c.c
M src/soc/rockchip/common/edp.c
M src/soc/rockchip/common/pwm.c
M src/soc/rockchip/rk3288/hdmi.c
M src/soc/rockchip/rk3288/tsadc.c
M src/soc/rockchip/rk3399/bl31_plat_params.c
M src/soc/rockchip/rk3399/mipi.c
M src/soc/rockchip/rk3399/tsadc.c
M src/soc/samsung/exynos5250/alternate_cbfs.c
M src/soc/samsung/exynos5250/pinmux.c
M src/soc/samsung/exynos5420/alternate_cbfs.c
M src/soc/samsung/exynos5420/pinmux.c
M src/superio/renesas/m3885x/superio.c
M src/superio/smsc/lpc47n227/early_serial.c
56 files changed, 4 insertions(+), 53 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/26796/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/26796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Gerrit-Change-Number: 26796
Gerrit-PatchSet: 9
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Aaron Durbin, Felix Held, Vanny E, Julius Werner, Philipp Deppenwiese, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/26796
to look at the new patch set (#8).
Change subject: src: include <assert.h> when appropriate
......................................................................
src: include <assert.h> when appropriate
Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/arm64/arm_tf.c
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpigen.h
M src/commonlib/storage/pci_sdhci.c
M src/commonlib/storage/sd.c
M src/commonlib/storage/sd_mmc.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
M src/commonlib/storage/storage.c
M src/cpu/intel/hyperthreading/intel_sibling.c
M src/cpu/intel/model_206ax/model_206ax_init.c
M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
M src/drivers/spi/spi-generic.c
M src/drivers/spi/tpm/tpm.c
M src/drivers/spi/winbond.c
M src/lib/gpio.c
M src/mainboard/google/dragonegg/romstage_fsp_params.c
M src/mainboard/intel/galileo/vboot.c
M src/northbridge/amd/pi/00630F01/northbridge.c
M src/security/vboot/vbnv_flash.c
M src/soc/cavium/cn81xx/ecam0.c
M src/soc/cavium/cn81xx/twsi.c
M src/soc/cavium/common/bdk-coreboot.c
M src/soc/cavium/common/ecam.c
M src/soc/intel/apollolake/acpi.c
M src/soc/intel/apollolake/gpio_apl.c
M src/soc/intel/apollolake/gpio_glk.c
M src/soc/intel/apollolake/uart.c
M src/soc/intel/cannonlake/romstage/romstage.c
M src/soc/intel/cannonlake/uart.c
M src/soc/intel/common/block/sgx/sgx.c
M src/soc/intel/common/block/uart/uart.c
M src/soc/intel/denverton_ns/gpio.c
M src/soc/intel/icelake/romstage/romstage.c
M src/soc/intel/icelake/uart.c
M src/soc/intel/quark/spi.c
M src/soc/intel/skylake/cpu.c
M src/soc/intel/skylake/gpio.c
M src/soc/mediatek/common/include/soc/rtc_common.h
M src/soc/mediatek/common/pmic_wrap.c
M src/soc/mediatek/mt8173/dramc_pi_calibration_api.c
M src/soc/mediatek/mt8173/emi.c
M src/soc/mediatek/mt8173/pmic_wrap.c
M src/soc/mediatek/mt8183/mt6358.c
M src/soc/qualcomm/ipq40xx/i2c.c
M src/soc/qualcomm/ipq806x/i2c.c
M src/soc/rockchip/common/edp.c
M src/soc/rockchip/common/pwm.c
M src/soc/rockchip/rk3288/hdmi.c
M src/soc/rockchip/rk3288/tsadc.c
M src/soc/rockchip/rk3399/bl31_plat_params.c
M src/soc/rockchip/rk3399/mipi.c
M src/soc/rockchip/rk3399/tsadc.c
M src/soc/samsung/exynos5250/alternate_cbfs.c
M src/soc/samsung/exynos5250/pinmux.c
M src/soc/samsung/exynos5420/alternate_cbfs.c
M src/soc/samsung/exynos5420/pinmux.c
M src/superio/renesas/m3885x/superio.c
M src/superio/smsc/lpc47n227/early_serial.c
59 files changed, 4 insertions(+), 56 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/26796/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/26796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a
Gerrit-Change-Number: 26796
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset