Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27496 )
Change subject: sb/amd/cimx/sb800: Get rid of power button device in coreboot
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/27496/4/3rdparty/vboot
File 3rdparty/vboot:
https://review.coreboot.org/#/c/27496/4/3rdparty/vboot@1
PS4, Line 1: a32c930e8c46424a3bba3c296fd78b3e60f50aeb
It seems the uprev of vboot should not be part of this patch?
--
To view, visit https://review.coreboot.org/c/coreboot/+/27496
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0cbecb72f7e1bf3d051d3b7656c6af4d6f43b497
Gerrit-Change-Number: 27496
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 04 Mar 2019 05:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29969 )
Change subject: qcs405: memlayout: Make bootblock 64k aligned
......................................................................
Patch Set 13:
> Patch Set 13:
>
> (1 comment)
Hi Julius,
The difference here from SDM845 is, in case of SDM845 the PBL, QC-SEC, COREBOOT all are 64 bit. But in case of QCS405, PBL , QC-SEC are 32 bit. So the QC-SEC is indeed taking care of jumping from 32bit to 64bit with the RMR instruction. The problem is after the jump from 32<->64bit context, bootblock start address gets mapped to 0x0 by the boot remapper hardware. Since the above bootlblock instructions by default use relative addressing things do not work. So the above change it to use absolute jump to set the PC value correctly
--
To view, visit https://review.coreboot.org/c/coreboot/+/29969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1599242bb5158477318867508c72dc14f1244b00
Gerrit-Change-Number: 29969
Gerrit-PatchSet: 13
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nsekar(a)codeaurora.org
Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 05:04:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Paul Menzel, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/28640
to look at the new patch set (#89).
Change subject: mb/clevo/kbl-u: Add mainboard
......................................................................
mb/clevo/kbl-u: Add mainboard
Devices:
- N130WU / N131WU
Working:
- Compiling
- Seabios, iPXE
- NVMe, SATA3, booting from SSD into Arch Linux
- USB2, USB3
- Thunderbolt
- Graphics, mDP, HDMI
- Sound
- Webcam
- WLAN, LAN, Bluetooth, LTE
- Keyboard, touchpad
- TPM
- Virtualization
- flashrom support; reading / flashing from Linux
Works, but needs testing:
- Nothing
WIP:
- Documentation
Not working:
- EC ACPI
Untested:
- Nothing
Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513
Signed-off-by: Felix Singer <migy(a)darmstadt.ccc.de>
---
A Documentation/mainboard/clevo/index.md
A Documentation/mainboard/clevo/n130wu/index.md
A Documentation/mainboard/clevo/n130wu/n130wu_overview.jpg
M Documentation/mainboard/index.md
A src/mainboard/clevo/Kconfig
A src/mainboard/clevo/Kconfig.name
A src/mainboard/clevo/kbl-u/Kconfig
A src/mainboard/clevo/kbl-u/Kconfig.name
A src/mainboard/clevo/kbl-u/Makefile.inc
A src/mainboard/clevo/kbl-u/acpi/ec.asl
A src/mainboard/clevo/kbl-u/acpi/superio.asl
A src/mainboard/clevo/kbl-u/acpi_tables.c
A src/mainboard/clevo/kbl-u/board_info.txt
A src/mainboard/clevo/kbl-u/dsdt.asl
A src/mainboard/clevo/kbl-u/gpio.h
A src/mainboard/clevo/kbl-u/hda_verb.c
A src/mainboard/clevo/kbl-u/pei_data.c
A src/mainboard/clevo/kbl-u/pei_data.h
A src/mainboard/clevo/kbl-u/ramstage.c
A src/mainboard/clevo/kbl-u/romstage.c
A src/mainboard/clevo/kbl-u/variants/n13xwu/data.vbt
A src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb
22 files changed, 1,283 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/28640/89
--
To view, visit https://review.coreboot.org/c/coreboot/+/28640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513
Gerrit-Change-Number: 28640
Gerrit-PatchSet: 89
Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de>
Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: Shaleen jain <shaleen(a)jain.sh>
Gerrit-MessageType: newpatchset
Hello Paul Menzel, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/28640
to look at the new patch set (#88).
Change subject: mb/clevo/kbl-u: Add mainboard
......................................................................
mb/clevo/kbl-u: Add mainboard
Devices:
- N130WU / N131WU
Working:
- Compiling
- Seabios, iPXE
- NVMe, SATA3, booting from SSD into Arch Linux
- USB2, USB3
- Thunderbolt
- Graphics, mDP, HDMI
- Sound
- Webcam
- WLAN, LAN, Bluetooth, LTE
- Keyboard, touchpad
- TPM
- Virtualization
- flashrom support; reading / flashing from Linux
Works, but needs testing:
- Nothing
WIP:
- Documentation
Not working:
- EC ACPI
Untested:
- Nothing
Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513
Signed-off-by: Felix Singer <migy(a)darmstadt.ccc.de>
---
A Documentation/mainboard/clevo/index.md
A Documentation/mainboard/clevo/n130wu/index.md
A Documentation/mainboard/clevo/n130wu/n130wu_overview.jpg
M Documentation/mainboard/index.md
A src/mainboard/clevo/Kconfig
A src/mainboard/clevo/Kconfig.name
A src/mainboard/clevo/kbl-u/Kconfig
A src/mainboard/clevo/kbl-u/Kconfig.name
A src/mainboard/clevo/kbl-u/Makefile.inc
A src/mainboard/clevo/kbl-u/acpi/ec.asl
A src/mainboard/clevo/kbl-u/acpi/superio.asl
A src/mainboard/clevo/kbl-u/acpi_tables.c
A src/mainboard/clevo/kbl-u/board_info.txt
A src/mainboard/clevo/kbl-u/dsdt.asl
A src/mainboard/clevo/kbl-u/gpio.h
A src/mainboard/clevo/kbl-u/hda_verb.c
A src/mainboard/clevo/kbl-u/pei_data.c
A src/mainboard/clevo/kbl-u/pei_data.h
A src/mainboard/clevo/kbl-u/ramstage.c
A src/mainboard/clevo/kbl-u/romstage.c
A src/mainboard/clevo/kbl-u/variants/n13xwu/data.vbt
A src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb
22 files changed, 1,285 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/28640/88
--
To view, visit https://review.coreboot.org/c/coreboot/+/28640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513
Gerrit-Change-Number: 28640
Gerrit-PatchSet: 88
Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de>
Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-CC: Shaleen jain <shaleen(a)jain.sh>
Gerrit-MessageType: newpatchset
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29897 )
Change subject: util/inteltool: Add Apollo Lake GPIO groups and names
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/29897
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cd687fdc1d2ae81f2e948178bf319897b47f031
Gerrit-Change-Number: 29897
Gerrit-PatchSet: 9
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Sun, 03 Mar 2019 19:15:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31701
to look at the new patch set (#7).
Change subject: arch/x86/acpi: Remove obsolete acpi_gen_regaddr resv field
......................................................................
arch/x86/acpi: Remove obsolete acpi_gen_regaddr resv field
Since ACPI v2.c, this field is access_size.
Currently, coreboot is using ACPI v3,so we can drop '.resv' field.
Change-Id: I7b3b930861669bb05cdc8e81f6502476a0568fe0
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpi.h
M src/cpu/amd/family_10h-family_15h/powernow_acpi.c
M src/cpu/intel/common/common_init.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/intel/model_206ax/model_206ax_init.c
M src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
M src/mainboard/amd/torpedo/fadt.c
M src/mainboard/aopen/dxplplusu/fadt.c
M src/mainboard/apple/macbook21/mainboard.c
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/mainboard/getac/p470/cstates.c
M src/mainboard/lenovo/t400/cstates.c
M src/mainboard/lenovo/t400/fadt.c
M src/mainboard/lenovo/t60/mainboard.c
M src/mainboard/lenovo/x200/cstates.c
M src/mainboard/lenovo/x200/fadt.c
M src/mainboard/lenovo/x201/mainboard.c
M src/mainboard/lenovo/x60/mainboard.c
M src/mainboard/lenovo/z61t/mainboard.c
M src/mainboard/packardbell/ms2290/mainboard.c
M src/mainboard/roda/rk9/cstates.c
M src/mainboard/roda/rk9/fadt.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/cannonlake/acpi.c
M src/soc/intel/icelake/acpi.c
M src/soc/intel/skylake/acpi.c
M src/southbridge/amd/sb700/fadt.c
M src/southbridge/amd/sb800/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/nvidia/ck804/fadt.c
M src/southbridge/nvidia/mcp55/fadt.c
34 files changed, 196 insertions(+), 211 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/31701/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/31701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b3b930861669bb05cdc8e81f6502476a0568fe0
Gerrit-Change-Number: 31701
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Felix Singer has uploaded a new patch set (#9) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/29897 )
Change subject: util/inteltool: Add Apollo Lake GPIO groups and names
......................................................................
util/inteltool: Add Apollo Lake GPIO groups and names
Apollo Lake has four GPIO communities each with a single group named
after the physical location of the pads (I guess): North West, North,
West and South West.
Also add some logic to be able to tag the default function of a pad
(with an asterisk before its name). This seems easier to review in the
tables, but we could also encode the number of the default explicitly
instead.
Used Intel documents:
- 334817-001 (datasheet vol. 1)
- 334819-001 (datasheet vol. 3)
Change-Id: I5cd687fdc1d2ae81f2e948178bf319897b47f031
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
Signed-off-by: Felix Singer <migy(a)darmstadt.ccc.de>
---
M util/inteltool/gpio.c
M util/inteltool/gpio_groups.c
2 files changed, 354 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/29897/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/29897
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cd687fdc1d2ae81f2e948178bf319897b47f031
Gerrit-Change-Number: 29897
Gerrit-PatchSet: 9
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31701
to look at the new patch set (#6).
Change subject: arch/x86/acpi: Remove obsolete acpi_gen_regaddr resv field
......................................................................
arch/x86/acpi: Remove obsolete acpi_gen_regaddr resv field
Since ACPI v2.c, this field is access_size.
Currently, coreboot is using ACPI v3,so we can drop '.resv' field.
Change-Id: I7b3b930861669bb05cdc8e81f6502476a0568fe0
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/x86/acpigen.c
M src/arch/x86/include/arch/acpi.h
M src/cpu/amd/family_10h-family_15h/powernow_acpi.c
M src/cpu/intel/common/common_init.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/intel/model_206ax/model_206ax_init.c
M src/mainboard/amd/serengeti_cheetah_fam10/fadt.c
M src/mainboard/amd/torpedo/fadt.c
M src/mainboard/aopen/dxplplusu/fadt.c
M src/mainboard/apple/macbook21/mainboard.c
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/mainboard/getac/p470/cstates.c
M src/mainboard/lenovo/t400/cstates.c
M src/mainboard/lenovo/t400/fadt.c
M src/mainboard/lenovo/t60/mainboard.c
M src/mainboard/lenovo/x200/cstates.c
M src/mainboard/lenovo/x200/fadt.c
M src/mainboard/lenovo/x201/mainboard.c
M src/mainboard/lenovo/x60/mainboard.c
M src/mainboard/lenovo/z61t/mainboard.c
M src/mainboard/packardbell/ms2290/mainboard.c
M src/mainboard/roda/rk9/cstates.c
M src/mainboard/roda/rk9/fadt.c
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/cannonlake/acpi.c
M src/soc/intel/icelake/acpi.c
M src/soc/intel/skylake/acpi.c
M src/southbridge/amd/sb700/fadt.c
M src/southbridge/amd/sb800/fadt.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/nvidia/ck804/fadt.c
M src/southbridge/nvidia/mcp55/fadt.c
34 files changed, 196 insertions(+), 211 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/31701/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/31701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b3b930861669bb05cdc8e81f6502476a0568fe0
Gerrit-Change-Number: 31701
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset