Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................
Patch Set 55:
> Thanks Idwer. @Werner please check your requirements @Subrata,
> let's wait before we merge it there are some tests ongoing.
Yes @Idwer, can you please help me to know your requirements so that i can intercept the same in this CL or future CL as it required.
--
To view, visit https://review.coreboot.org/c/coreboot/+/25634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 55
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Vincent Zimmer <vincent.zimmer(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 02:41:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................
Patch Set 55:
Thanks Idwer. @Werner please check your requirements @Subrata, let's wait before we merge it there are some tests ongoing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/25634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 55
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Vincent Zimmer <vincent.zimmer(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 00:52:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................
Patch Set 55: Code-Review-1
"I've indicated my unhappiness with this direction, but it's also clear that I am not connected enough to these decisions that I should block it. I'll leave it at -1 for now and let others with more knowledge make the call. Thanks."
--
To view, visit https://review.coreboot.org/c/coreboot/+/25634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 55
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Vincent Zimmer <vincent.zimmer(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 19:03:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support
......................................................................
Patch Set 14:
> Patch Set 14:
>
> > Hi Julius,
> > So this patch is without the interface table support. Only loading the qclib blob. Will add the support for the interface table in later patches. Was planning to add all the relevant structures at that time. Hence trimmed this patch to be minimal like this. Not ok ?
>
> Well... I'm just generally not a fan of landing premature hacks. It's just taking time away from working on the actual fix. You might as well leave this floating until you can clean it up.
>
> Note that this patch also has the same problem in the Makefile as the other one I pointed out anyway. We shouldn't submit those hacks which work around valid build errors, we should rather spend our energy on getting the licensing issues worked out for good.
Ok, the interface table support is not yet added. But will add that in the coming week.
Apart from that, i have already started checking with Qualcomm internal team to solve the issue with Blobs sharing for Qcs405. Till that point, this patch and the subsequent ones that depends on blobs will anyways have to be floating though. Will try to push to get the solution ASAP.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 14
Gerrit-Owner: nsekar(a)codeaurora.org
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: nsekar(a)codeaurora.org
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 11:11:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment