Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30287 )
Change subject: soc/intel/common: Add Kconfig option to choose desired MP Init for platform
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/#/c/30287/9/src/soc/intel/common/block/cpu/Kcon…
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/#/c/30287/9/src/soc/intel/common/block/cpu/Kcon…
PS9, Line 53:
what about a kconfig menu here in order so select the MP init type?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30287
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbea463fdaf97d68c21a759c37f49492d58a056b
Gerrit-Change-Number: 30287
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 03:27:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30310 )
Change subject: drivers/intel/fsp2_0: Add support for FSP minor version update
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/30310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef95a783a08d85a7dc2987f804a931613f5524
Gerrit-Change-Number: 30310
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 03:23:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30310 )
Change subject: drivers/intel/fsp2_0: Add support for FSP minor version update
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30310/8/src/drivers/intel/fsp2_0/Kconfig
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/#/c/30310/8/src/drivers/intel/fsp2_0/Kconfig@32
PS8, Line 32: 2. FSP should support external EFI_PEI_MP_SERVICES_PPI service
> sorry, can you please help me to understand your comment.
FSP should support external PPI interface pulled in via FSP_PEIM_TO_PEIM_INTERFACE
--
To view, visit https://review.coreboot.org/c/coreboot/+/30310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef95a783a08d85a7dc2987f804a931613f5524
Gerrit-Change-Number: 30310
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 02:49:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Comment-In-Reply-To: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-MessageType: comment
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30310 )
Change subject: drivers/intel/fsp2_0: Add support for FSP minor version update
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30310/8/src/drivers/intel/fsp2_0/Kconfig
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/#/c/30310/8/src/drivers/intel/fsp2_0/Kconfig@32
PS8, Line 32: 2. FSP should support external EFI_PEI_MP_SERVICES_PPI service
> wrong kconfig name
sorry, can you please help me to understand your comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef95a783a08d85a7dc2987f804a931613f5524
Gerrit-Change-Number: 30310
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 01:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-MessageType: comment
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30307 )
Change subject: mb/google/octopus/var/ampton: Define GPIO_134 as EC_SYNC_IRQ
......................................................................
Patch Set 1:
be deprecated by 30788
--
To view, visit https://review.coreboot.org/c/coreboot/+/30307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3def37d83ef110cff86d5ae5ed32a3298b66110
Gerrit-Change-Number: 30307
Gerrit-PatchSet: 1
Gerrit-Owner: Carl Yang <carl_yang(a)asus.corp-partner.google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Carl Yang <carl_yang(a)asus.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-CC: Randy Wang <randy2_wang(a)asus.corp-partner.google.com>
Gerrit-CC: YuCheng Hung <yucheng_hung(a)asus.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 01:17:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31792
Change subject: mb/facebook/watson: Enable TPM 1.2 support
......................................................................
mb/facebook/watson: Enable TPM 1.2 support
Enable TPM 1.2 via Kconfig options and devicetree.
Change-Id: I394195b3117c8583b6b506d6ad4f5170d2f45f9f
Signed-off-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
---
M src/mainboard/facebook/watson/Kconfig
M src/mainboard/facebook/watson/devicetree.cb
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/31792/1
diff --git a/src/mainboard/facebook/watson/Kconfig b/src/mainboard/facebook/watson/Kconfig
index 00bdbea..609b14a 100644
--- a/src/mainboard/facebook/watson/Kconfig
+++ b/src/mainboard/facebook/watson/Kconfig
@@ -9,6 +9,8 @@
select INTEGRATED_UART
select SERIRQ_CONTINUOUS_MODE
select MAINBOARD_USES_IFD_GBE_REGION
+ select MAINBOARD_HAS_LPC_TPM
+ select MAINBOARD_HAS_TPM1
config MAINBOARD_DIR
string
diff --git a/src/mainboard/facebook/watson/devicetree.cb b/src/mainboard/facebook/watson/devicetree.cb
index 30d99c2..92fe9c3 100644
--- a/src/mainboard/facebook/watson/devicetree.cb
+++ b/src/mainboard/facebook/watson/devicetree.cb
@@ -7,7 +7,11 @@
device pci 14.0 on end # xHCI Controller
device pci 19.0 on end # Gigabit LAN Controller
device pci 1d.0 on end # EHCI Controller
- device pci 1f.0 on end # LPC Bridge
+ device pci 1f.0 on # LPC Bridge
+ chip drivers/pc80/tpm
+ device pnp 0c31.0 on end
+ end
+ end
device pci 1f.2 on end # SATA Controller
device pci 1f.3 on end # SMBus Controller
device pci 1f.5 on end # SATA Controller
--
To view, visit https://review.coreboot.org/c/coreboot/+/31792
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I394195b3117c8583b6b506d6ad4f5170d2f45f9f
Gerrit-Change-Number: 31792
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-MessageType: newchange
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30310 )
Change subject: drivers/intel/fsp2_0: Add support for FSP minor version update
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/30310/8/src/drivers/intel/fsp2_0/Kconfig
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/#/c/30310/8/src/drivers/intel/fsp2_0/Kconfig@32
PS8, Line 32: 2. FSP should support external EFI_PEI_MP_SERVICES_PPI service
wrong kconfig name
--
To view, visit https://review.coreboot.org/c/coreboot/+/30310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef95a783a08d85a7dc2987f804a931613f5524
Gerrit-Change-Number: 30310
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 23:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment