Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30289
to look at the new patch set (#9).
Change subject: soc/intel/common: Remove common chip config use_fsp_mp_init
......................................................................
soc/intel/common: Remove common chip config use_fsp_mp_init
This patch ensures to make use of common MP Init Kconfig to
choose desire method to peform MP initialization for platform.
Change-Id: I4ee51276026748e8daf154f89e57095e8fe50280
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/mainboard/google/dragonegg/Kconfig
M src/mainboard/intel/icelake_rvp/Kconfig
M src/mainboard/intel/saddlebrook/Kconfig
M src/mainboard/intel/saddlebrook/devicetree.cb
M src/soc/intel/apollolake/chip.c
M src/soc/intel/cannonlake/romstage/fsp_params.c
M src/soc/intel/common/block/chip/chip.c
M src/soc/intel/common/block/cpu/mp_init.c
M src/soc/intel/common/block/include/intelblocks/chip.h
M src/soc/intel/skylake/chip.c
M src/soc/intel/skylake/chip_fsp20.c
11 files changed, 27 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/30289/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/30289
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ee51276026748e8daf154f89e57095e8fe50280
Gerrit-Change-Number: 30289
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30289
to look at the new patch set (#8).
Change subject: soc/intel/common: Remove common chip config use_fsp_mp_init
......................................................................
soc/intel/common: Remove common chip config use_fsp_mp_init
This patch ensures to make use of common MP Init Kconfig to
choose desire method to peform MP initialization for platform.
Change-Id: I4ee51276026748e8daf154f89e57095e8fe50280
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/mainboard/google/dragonegg/Kconfig
M src/mainboard/intel/icelake_rvp/Kconfig
M src/mainboard/intel/saddlebrook/Kconfig
M src/mainboard/intel/saddlebrook/devicetree.cb
M src/soc/intel/apollolake/chip.c
M src/soc/intel/cannonlake/romstage/fsp_params.c
M src/soc/intel/common/block/chip/chip.c
M src/soc/intel/common/block/cpu/mp_init.c
M src/soc/intel/common/block/include/intelblocks/chip.h
M src/soc/intel/skylake/chip.c
M src/soc/intel/skylake/chip_fsp20.c
11 files changed, 27 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/30289/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/30289
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ee51276026748e8daf154f89e57095e8fe50280
Gerrit-Change-Number: 30289
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30287
to look at the new patch set (#8).
Change subject: soc/intel/common: Add Kconfig option to choose desired MP Init for platform
......................................................................
soc/intel/common: Add Kconfig option to choose desired MP Init for platform
mainboard users can select correct MP Init Kconfig in order to
perform MP initialization.
1. Native coreboot MP Init.
2. FSP to do MP Init.
3. FSP to make use of coreboot MP service PPI to make MP Init
Change-Id: Ifbea463fdaf97d68c21a759c37f49492d58a056b
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/soc/intel/common/block/cpu/Kconfig
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/30287/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/30287
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbea463fdaf97d68c21a759c37f49492d58a056b
Gerrit-Change-Number: 30287
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Aamir Bohra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30310
to look at the new patch set (#7).
Change subject: drivers/intel/fsp2_0: Add support for FSP minor version update
......................................................................
drivers/intel/fsp2_0: Add support for FSP minor version update
This patch adds support for FSP2.1 Kconfig which is backward compatible
with FSP2.0 specification and added below coreboot impacted features as below:
1. Remove FSP stack switch and use the same stack with boot firmware
2. FSP should support external EFI_PEI_MP_SERVICES_PPI service
Change-Id: I2fef95a783a08d85a7dc2987f804a931613f5524
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/drivers/intel/fsp2_0/Kconfig
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/30310/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/30310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef95a783a08d85a7dc2987f804a931613f5524
Gerrit-Change-Number: 30310
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, dhaval v sharma, Balaji Manigandan, Vincent Zimmer, Paul Menzel, build bot (Jenkins), Patrick Georgi, ron minnich, Idwer Vollering, Philipp Deppenwiese, Nico Huber, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/25634
to look at the new patch set (#53).
Change subject: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................
drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs
This patch ensures to have below listed features:
1. All required APIs to create MP service structure.
2. Function to get MP service PPI status
MP specification here:
http://github.com/tianocore/edk2/blob/master/MdePkg/Include/Ppi/MpServices.h
coreboot design document here:
../Documentation/soc/intel/icelake/MultiProcessorInit.md
Supported platform will call fill mp_services structure so that FSP can
install the required PPI based on coreboot published structure.
BRANCH=none
BUG=b:74436746
TEST=Able to publish MP service PPI in coreboot.
Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/drivers/intel/fsp2_0/Kconfig
A src/drivers/intel/fsp2_0/include/fsp/ppi/mp_service_ppi.h
A src/drivers/intel/fsp2_0/ppi/Kconfig
A src/drivers/intel/fsp2_0/ppi/Makefile.inc
A src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
5 files changed, 244 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/25634/53
--
To view, visit https://review.coreboot.org/c/coreboot/+/25634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 53
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Vincent Zimmer <vincent.zimmer(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com>
Gerrit-MessageType: newpatchset
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30310 )
Change subject: drivers/intel/fsp2_0: Add support for FSP minor version update
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/30310/6/src/drivers/intel/fsp2_0/Kconfig
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/#/c/30310/6/src/drivers/intel/fsp2_0/Kconfig@31
PS6, Line 31: 1. Remove FSP stack switch and use the same stack with bootloader
> boot firmware?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/30310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef95a783a08d85a7dc2987f804a931613f5524
Gerrit-Change-Number: 30310
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 09:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: comment
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30287 )
Change subject: soc/intel/common: Add Kconfig option to choose desired MP Init for platform
......................................................................
Patch Set 7:
> Please add Documentation:
> * There's no description which Kconfig should be used.
> * Add examples
> * Explain pro/cons of given options
i will add documentation
--
To view, visit https://review.coreboot.org/c/coreboot/+/30287
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbea463fdaf97d68c21a759c37f49492d58a056b
Gerrit-Change-Number: 30287
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 06:55:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30310 )
Change subject: drivers/intel/fsp2_0: Add support for FSP minor version update
......................................................................
Patch Set 6:
> (1 comment)
>
> Please add Documentation for FSP2.1 similar to https://www.intel.com/content/dam/www/public/us/en/documents/technical-spec…
>
> It looks like it's no officially announced by Intel.
Its not a major FSP specification change but i will check with FSP POC if we have any plan to make official announcement.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30310
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef95a783a08d85a7dc2987f804a931613f5524
Gerrit-Change-Number: 30310
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 06:50:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31803
Change subject: mb/google/poppy/variant/nami: change the vbt bin loading for bard sku
......................................................................
mb/google/poppy/variant/nami: change the vbt bin loading for bard sku
remove the bard vbt bin in coreboot,and add it in cbfs(CL:990403)
to fix the bugs
BUG=b:127552559 b:127611290
TEST= build the coreboot and firmware include CL:990403 to verify
Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nami/Makefile.inc
D src/mainboard/google/poppy/variants/nami/bard-data.vbt
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31803/1
diff --git a/src/mainboard/google/poppy/variants/nami/Makefile.inc b/src/mainboard/google/poppy/variants/nami/Makefile.inc
index dc80357..7f86bb7 100644
--- a/src/mainboard/google/poppy/variants/nami/Makefile.inc
+++ b/src/mainboard/google/poppy/variants/nami/Makefile.inc
@@ -41,5 +41,3 @@
cbfs-files-y += oem.bin
oem.bin-file := $(call strip_quotes,$(CONFIG_OEM_BIN_FILE))
oem.bin-type := raw
-
-$(call add_vbt_to_cbfs, vbt-bard.bin, bard-data.vbt)
diff --git a/src/mainboard/google/poppy/variants/nami/bard-data.vbt b/src/mainboard/google/poppy/variants/nami/bard-data.vbt
deleted file mode 100644
index cdaca6a..0000000
--- a/src/mainboard/google/poppy/variants/nami/bard-data.vbt
+++ /dev/null
Binary files differ
--
To view, visit https://review.coreboot.org/c/coreboot/+/31803
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d
Gerrit-Change-Number: 31803
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newchange