coreboot-gerrit March 2019

coreboot-gerrit@coreboot.org

1 participants
1542 discussions

Change in ...coreboot[master]: tint: introduce the new tint build system with checksum verification
by build bot (Jenkins) (Code Review) 10 Mar '19

10 Mar '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23856 ) Change subject: tint: introduce the new tint build system with checksum verification ...................................................................... Patch Set 10: (7 comments) https://review.coreboot.org/#/c/23856/10/payloads/external/tint/generate_co… File payloads/external/tint/generate_core.sh: https://review.coreboot.org/#/c/23856/10/payloads/external/tint/generate_co… PS10, Line 40: sed -n "/^${start}/,/^${end}/{/^${start}/{p;n};/^${end}/{q};{p}}" $source >> $destination line over 96 characters https://review.coreboot.org/#/c/23856/10/payloads/external/tint/generate_co… PS10, Line 54: FUNCTIONS="please_install searchtool download compute_hash error_hash_mismatch verify_hash unpack_and_patch" line over 96 characters https://review.coreboot.org/#/c/23856/10/payloads/external/tint/generate_co… PS10, Line 64: import_from_file $buildgcc $corescript "# Find all the required tools" "# Allow" last_line_disabled || exit "$?" line over 96 characters https://review.coreboot.org/#/c/23856/10/payloads/external/tint/generate_co… PS10, Line 99: sed -i -e "/\$TAR \$FLAGS \"\$(basename \"\$archive\")\"/a prepare_\${package} || exit \"\$?\"" $corescript line over 96 characters https://review.coreboot.org/#/c/23856/10/payloads/external/tint/tintify_cor… File payloads/external/tint/tintify_core.sh: https://review.coreboot.org/#/c/23856/10/payloads/external/tint/tintify_cor… PS10, Line 55: echo "rm -rf ./\${TINT_DIR}/debian ./\${TINT_DIR}/typedefs.h ./\${TINT_DIR}/Makefile;" >> $tintified line over 96 characters https://review.coreboot.org/#/c/23856/10/payloads/external/tint/tintify_cor… PS10, Line 70: sed -i -e "/download() {/a package=\$1\narchive_link=\"\$(eval echo \\\\\$\$package\"_ARCHIVE_LINK\")\"" $tintified line over 96 characters https://review.coreboot.org/#/c/23856/10/payloads/external/tint/tintify_cor… PS10, Line 72: sed -i -e "s/$download_showing_percentage \"\$archive$./\1_link\"\nreplace_plus_with_minus/g" $tintified line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/23856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d24f222d1b92030b81bba3951e243a2a9f37290 Gerrit-Change-Number: 23856 Gerrit-PatchSet: 10 Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mikeb mikeb <mikebdp2(a)gmail.com> Gerrit-Comment-Date: Sat, 09 Mar 2019 22:09:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: tint: introduce the new tint build system with checksum verification
by mikeb mikeb (Code Review) 10 Mar '19

10 Mar '19

Hello Patrick Rudolph, Jonathan Neuschäfer, Stefan Reinauer, Paul Menzel, Mike Banon, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/23856 to look at the new patch set (#10). Change subject: tint: introduce the new tint build system with checksum verification ...................................................................... tint: introduce the new tint build system with checksum verification Three stages of the new tint build system: 1) generate_core.sh extracts the core part from buildgcc script, most importantly the checksum calculation/verification functions. 2) tintify_core.sh adds the tint-specific footer/header to the core, such as the properties of current version including its checksum. 3) tint.sh - generated and "tintified" core script - builds a tint. Change-Id: I1d24f222d1b92030b81bba3951e243a2a9f37290 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- M payloads/external/tint/Makefile A payloads/external/tint/generate_core.sh R payloads/external/tint/tint-0.04-nmu1_libpayload.patch A payloads/external/tint/tintify_core.sh 4 files changed, 244 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/23856/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/23856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d24f222d1b92030b81bba3951e243a2a9f37290 Gerrit-Change-Number: 23856 Gerrit-PatchSet: 10 Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mikeb mikeb <mikebdp2(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On
by Nicola Corna (Code Review) 10 Mar '19

10 Mar '19

Nicola Corna has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29032 ) Change subject: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On ...................................................................... Patch Set 4: Code-Review+1 Tested, works. Note that it requires change 31829, otherwise the USB ports are always powered in S3. -- To view, visit https://review.coreboot.org/c/coreboot/+/29032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9070b659b0c9ad5dde4200ec2845c6fa2b78b25 Gerrit-Change-Number: 29032 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 09 Mar 2019 21:21:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src/soc/intel/apollolake/cpu.c: Set up local APIC
by Mario Scheithauer (Code Review) 10 Mar '19

10 Mar '19

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31802 Change subject: src/soc/intel/apollolake/cpu.c: Set up local APIC ...................................................................... src/soc/intel/apollolake/cpu.c: Set up local APIC Some Apollo Lake mainboards use SeaBIOS as payload. SeaBIOS requires the initialization of the programmable interrupt controller (PIC) for faultless operation. Therefore add setup_lapic() to configure the APIC. Change-Id: I00b339ce1850729023db74da7f8845927a95dcc6 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/soc/intel/apollolake/cpu.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/31802/1 diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c index a08f1f0..7d42d6b 100644 --- a/src/soc/intel/apollolake/cpu.c +++ b/src/soc/intel/apollolake/cpu.c @@ -2,7 +2,7 @@ * This file is part of the coreboot project. * * Copyright (C) 2015-2017 Intel Corp. - * Copyright (C) 2017 Siemens AG, Inc. + * Copyright (C) 2017-2019 Siemens AG * (Written by Andrey Petrov <andrey.petrov(a)intel.com> for Intel Corp.) * (Written by Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> for Intel Corp.) * @@ -23,6 +23,7 @@ #include "chip.h" #include <cpu/cpu.h> #include <cpu/x86/cache.h> +#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/intel/microcode.h> #include <cpu/intel/turbo.h> @@ -161,6 +162,10 @@ } x86_setup_mtrrs_with_detect(); x86_mtrr_check(); + + /* Enable the local CPU apics */ + if (IS_ENABLED(CONFIG_PAYLOAD_SEABIOS)) + setup_lapic(); } #if !IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) -- To view, visit https://review.coreboot.org/c/coreboot/+/31802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00b339ce1850729023db74da7f8845927a95dcc6 Gerrit-Change-Number: 31802 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: newchange

5 13

Change in ...coreboot[master]: lenovo/x230: introduce FHD variant
by Holger Levsen (Code Review) 09 Mar '19

09 Mar '19

Holger Levsen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 7: patchset 6 works for me on my x230 with a full hd display. even using qubes/xen :) -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 7 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Kilian Neuner <cb(a)9-r.net> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Comment-Date: Sat, 09 Mar 2019 14:50:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Docs/project_ideas: Add a "parse SerialICE traces" project idea
by Patrick Georgi (Code Review) 09 Mar '19

09 Mar '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31820 Change subject: Docs/project_ideas: Add a "parse SerialICE traces" project idea ...................................................................... Docs/project_ideas: Add a "parse SerialICE traces" project idea Change-Id: I696811ff93948358f03ff617d294ecc40bd4c746 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/contributing/project_ideas.md 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31820/1 diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md index 97499a8..21a756d 100644 --- a/Documentation/contributing/project_ideas.md +++ b/Documentation/contributing/project_ideas.md @@ -179,3 +179,25 @@ useful for firmware related work: Automatically parse formats (eg. by integrating UEFITool, cbfstool, decompressors), automatically identify 16/32/64bit code on x86/amd64, etc. + +## Learn hardware behavior from I/O and memory access logs +[SerialICE](https://www.serialice.com) is a tool to trace the behavior of +executable code like firmware images. One result of that is a long log file +containing the accesses to hardware resources. + +It would be useful to have a tool that assists a developer-analyst in deriving +knowledge about hardware from such logs. This likely can't be entirely +automatic, but a tool that finds patterns and can propagate them across the +log (incrementially raising the log from plain I/O accesses to a high-level +description of driver behavior) would be of great use. + +This is a research-heavy project. + +### Requirements +* Driver knowledge: Somebody working on this should be familiar with + how hardware works (eg. MMIO based register access, index/data port + accesses) and how to read data sheets. +* Machine Learning: ML techniques may be useful to find structure in traces. + +### Mentors +* Ron Minnich <rminnich(a)google.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/31820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I696811ff93948358f03ff617d294ecc40bd4c746 Gerrit-Change-Number: 31820 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

4 5

Change in ...coreboot[master]: Docs/project_ideas: Add a stub for Ghidra integration
by Patrick Georgi (Code Review) 09 Mar '19

09 Mar '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31806 Change subject: Docs/project_ideas: Add a stub for Ghidra integration ...................................................................... Docs/project_ideas: Add a stub for Ghidra integration It may be useful to have a common, easily available toolbench for firmware analysis and Ghidra looks promising. Change-Id: I56d0ff875bb939f6d31f088232f8a6fd168abbb6 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/contributing/project_ideas.md 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/31806/1 diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md index 117dcce..0c94560 100644 --- a/Documentation/contributing/project_ideas.md +++ b/Documentation/contributing/project_ideas.md @@ -172,3 +172,10 @@ ### Mentors * Patrick Georgi <patrick(a)georgi.software> + +## Extend Ghidra to support analysis of firmware images +[Ghidra](https://ghidra-sre.org) is a recently released cross-platform +disassembler and decompiler that is extensible through plugins. Make it +useful for firmware related work: Automatically parse formats (eg. by +integrating UEFITool, cbfstool, decompressors), automatically identify +16/32bit code on x86, etc. -- To view, visit https://review.coreboot.org/c/coreboot/+/31806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56d0ff875bb939f6d31f088232f8a6fd168abbb6 Gerrit-Change-Number: 31806 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

3 6

Change in ...coreboot[master]: soc/intel/common: Add Kconfig option to choose desired MP Init for pl...
by Arthur Heymans (Code Review) 09 Mar '19

09 Mar '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30287 ) Change subject: soc/intel/common: Add Kconfig option to choose desired MP Init for platform ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/30287/7/src/soc/intel/common/block/cpu/Kcon… File src/soc/intel/common/block/cpu/Kconfig: https://review.coreboot.org/#/c/30287/7/src/soc/intel/common/block/cpu/Kcon… PS7, Line 74: publish published? -- To view, visit https://review.coreboot.org/c/coreboot/+/30287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbea463fdaf97d68c21a759c37f49492d58a056b Gerrit-Change-Number: 30287 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 09 Mar 2019 07:59:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: include/efi/efi_datatype: Convert EFI datatypes as per coreboot speci...
by Subrata Banik (Code Review) 09 Mar '19

09 Mar '19

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31648 ) Change subject: include/efi/efi_datatype: Convert EFI datatypes as per coreboot specification ...................................................................... include/efi/efi_datatype: Convert EFI datatypes as per coreboot specification This patch replaces commonly used EFI datatypes and structures into coreboot compatible datatypes as below: typedef UINTN efi_uintn_t Change-Id: I79cdaaa1dd63d248692989d943a15ad178c46369 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/31648 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- A src/include/efi/efi_datatype.h 1 file changed, 87 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/src/include/efi/efi_datatype.h b/src/include/efi/efi_datatype.h new file mode 100644 index 0000000..053d713 --- /dev/null +++ b/src/include/efi/efi_datatype.h @@ -0,0 +1,87 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Intel Corporation. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/* Create EFI equivalent datatype in coreboot based on UEFI specification */ +#ifndef __EFI_DATATYPE_H__ +#define __EFI_DATATYPE_H__ + +#include <Base.h> +#include <PiPei.h> +#include <Ppi/MpServices.h> + +/* Basic Data types */ + +/* 8-byte unsigned value. */ +typedef UINT64 efi_uint64_t; + +/* 8-byte signed value. */ +typedef INT64 efi_int64_t; + +/* 4-byte unsigned value. */ +typedef UINT32 efi_uint32_t; + +/* 4-byte signed value. */ +typedef INT32 efi_int32_t; + +/* 2-byte unsigned value. */ +typedef UINT16 efi_uint16_t; + +/* 2-byte Character. */ +typedef CHAR16 efi_char16_t; + +/* 2-byte signed value. */ +typedef INT16 efi_int16_t; + +/* Logical Boolean. */ +typedef BOOLEAN efi_boolean_t; + +/* 1-byte unsigned value. */ +typedef UINT8 efi_uint8_t; + +/* 1-byte Character */ +typedef CHAR8 efi_char8_t; + +/* 1-byte signed value */ +typedef INT8 efi_int8_t; + +/* Unsigned value of native width. */ +typedef UINTN efi_uintn_t; + +/* Signed value of native width. */ +typedef INTN efi_intn_t; + +/* Status codes common to all execution phases */ +typedef EFI_STATUS efi_return_status_t; + +/* Data structure */ + +/* Data structure for EFI_PEI_SERVICE. */ +typedef EFI_PEI_SERVICES efi_pei_services; + +/* Data structure for UEFI PI Multi-processor PPI */ +typedef EFI_PEI_MP_SERVICES_PPI efi_pei_mp_services_ppi; + +/* Structure that describes information about a logical CPU. */ +typedef EFI_PROCESSOR_INFORMATION efi_processor_information; + +/* + * The function prototype for invoking a function on an + * Application Processor. + */ +typedef +void +(EFIAPI *efi_ap_procedure)(void *buffer); + +#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/31648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79cdaaa1dd63d248692989d943a15ad178c46369 Gerrit-Change-Number: 31648 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: qclib: Add qclib support
by Julius Werner (Code Review) 09 Mar '19

09 Mar '19

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 ) Change subject: qclib: Add qclib support ...................................................................... Patch Set 14: > Hi Julius, > So this patch is without the interface table support. Only loading the qclib blob. Will add the support for the interface table in later patches. Was planning to add all the relevant structures at that time. Hence trimmed this patch to be minimal like this. Not ok ? Well... I'm just generally not a fan of landing premature hacks. It's just taking time away from working on the actual fix. You might as well leave this floating until you can clean it up. Note that this patch also has the same problem in the Makefile as the other one I pointed out anyway. We shouldn't submit those hacks which work around valid build errors, we should rather spend our energy on getting the licensing issues worked out for good. -- To view, visit https://review.coreboot.org/c/coreboot/+/29967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07 Gerrit-Change-Number: 29967 Gerrit-PatchSet: 14 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sricharan Ramabadhran <srichara(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Fri, 08 Mar 2019 22:36:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2019