Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31871 )
Change subject: Remove leftover files
......................................................................
Patch Set 1: Code-Review+2
oh. yeah, then let's either fix this or get rid of it. since no one has noticed that it's broken, it likely hasn't been used for quite some time
--
To view, visit https://review.coreboot.org/c/coreboot/+/31871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7fa27a2cbc73b4acae41373a51f600f32b9002bf
Gerrit-Change-Number: 31871
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 10:07:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31871 )
Change subject: Remove leftover files
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31871/1/src/lib/debug.c
File src/lib/debug.c:
https://review.coreboot.org/#/c/31871/1/src/lib/debug.c@a20
PS1, Line 20:
Hmm.. ever since introduction of PCI MMCONF, bottom 12 bits of dev have been register. So broken and nobody noticed for 6 years?
https://review.coreboot.org/#/c/31871/1/src/lib/debug.c@a90
PS1, Line 90:
Say again? Read 256 bytes from single IO port?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7fa27a2cbc73b4acae41373a51f600f32b9002bf
Gerrit-Change-Number: 31871
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 10:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31871 )
Change subject: Remove leftover files
......................................................................
Patch Set 1:
> Patch Set 1:
>
> Maybe we should add one qemu configuration so that code "useful for copy-pasting for debug purposes" gets build tested?
>
> Should have one for usbdebug and oxpcie-serial as well as other things that are not enabled in any default configuration.
sounds good to me
--
To view, visit https://review.coreboot.org/c/coreboot/+/31871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7fa27a2cbc73b4acae41373a51f600f32b9002bf
Gerrit-Change-Number: 31871
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 10:00:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31871 )
Change subject: Remove leftover files
......................................................................
Patch Set 1:
Maybe we should add one qemu configuration so that code "useful for copy-pasting for debug purposes" gets build tested?
Should have one for usbdebug and oxpcie-serial as well as other things that are not enabled in any default configuration.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7fa27a2cbc73b4acae41373a51f600f32b9002bf
Gerrit-Change-Number: 31871
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 10:00:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31871 )
Change subject: Remove leftover files
......................................................................
Patch Set 1:
haven't looked closely into that, but src/lib/debug.c still looks useful to me
--
To view, visit https://review.coreboot.org/c/coreboot/+/31871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7fa27a2cbc73b4acae41373a51f600f32b9002bf
Gerrit-Change-Number: 31871
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 09:53:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 7:
> Patch Set 7:
>
> patchset 6 works for me on my x230 with a full hd display. even using qubes/xen :)
just to make sure: with the current patchset you get graphics output before the kernel starts, right? if so, i'll merge this :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 7
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Holger Levsen <holger(a)layer-acht.org>
Gerrit-CC: Kilian Neuner <cb(a)9-r.net>
Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com>
Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 09:50:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31871 )
Change subject: Remove leftover files
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7fa27a2cbc73b4acae41373a51f600f32b9002bf
Gerrit-Change-Number: 31871
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Mar 2019 09:37:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29106 )
Change subject: lib/ramtest: Use Kconfig switch CONFIG_RAMBASE for RAM test
......................................................................
Patch Set 2:
> Patch Set 2:
>
> > Patch Set 2:
> >
> > That is an arbitrary address that is "tested" here. For all the platforms with RELOCATABLE_RAMSTAGE=y, CONFIG_RAMBASE is no longer where ramstage will be loaded as it's dynamically located somewhere high inside CBMEM.
> >
> > In my opinion testing some address near CBMEM / IMD root (or even cbmem_top()) would be more useful, as that will be utilised before ramstage region.
>
> Thank you for the clarification Kyösti, then I was wrong here. Should we still follow the CBMEM approach? Otherwise I can abandon this patch.
> Sorry for the noise.
With the few remaining quick_ram_check() calls, I think checking memory near CBMEM / IMD root would be good option.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc57e684a677ac64225ea54cb43e6fbb68930354
Gerrit-Change-Number: 29106
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 08:28:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment