coreboot-gerrit March 2019

coreboot-gerrit@coreboot.org

1 participants
1542 discussions

Change in ...coreboot[master]: libpayload: Fix compile error with DEBUG_MALLOC
by You-Cheng Syu (Code Review) 14 Mar '19

14 Mar '19

You-Cheng Syu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31562 Change subject: libpayload: Fix compile error with DEBUG_MALLOC ...................................................................... libpayload: Fix compile error with DEBUG_MALLOC DEBUG_MALLOC is an option for debugging memory allocator issues. However, we would encounter a lot of compile error if we turn it on in environments with strict compile options (e.g., ChromeOS) or different architecture (e.g., ARM64). This CL: 1. Eliminate redundant redeclaration errors in memory allocation macros. 2. Include 'stdio.h' for printing debug messages. 3. Move the declaration of 'print_malloc_map' from 'malloc.c' to 'stdlib.h' for memory allocation macros. 4. Cast arguments to unsigned int when printing debug messages to eliminate printf argument type errors. BUG=b:125576961 TEST='emerge-kukui libpayload' succeeds with and without DEBUG_MALLOC Change-Id: I5927f941f386d4920a5d41528b1471e5af294fcb Signed-off-by: You-Cheng Syu <youcheng(a)google.com> --- M payloads/libpayload/include/stdlib.h M payloads/libpayload/libc/malloc.c 2 files changed, 38 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/31562/1 diff --git a/payloads/libpayload/include/stdlib.h b/payloads/libpayload/include/stdlib.h index a2e612d..682cbf4 100644 --- a/payloads/libpayload/include/stdlib.h +++ b/payloads/libpayload/include/stdlib.h @@ -33,6 +33,9 @@ #include <die.h> #include <stddef.h> +#if IS_ENABLED(CONFIG_LP_DEBUG_MALLOC) && !defined(IN_MALLOC_C) +#include <stdio.h> +#endif #include <string.h> #define ALIGN(x,a) __ALIGN_MASK(x,(typeof(x))(a)-1UL) @@ -45,13 +48,19 @@ * @defgroup malloc Memory allocation functions * @{ */ +void free(void *ptr); +void *malloc(size_t size); +void *calloc(size_t nmemb, size_t size); +void *realloc(void *ptr, size_t size); +void *memalign(size_t align, size_t size); +void *dma_malloc(size_t size); +void *dma_memalign(size_t align, size_t size); +void print_malloc_map(void); #if IS_ENABLED(CONFIG_LP_DEBUG_MALLOC) && !defined(IN_MALLOC_C) -#define free(p) \ +#define free(p) \ ({ \ - extern void print_malloc_map(void); \ - extern void free(void *); \ - printf("free(%p) called from %s:%s:%d...\n", p, __FILE__, __func__, \ - __LINE__);\ + printf("free(%p) called from %s:%s:%d...\n", \ + p, __FILE__, __func__, __LINE__); \ printf("PRE free()\n"); \ print_malloc_map(); \ free(p); \ @@ -60,11 +69,9 @@ }) #define malloc(s) \ ({ \ - extern void print_malloc_map(void); \ - extern void *malloc(size_t); \ void *ptr; \ - printf("malloc(%u) called from %s:%s:%d...\n", s, __FILE__, __func__, \ - __LINE__);\ + printf("malloc(%u) called from %s:%s:%d...\n", \ + (unsigned int)(s), __FILE__, __func__, __LINE__); \ printf("PRE malloc\n"); \ print_malloc_map(); \ ptr = malloc(s); \ @@ -74,11 +81,10 @@ }) #define calloc(n,s) \ ({ \ - extern void print_malloc_map(void); \ - extern void *calloc(size_t,size_t); \ void *ptr; \ - printf("calloc(%u, %u) called from %s:%s:%d...\n", n, s, __FILE__, \ - __func__, __LINE__);\ + printf("calloc(%u, %u) called from %s:%s:%d...\n", \ + (unsigned int)(n), (unsigned int)(s), \ + __FILE__, __func__, __LINE__); \ printf("PRE calloc\n"); \ print_malloc_map(); \ ptr = calloc(n,s); \ @@ -88,11 +94,9 @@ }) #define realloc(p,s) \ ({ \ - extern void print_malloc_map(void); \ - extern void *realloc(void*,size_t); \ void *ptr; \ - printf("realloc(%p, %u) called from %s:%s:%d...\n", p, s, __FILE__, \ - __func__, __LINE__);\ + printf("realloc(%p, %u) called from %s:%s:%d...\n", \ + p, (unsigned int)(s), __FILE__, __func__, __LINE__); \ printf("PRE realloc\n"); \ print_malloc_map(); \ ptr = realloc(p,s); \ @@ -102,11 +106,10 @@ }) #define memalign(a,s) \ ({ \ - extern void print_malloc_map(void); \ - extern void *memalign(size_t, size_t); \ void *ptr; \ - printf("memalign(%u, %u) called from %s:%s:%d...\n", a, s, __FILE__, \ - __func__, __LINE__);\ + printf("memalign(%u, %u) called from %s:%s:%d...\n", \ + (unsigned int)(a), (unsigned int)(s), \ + __FILE__, __func__, __LINE__); \ printf("PRE memalign\n"); \ print_malloc_map(); \ ptr = memalign(a,s); \ @@ -116,11 +119,9 @@ }) #define dma_malloc(s) \ ({ \ - extern void print_malloc_map(void); \ - extern void *dma_malloc(size_t); \ void *ptr; \ - printf("dma_malloc(%u) called from %s:%s:%d...\n", s, __FILE__, \ - __func__, __LINE__);\ + printf("dma_malloc(%u) called from %s:%s:%d...\n", \ + (unsigned int)(s), __FILE__, __func__, __LINE__); \ printf("PRE dma_malloc\n"); \ print_malloc_map(); \ ptr = dma_malloc(s); \ @@ -130,11 +131,10 @@ }) #define dma_memalign(a,s) \ ({ \ - extern void print_malloc_map(void); \ - extern void *dma_memalign(size_t, size_t); \ void *ptr; \ - printf("dma_memalign(%u, %u) called from %s:%s:%d...\n", a, s, \ - __FILE__, __func__, __LINE__);\ + printf("dma_memalign(%u, %u) called from %s:%s:%d...\n", \ + (unsigned int)(a), (unsigned int)(s), \ + __FILE__, __func__, __LINE__); \ printf("PRE dma_memalign\n"); \ print_malloc_map(); \ ptr = dma_memalign(a,s); \ @@ -142,14 +142,6 @@ print_malloc_map(); \ ptr; \ }) -#else -void free(void *ptr); -void *malloc(size_t size); -void *calloc(size_t nmemb, size_t size); -void *realloc(void *ptr, size_t size); -void *memalign(size_t align, size_t size); -void *dma_malloc(size_t size); -void *dma_memalign(size_t align, size_t size); #endif void init_dma_memory(void *start, u32 size); int dma_initialized(void); diff --git a/payloads/libpayload/libc/malloc.c b/payloads/libpayload/libc/malloc.c index 595af63..c4a39b4 100644 --- a/payloads/libpayload/libc/malloc.c +++ b/payloads/libpayload/libc/malloc.c @@ -84,7 +84,6 @@ #define HAS_MAGIC(_h) (((_h) & MAGIC) == MAGIC) static int free_aligned(void* addr, struct memory_type *type); -void print_malloc_map(void); void init_dma_memory(void *start, u32 size) { @@ -480,7 +479,10 @@ if ((reg->alignment == align) && (reg->free >= (size + align - 1)/align)) { #if IS_ENABLED(CONFIG_LP_DEBUG_MALLOC) - printf(" found memalign region. %x free, %x required\n", reg->free, (size + align - 1)/align); + printf(" found memalign region. " + "%u free, %u required\n", + (unsigned int)reg->free, + (unsigned int)((size + align - 1)/align)); #endif break; } @@ -563,9 +565,10 @@ /* FIXME: Verify the size of the block. */ - printf("%s %x: %s (%x bytes)\n", type->name, + printf("%s 0x%x: %s (%u bytes)\n", type->name, (unsigned int)(ptr - type->start), - hdr & FLAG_FREE ? "FREE" : "USED", SIZE(hdr)); + hdr & FLAG_FREE ? "FREE" : "USED", + (unsigned int)SIZE(hdr)); if (hdr & FLAG_FREE) free_memory += SIZE(hdr); @@ -576,7 +579,8 @@ if (free_memory && (type->minimal_free > free_memory)) type->minimal_free = free_memory; printf("%s: Maximum memory consumption: %u bytes\n", type->name, - (type->end - type->start) - HDRSIZE - type->minimal_free); + (unsigned int)(type->end - type->start - HDRSIZE - + type->minimal_free)); if (type != dma) { type = dma; -- To view, visit https://review.coreboot.org/c/coreboot/+/31562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5927f941f386d4920a5d41528b1471e5af294fcb Gerrit-Change-Number: 31562 Gerrit-PatchSet: 1 Gerrit-Owner: You-Cheng Syu <youcheng(a)google.com> Gerrit-MessageType: newchange

2 5

Change in ...coreboot[master]: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs
by Subrata Banik (Code Review) 14 Mar '19

14 Mar '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 ) Change subject: drivers/intel/fsp2_0: Implement EFI_MP_SERVICES_PPI structure APIs ...................................................................... Patch Set 55: > Thanks Idwer. @Werner please check your requirements @Subrata, > let's wait before we merge it there are some tests ongoing. Sure Philipp, let me know once you have done with testing. i will wait for submission. -- To view, visit https://review.coreboot.org/c/coreboot/+/25634 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956 Gerrit-Change-Number: 25634 Gerrit-PatchSet: 55 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Vincent Zimmer <vincent.zimmer(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Comment-Date: Thu, 14 Mar 2019 05:38:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
by Hung-Te Lin (Code Review) 14 Mar '19

14 Mar '19

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/14921 ) Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.h File payloads/libpayload/include/stdlib.h: https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.… PS5, Line 142: #endif one more blank line after #endif? https://review.coreboot.org/#/c/14921/5/payloads/libpayload/libc/malloc.c File payloads/libpayload/libc/malloc.c: https://review.coreboot.org/#/c/14921/5/payloads/libpayload/libc/malloc.c@4… PS5, Line 483: printf(" found memalign region. %u free, %zu required\n", reg->free, (size + align - 1)/align); > line over 96 characters fix col 80? -- To view, visit https://review.coreboot.org/c/coreboot/+/14921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45 Gerrit-Change-Number: 14921 Gerrit-PatchSet: 5 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Mar 2019 01:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src/arch: Upgrading SMBIOS to latest version 3.2.
by Francois Toguo Fotso (Code Review) 14 Mar '19

14 Mar '19

Francois Toguo Fotso has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31725 Change subject: src/arch: Upgrading SMBIOS to latest version 3.2. ...................................................................... src/arch: Upgrading SMBIOS to latest version 3.2. "This is second of 2 patches upgrading the SMBIOS interface to the latest 3.2" BUG=NONE TEST=Boot to OS Signed-off-by: Francois Toguo <francois.toguo.fotso(a)intel.com> Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 29 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31725/1 diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index fdf8ca1..7d3cfae 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -560,7 +560,13 @@ t->processor_version = smbios_processor_name(t->eos); t->processor_family = (res.eax > 0) ? 0x0c : 0x6; t->processor_type = 3; /* System Processor */ - t->core_count = (res.ebx >> 16) & 0xff; + if (((res.ebx >> 16) & 0xffff) > 255) { + t->core_count = 0xff; + t->core_count2 = (res.ebx >> 16) & 0xffff; + } else { + t->core_count = (res.ebx >> 16) & 0xff; + t->core_count2 = (res.ebx >> 16) & 0x00ff; + } t->l1_cache_handle = 0xffff; t->l2_cache_handle = 0xffff; t->l3_cache_handle = 0xffff; diff --git a/src/include/smbios.h b/src/include/smbios.h index c046b1a..4937dd6 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -298,6 +298,8 @@ u8 location_in_chassis; u16 chassis_handle; u8 board_type; + u8 num_cont_obj_handles; + u16 cont_obj_hanles[256]; u8 eos[2]; } __packed; @@ -389,6 +391,9 @@ u8 thread_count; u16 processor_characteristics; u16 processor_family2; + u16 core_count2; + u16 core_enabled2; + u16 thread_count2; u8 eos[2]; } __packed; @@ -400,6 +405,11 @@ u8 eos[2]; } __packed; +typedef struct { + u8 type; + u8 format_descriptor; +} log_type_descriptor; + struct smbios_type15 { u8 type; u8 length; @@ -414,6 +424,7 @@ u8 header_format; u8 log_type_descriptors; u8 log_type_descriptor_length; + log_type_descriptor descriptor[0]; u8 eos[2]; } __packed; @@ -470,6 +481,17 @@ u16 minimum_voltage; u16 maximum_voltage; u16 configured_voltage; + u8 memory_technology; + u16 operating_mode_capability; + u8 fw_version; + u16 manufacturer_id; + u16 product_id; + u16 sub_ctrl_manufacturer_id; + u16 sub_ctrl_product_id; + u64 non_volatile_size; + u64 volatile_size; + u64 cache_size; + u64 logical_size; u8 eos[2]; } __packed; -- To view, visit https://review.coreboot.org/c/coreboot/+/31725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e Gerrit-Change-Number: 31725 Gerrit-PatchSet: 1 Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-MessageType: newchange

6 11

Change in ...coreboot[master]: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
by Julius Werner (Code Review) 14 Mar '19

14 Mar '19

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/14921 ) Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.h File payloads/libpayload/include/stdlib.h: https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.… PS5, Line 97: printf("realloc(%p, %zu) called from %s:%s:%d...\n", __p, __s, \ > Prefer using '"%s... […] Pretty sure I can't do that here, not sure what the linter is smoking. This is not a function. -- To view, visit https://review.coreboot.org/c/coreboot/+/14921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45 Gerrit-Change-Number: 14921 Gerrit-PatchSet: 5 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Mar 2019 20:01:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
by build bot (Jenkins) (Code Review) 14 Mar '19

14 Mar '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/14921 ) Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs ...................................................................... Patch Set 5: (4 comments) https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.h File payloads/libpayload/include/stdlib.h: https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.… PS5, Line 97: printf("realloc(%p, %zu) called from %s:%s:%d...\n", __p, __s, \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.… PS5, Line 99: printf("PRE realloc\n"); \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string https://review.coreboot.org/#/c/14921/5/payloads/libpayload/include/stdlib.… PS5, Line 102: printf("POST realloc (ptr = %p)\n", ptr); \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string https://review.coreboot.org/#/c/14921/5/payloads/libpayload/libc/malloc.c File payloads/libpayload/libc/malloc.c: https://review.coreboot.org/#/c/14921/5/payloads/libpayload/libc/malloc.c@4… PS5, Line 483: printf(" found memalign region. %u free, %zu required\n", reg->free, (size + align - 1)/align); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/14921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45 Gerrit-Change-Number: 14921 Gerrit-PatchSet: 5 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Mar 2019 19:59:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
by Julius Werner (Code Review) 14 Mar '19

14 Mar '19

Hello Aaron Durbin, Philippe Mathieu-Daudé, Uwe Hermann, You-Cheng Syu, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/14921 to look at the new patch set (#5). Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs ...................................................................... libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs New compilers are a little more stringent about defining the same prototype more than once, so some of our CONFIG_LP_DEBUG_MALLOC wrappers don't quite work the way they are written anymore. Also, several of the printf()s weren't written 64-bit safe. And let's add some double-evaluation safety while I'm here anyway... and I have no idea why this ever depended on CONFIG_LP_USB, that just seems like a typo. Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M payloads/libpayload/Kconfig M payloads/libpayload/include/stdlib.h M payloads/libpayload/libc/malloc.c 3 files changed, 90 insertions(+), 102 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/14921/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/14921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45 Gerrit-Change-Number: 14921 Gerrit-PatchSet: 5 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
by build bot (Jenkins) (Code Review) 14 Mar '19

14 Mar '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/14921 ) Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs ...................................................................... Patch Set 4: (8 comments) https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.h File payloads/libpayload/include/stdlib.h: https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.… PS4, Line 81: #define calloc(n,s) ({ \ space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.… PS4, Line 93: #define realloc(p,s) ({ \ space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.… PS4, Line 97: printf("realloc(%p, %zu) called from %s:%s:%d...\n", __p, __s, \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.… PS4, Line 99: printf("PRE realloc\n"); \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.… PS4, Line 102: printf("POST realloc (ptr = %p)\n", ptr); \ Prefer using '"%s...", __func__' to using 'realloc', this function's name, in a string https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.… PS4, Line 106: #define memalign(a,s) ({ \ space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/14921/4/payloads/libpayload/include/stdlib.… PS4, Line 130: #define dma_memalign(a,s) ({ \ space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/14921/4/payloads/libpayload/libc/malloc.c File payloads/libpayload/libc/malloc.c: https://review.coreboot.org/#/c/14921/4/payloads/libpayload/libc/malloc.c@4… PS4, Line 483: printf(" found memalign region. %u free, %zu required\n", reg->free, (size + align - 1)/align); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/14921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45 Gerrit-Change-Number: 14921 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Mar 2019 19:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs
by Julius Werner (Code Review) 14 Mar '19

14 Mar '19

Hello Aaron Durbin, Philippe Mathieu-Daudé, Uwe Hermann, You-Cheng Syu, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/14921 to look at the new patch set (#4). Change subject: libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs ...................................................................... libpayload: Fix CONFIG_LP_DEBUG_MALLOC for 64-bit archs New compilers are a little more stringent about defining the same prototype more than once, so some of our CONFIG_LP_DEBUG_MALLOC wrappers don't quite work the way they are written anymore. Also, several of the printf()s weren't written 64-bit safe. And let's add some double-evaluation safety while I'm here anyway... and I have no idea why this ever depended on CONFIG_LP_USB, that just seems like a typo. Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M payloads/libpayload/Kconfig M payloads/libpayload/include/stdlib.h M payloads/libpayload/libc/malloc.c 3 files changed, 90 insertions(+), 102 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/14921/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/14921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib54ebc3cfba99f372690365b78c7ceb372c0bd45 Gerrit-Change-Number: 14921 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Uwe Hermann <uwe(a)hermann-uwe.de> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: drivers/i2c/lm96000: Add new hardware-monitoring IC
by Nico Huber (Code Review) 14 Mar '19

14 Mar '19

Hello Felix Held, Thomas Heijligen, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/21194 to look at the new patch set (#9). Change subject: drivers/i2c/lm96000: Add new hardware-monitoring IC ...................................................................... drivers/i2c/lm96000: Add new hardware-monitoring IC LM96000 is the successor of the famous LM85. Change-Id: Ie7df3107bffb7f8e45e71c4c1fbe4eb0a9e3cd03 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- A src/drivers/i2c/lm96000/Kconfig A src/drivers/i2c/lm96000/Makefile.inc A src/drivers/i2c/lm96000/chip.h A src/drivers/i2c/lm96000/lm96000.c A src/drivers/i2c/lm96000/lm96000.h 5 files changed, 425 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/21194/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/21194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7df3107bffb7f8e45e71c4c1fbe4eb0a9e3cd03 Gerrit-Change-Number: 21194 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2019