coreboot-gerrit February 2019

coreboot-gerrit@coreboot.org

1 participants
1249 discussions

Change in ...coreboot[master]: soc/intel/apl: Implement "Power State after Failure"
by Nico Huber (Code Review) 12 Feb '19

12 Feb '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31352 ) Change subject: soc/intel/apl: Implement "Power State after Failure" ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/31352/2/src/soc/intel/common/block/fast_spi… File src/soc/intel/common/block/fast_spi/Makefile.inc: https://review.coreboot.org/#/c/31352/2/src/soc/intel/common/block/fast_spi… PS2, Line 17: ifeq ($(CONFIG_SPI_FLASH_SMM),y) > How is this related? To access the NVRAM setting from SMM, you need access to CBFS (`cmos.layout`) which in case of APL needs access to the flash descriptor to locate it. What made the flaw here obvious: `fast_spi.c` is only about the SPI controller not the flash access, but `SPI_FLASH_SMM` is about flash access, thus the former shouldn't be guarded. Actually, I don't know what the guard is there for anyway. All the other stages don't have one and I doubt `fast_spi_flash.c` is used anywhere but in ramstage. -- To view, visit https://review.coreboot.org/c/coreboot/+/31352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf218b90088a45349c54f4b881e895bb852e88bb Gerrit-Change-Number: 31352 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Feb 2019 13:26:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/apl: Implement "Power State after Failure"
by Nico Huber (Code Review) 12 Feb '19

12 Feb '19

Nico Huber has uploaded a new patch set (#3) to the change originally created by Thomas Heijligen. ( https://review.coreboot.org/c/coreboot/+/31352 ) Change subject: soc/intel/apl: Implement "Power State after Failure" ...................................................................... soc/intel/apl: Implement "Power State after Failure" Add missing functionality around the already selected HAVE_POWER_STATE_AFTER_FAILURE, that is, configure what power state to enter after G3. Beside the Kconfig settings, we allow NVRAM to override the choice via `power_on_after_fail`. Change-Id: Ibf218b90088a45349c54f4b881e895bb852e88bb Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M src/soc/intel/apollolake/Makefile.inc M src/soc/intel/apollolake/pmc.c M src/soc/intel/common/block/fast_spi/Makefile.inc 3 files changed, 48 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31352/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/31352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf218b90088a45349c54f4b881e895bb852e88bb Gerrit-Change-Number: 31352 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: intel/apollolake: Add HDA to disable_dev function
by Nico Huber (Code Review) 12 Feb '19

12 Feb '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31353 ) Change subject: intel/apollolake: Add HDA to disable_dev function ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/31353/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31353/2//COMMIT_MSG@8 PS2, Line 8: > Why? There warning below the added lines should explain enough, no? "Because it was missing"? -- To view, visit https://review.coreboot.org/c/coreboot/+/31353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4f5e1fad935645830782ba922f55f614c72cf06 Gerrit-Change-Number: 31353 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Feb 2019 13:13:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/apl: Disable LPC Clock Run feature after FSP-S
by Nico Huber (Code Review) 12 Feb '19

12 Feb '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29900 ) Change subject: soc/intel/apl: Disable LPC Clock Run feature after FSP-S ...................................................................... Abandoned The hook is hard to implement correctly and we can avoid the issue by being more careful about the pad configuration. -- To view, visit https://review.coreboot.org/c/coreboot/+/29900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfad2555cc78ed9639f4f8b54d4b5b4ad28db65d Gerrit-Change-Number: 29900 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: drivers/intel/fsp2_0: Add hook to fix up FSP-S
by Nico Huber (Code Review) 12 Feb '19

12 Feb '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29899 ) Change subject: drivers/intel/fsp2_0: Add hook to fix up FSP-S ...................................................................... Abandoned Not worth the hassle. Also, would make it harder to distinguish the work within the blob from that in coreboot (i.e. raises license questions again). The original problem fixed with this hook can be avoided in different ways. -- To view, visit https://review.coreboot.org/c/coreboot/+/29899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5a52752d757159f12a65dfa5d08ac5fd65c259 Gerrit-Change-Number: 29899 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: [RFC] cpu/intel/car: Use symbols for CAR MTRR setup
by Paul Menzel (Code Review) 12 Feb '19

12 Feb '19

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30873 ) Change subject: [RFC] cpu/intel/car: Use symbols for CAR MTRR setup ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32d7337ccf8005c7fb65d2efea40c122093d4dd9 Gerrit-Change-Number: 30873 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Feb 2019 12:47:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: util/inteltool: Add Apollo Lake GPIO groups and names
by Nico Huber (Code Review) 12 Feb '19

12 Feb '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29897 ) Change subject: util/inteltool: Add Apollo Lake GPIO groups and names ...................................................................... Patch Set 5: Code-Review+1 +2 to Felix' changes -- To view, visit https://review.coreboot.org/c/coreboot/+/29897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cd687fdc1d2ae81f2e948178bf319897b47f031 Gerrit-Change-Number: 29897 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Feb 2019 12:45:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: device/i2c_bus: Add i2c_dev_readb_at_word()
by Paul Menzel (Code Review) 12 Feb '19

12 Feb '19

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29478 ) Change subject: device/i2c_bus: Add i2c_dev_readb_at_word() ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/29478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412 Gerrit-Change-Number: 29478 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Feb 2019 12:05:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: intel/apollolake: Add HDA to disable_dev function
by Paul Menzel (Code Review) 12 Feb '19

12 Feb '19

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31353 ) Change subject: intel/apollolake: Add HDA to disable_dev function ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/31353/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31353/2//COMMIT_MSG@8 PS2, Line 8: Why? -- To view, visit https://review.coreboot.org/c/coreboot/+/31353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4f5e1fad935645830782ba922f55f614c72cf06 Gerrit-Change-Number: 31353 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Feb 2019 12:04:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/apl: Implement "Power State after Failure"
by Paul Menzel (Code Review) 12 Feb '19

12 Feb '19

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31352 ) Change subject: soc/intel/apl: Implement "Power State after Failure" ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/31352/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31352/2//COMMIT_MSG@8 PS2, Line 8: Could you elaborate please? https://review.coreboot.org/#/c/31352/2/src/soc/intel/common/block/fast_spi… File src/soc/intel/common/block/fast_spi/Makefile.inc: https://review.coreboot.org/#/c/31352/2/src/soc/intel/common/block/fast_spi… PS2, Line 17: ifeq ($(CONFIG_SPI_FLASH_SMM),y) How is this related? -- To view, visit https://review.coreboot.org/c/coreboot/+/31352 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf218b90088a45349c54f4b881e895bb852e88bb Gerrit-Change-Number: 31352 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Feb 2019 12:04:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2019