February 2019 - coreboot-gerrit

Change in ...coreboot[master]: nb/intel/gm45: Use a common romstage
by Arthur Heymans (Code Review) Feb. 5, 2019

Feb. 5, 2019

Hello Alexander Couzens, Patrick Rudolph, Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31190 to look at the new patch set (#4). Change subject: nb/intel/gm45: Use a common romstage ...................................................................... nb/intel/gm45: Use a common romstage This moves a lot of the common romstage boilerplate code to a common location, while adding a few mainboard specific hooks. Another difference is that the settings for enable_igd and enable_peg are now based on the static devicetree settings. Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/t400/romstage.c M src/mainboard/lenovo/x200/romstage.c M src/mainboard/roda/rk9/romstage.c M src/northbridge/intel/gm45/Makefile.inc M src/northbridge/intel/gm45/gm45.h A src/northbridge/intel/gm45/romstage.c 6 files changed, 181 insertions(+), 267 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/31190/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/31190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1 Gerrit-Change-Number: 31190 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: nb/intel/gm45: Use a common romstage
by build bot (Jenkins) (Code Review) Feb. 5, 2019

Feb. 5, 2019

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31190 ) Change subject: nb/intel/gm45: Use a common romstage ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/31190/3/src/northbridge/intel/gm45/gm45.h File src/northbridge/intel/gm45/gm45.h: https://review.coreboot.org/#/c/31190/3/src/northbridge/intel/gm45/gm45.h@4… PS3, Line 443: void mb_pre_raminit_setup(sysinfo_t *); /* optional */ function definition argument 'sysinfo_t *' should also have an identifier name -- To view, visit https://review.coreboot.org/c/coreboot/+/31190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1 Gerrit-Change-Number: 31190 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Feb 2019 12:32:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: nb/intel/gm45: Use a common romstage
by Arthur Heymans (Code Review) Feb. 5, 2019

Feb. 5, 2019

Hello Alexander Couzens, Patrick Rudolph, Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31190 to look at the new patch set (#3). Change subject: nb/intel/gm45: Use a common romstage ...................................................................... nb/intel/gm45: Use a common romstage This moves a lot of the common romstage boilerplate code to a common location, while adding a few mainboard specific hooks. Another difference is that the settings for enable_igd and enable_peg are now based on the static devicetree settings. Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/t400/romstage.c M src/mainboard/lenovo/x200/romstage.c M src/mainboard/roda/rk9/romstage.c M src/northbridge/intel/gm45/Makefile.inc M src/northbridge/intel/gm45/gm45.h A src/northbridge/intel/gm45/romstage.c 6 files changed, 181 insertions(+), 267 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/31190/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/31190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1 Gerrit-Change-Number: 31190 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/emulation/qemu-i440fx: use e820 in romstage
by Thomas Heijligen (Code Review) Feb. 5, 2019

Feb. 5, 2019

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30850 Change subject: mb/emulation/qemu-i440fx: use e820 in romstage ...................................................................... mb/emulation/qemu-i440fx: use e820 in romstage Use memory map from fw_cfg e820 map to find cbmem_top in romstage to avoid conflicts with CMOS option table. Keep qemu_gwt_memory_size() as fallback. Change-Id: I6465085020125fc790257f09eb157030c6ceabcb Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M src/mainboard/emulation/qemu-i440fx/Makefile.inc M src/mainboard/emulation/qemu-i440fx/memory.c 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/30850/1 diff --git a/src/mainboard/emulation/qemu-i440fx/Makefile.inc b/src/mainboard/emulation/qemu-i440fx/Makefile.inc index 9e2880a..8c19afc 100644 --- a/src/mainboard/emulation/qemu-i440fx/Makefile.inc +++ b/src/mainboard/emulation/qemu-i440fx/Makefile.inc @@ -1,4 +1,5 @@ ramstage-y += northbridge.c ramstage-y += fw_cfg.c +romstage-y += fw_cfg.c romstage-y += memory.c ramstage-y += memory.c diff --git a/src/mainboard/emulation/qemu-i440fx/memory.c b/src/mainboard/emulation/qemu-i440fx/memory.c index dea96f2..863d923 100644 --- a/src/mainboard/emulation/qemu-i440fx/memory.c +++ b/src/mainboard/emulation/qemu-i440fx/memory.c @@ -16,6 +16,8 @@ #include <cbmem.h> #include <arch/io.h> #include "memory.h" +#include "fw_cfg.h" +#include "fw_cfg_if.h" #define CMOS_ADDR_PORT 0x70 #define CMOS_DATA_PORT 0x71 @@ -52,5 +54,19 @@ void *cbmem_top(void) { - return (void *) (qemu_get_memory_size() * 1024); + FwCfgE820Entry e; + uint64_t tom = 0; + + if (fw_cfg_e820_select()) { + while (!fw_cfg_e820_read(&e)) { + uint64_t limit = (uint64_t)e.address + e.length; + if (e.type == 1 && limit < 4ULL * GiB && limit > tom) + tom = limit; + } + } + + if (!tom) + tom = qemu_get_memory_size() * 1024; + + return (void *)((uint32_t)tom); } -- To view, visit https://review.coreboot.org/c/coreboot/+/30850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6465085020125fc790257f09eb157030c6ceabcb Gerrit-Change-Number: 30850 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

3 7

Change in ...coreboot[master]: mb/emulation/qemu-i440fx: use car for e820
by Thomas Heijligen (Code Review) Feb. 5, 2019

Feb. 5, 2019

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30849 Change subject: mb/emulation/qemu-i440fx: use car for e820 ...................................................................... mb/emulation/qemu-i440fx: use car for e820 Use cache as ram to store e820 table size and read index Change-Id: I98f1c97e3ca33a12620cdd073c76fd4e271f1fcc Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M src/mainboard/emulation/qemu-i440fx/fw_cfg.c 1 file changed, 13 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/30849/1 diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 1890e66..e261bba 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -17,6 +17,7 @@ #include <console/console.h> #include <arch/io.h> #include <arch/acpigen.h> +#include <arch/early_variables.h> #include <commonlib/endian.h> #include "fw_cfg.h" @@ -25,21 +26,22 @@ #define FW_CFG_PORT_CTL 0x0510 #define FW_CFG_PORT_DATA 0x0511 -static unsigned char fw_cfg_detected = 0xff; -//static FWCfgFiles *fw_files; +static int fw_cfg_detected CAR_GLOBAL; static int fw_cfg_present(void) { static const char qsig[] = "QEMU"; unsigned char sig[4]; + int detected = 0; - if (fw_cfg_detected == 0xff) { + if (car_get_var(fw_cfg_detected) == 0) { fw_cfg_get(FW_CFG_SIGNATURE, sig, sizeof(sig)); - fw_cfg_detected = (memcmp(sig, qsig, 4) == 0) ? 1 : 0; + detected = memcmp(sig, qsig, 4) == 0; printk(BIOS_INFO, "QEMU: firmware config interface %s\n", - fw_cfg_detected ? "detected" : "not found"); + detected ? "detected" : "not found"); + car_set_var(fw_cfg_detected, detected + 1); } - return fw_cfg_detected; + return car_get_var(fw_cfg_detected) - 1; } static void fw_cfg_select(int entry) @@ -83,8 +85,8 @@ return fw_cfg_find_file(file, name); } -static uint32_t fw_cfg_e820_size; -static uint32_t fw_cfg_e820_pos; +static uint32_t fw_cfg_e820_size CAR_GLOBAL; +static uint32_t fw_cfg_e820_pos CAR_GLOBAL; int fw_cfg_e820_select(void) { @@ -99,11 +101,12 @@ int fw_cfg_e820_read(FwCfgE820Entry *entry) { - if (fw_cfg_e820_pos + sizeof(*entry) > fw_cfg_e820_size) + if (car_get_var(fw_cfg_e820_pos) + sizeof(*entry) + > car_get_var(fw_cfg_e820_size)) return -1; fw_cfg_read(entry, sizeof(*entry)); - fw_cfg_e820_pos += sizeof(*entry); + car_get_var(fw_cfg_e820_pos) += sizeof(*entry); return 0; } -- To view, visit https://review.coreboot.org/c/coreboot/+/30849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98f1c97e3ca33a12620cdd073c76fd4e271f1fcc Gerrit-Change-Number: 30849 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

3 7

Change in ...coreboot[master]: mb/emulation/qemu-i440fx: add e820 interface
by Thomas Heijligen (Code Review) Feb. 5, 2019

Feb. 5, 2019

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30848 Change subject: mb/emulation/qemu-i440fx: add e820 interface ...................................................................... mb/emulation/qemu-i440fx: add e820 interface Qemu provides e820 table at fw_cfg interface. Add functions to access it. Change-Id: I547bc7fef09999baa28149a6325cbca91e31e99b Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.h 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/30848/1 diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index c5d6253..1890e66 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -83,6 +83,30 @@ return fw_cfg_find_file(file, name); } +static uint32_t fw_cfg_e820_size; +static uint32_t fw_cfg_e820_pos; + +int fw_cfg_e820_select(void) +{ + FWCfgFile file; + + if (!fw_cfg_present() || fw_cfg_find_file(&file, "etc/e820")) + return -1; + fw_cfg_select(file.select); + fw_cfg_e820_size = file.size; + return 0; +} + +int fw_cfg_e820_read(FwCfgE820Entry *entry) +{ + if (fw_cfg_e820_pos + sizeof(*entry) > fw_cfg_e820_size) + return -1; + + fw_cfg_read(entry, sizeof(*entry)); + fw_cfg_e820_pos += sizeof(*entry); + return 0; +} + int fw_cfg_max_cpus(void) { unsigned short max_cpus; diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.h b/src/mainboard/emulation/qemu-i440fx/fw_cfg.h index b5cdb92..eb07847 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.h +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.h @@ -18,5 +18,11 @@ int fw_cfg_check_file(FWCfgFile *file, const char *name); int fw_cfg_max_cpus(void); unsigned long fw_cfg_smbios_tables(int *handle, unsigned long *current); +/* + * Do not call any other fw_cfg_ function between fw_cfg_e820_select and + * fw_cfg_e820_read. This causes undefind behavior. + */ +int fw_cfg_e820_select(void); +int fw_cfg_e820_read(FwCfgE820Entry *entry); #endif /* FW_CFG_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/30848 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I547bc7fef09999baa28149a6325cbca91e31e99b Gerrit-Change-Number: 30848 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

4 13

Change in ...coreboot[master]: mb/emulation/qemu-440fx: remove mm file listing
by Thomas Heijligen (Code Review) Feb. 5, 2019

Feb. 5, 2019

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30847 Change subject: mb/emulation/qemu-440fx: remove mm file listing ...................................................................... mb/emulation/qemu-440fx: remove mm file listing Remove memory maped copy of the file list to use it also in romstage. fw_cfg_find_file search directly for the file on data port. Change-Id: Ie97ed3f0c98a5bb18a35ab0eaf8c4777a53e5779 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M src/mainboard/emulation/qemu-i440fx/fw_cfg.c 1 file changed, 14 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/30847/1 diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 957e9d2..c5d6253 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -26,7 +26,7 @@ #define FW_CFG_PORT_DATA 0x0511 static unsigned char fw_cfg_detected = 0xff; -static FWCfgFiles *fw_files; +//static FWCfgFiles *fw_files; static int fw_cfg_present(void) { @@ -58,49 +58,29 @@ fw_cfg_read(dst, dstlen); } -static void fw_cfg_init_file(void) +static int fw_cfg_find_file(FWCfgFile *file, const char *name) { - u32 i, size, count = 0; + uint32_t count = 0; - if (fw_files != NULL) - return; + fw_cfg_select(FW_CFG_FILE_DIR); + fw_cfg_read(&count, sizeof(count)); - fw_cfg_get(FW_CFG_FILE_DIR, &count, sizeof(count)); - count = swab32(count); - size = count * sizeof(FWCfgFile) + sizeof(count); - printk(BIOS_DEBUG, "QEMU: %d files in fw_cfg\n", count); - fw_files = malloc(size); - fw_cfg_get(FW_CFG_FILE_DIR, fw_files, size); - fw_files->count = swab32(fw_files->count); - for (i = 0; i < count; i++) { - fw_files->f[i].size = swab32(fw_files->f[i].size); - fw_files->f[i].select = swab16(fw_files->f[i].select); - printk(BIOS_DEBUG, "QEMU: %s [size=%d]\n", - fw_files->f[i].name, fw_files->f[i].size); + for (int i = 0; i < count; i++) { + fw_cfg_read(file, sizeof(*file)); + if (strcmp(file->name, name) == 0) { + file->size = be32_to_cpu(file->size); + file->select = be16_to_cpu(file->select); + return 0; + } } -} - -static FWCfgFile *fw_cfg_find_file(const char *name) -{ - int i; - - fw_cfg_init_file(); - for (i = 0; i < fw_files->count; i++) - if (strcmp(fw_files->f[i].name, name) == 0) - return fw_files->f + i; - return NULL; + return -1; } int fw_cfg_check_file(FWCfgFile *file, const char *name) { - FWCfgFile *f; if (!fw_cfg_present()) return -1; - f = fw_cfg_find_file(name); - if (!f) - return -1; - *file = *f; - return 0; + return fw_cfg_find_file(file, name); } int fw_cfg_max_cpus(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/30847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie97ed3f0c98a5bb18a35ab0eaf8c4777a53e5779 Gerrit-Change-Number: 30847 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

4 13

Change in ...coreboot[master]: soc/intel/cannonlake: Add Whiskeylake SoC kconfig
by Subrata Banik (Code Review) Feb. 5, 2019

Feb. 5, 2019

Hello Aaron Durbin, Patrick Rudolph, PraveenX Hodagatta Pranesh, Angel Pons, Aamir Bohra, Duncan Laurie, Rizwan Qureshi, build bot (Jenkins), Lijian Zhao, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31133 to look at the new patch set (#7). Change subject: soc/intel/cannonlake: Add Whiskeylake SoC kconfig ...................................................................... soc/intel/cannonlake: Add Whiskeylake SoC kconfig This patch performs below tasks 1. Create SOC_INTEL_COMMON_CANNONLAKE_BASE kconfig. 2. Allow required SoC to select this kconfig to extend CANNONLAKE SoC support and add incremental changes. 3. Select correct SoC support for hatch, sarien, cflrvps and whlrvp. * Hatch is WHL SoC based board * Sarien is WHL SoC based board * CFLRVP U/8/11 are CFL SoC based board * WHLRVP is based on WHL SoC 4. Add correct FSP blobs path for WHL SoC based designs. Change-Id: I66b63361841f5a16615ddce4225c4f6182eabdb3 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/drivers/intel/fsp2_0/Kconfig M src/mainboard/google/hatch/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig.name M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/romstage/fsp_params.c 8 files changed, 32 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/31133/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/31133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66b63361841f5a16615ddce4225c4f6182eabdb3 Gerrit-Change-Number: 31133 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig
by Subrata Banik (Code Review) Feb. 5, 2019

Feb. 5, 2019

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 ) Change subject: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig ...................................................................... Patch Set 6: (3 comments) https://review.coreboot.org/#/c/31133/6/src/mainboard/intel/coffeelake_rvp/… File src/mainboard/intel/coffeelake_rvp/Kconfig: https://review.coreboot.org/#/c/31133/6/src/mainboard/intel/coffeelake_rvp/… PS6, Line 15: select SOC_INTEL_COFFEELAKE > It might be easier to just select this in Kconfig.name under appropriate BOARD_INTEL_*. […] Done https://review.coreboot.org/#/c/31133/6/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig: https://review.coreboot.org/#/c/31133/6/src/soc/intel/cannonlake/Kconfig@16 PS6, Line 16: select SOC_INTEL_CANNONLAKE > Just thinking out loud: Should this do a "select SOC_INTEL_COFFEELAKE" or maybe add another config o […] make sense and its valid as well https://review.coreboot.org/#/c/31133/6/src/soc/intel/cannonlake/Kconfig@258 PS6, Line 258: default "src/vendorcode/intel/fsp/fsp2_0/cannonlake/" if !SOC_INTEL_COFFEELAKE && !SOC_INTEL_WHISKEYLAKE : default "3rdparty/fsp/CoffeeLakeFspBinPkg/Include/" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE > Can we just swap the order so that the we can have the second case as default "src/vendorcode/intel/ […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/31133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66b63361841f5a16615ddce4225c4f6182eabdb3 Gerrit-Change-Number: 31133 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 05 Feb 2019 10:36:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: nb/intel/gm45: Use a common romstage
by Patrick Rudolph (Code Review) Feb. 5, 2019

Feb. 5, 2019

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31190 ) Change subject: nb/intel/gm45: Use a common romstage ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/31190/2/src/mainboard/lenovo/t400/romstage.c File src/mainboard/lenovo/t400/romstage.c: https://review.coreboot.org/#/c/31190/2/src/mainboard/lenovo/t400/romstage.… PS2, Line 71: if (dock_err) > Console is not yet initialised in mb_setup_superio. Yes, just put it in the code as comment to make sure future developers doesn't move it. -- To view, visit https://review.coreboot.org/c/coreboot/+/31190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1 Gerrit-Change-Number: 31190 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Feb 2019 09:00:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro(a)das-labor.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0