Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31216
to review the following change.
Change subject: sb/amd/agesa/hudson/Kconfig: Disable xHCI by default if no USE_BLOBS
......................................................................
sb/amd/agesa/hudson/Kconfig: Disable xHCI by default if no USE_BLOBS
Disable xHCI by default if USE_BLOBS option has not been selected.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: I1c3f0ff49fbe3db3ef095d99055f75d65cd6f661
---
M src/southbridge/amd/agesa/hudson/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/31216/1
diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index 3bb9385..8b6a60e 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -38,7 +38,7 @@
config HUDSON_XHCI_ENABLE
bool "Enable Hudson XHCI Controller"
- default y
+ default y if USE_BLOBS
help
The XHCI controller must be enabled and the XHCI firmware
must be added in order to have USB 3.0 support configured
--
To view, visit https://review.coreboot.org/c/coreboot/+/31216
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c3f0ff49fbe3db3ef095d99055f75d65cd6f661
Gerrit-Change-Number: 31216
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
Hello Alexander Couzens, Patrick Rudolph, Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31190
to look at the new patch set (#2).
Change subject: nb/intel/gm45: Use a common romstage
......................................................................
nb/intel/gm45: Use a common romstage
This moves a lot of the common romstage boilerplate code to a common
location, while adding a few mainboard specific hooks.
Another difference is that the settings for enable_igd and enable_peg
are now based on the static devicetree settings.
Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/mainboard/lenovo/t400/romstage.c
M src/mainboard/lenovo/x200/romstage.c
M src/mainboard/roda/rk9/romstage.c
M src/northbridge/intel/gm45/Makefile.inc
M src/northbridge/intel/gm45/gm45.h
A src/northbridge/intel/gm45/romstage.c
6 files changed, 179 insertions(+), 267 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/31190/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/31190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1
Gerrit-Change-Number: 31190
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31189
to look at the new patch set (#2).
Change subject: mb/lenovo/{x200,t400}: Set SMBUS mux using common SB functions
......................................................................
mb/lenovo/{x200,t400}: Set SMBUS mux using common SB functions
Change-Id: I1e9a165b722006557557058a14e9f5dac78d4538
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/mainboard/lenovo/t400/romstage.c
M src/mainboard/lenovo/x200/romstage.c
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/31189/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/31189
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e9a165b722006557557058a14e9f5dac78d4538
Gerrit-Change-Number: 31189
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31221
to review the following change.
Change subject: src/mainboard/lenovo/g505s/Kconfig: select NO_INTEL_WIFI option
......................................................................
src/mainboard/lenovo/g505s/Kconfig: select NO_INTEL_WIFI option
There were no G505S shipped with pre-installed Intel PCI-e WiFi adapters,
almost all such adapters (except Intel 135) could not be installed under
proprietary UEFI because of a whitelist, and I am not aware of anyone who
installed them after upgrading to coreboot - maybe because Atheros ath9k
have a much better software freedom status and are the preferred choice.
Select NO_INTEL_WIFI option to disable DRIVERS_INTEL_WIFI by default.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: I2e32436a88777fa58661611cb9dbca7f56a65b6e
---
M src/mainboard/lenovo/g505s/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31221/1
diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig
index 883ef27..53858ca 100644
--- a/src/mainboard/lenovo/g505s/Kconfig
+++ b/src/mainboard/lenovo/g505s/Kconfig
@@ -30,6 +30,7 @@
select BOARD_ROMSIZE_KB_4096
select GFXUMA
select NO_UART_ON_SUPERIO
+ select NO_INTEL_WIFI
config MAINBOARD_DIR
string
--
To view, visit https://review.coreboot.org/c/coreboot/+/31221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e32436a88777fa58661611cb9dbca7f56a65b6e
Gerrit-Change-Number: 31221
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31219
to review the following change.
Change subject: src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option
......................................................................
src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option
This NO_INTEL_WIFI option will help to disable DRIVERS_INTEL_WIFI by
default for the boards which are unlikely to have Intel PCI-e WiFi adapters.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: Ia21a141e25e58f6126a6d48d83cdfb4f746f3320
---
M src/drivers/intel/wifi/Kconfig
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/31219/1
diff --git a/src/drivers/intel/wifi/Kconfig b/src/drivers/intel/wifi/Kconfig
index 4dc4d7f..4082d7e 100644
--- a/src/drivers/intel/wifi/Kconfig
+++ b/src/drivers/intel/wifi/Kconfig
@@ -1,11 +1,15 @@
config DRIVERS_INTEL_WIFI
bool "Support Intel PCI-e WiFi adapters"
depends on ARCH_X86
- default y if PCIEXP_PLUGIN_SUPPORT
+ default y if PCIEXP_PLUGIN_SUPPORT && !NO_INTEL_WIFI
help
When enabled, add identifiers in ACPI and SMBIOS tables to
make OS drivers work with certain Intel PCI-e WiFi chipsets.
+# Select this for mainboard which is unlikely to have Intel PCI-e WiFi adapter.
+config NO_INTEL_WIFI
+ def_bool n
+
config USE_SAR
bool
default n
--
To view, visit https://review.coreboot.org/c/coreboot/+/31219
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia21a141e25e58f6126a6d48d83cdfb4f746f3320
Gerrit-Change-Number: 31219
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange