Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37586 )
Change subject: [WIP] soc/intel/denverton_ns: Fix virtual PCIe root port interrupts
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I333c2afd1e40bcd7daa3df4ceb8e5c34d3489871
Gerrit-Change-Number: 37586
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 10 Dec 2019 14:32:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36607 )
Change subject: mb/intel/harcuvar: Hack ast25xx bootstrap code
......................................................................
Patch Set 7:
(1 comment)
These aren't really ready for proper review yet...
https://review.coreboot.org/c/coreboot/+/36607/7/src/soc/intel/denverton_ns…
File src/soc/intel/denverton_ns/chip.c:
https://review.coreboot.org/c/coreboot/+/36607/7/src/soc/intel/denverton_ns…
PS7, Line 73: /* Debug output, remove if it stalls here. */
: pci_dump_ast25xx_path();
:
: ast25xx_probe();
:
: /* Debug output, remove if it stalls here. */
: pci_dump_ast25xx_path();
> Maybe wrap this is Kconfig option: […]
It will go into mainboard/ one day.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92195969419f9c38845cb67f294fdab33fb481af
Gerrit-Change-Number: 36607
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Dmitry Ponamorev
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-CC: David Guckian
Gerrit-Comment-Date: Tue, 10 Dec 2019 13:57:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Guckian
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37636 )
Change subject: Add Kyösti Mälkki <kyosti.malkki(a)gmail.com> patch files:
......................................................................
Patch Set 1:
Dmitry, please press abandon near top-right corner, this is squashed CB:37585 and CB:37586. I will resubmit these in a more reviewer-friendly shape.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c96a6ee86b0d01e9059558f754d001acdb3ed6a
Gerrit-Change-Number: 37636
Gerrit-PatchSet: 1
Gerrit-Owner: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 13:30:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36411 )
Change subject: Changes of Intel Harcuvar CRB sources for Atom C3538 Teleplatforms Zero board
......................................................................
Patch Set 2:
> Patch Set 2:
>
> > Patch Set 2: Code-Review-1
> >
> > You should not make these changes in mainboard/harcuvar
> > Instead you should create your own mainboard pkg
>
> Don't worry, there's currently the learning curve of gerrit and git going on.
no prob
--
To view, visit https://review.coreboot.org/c/coreboot/+/36411
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43735b376bafb1fd995fde50bc4e7d7ace915a03
Gerrit-Change-Number: 36411
Gerrit-PatchSet: 2
Gerrit-Owner: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 12:39:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36411 )
Change subject: Changes of Intel Harcuvar CRB sources for Atom C3538 Teleplatforms Zero board
......................................................................
Patch Set 2:
> Patch Set 2: Code-Review-1
>
> You should not make these changes in mainboard/harcuvar
> Instead you should create your own mainboard pkg
If your Vendor name is "Teleplatforms" then I suggest:
mainboard/teleplatforms/mainboard_name/
--
To view, visit https://review.coreboot.org/c/coreboot/+/36411
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43735b376bafb1fd995fde50bc4e7d7ace915a03
Gerrit-Change-Number: 36411
Gerrit-PatchSet: 2
Gerrit-Owner: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 12:37:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36411 )
Change subject: Changes of Intel Harcuvar CRB sources for Atom C3538 Teleplatforms Zero board
......................................................................
Patch Set 2:
> Patch Set 2: Code-Review-1
>
> You should not make these changes in mainboard/harcuvar
> Instead you should create your own mainboard pkg
Don't worry, there's currently the learning curve of gerrit and git going on.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36411
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43735b376bafb1fd995fde50bc4e7d7ace915a03
Gerrit-Change-Number: 36411
Gerrit-PatchSet: 2
Gerrit-Owner: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 12:36:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36411 )
Change subject: Changes of Intel Harcuvar CRB sources for Atom C3538 Teleplatforms Zero board
......................................................................
Patch Set 2: Code-Review-1
You should not make these changes in mainboard/harcuvar
Instead you should create your own mainboard pkg
--
To view, visit https://review.coreboot.org/c/coreboot/+/36411
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43735b376bafb1fd995fde50bc4e7d7ace915a03
Gerrit-Change-Number: 36411
Gerrit-PatchSet: 2
Gerrit-Owner: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: Дмитрий Понаморев <dponamorev(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 12:35:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment