coreboot-gerrit December 2019

coreboot-gerrit@coreboot.org

1 participants
1761 discussions

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Pavel Kovalenko (Code Review) 17 Dec '19

17 Dec '19

Pavel Kovalenko has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 8: > Patch Set 8: > > > Patch Set 8: > > > > I've published the schematic of the latest adapter board here: https://nitrocaster.me/files/X230U_rev6_schematic.pdf > > Hopefully this will help getting this merged. > > Let me know what you guys think. > > There is something wrong with the link now, just in case here is the mirror (I hope you don't mind): https://der.ttyh.ru/X230U_rev6_schematic.pdf Yeah, I accidentally messed up my apache configuration. Having a mirror won't hurt. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Kilian Neuner <cb(a)9-r.net> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-Comment-Date: Tue, 17 Dec 2019 10:35:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/rambi: add VBTs for variants
by Matt DeVillier (Code Review) 17 Dec '19

17 Dec '19

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37761 ) Change subject: mb/google/rambi: add VBTs for variants ...................................................................... mb/google/rambi: add VBTs for variants Add VBTs for all rambi variants, extracted from VGA BIOS from stock firmware images using intelvbttool. Test: boot several rambi variants using MrChromebox edk2/master branch with Baytrail GOP driver and extracted VBTs. Change-Id: I401ae5accd852fc5211092a5944fc85871b642ae Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/rambi/Kconfig A src/mainboard/google/rambi/variants/banjo/data.vbt A src/mainboard/google/rambi/variants/candy/data.vbt A src/mainboard/google/rambi/variants/clapper/data.vbt A src/mainboard/google/rambi/variants/enguarde/data.vbt A src/mainboard/google/rambi/variants/glimmer/data.vbt A src/mainboard/google/rambi/variants/gnawty/data.vbt A src/mainboard/google/rambi/variants/heli/data.vbt A src/mainboard/google/rambi/variants/kip/data.vbt A src/mainboard/google/rambi/variants/ninja/data.vbt A src/mainboard/google/rambi/variants/orco/data.vbt A src/mainboard/google/rambi/variants/quawks/data.vbt A src/mainboard/google/rambi/variants/squawks/data.vbt A src/mainboard/google/rambi/variants/sumo/data.vbt A src/mainboard/google/rambi/variants/swanky/data.vbt A src/mainboard/google/rambi/variants/winky/data.vbt 16 files changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/37761/1 diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index fc6e28e..7a23a7d 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -9,6 +9,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME + select INTEL_GMA_HAVE_VBT if !BOARD_GOOGLE_RAMBI select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 diff --git a/src/mainboard/google/rambi/variants/banjo/data.vbt b/src/mainboard/google/rambi/variants/banjo/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/banjo/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/candy/data.vbt b/src/mainboard/google/rambi/variants/candy/data.vbt new file mode 100644 index 0000000..0b76491 --- /dev/null +++ b/src/mainboard/google/rambi/variants/candy/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/clapper/data.vbt b/src/mainboard/google/rambi/variants/clapper/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/clapper/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/enguarde/data.vbt b/src/mainboard/google/rambi/variants/enguarde/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/enguarde/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/glimmer/data.vbt b/src/mainboard/google/rambi/variants/glimmer/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/glimmer/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/gnawty/data.vbt b/src/mainboard/google/rambi/variants/gnawty/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/gnawty/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/heli/data.vbt b/src/mainboard/google/rambi/variants/heli/data.vbt new file mode 100644 index 0000000..0b76491 --- /dev/null +++ b/src/mainboard/google/rambi/variants/heli/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/kip/data.vbt b/src/mainboard/google/rambi/variants/kip/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/kip/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/ninja/data.vbt b/src/mainboard/google/rambi/variants/ninja/data.vbt new file mode 100644 index 0000000..1971ebb --- /dev/null +++ b/src/mainboard/google/rambi/variants/ninja/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/orco/data.vbt b/src/mainboard/google/rambi/variants/orco/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/orco/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/quawks/data.vbt b/src/mainboard/google/rambi/variants/quawks/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/quawks/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/squawks/data.vbt b/src/mainboard/google/rambi/variants/squawks/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/squawks/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/sumo/data.vbt b/src/mainboard/google/rambi/variants/sumo/data.vbt new file mode 100644 index 0000000..51cc56b --- /dev/null +++ b/src/mainboard/google/rambi/variants/sumo/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/swanky/data.vbt b/src/mainboard/google/rambi/variants/swanky/data.vbt new file mode 100644 index 0000000..d299aa4 --- /dev/null +++ b/src/mainboard/google/rambi/variants/swanky/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/winky/data.vbt b/src/mainboard/google/rambi/variants/winky/data.vbt new file mode 100644 index 0000000..55fa91a --- /dev/null +++ b/src/mainboard/google/rambi/variants/winky/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/37761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I401ae5accd852fc5211092a5944fc85871b642ae Gerrit-Change-Number: 37761 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: mb/google/jecht: Add VBTs for all variants
by Nico Huber (Code Review) 17 Dec '19

17 Dec '19

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37735 ) Change subject: mb/google/jecht: Add VBTs for all variants ...................................................................... mb/google/jecht: Add VBTs for all variants Add VBTs for jecht variants, extracted from VGA BIOS from stock firmware images using intelvbttool, zero-padded to 0x11ff bytes to make the Intel BMP editor happy. Use a common VBT for all except tidus, since it differs from the others. Change-Id: I570bdb749ef7d49f41539074220bb16c9c100342 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37735 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/google/jecht/Kconfig A src/mainboard/google/jecht/data.vbt A src/mainboard/google/jecht/variants/tidus/data.vbt 3 files changed, 6 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index 6d1fda9..71143c9 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -6,6 +6,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM @@ -46,6 +47,11 @@ string default "pci8086,0406.rom" +# Override the default variant behavior, since the data.vbt is the same +# for all variants except tidus +config INTEL_GMA_VBT_FILE + default "src/mainboard/$(MAINBOARDDIR)/data.vbt" if !BOARD_GOOGLE_TIDUS + config MAINBOARD_SMBIOS_MANUFACTURER string default "GOOGLE" diff --git a/src/mainboard/google/jecht/data.vbt b/src/mainboard/google/jecht/data.vbt new file mode 100644 index 0000000..300035c --- /dev/null +++ b/src/mainboard/google/jecht/data.vbt Binary files differ diff --git a/src/mainboard/google/jecht/variants/tidus/data.vbt b/src/mainboard/google/jecht/variants/tidus/data.vbt new file mode 100644 index 0000000..dce9168 --- /dev/null +++ b/src/mainboard/google/jecht/variants/tidus/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/37735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I570bdb749ef7d49f41539074220bb16c9c100342 Gerrit-Change-Number: 37735 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Aleksei Kharlamov (Code Review) 17 Dec '19

17 Dec '19

Aleksei Kharlamov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 8: > Patch Set 8: > > I've published the schematic of the latest adapter board here: https://nitrocaster.me/files/X230U_rev6_schematic.pdf > Hopefully this will help getting this merged. > Let me know what you guys think. There is something wrong with the link now, just in case here is the mirror (I hope you don't mind): https://der.ttyh.ru/X230U_rev6_schematic.pdf -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Kilian Neuner <cb(a)9-r.net> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <paul-kv(a)yandex.ru> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-Comment-Date: Tue, 17 Dec 2019 10:17:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/poppy: add VBTs for remaining variants
by Matt DeVillier (Code Review) 17 Dec '19

17 Dec '19

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37311 ) Change subject: mb/google/poppy: add VBTs for remaining variants ...................................................................... mb/google/poppy: add VBTs for remaining variants Add VBT files for Atlas, Nocturne, Rammus, and Soraka variants. Extracted from ChromeOS recovery images for the respective boards. Change-Id: Icba2741e0b7309c22c027f956cd20cec78f34052 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/atlas/data.vbt A src/mainboard/google/poppy/variants/nocturne/data.vbt A src/mainboard/google/poppy/variants/rammus/data.vbt A src/mainboard/google/poppy/variants/soraka/data.vbt 5 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/37311/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index e8fb38d..9fafef7 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -10,7 +10,6 @@ select EC_GOOGLE_CHROMEEC_ESPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI || BOARD_GOOGLE_NAUTILUS select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select SOC_INTEL_KABYLAKE @@ -145,6 +144,7 @@ select EXCLUDE_NATIVE_SD_INTERFACE select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR select INCLUDE_NHLT_BLOBS_ATLAS if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_SPI_TPM_CR50 select VARIANT_HAS_CAMERA_ACPI @@ -163,6 +163,7 @@ select DRIVERS_SPI_ACPI select EXCLUDE_NATIVE_SD_INTERFACE select INCLUDE_NHLT_BLOBS_NAMI if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_SPI_TPM_CR50 config VARIANT_SPECIFIC_OPTIONS_NAUTILUS @@ -171,6 +172,7 @@ select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 select INCLUDE_NHLT_BLOBS_NAUTILUS if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_I2C_TPM_CR50 select VARIANT_HAS_CAMERA_ACPI @@ -185,6 +187,7 @@ select EXCLUDE_NATIVE_SD_INTERFACE select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR select INCLUDE_NHLT_BLOBS_NOCTURNE if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_SPI_TPM_CR50 select NO_FADT_8042 select VARIANT_HAS_CAMERA_ACPI @@ -197,6 +200,7 @@ select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select INCLUDE_NHLT_BLOBS_RAMMUS if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_SPI_TPM_CR50 config VARIANT_SPECIFIC_OPTIONS_SORAKA @@ -204,6 +208,7 @@ select DRIVERS_I2C_MAX98927 select NO_FADT_8042 select MAINBOARD_HAS_I2C_TPM_CR50 + select INTEL_GMA_HAVE_VBT select VARIANT_HAS_CAMERA_ACPI config VBOOT diff --git a/src/mainboard/google/poppy/variants/atlas/data.vbt b/src/mainboard/google/poppy/variants/atlas/data.vbt new file mode 100644 index 0000000..850375e --- /dev/null +++ b/src/mainboard/google/poppy/variants/atlas/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/nocturne/data.vbt b/src/mainboard/google/poppy/variants/nocturne/data.vbt new file mode 100644 index 0000000..4d9293e --- /dev/null +++ b/src/mainboard/google/poppy/variants/nocturne/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/rammus/data.vbt b/src/mainboard/google/poppy/variants/rammus/data.vbt new file mode 100644 index 0000000..5fc6e1c --- /dev/null +++ b/src/mainboard/google/poppy/variants/rammus/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/soraka/data.vbt b/src/mainboard/google/poppy/variants/soraka/data.vbt new file mode 100644 index 0000000..4156bde --- /dev/null +++ b/src/mainboard/google/poppy/variants/soraka/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/37311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icba2741e0b7309c22c027f956cd20cec78f34052 Gerrit-Change-Number: 37311 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

5 10

Change in coreboot[master]: mb/intel/tglrvp: Do initial mainboard commit
by Ravishankar Sarawadi (Code Review) 17 Dec '19

17 Dec '19

Hello Srinidhi N Kaushik, Raj Astekar, Subrata Banik, Arthur Heymans, Wonkyu Kim, John Zhao, build bot (Jenkins), Shaunak Saha, Furquan Shaikh, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36091 to look at the new patch set (#15). Change subject: mb/intel/tglrvp: Do initial mainboard commit ...................................................................... mb/intel/tglrvp: Do initial mainboard commit - Add tglrvp baseboard files - Add tglrvp UP3 variant board files - Add board id support - Add SPD memory support TEST=Build and boot tigerlake rvp board Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Change-Id: I79a05881d2ea50ff4113243bf5ae26207db63322 --- A src/mainboard/intel/tglrvp/Kconfig A src/mainboard/intel/tglrvp/Kconfig.name A src/mainboard/intel/tglrvp/Makefile.inc A src/mainboard/intel/tglrvp/acpi/mainboard.asl A src/mainboard/intel/tglrvp/acpi/mipi_camera.asl A src/mainboard/intel/tglrvp/acpi_tables.c A src/mainboard/intel/tglrvp/board_id.c A src/mainboard/intel/tglrvp/board_id.h A src/mainboard/intel/tglrvp/board_info.txt A src/mainboard/intel/tglrvp/bootblock.c A src/mainboard/intel/tglrvp/chromeos.c A src/mainboard/intel/tglrvp/chromeos.fmd A src/mainboard/intel/tglrvp/dsdt.asl A src/mainboard/intel/tglrvp/ec.c A src/mainboard/intel/tglrvp/romstage.c A src/mainboard/intel/tglrvp/smihandler.c A src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.hex A src/mainboard/intel/tglrvp/spd/Makefile.inc A src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.hex A src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd.hex A src/mainboard/intel/tglrvp/spd/spd.h A src/mainboard/intel/tglrvp/variants/baseboard/Makefile.inc A src/mainboard/intel/tglrvp/variants/baseboard/devicetree.cb A src/mainboard/intel/tglrvp/variants/baseboard/gpio.c A src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h A src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/gpio.h A src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/variants.h A src/mainboard/intel/tglrvp/variants/baseboard/mainboard.c A src/mainboard/intel/tglrvp/variants/baseboard/memory.c A src/mainboard/intel/tglrvp/variants/tglrvp_up3/Makefile.inc A src/mainboard/intel/tglrvp/variants/tglrvp_up3/include/variant/ec.h A src/mainboard/intel/tglrvp/variants/tglrvp_up3/include/variant/gpio.h 32 files changed, 2,125 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/36091/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/36091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79a05881d2ea50ff4113243bf5ae26207db63322 Gerrit-Change-Number: 36091 Gerrit-PatchSet: 15 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/tigerlake: Update GPIO config
by Ravishankar Sarawadi (Code Review) 17 Dec '19

17 Dec '19

Hello Srinidhi N Kaushik, Raj Astekar, Patrick Rudolph, Venkata Krishna Nimmagadda, Subrata Banik, Wonkyu Kim, build bot (Jenkins), Shaunak Saha, Furquan Shaikh, Jamie Ryu, Francois Toguo Fotso, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37427 to look at the new patch set (#9). Change subject: soc/intel/tigerlake: Update GPIO config ...................................................................... soc/intel/tigerlake: Update GPIO config Add tigerlake SOC specific GPIO definitions and ASL setting. BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa --- M src/soc/intel/tigerlake/acpi/gpio.asl M src/soc/intel/tigerlake/gpio.c M src/soc/intel/tigerlake/include/soc/gpio.h M src/soc/intel/tigerlake/include/soc/gpio_defs.h M src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h M src/soc/intel/tigerlake/include/soc/pmc.h 6 files changed, 781 insertions(+), 637 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37427/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/37427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa Gerrit-Change-Number: 37427 Gerrit-PatchSet: 9 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: pc80/rtc/mc146818rtc: {read,save}_vbnv_cmos only if VBOOT is set
by HAOUAS Elyes (Code Review) 17 Dec '19

17 Dec '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37785 ) Change subject: pc80/rtc/mc146818rtc: {read,save}_vbnv_cmos only if VBOOT is set ...................................................................... pc80/rtc/mc146818rtc: {read,save}_vbnv_cmos only if VBOOT is set Change-Id: Ib33e70efbe57b6ff57e132040bb3a6d08be7d50c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/pc80/rtc/mc146818rtc.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/37785/1 diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index d3efdec..29f498b 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -173,10 +173,12 @@ clear vbnv data for other internal reasons. For that, always back up the vbnv contents and conditionally save them when __cmos_init() indicates cmos was cleared. */ - read_vbnv_cmos(vbnv); + if (CONFIG(VBOOT)) { + read_vbnv_cmos(vbnv); - if (__cmos_init(invalid)) - save_vbnv_cmos(vbnv); + if (__cmos_init(invalid)) + save_vbnv_cmos(vbnv); + } } void cmos_init(bool invalid) -- To view, visit https://review.coreboot.org/c/coreboot/+/37785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib33e70efbe57b6ff57e132040bb3a6d08be7d50c Gerrit-Change-Number: 37785 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/tglrvp: Do initial mainboard commit
by Ravishankar Sarawadi (Code Review) 17 Dec '19

17 Dec '19

Hello Srinidhi N Kaushik, Raj Astekar, Subrata Banik, Arthur Heymans, Wonkyu Kim, John Zhao, build bot (Jenkins), Shaunak Saha, Furquan Shaikh, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36091 to look at the new patch set (#14). Change subject: mb/intel/tglrvp: Do initial mainboard commit ...................................................................... mb/intel/tglrvp: Do initial mainboard commit - Add tglrvp baseboard files - Add tglrvp UP3 variant board files - Add board id support - Add SPD memory support TEST=Build and boot tigerlake rvp board Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Change-Id: I79a05881d2ea50ff4113243bf5ae26207db63322 --- A src/mainboard/intel/tglrvp/Kconfig A src/mainboard/intel/tglrvp/Kconfig.name A src/mainboard/intel/tglrvp/Makefile.inc A src/mainboard/intel/tglrvp/acpi/mainboard.asl A src/mainboard/intel/tglrvp/acpi/mipi_camera.asl A src/mainboard/intel/tglrvp/acpi_tables.c A src/mainboard/intel/tglrvp/board_id.c A src/mainboard/intel/tglrvp/board_id.h A src/mainboard/intel/tglrvp/board_info.txt A src/mainboard/intel/tglrvp/bootblock.c A src/mainboard/intel/tglrvp/chromeos.c A src/mainboard/intel/tglrvp/chromeos.fmd A src/mainboard/intel/tglrvp/dsdt.asl A src/mainboard/intel/tglrvp/ec.c A src/mainboard/intel/tglrvp/romstage.c A src/mainboard/intel/tglrvp/smihandler.c A src/mainboard/intel/tglrvp/spd/Hynix-H9HKNNNEBMAV-4267.spd.hex A src/mainboard/intel/tglrvp/spd/Makefile.inc A src/mainboard/intel/tglrvp/spd/Micron-MT53D1G64D8SQ-046.spd.hex A src/mainboard/intel/tglrvp/spd/Samsung-K4UBE3D4AA-MGCL.spd.hex A src/mainboard/intel/tglrvp/spd/spd.h A src/mainboard/intel/tglrvp/variants/baseboard/Makefile.inc A src/mainboard/intel/tglrvp/variants/baseboard/devicetree.cb A src/mainboard/intel/tglrvp/variants/baseboard/gpio.c A src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/ec.h A src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/gpio.h A src/mainboard/intel/tglrvp/variants/baseboard/include/baseboard/variants.h A src/mainboard/intel/tglrvp/variants/baseboard/mainboard.c A src/mainboard/intel/tglrvp/variants/baseboard/memory.c A src/mainboard/intel/tglrvp/variants/tglrvp_up3/Makefile.inc A src/mainboard/intel/tglrvp/variants/tglrvp_up3/include/variant/ec.h A src/mainboard/intel/tglrvp/variants/tglrvp_up3/include/variant/gpio.h 32 files changed, 2,128 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/36091/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/36091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79a05881d2ea50ff4113243bf5ae26207db63322 Gerrit-Change-Number: 36091 Gerrit-PatchSet: 14 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/tigerlake: Update GPIO config
by Ravishankar Sarawadi (Code Review) 17 Dec '19

17 Dec '19

Hello Srinidhi N Kaushik, Raj Astekar, Patrick Rudolph, Venkata Krishna Nimmagadda, Subrata Banik, Wonkyu Kim, build bot (Jenkins), Shaunak Saha, Jamie Ryu, Francois Toguo Fotso, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37427 to look at the new patch set (#8). Change subject: soc/intel/tigerlake: Update GPIO config ...................................................................... soc/intel/tigerlake: Update GPIO config Add tigerlake SOC specific GPIO definitions and ASL setting. BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa --- M src/soc/intel/tigerlake/acpi/gpio.asl M src/soc/intel/tigerlake/gpio.c M src/soc/intel/tigerlake/include/soc/gpio.h M src/soc/intel/tigerlake/include/soc/gpio_defs.h M src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h M src/soc/intel/tigerlake/include/soc/pmc.h 6 files changed, 785 insertions(+), 637 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37427/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/37427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa Gerrit-Change-Number: 37427 Gerrit-PatchSet: 8 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2019