coreboot-gerrit December 2019

coreboot-gerrit@coreboot.org

1 participants
1761 discussions

Change in coreboot[master]: arch|cpu/x86: Add Kconfig option for x86 reset vector
by Marshall Dawson (Code Review) 20 Dec '19

20 Dec '19

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37485 ) Change subject: arch|cpu/x86: Add Kconfig option for x86 reset vector ...................................................................... arch|cpu/x86: Add Kconfig option for x86 reset vector Prepare for an implementation supporting the reset vector in RAM and not the traditional 0xfffffff0. Add a Kconfig symbol that can be used in place of hardcoded values. Change-Id: I6a814f7179ee4251aeeccb2555221616e944e03d Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/arch/x86/Kconfig M src/arch/x86/failover.ld M src/arch/x86/id.ld M src/arch/x86/memlayout.ld M src/cpu/intel/fit/fit.ld M src/cpu/x86/16bit/reset16.ld 6 files changed, 19 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/37485/1 diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 0e6f486..e27aec2 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -87,6 +87,16 @@ default n depends on ARCH_X86 && SMP +config X86_RESET_VECTOR + hex + depends on ARCH_X86 + default 0xfffffff0 + help + Specify the location of the x86 reset vector. In traditional devices + this must match the architectural reset vector to produce a bootable + image. Nontraditional designs may use this to position the reset + vector into its desired location. + config RESET_VECTOR_IN_RAM bool depends on ARCH_X86 diff --git a/src/arch/x86/failover.ld b/src/arch/x86/failover.ld index 334145a..8015d66 100644 --- a/src/arch/x86/failover.ld +++ b/src/arch/x86/failover.ld @@ -14,7 +14,7 @@ ENTRY(_start) MEMORY { - rom : ORIGIN = 0xffff0000, LENGTH = 64K + rom : ORIGIN = (CONFIG_X86_RESET_VECTOR - 0xfff0, LENGTH = 64K } TARGET(binary) diff --git a/src/arch/x86/id.ld b/src/arch/x86/id.ld index 2a50f9c..3d9ef37 100644 --- a/src/arch/x86/id.ld +++ b/src/arch/x86/id.ld @@ -12,7 +12,7 @@ */ SECTIONS { - . = (0xffffffff - CONFIG_ID_SECTION_OFFSET) - (__id_end - __id_start) + 1; + . = (CONFIG_X86_RESET_VECTOR - CONFIG_ID_SECTION_OFFSET) - (__id_end - __id_start) + 0x10; .id (.): { KEEP(*(.id)) } diff --git a/src/arch/x86/memlayout.ld b/src/arch/x86/memlayout.ld index f8ae9f3..b14fd62 100644 --- a/src/arch/x86/memlayout.ld +++ b/src/arch/x86/memlayout.ld @@ -50,7 +50,7 @@ #include EARLY_MEMLAYOUT #elif ENV_BOOTBLOCK /* arch/x86/bootblock.ld contains the logic for the ROMCC_BOOTBLOCK linking. */ - BOOTBLOCK(0xffffffff - CONFIG_C_ENV_BOOTBLOCK_SIZE + 1, + BOOTBLOCK(CONFIG_X86_RESET_VECTOR - CONFIG_C_ENV_BOOTBLOCK_SIZE + 0x10, CONFIG_C_ENV_BOOTBLOCK_SIZE) #include EARLY_MEMLAYOUT diff --git a/src/cpu/intel/fit/fit.ld b/src/cpu/intel/fit/fit.ld index 6e30ea1..2e65186 100644 --- a/src/cpu/intel/fit/fit.ld +++ b/src/cpu/intel/fit/fit.ld @@ -12,7 +12,7 @@ */ SECTIONS { - . = 0xffffffc0; + . = CONFIG_X86_RESET_VECTOR - 0x30; /* 0xffffffc0 */ .fit_pointer (.): { KEEP(*(.fit_pointer)) } diff --git a/src/cpu/x86/16bit/reset16.ld b/src/cpu/x86/16bit/reset16.ld index c57cc96..ec01810 100644 --- a/src/cpu/x86/16bit/reset16.ld +++ b/src/cpu/x86/16bit/reset16.ld @@ -11,16 +11,14 @@ * GNU General Public License for more details. */ -/* - * _ROMTOP : The top of the ROM used where we - * need to put the reset vector. - */ +/* _RESET_VECTOR: typically the top of the ROM */ SECTIONS { /* Trigger an error if I have an unuseable start address */ - _bogus = ASSERT(_start16bit >= 0xffff0000, "_start16bit too low. Please report."); - _ROMTOP = 0xfffffff0; - . = _ROMTOP; + _TOO_LOW = CONFIG_X86_RESET_VECTOR - 0xfff0; + _bogus = ASSERT(_start16bit >= _TOO_LOW, "_start16bit too low. Please report."); + + . = CONFIG_X86_RESET_VECTOR; .reset . : { *(.reset); . = 15; -- To view, visit https://review.coreboot.org/c/coreboot/+/37485 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a814f7179ee4251aeeccb2555221616e944e03d Gerrit-Change-Number: 37485 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

3 6

Change in coreboot[master]: AGESA,binaryPI: Drop remains of ROMCC_BOOTBLOCK
by Kyösti Mälkki (Code Review) 20 Dec '19

20 Dec '19

Hello Michał Żygowski, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/37440 to review the following change. Change subject: AGESA,binaryPI: Drop remains of ROMCC_BOOTBLOCK ...................................................................... AGESA,binaryPI: Drop remains of ROMCC_BOOTBLOCK Change-Id: I507ac6d483d9854852d6d01f10544c450b8d33cc Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/drivers/amd/agesa/Makefile.inc M src/drivers/amd/agesa/bootblock.c M src/drivers/amd/agesa/romstage.c M src/northbridge/amd/agesa/family14/Makefile.inc M src/southbridge/amd/agesa/hudson/Kconfig M src/southbridge/amd/agesa/hudson/Makefile.inc M src/southbridge/amd/agesa/hudson/bootblock.c M src/southbridge/amd/cimx/sb800/Makefile.inc M src/southbridge/amd/cimx/sb800/bootblock.c M src/southbridge/amd/pi/hudson/Kconfig M src/southbridge/amd/pi/hudson/Makefile.inc M src/southbridge/amd/pi/hudson/bootblock.c 12 files changed, 19 insertions(+), 100 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37440/1 diff --git a/src/drivers/amd/agesa/Makefile.inc b/src/drivers/amd/agesa/Makefile.inc index 3c3c4fc..4536fc9 100644 --- a/src/drivers/amd/agesa/Makefile.inc +++ b/src/drivers/amd/agesa/Makefile.inc @@ -19,12 +19,8 @@ ramstage-y += state_machine.c -ifneq ($(CONFIG_ROMCC_BOOTBLOCK),y) bootblock-y += bootblock.c bootblock-y += cache_as_ram.S -else -cpu_incs-y += $(src)/drivers/amd/agesa/cache_as_ram.S -endif postcar-y += exit_car.S diff --git a/src/drivers/amd/agesa/bootblock.c b/src/drivers/amd/agesa/bootblock.c index 42752bc..e245508 100644 --- a/src/drivers/amd/agesa/bootblock.c +++ b/src/drivers/amd/agesa/bootblock.c @@ -45,6 +45,11 @@ CONFIG_PI_AGESA_HEAP_SIZE, MTRR_TYPE_WRBACK); } +void bootblock_soc_early_init(void) +{ + bootblock_early_southbridge_init(); +} + asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { init_mmio(); diff --git a/src/drivers/amd/agesa/romstage.c b/src/drivers/amd/agesa/romstage.c index 684fa66..82450f4 100644 --- a/src/drivers/amd/agesa/romstage.c +++ b/src/drivers/amd/agesa/romstage.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/cpu.h> #include <arch/romstage.h> -#include <bootblock_common.h> #include <cbmem.h> #include <console/console.h> #include <halt.h> @@ -53,16 +52,10 @@ u8 initial_apic_id = (u8) (cpuid_ebx(1) >> 24); int cbmem_initted = 0; - /* Enable PCI MMIO configuration. */ - if (CONFIG(ROMCC_BOOTBLOCK)) - amd_initmmio(); - fill_sysinfo(cb); if (initial_apic_id == 0) { - if (CONFIG(ROMCC_BOOTBLOCK)) - timestamp_init(timestamp_get()); timestamp_add_now(TS_START_ROMSTAGE); platform_once(cb); @@ -73,8 +66,7 @@ printk(BIOS_DEBUG, "APIC %02d: CPU Family_Model = %08x\n", initial_apic_id, cpuid_eax(1)); - if (!CONFIG(ROMCC_BOOTBLOCK)) - set_ap_entry_ptr(ap_romstage_main); + set_ap_entry_ptr(ap_romstage_main); agesa_execute_state(cb, AMD_INIT_RESET); @@ -115,10 +107,6 @@ struct sysinfo romstage_state; struct sysinfo *cb = &romstage_state; - /* Enable PCI MMIO configuration. */ - if (CONFIG(ROMCC_BOOTBLOCK)) - amd_initmmio(); - fill_sysinfo(cb); agesa_execute_state(cb, AMD_INIT_RESET); @@ -129,22 +117,7 @@ halt(); } -#if CONFIG(ROMCC_BOOTBLOCK) -/* This wrapper enables easy transition away from ROMCC_BOOTBLOCK - * keeping changes in cache_as_ram.S easy to manage. - */ -asmlinkage void bootblock_c_entry(uint64_t base_timestamp) -{ - romstage_main(); -} - -asmlinkage void ap_bootblock_c_entry(void) -{ - ap_romstage_main(); -} -#else asmlinkage void car_stage_entry(void) { romstage_main(); } -#endif diff --git a/src/northbridge/amd/agesa/family14/Makefile.inc b/src/northbridge/amd/agesa/family14/Makefile.inc index aad7acc..dd9ba58 100644 --- a/src/northbridge/amd/agesa/family14/Makefile.inc +++ b/src/northbridge/amd/agesa/family14/Makefile.inc @@ -13,9 +13,7 @@ # GNU General Public License for more details. # -ifneq ($(CONFIG_ROMCC_BOOTBLOCK),y) bootblock-y += bootblock.c -endif romstage-y += dimmSpd.c diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig index 93db1a9..e56a493 100644 --- a/src/southbridge/amd/agesa/hudson/Kconfig +++ b/src/southbridge/amd/agesa/hudson/Kconfig @@ -31,10 +31,6 @@ select SOC_AMD_COMMON_BLOCK select SOC_AMD_COMMON_BLOCK_ACPIMMIO -config BOOTBLOCK_SOUTHBRIDGE_INIT - string - default "southbridge/amd/agesa/hudson/bootblock.c" - config EHCI_BAR hex default 0xfef00000 diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc index 5c92128..34c7518 100644 --- a/src/southbridge/amd/agesa/hudson/Makefile.inc +++ b/src/southbridge/amd/agesa/hudson/Makefile.inc @@ -17,11 +17,9 @@ ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c ramstage-y += reset.c -ifneq ($(CONFIG_ROMCC_BOOTBLOCK),y) bootblock-y += bootblock.c bootblock-y += early_setup.c bootblock-$(CONFIG_USBDEBUG) += enable_usbdebug.c -endif romstage-y += enable_usbdebug.c ramstage-y += enable_usbdebug.c diff --git a/src/southbridge/amd/agesa/hudson/bootblock.c b/src/southbridge/amd/agesa/hudson/bootblock.c index 97e8803..bef87e0 100644 --- a/src/southbridge/amd/agesa/hudson/bootblock.c +++ b/src/southbridge/amd/agesa/hudson/bootblock.c @@ -14,7 +14,10 @@ */ #include <stdint.h> +#include <bootblock_common.h> +#include <amdblocks/acpimmio.h> #include <device/pci_ops.h> +#include <southbridge/amd/agesa/hudson/hudson.h> /* * Enable 4MB (LPC) ROM access at 0xFFC00000 - 0xFFFFFFFF. @@ -56,24 +59,12 @@ pci_io_write_config16(dev, 0x6e, 0xffff); } -static void bootblock_southbridge_init(void) -{ - hudson_enable_rom(); -} - - -#if !CONFIG(ROMCC_BOOTBLOCK) - -#include <bootblock_common.h> -#include <amdblocks/acpimmio.h> -#include <southbridge/amd/agesa/hudson/hudson.h> - -void bootblock_soc_early_init(void) +void bootblock_early_southbridge_init(void) { pci_devfn_t dev; u32 data; - bootblock_southbridge_init(); + hudson_enable_rom(); hudson_lpc_decode(); enable_acpimmio_decode_pm24(); @@ -89,7 +80,6 @@ * Enable decoding of legacy TPM addresses: IO addresses 0x7f- * 0x7e and 0xef-0xee. */ - data = pci_read_config32(dev, LPC_TRUSTED_PLATFORM_MODULE); data |= TPM_12_EN | TPM_LEGACY_EN; pci_write_config32(dev, LPC_TRUSTED_PLATFORM_MODULE, data); @@ -104,4 +94,3 @@ */ pm_write8(0xd2, 0); } -#endif diff --git a/src/southbridge/amd/cimx/sb800/Makefile.inc b/src/southbridge/amd/cimx/sb800/Makefile.inc index ccb3a2a..8e27b34 100644 --- a/src/southbridge/amd/cimx/sb800/Makefile.inc +++ b/src/southbridge/amd/cimx/sb800/Makefile.inc @@ -16,9 +16,7 @@ # SB800 Platform Files -ifneq ($(CONFIG_ROMCC_BOOTBLOCK),y) bootblock-y += bootblock.c -endif romstage-y += cfg.c romstage-y += early.c diff --git a/src/southbridge/amd/cimx/sb800/bootblock.c b/src/southbridge/amd/cimx/sb800/bootblock.c index b4f03da..0e11db3 100644 --- a/src/southbridge/amd/cimx/sb800/bootblock.c +++ b/src/southbridge/amd/cimx/sb800/bootblock.c @@ -13,7 +13,8 @@ * GNU General Public License for more details. */ -#include <arch/io.h> +#include <amdblocks/acpimmio.h> +#include <bootblock_common.h> #include <device/pci_ops.h> static void enable_rom(void) @@ -79,17 +80,6 @@ pci_io_write_config32(dev, 0xa0, save); } -static void enable_acpimmio_decode_pm24(void) -{ - u8 reg8; - - outb(0x24, 0xCD6); - reg8 = inb(0xCD7); - reg8 |= 1; - reg8 &= ~(1 << 1); - outb(reg8, 0xCD7); -} - static void enable_clocks(void) { u32 reg32; @@ -109,7 +99,7 @@ *acpi_mmio = reg32; } -static void bootblock_southbridge_init(void) +void bootblock_early_southbridge_init(void) { /* Setup the ROM access for 2M */ enable_rom(); @@ -120,12 +110,3 @@ enable_acpimmio_decode_pm24(); enable_clocks(); } - -#if !CONFIG(ROMCC_BOOTBLOCK) -#include <bootblock_common.h> - -void bootblock_soc_early_init(void) -{ - bootblock_southbridge_init(); -} -#endif diff --git a/src/southbridge/amd/pi/hudson/Kconfig b/src/southbridge/amd/pi/hudson/Kconfig index 01f3937..ea37e3e 100644 --- a/src/southbridge/amd/pi/hudson/Kconfig +++ b/src/southbridge/amd/pi/hudson/Kconfig @@ -34,10 +34,6 @@ select SOC_AMD_COMMON_BLOCK select SOC_AMD_COMMON_BLOCK_ACPIMMIO -config BOOTBLOCK_SOUTHBRIDGE_INIT - string - default "southbridge/amd/pi/hudson/bootblock.c" - config EHCI_BAR hex default 0xfef00000 diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc index 615fc04..738e0be 100644 --- a/src/southbridge/amd/pi/hudson/Makefile.inc +++ b/src/southbridge/amd/pi/hudson/Makefile.inc @@ -28,11 +28,9 @@ # #***************************************************************************** -ifneq ($(CONFIG_ROMCC_BOOTBLOCK),y) bootblock-y += bootblock.c bootblock-y += early_setup.c bootblock-$(CONFIG_USBDEBUG) += enable_usbdebug.c -endif romstage-y += early_setup.c romstage-y += enable_usbdebug.c diff --git a/src/southbridge/amd/pi/hudson/bootblock.c b/src/southbridge/amd/pi/hudson/bootblock.c index e9a9d33..a8fcaac 100644 --- a/src/southbridge/amd/pi/hudson/bootblock.c +++ b/src/southbridge/amd/pi/hudson/bootblock.c @@ -14,7 +14,10 @@ */ #include <stdint.h> +#include <bootblock_common.h> +#include <amdblocks/acpimmio.h> #include <device/pci_ops.h> +#include <southbridge/amd/pi/hudson/hudson.h> /* * Enable 4MB (LPC) ROM access at 0xFFC00000 - 0xFFFFFFFF. @@ -56,23 +59,12 @@ pci_io_write_config16(dev, 0x6e, 0xffff); } -static void bootblock_southbridge_init(void) -{ - hudson_enable_rom(); -} - -#if !CONFIG(ROMCC_BOOTBLOCK) - -#include <bootblock_common.h> -#include <amdblocks/acpimmio.h> -#include <southbridge/amd/pi/hudson/hudson.h> - -void bootblock_soc_early_init(void) +void bootblock_early_southbridge_init(void) { pci_devfn_t dev; u32 data; - bootblock_southbridge_init(); + hudson_enable_rom(); hudson_lpc_decode(); if (CONFIG(SOUTHBRIDGE_AMD_PI_BOLTON)) enable_acpimmio_decode_pm24(); @@ -106,4 +98,3 @@ */ pm_write8(0xd2, 0); } -#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/37440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I507ac6d483d9854852d6d01f10544c450b8d33cc Gerrit-Change-Number: 37440 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

6 19

Change in coreboot[master]: mb/intel/tglrvp: Do initial mainboard commit
by Wonkyu Kim (Code Review) 20 Dec '19

20 Dec '19

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36091 ) Change subject: mb/intel/tglrvp: Do initial mainboard commit ...................................................................... Patch Set 17: (1 comment) https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… File src/mainboard/intel/tglrvp/acpi/mipi_camera.asl: https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… PS17, Line 1: * : * This file is part of the coreboot project. Delete this file as this file it not used for now. This file can be added with Camera patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/36091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79a05881d2ea50ff4113243bf5ae26207db63322 Gerrit-Change-Number: 36091 Gerrit-PatchSet: 17 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 20 Dec 2019 18:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/mainboard: Remove unused '#include <device/pci.h>'
by HAOUAS Elyes (Code Review) 20 Dec '19

20 Dec '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37522 ) Change subject: src/mainboard: Remove unused '#include <device/pci.h>' ...................................................................... src/mainboard: Remove unused '#include <device/pci.h>' Change-Id: I5791fddec8b2387df5979adbb1a0fa64c5dd23ea Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/amd/bettong/acpi_tables.c M src/mainboard/amd/bettong/irq_tables.c M src/mainboard/amd/bettong/mptable.c M src/mainboard/amd/db-ft3b-lc/acpi_tables.c M src/mainboard/amd/db-ft3b-lc/irq_tables.c M src/mainboard/amd/db-ft3b-lc/mainboard.c M src/mainboard/amd/db-ft3b-lc/mptable.c M src/mainboard/amd/gardenia/irq_tables.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/inagua/acpi_tables.c M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/inagua/mptable.c M src/mainboard/amd/lamar/acpi_tables.c M src/mainboard/amd/lamar/irq_tables.c M src/mainboard/amd/lamar/mainboard.c M src/mainboard/amd/lamar/mptable.c M src/mainboard/amd/olivehill/acpi_tables.c M src/mainboard/amd/olivehill/irq_tables.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/olivehillplus/acpi_tables.c M src/mainboard/amd/olivehillplus/irq_tables.c M src/mainboard/amd/olivehillplus/mainboard.c M src/mainboard/amd/olivehillplus/mptable.c M src/mainboard/amd/padmelon/bootblock/bootblock.c M src/mainboard/amd/parmer/acpi_tables.c M src/mainboard/amd/parmer/irq_tables.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/persimmon/acpi_tables.c M src/mainboard/amd/persimmon/irq_tables.c M src/mainboard/amd/persimmon/mptable.c M src/mainboard/amd/south_station/acpi_tables.c M src/mainboard/amd/south_station/irq_tables.c M src/mainboard/amd/south_station/mptable.c M src/mainboard/amd/thatcher/acpi_tables.c M src/mainboard/amd/thatcher/irq_tables.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/amd/union_station/acpi_tables.c M src/mainboard/amd/union_station/irq_tables.c M src/mainboard/amd/union_station/mptable.c M src/mainboard/aopen/dxplplusu/acpi_tables.c M src/mainboard/aopen/dxplplusu/fadt.c M src/mainboard/apple/macbook21/mptable.c M src/mainboard/asrock/e350m1/acpi_tables.c M src/mainboard/asrock/e350m1/irq_tables.c M src/mainboard/asrock/e350m1/mptable.c M src/mainboard/asrock/imb-a180/acpi_tables.c M src/mainboard/asrock/imb-a180/irq_tables.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/acpi_tables.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/acpi_tables.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/asus/p2b-d/mptable.c M src/mainboard/asus/p2b-ds/mptable.c M src/mainboard/bap/ode_e20XX/acpi_tables.c M src/mainboard/bap/ode_e20XX/irq_tables.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/acpi_tables.c M src/mainboard/bap/ode_e21XX/irq_tables.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/biostar/a68n_5200/acpi_tables.c M src/mainboard/biostar/a68n_5200/irq_tables.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/acpi_tables.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/elmex/pcm205400/acpi_tables.c M src/mainboard/elmex/pcm205400/irq_tables.c M src/mainboard/elmex/pcm205400/mptable.c M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/emulation/qemu-q35/acpi_tables.c M src/mainboard/getac/p470/acpi_tables.c M src/mainboard/getac/p470/mptable.c M src/mainboard/gizmosphere/gizmo/acpi_tables.c M src/mainboard/gizmosphere/gizmo/irq_tables.c M src/mainboard/gizmosphere/gizmo/mptable.c M src/mainboard/gizmosphere/gizmo2/acpi_tables.c M src/mainboard/gizmosphere/gizmo2/irq_tables.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/auron/variants/buddy/variant.c M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/beltino/chromeos.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/chromeos.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/kahlee/irq_tables.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/kahlee/variants/baseboard/mainboard.c M src/mainboard/google/link/early_init.c M src/mainboard/google/link/mainboard.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/parrot/chromeos.c M src/mainboard/google/parrot/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/chromeos.c M src/mainboard/google/stout/ec.c M src/mainboard/google/stout/mainboard.c M src/mainboard/hp/abm/acpi_tables.c M src/mainboard/hp/abm/irq_tables.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/acpi_tables.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/ibase/mb899/mptable.c M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/baskingridge/chromeos.c M src/mainboard/intel/d510mo/mainboard.c M src/mainboard/intel/d945gclf/mptable.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/emeraldlake2/chromeos.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c M src/mainboard/jetway/nf81-t56n-lf/mptable.c M src/mainboard/kontron/986lcd-m/mptable.c M src/mainboard/lenovo/g505s/acpi_tables.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/t400/acpi_tables.c M src/mainboard/lenovo/t400/dock.c M src/mainboard/lenovo/t400/fadt.c M src/mainboard/lenovo/t420/early_init.c M src/mainboard/lenovo/t420s/early_init.c M src/mainboard/lenovo/t430/early_init.c M src/mainboard/lenovo/t520/early_init.c M src/mainboard/lenovo/t530/early_init.c M src/mainboard/lenovo/t60/mptable.c M src/mainboard/lenovo/x200/acpi_tables.c M src/mainboard/lenovo/x200/fadt.c M src/mainboard/lenovo/x60/mptable.c M src/mainboard/lippert/frontrunner-af/acpi_tables.c M src/mainboard/lippert/frontrunner-af/irq_tables.c M src/mainboard/lippert/frontrunner-af/mainboard.c M src/mainboard/lippert/frontrunner-af/mptable.c M src/mainboard/lippert/toucan-af/acpi_tables.c M src/mainboard/lippert/toucan-af/irq_tables.c M src/mainboard/lippert/toucan-af/mainboard.c M src/mainboard/lippert/toucan-af/mptable.c M src/mainboard/msi/ms7721/acpi_tables.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/pcengines/apu1/acpi_tables.c M src/mainboard/pcengines/apu1/irq_tables.c M src/mainboard/pcengines/apu1/mainboard.c M src/mainboard/pcengines/apu1/mptable.c M src/mainboard/pcengines/apu2/acpi_tables.c M src/mainboard/pcengines/apu2/irq_tables.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/roda/rk886ex/mptable.c M src/mainboard/roda/rk9/acpi_tables.c M src/mainboard/roda/rk9/fadt.c M src/mainboard/roda/rv11/variants/rv11/early_init.c M src/mainboard/roda/rv11/variants/rw11/early_init.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/lumpy/chromeos.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/samsung/stumpy/chromeos.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/mainboard/siemens/mc_apl1/mainboard.c 168 files changed, 0 insertions(+), 168 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/37522/1 diff --git a/src/mainboard/amd/bettong/acpi_tables.c b/src/mainboard/amd/bettong/acpi_tables.c index 8c68404..9117c1f 100644 --- a/src/mainboard/amd/bettong/acpi_tables.c +++ b/src/mainboard/amd/bettong/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> #define IO_APIC2_ADDR 0xFEC20000 diff --git a/src/mainboard/amd/bettong/irq_tables.c b/src/mainboard/amd/bettong/irq_tables.c index 2a961a4..4503099 100644 --- a/src/mainboard/amd/bettong/irq_tables.c +++ b/src/mainboard/amd/bettong/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/bettong/mptable.c b/src/mainboard/amd/bettong/mptable.c index af943f1..d9632d5 100644 --- a/src/mainboard/amd/bettong/mptable.c +++ b/src/mainboard/amd/bettong/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <string.h> #include <stdint.h> diff --git a/src/mainboard/amd/db-ft3b-lc/acpi_tables.c b/src/mainboard/amd/db-ft3b-lc/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/amd/db-ft3b-lc/acpi_tables.c +++ b/src/mainboard/amd/db-ft3b-lc/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/db-ft3b-lc/irq_tables.c b/src/mainboard/amd/db-ft3b-lc/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/amd/db-ft3b-lc/irq_tables.c +++ b/src/mainboard/amd/db-ft3b-lc/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/db-ft3b-lc/mainboard.c b/src/mainboard/amd/db-ft3b-lc/mainboard.c index 6ea80ed..a339659 100644 --- a/src/mainboard/amd/db-ft3b-lc/mainboard.c +++ b/src/mainboard/amd/db-ft3b-lc/mainboard.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <southbridge/amd/pi/hudson/hudson.h> #include <southbridge/amd/pi/hudson/pci_devs.h> diff --git a/src/mainboard/amd/db-ft3b-lc/mptable.c b/src/mainboard/amd/db-ft3b-lc/mptable.c index 3aad0e3..40a75ad 100644 --- a/src/mainboard/amd/db-ft3b-lc/mptable.c +++ b/src/mainboard/amd/db-ft3b-lc/mptable.c @@ -15,7 +15,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <stdint.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/amd/gardenia/irq_tables.c b/src/mainboard/amd/gardenia/irq_tables.c index bf1daec..5dcdb41 100644 --- a/src/mainboard/amd/gardenia/irq_tables.c +++ b/src/mainboard/amd/gardenia/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/gardenia/mptable.c b/src/mainboard/amd/gardenia/mptable.c index fa60d35..5bb70e9 100644 --- a/src/mainboard/amd/gardenia/mptable.c +++ b/src/mainboard/amd/gardenia/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <string.h> #include <stdint.h> diff --git a/src/mainboard/amd/inagua/acpi_tables.c b/src/mainboard/amd/inagua/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/amd/inagua/acpi_tables.c +++ b/src/mainboard/amd/inagua/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/inagua/irq_tables.c b/src/mainboard/amd/inagua/irq_tables.c index 9ebe58a..a066864 100644 --- a/src/mainboard/amd/inagua/irq_tables.c +++ b/src/mainboard/amd/inagua/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/inagua/mptable.c b/src/mainboard/amd/inagua/mptable.c index 8d1ec59..1b4e64a 100644 --- a/src/mainboard/amd/inagua/mptable.c +++ b/src/mainboard/amd/inagua/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/amd/lamar/acpi_tables.c b/src/mainboard/amd/lamar/acpi_tables.c index 8b0c2c9..65e74ba 100644 --- a/src/mainboard/amd/lamar/acpi_tables.c +++ b/src/mainboard/amd/lamar/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/lamar/irq_tables.c b/src/mainboard/amd/lamar/irq_tables.c index be8c702..9cc27f7 100644 --- a/src/mainboard/amd/lamar/irq_tables.c +++ b/src/mainboard/amd/lamar/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/lamar/mainboard.c b/src/mainboard/amd/lamar/mainboard.c index 3d33850..2f716d0 100644 --- a/src/mainboard/amd/lamar/mainboard.c +++ b/src/mainboard/amd/lamar/mainboard.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> diff --git a/src/mainboard/amd/lamar/mptable.c b/src/mainboard/amd/lamar/mptable.c index d89e02f..1f2093d 100644 --- a/src/mainboard/amd/lamar/mptable.c +++ b/src/mainboard/amd/lamar/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <stdint.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/amd/olivehill/acpi_tables.c b/src/mainboard/amd/olivehill/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/amd/olivehill/acpi_tables.c +++ b/src/mainboard/amd/olivehill/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/olivehill/irq_tables.c b/src/mainboard/amd/olivehill/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/amd/olivehill/irq_tables.c +++ b/src/mainboard/amd/olivehill/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/olivehill/mptable.c b/src/mainboard/amd/olivehill/mptable.c index 3054eff..52374f1 100644 --- a/src/mainboard/amd/olivehill/mptable.c +++ b/src/mainboard/amd/olivehill/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/amd/olivehillplus/acpi_tables.c b/src/mainboard/amd/olivehillplus/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/amd/olivehillplus/acpi_tables.c +++ b/src/mainboard/amd/olivehillplus/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/olivehillplus/irq_tables.c b/src/mainboard/amd/olivehillplus/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/amd/olivehillplus/irq_tables.c +++ b/src/mainboard/amd/olivehillplus/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/olivehillplus/mainboard.c b/src/mainboard/amd/olivehillplus/mainboard.c index 00ac1a4..1367b03 100644 --- a/src/mainboard/amd/olivehillplus/mainboard.c +++ b/src/mainboard/amd/olivehillplus/mainboard.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> diff --git a/src/mainboard/amd/olivehillplus/mptable.c b/src/mainboard/amd/olivehillplus/mptable.c index b04f5ac..6c81d06 100644 --- a/src/mainboard/amd/olivehillplus/mptable.c +++ b/src/mainboard/amd/olivehillplus/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/amd/padmelon/bootblock/bootblock.c b/src/mainboard/amd/padmelon/bootblock/bootblock.c index 8649287..9886b61 100644 --- a/src/mainboard/amd/padmelon/bootblock/bootblock.c +++ b/src/mainboard/amd/padmelon/bootblock/bootblock.c @@ -16,7 +16,6 @@ #include <bootblock_common.h> #include <soc/southbridge.h> #include <amdblocks/lpc.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <soc/pci_devs.h> #include <drivers/uart/uart8250reg.h> diff --git a/src/mainboard/amd/parmer/acpi_tables.c b/src/mainboard/amd/parmer/acpi_tables.c index eba2d1d..fd59a3a 100644 --- a/src/mainboard/amd/parmer/acpi_tables.c +++ b/src/mainboard/amd/parmer/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/parmer/irq_tables.c b/src/mainboard/amd/parmer/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/amd/parmer/irq_tables.c +++ b/src/mainboard/amd/parmer/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/parmer/mptable.c b/src/mainboard/amd/parmer/mptable.c index ea18624..c2b9f98 100644 --- a/src/mainboard/amd/parmer/mptable.c +++ b/src/mainboard/amd/parmer/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/amd/persimmon/acpi_tables.c b/src/mainboard/amd/persimmon/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/amd/persimmon/acpi_tables.c +++ b/src/mainboard/amd/persimmon/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/persimmon/irq_tables.c b/src/mainboard/amd/persimmon/irq_tables.c index 9ebe58a..a066864 100644 --- a/src/mainboard/amd/persimmon/irq_tables.c +++ b/src/mainboard/amd/persimmon/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/persimmon/mptable.c b/src/mainboard/amd/persimmon/mptable.c index d9f550e..bc7a3ac 100644 --- a/src/mainboard/amd/persimmon/mptable.c +++ b/src/mainboard/amd/persimmon/mptable.c @@ -15,7 +15,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <stdint.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include <southbridge/amd/common/amd_pci_util.h> diff --git a/src/mainboard/amd/south_station/acpi_tables.c b/src/mainboard/amd/south_station/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/amd/south_station/acpi_tables.c +++ b/src/mainboard/amd/south_station/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/south_station/irq_tables.c b/src/mainboard/amd/south_station/irq_tables.c index 9ebe58a..a066864 100644 --- a/src/mainboard/amd/south_station/irq_tables.c +++ b/src/mainboard/amd/south_station/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/south_station/mptable.c b/src/mainboard/amd/south_station/mptable.c index 8052dc0..c38708e 100644 --- a/src/mainboard/amd/south_station/mptable.c +++ b/src/mainboard/amd/south_station/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/amd/thatcher/acpi_tables.c b/src/mainboard/amd/thatcher/acpi_tables.c index eba2d1d..fd59a3a 100644 --- a/src/mainboard/amd/thatcher/acpi_tables.c +++ b/src/mainboard/amd/thatcher/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/thatcher/irq_tables.c b/src/mainboard/amd/thatcher/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/amd/thatcher/irq_tables.c +++ b/src/mainboard/amd/thatcher/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/thatcher/mptable.c b/src/mainboard/amd/thatcher/mptable.c index f7698bb..b23d036 100644 --- a/src/mainboard/amd/thatcher/mptable.c +++ b/src/mainboard/amd/thatcher/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/amd/union_station/acpi_tables.c b/src/mainboard/amd/union_station/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/amd/union_station/acpi_tables.c +++ b/src/mainboard/amd/union_station/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/amd/union_station/irq_tables.c b/src/mainboard/amd/union_station/irq_tables.c index 9ebe58a..a066864 100644 --- a/src/mainboard/amd/union_station/irq_tables.c +++ b/src/mainboard/amd/union_station/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/union_station/mptable.c b/src/mainboard/amd/union_station/mptable.c index 8052dc0..c38708e 100644 --- a/src/mainboard/amd/union_station/mptable.c +++ b/src/mainboard/amd/union_station/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/aopen/dxplplusu/acpi_tables.c b/src/mainboard/aopen/dxplplusu/acpi_tables.c index cc6835b..0f8a533 100644 --- a/src/mainboard/aopen/dxplplusu/acpi_tables.c +++ b/src/mainboard/aopen/dxplplusu/acpi_tables.c @@ -19,7 +19,6 @@ */ #include <arch/acpi.h> -#include <device/pci.h> #define IOAPIC_ICH4 2 #define IOAPIC_P64H2_BUS_B 3 /* IOAPIC 3 at 02:1c.0 */ diff --git a/src/mainboard/aopen/dxplplusu/fadt.c b/src/mainboard/aopen/dxplplusu/fadt.c index adf94e9..a716a02 100644 --- a/src/mainboard/aopen/dxplplusu/fadt.c +++ b/src/mainboard/aopen/dxplplusu/fadt.c @@ -14,7 +14,6 @@ */ #include <string.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <arch/acpi.h> #include <version.h> diff --git a/src/mainboard/apple/macbook21/mptable.c b/src/mainboard/apple/macbook21/mptable.c index 6129613..021115a 100644 --- a/src/mainboard/apple/macbook21/mptable.c +++ b/src/mainboard/apple/macbook21/mptable.c @@ -15,7 +15,6 @@ */ #include <device/device.h> -#include <device/pci.h> #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/asrock/e350m1/acpi_tables.c b/src/mainboard/asrock/e350m1/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/asrock/e350m1/acpi_tables.c +++ b/src/mainboard/asrock/e350m1/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/asrock/e350m1/irq_tables.c b/src/mainboard/asrock/e350m1/irq_tables.c index 9ebe58a..a066864 100644 --- a/src/mainboard/asrock/e350m1/irq_tables.c +++ b/src/mainboard/asrock/e350m1/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/asrock/e350m1/mptable.c b/src/mainboard/asrock/e350m1/mptable.c index 9c62712..6093e8f 100644 --- a/src/mainboard/asrock/e350m1/mptable.c +++ b/src/mainboard/asrock/e350m1/mptable.c @@ -17,7 +17,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <stdint.h> #include <string.h> diff --git a/src/mainboard/asrock/imb-a180/acpi_tables.c b/src/mainboard/asrock/imb-a180/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/asrock/imb-a180/acpi_tables.c +++ b/src/mainboard/asrock/imb-a180/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/asrock/imb-a180/irq_tables.c b/src/mainboard/asrock/imb-a180/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/asrock/imb-a180/irq_tables.c +++ b/src/mainboard/asrock/imb-a180/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/asrock/imb-a180/mptable.c b/src/mainboard/asrock/imb-a180/mptable.c index fd4dff7..37080ea 100644 --- a/src/mainboard/asrock/imb-a180/mptable.c +++ b/src/mainboard/asrock/imb-a180/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/asus/am1i-a/acpi_tables.c b/src/mainboard/asus/am1i-a/acpi_tables.c index 411ebe7..447c895 100644 --- a/src/mainboard/asus/am1i-a/acpi_tables.c +++ b/src/mainboard/asus/am1i-a/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/asus/am1i-a/mptable.c b/src/mainboard/asus/am1i-a/mptable.c index d97e6ac..9efcab3 100644 --- a/src/mainboard/asus/am1i-a/mptable.c +++ b/src/mainboard/asus/am1i-a/mptable.c @@ -15,7 +15,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <stdint.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/asus/f2a85-m/acpi_tables.c b/src/mainboard/asus/f2a85-m/acpi_tables.c index eba2d1d..fd59a3a 100644 --- a/src/mainboard/asus/f2a85-m/acpi_tables.c +++ b/src/mainboard/asus/f2a85-m/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/asus/f2a85-m/mptable.c b/src/mainboard/asus/f2a85-m/mptable.c index 8bfe4d5..303f3bf 100644 --- a/src/mainboard/asus/f2a85-m/mptable.c +++ b/src/mainboard/asus/f2a85-m/mptable.c @@ -17,7 +17,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <cpu/x86/lapic.h> -#include <device/pci.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/asus/p2b-d/mptable.c b/src/mainboard/asus/p2b-d/mptable.c index fde1281..8f643d1 100644 --- a/src/mainboard/asus/p2b-d/mptable.c +++ b/src/mainboard/asus/p2b-d/mptable.c @@ -16,7 +16,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> -#include <device/pci.h> #include <stdint.h> static void *smp_write_config_table(void *v) diff --git a/src/mainboard/asus/p2b-ds/mptable.c b/src/mainboard/asus/p2b-ds/mptable.c index 4e085b1..b492511 100644 --- a/src/mainboard/asus/p2b-ds/mptable.c +++ b/src/mainboard/asus/p2b-ds/mptable.c @@ -16,7 +16,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> -#include <device/pci.h> #include <stdint.h> static void *smp_write_config_table(void *v) diff --git a/src/mainboard/bap/ode_e20XX/acpi_tables.c b/src/mainboard/bap/ode_e20XX/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/bap/ode_e20XX/acpi_tables.c +++ b/src/mainboard/bap/ode_e20XX/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/bap/ode_e20XX/irq_tables.c b/src/mainboard/bap/ode_e20XX/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/bap/ode_e20XX/irq_tables.c +++ b/src/mainboard/bap/ode_e20XX/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/bap/ode_e20XX/mptable.c b/src/mainboard/bap/ode_e20XX/mptable.c index ea9f959..e4edc5f 100644 --- a/src/mainboard/bap/ode_e20XX/mptable.c +++ b/src/mainboard/bap/ode_e20XX/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <stdint.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/bap/ode_e21XX/acpi_tables.c b/src/mainboard/bap/ode_e21XX/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/bap/ode_e21XX/acpi_tables.c +++ b/src/mainboard/bap/ode_e21XX/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/bap/ode_e21XX/irq_tables.c b/src/mainboard/bap/ode_e21XX/irq_tables.c index f1dbc08..413ccf8 100644 --- a/src/mainboard/bap/ode_e21XX/irq_tables.c +++ b/src/mainboard/bap/ode_e21XX/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/bap/ode_e21XX/mainboard.c b/src/mainboard/bap/ode_e21XX/mainboard.c index 00ac1a4..1367b03 100644 --- a/src/mainboard/bap/ode_e21XX/mainboard.c +++ b/src/mainboard/bap/ode_e21XX/mainboard.c @@ -15,7 +15,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> diff --git a/src/mainboard/bap/ode_e21XX/mptable.c b/src/mainboard/bap/ode_e21XX/mptable.c index b04f5ac..6c81d06 100644 --- a/src/mainboard/bap/ode_e21XX/mptable.c +++ b/src/mainboard/bap/ode_e21XX/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/biostar/a68n_5200/acpi_tables.c b/src/mainboard/biostar/a68n_5200/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/biostar/a68n_5200/acpi_tables.c +++ b/src/mainboard/biostar/a68n_5200/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/biostar/a68n_5200/irq_tables.c b/src/mainboard/biostar/a68n_5200/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/biostar/a68n_5200/irq_tables.c +++ b/src/mainboard/biostar/a68n_5200/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/biostar/a68n_5200/mptable.c b/src/mainboard/biostar/a68n_5200/mptable.c index 3054eff..52374f1 100644 --- a/src/mainboard/biostar/a68n_5200/mptable.c +++ b/src/mainboard/biostar/a68n_5200/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/biostar/am1ml/acpi_tables.c b/src/mainboard/biostar/am1ml/acpi_tables.c index 411ebe7..447c895 100644 --- a/src/mainboard/biostar/am1ml/acpi_tables.c +++ b/src/mainboard/biostar/am1ml/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/biostar/am1ml/mptable.c b/src/mainboard/biostar/am1ml/mptable.c index 4d93361..659a141 100644 --- a/src/mainboard/biostar/am1ml/mptable.c +++ b/src/mainboard/biostar/am1ml/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <stdint.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/elmex/pcm205400/acpi_tables.c b/src/mainboard/elmex/pcm205400/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/elmex/pcm205400/acpi_tables.c +++ b/src/mainboard/elmex/pcm205400/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/elmex/pcm205400/irq_tables.c b/src/mainboard/elmex/pcm205400/irq_tables.c index 591cabb..804f52d 100644 --- a/src/mainboard/elmex/pcm205400/irq_tables.c +++ b/src/mainboard/elmex/pcm205400/irq_tables.c @@ -15,7 +15,6 @@ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/elmex/pcm205400/mptable.c b/src/mainboard/elmex/pcm205400/mptable.c index d9f550e..bc7a3ac 100644 --- a/src/mainboard/elmex/pcm205400/mptable.c +++ b/src/mainboard/elmex/pcm205400/mptable.c @@ -15,7 +15,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <stdint.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include <southbridge/amd/common/amd_pci_util.h> diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 0bff4d7..8ef6787 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -19,7 +19,6 @@ #include <arch/ioapic.h> #include <stdint.h> #include <device/device.h> -#include <device/pci.h> #include <stdlib.h> #include <string.h> #include <smbios.h> diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c index a609b5d..5c48e95 100644 --- a/src/mainboard/emulation/qemu-q35/acpi_tables.c +++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c @@ -19,7 +19,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <version.h> diff --git a/src/mainboard/getac/p470/acpi_tables.c b/src/mainboard/getac/p470/acpi_tables.c index 59c2876..3372ace 100644 --- a/src/mainboard/getac/p470/acpi_tables.c +++ b/src/mainboard/getac/p470/acpi_tables.c @@ -20,7 +20,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/i82801gx/nvs.h> #include "mainboard.h" diff --git a/src/mainboard/getac/p470/mptable.c b/src/mainboard/getac/p470/mptable.c index 86006e1..795ac08 100644 --- a/src/mainboard/getac/p470/mptable.c +++ b/src/mainboard/getac/p470/mptable.c @@ -15,7 +15,6 @@ */ #include <device/device.h> -#include <device/pci.h> #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/gizmosphere/gizmo/acpi_tables.c b/src/mainboard/gizmosphere/gizmo/acpi_tables.c index 2154cd8..364c915 100644 --- a/src/mainboard/gizmosphere/gizmo/acpi_tables.c +++ b/src/mainboard/gizmosphere/gizmo/acpi_tables.c @@ -16,7 +16,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/gizmosphere/gizmo/irq_tables.c b/src/mainboard/gizmosphere/gizmo/irq_tables.c index ca30cc7..f28ddee 100644 --- a/src/mainboard/gizmosphere/gizmo/irq_tables.c +++ b/src/mainboard/gizmosphere/gizmo/irq_tables.c @@ -15,7 +15,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/gizmosphere/gizmo/mptable.c b/src/mainboard/gizmosphere/gizmo/mptable.c index d44e276..dca5f3c 100644 --- a/src/mainboard/gizmosphere/gizmo/mptable.c +++ b/src/mainboard/gizmosphere/gizmo/mptable.c @@ -15,7 +15,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/gizmosphere/gizmo2/acpi_tables.c b/src/mainboard/gizmosphere/gizmo2/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/gizmosphere/gizmo2/acpi_tables.c +++ b/src/mainboard/gizmosphere/gizmo2/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/gizmosphere/gizmo2/irq_tables.c b/src/mainboard/gizmosphere/gizmo2/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/gizmosphere/gizmo2/irq_tables.c +++ b/src/mainboard/gizmosphere/gizmo2/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/gizmosphere/gizmo2/mptable.c b/src/mainboard/gizmosphere/gizmo2/mptable.c index ea9f959..e4edc5f 100644 --- a/src/mainboard/gizmosphere/gizmo2/mptable.c +++ b/src/mainboard/gizmosphere/gizmo2/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <stdint.h> #include <cpu/x86/lapic.h> diff --git a/src/mainboard/google/auron/variants/buddy/variant.c b/src/mainboard/google/auron/variants/buddy/variant.c index dcda04d..58fee1e 100644 --- a/src/mainboard/google/auron/variants/buddy/variant.c +++ b/src/mainboard/google/auron/variants/buddy/variant.c @@ -18,7 +18,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <smbios.h> #include <soc/pch.h> #include <variant/onboard.h> diff --git a/src/mainboard/google/beltino/acpi_tables.c b/src/mainboard/google/beltino/acpi_tables.c index 2b2acba..a04a950 100644 --- a/src/mainboard/google/beltino/acpi_tables.c +++ b/src/mainboard/google/beltino/acpi_tables.c @@ -17,7 +17,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <ec/google/chromeec/ec.h> #include <southbridge/intel/lynxpoint/nvs.h> #include <southbridge/intel/lynxpoint/pch.h> diff --git a/src/mainboard/google/beltino/chromeos.c b/src/mainboard/google/beltino/chromeos.c index 1039707..8940d36 100644 --- a/src/mainboard/google/beltino/chromeos.c +++ b/src/mainboard/google/beltino/chromeos.c @@ -17,7 +17,6 @@ #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/lynxpoint/pch.h> #include <southbridge/intel/common/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/beltino/lan.c b/src/mainboard/google/beltino/lan.c index 090f280..1c38e45 100644 --- a/src/mainboard/google/beltino/lan.c +++ b/src/mainboard/google/beltino/lan.c @@ -19,7 +19,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <fmap.h> #include <southbridge/intel/bd82x6x/pch.h> #include "onboard.h" diff --git a/src/mainboard/google/butterfly/chromeos.c b/src/mainboard/google/butterfly/chromeos.c index ea4b8ac..63e582e 100644 --- a/src/mainboard/google/butterfly/chromeos.c +++ b/src/mainboard/google/butterfly/chromeos.c @@ -17,7 +17,6 @@ #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index b5f96b4..56ef0c2 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -28,7 +28,6 @@ #include "ec.h" #include <southbridge/intel/bd82x6x/pch.h> #include <smbios.h> -#include <device/pci.h> #include <ec/quanta/ene_kb3940q/ec.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/jecht/acpi_tables.c b/src/mainboard/google/jecht/acpi_tables.c index 879ff93..445f037 100644 --- a/src/mainboard/google/jecht/acpi_tables.c +++ b/src/mainboard/google/jecht/acpi_tables.c @@ -18,7 +18,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <soc/acpi.h> #include <soc/nvs.h> #include <variant/thermal.h> diff --git a/src/mainboard/google/jecht/chromeos.c b/src/mainboard/google/jecht/chromeos.c index f2db756..e8a9d1a 100644 --- a/src/mainboard/google/jecht/chromeos.c +++ b/src/mainboard/google/jecht/chromeos.c @@ -16,7 +16,6 @@ #include <boot/coreboot_tables.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <vendorcode/google/chromeos/chromeos.h> #include <ec/google/chromeec/ec.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/jecht/lan.c b/src/mainboard/google/jecht/lan.c index f733bca..bd08b09 100644 --- a/src/mainboard/google/jecht/lan.c +++ b/src/mainboard/google/jecht/lan.c @@ -20,7 +20,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <soc/pch.h> #include "onboard.h" diff --git a/src/mainboard/google/kahlee/irq_tables.c b/src/mainboard/google/kahlee/irq_tables.c index 31cfbc1..b134c6b 100644 --- a/src/mainboard/google/kahlee/irq_tables.c +++ b/src/mainboard/google/kahlee/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/google/kahlee/mptable.c b/src/mainboard/google/kahlee/mptable.c index fa60d35..5bb70e9 100644 --- a/src/mainboard/google/kahlee/mptable.c +++ b/src/mainboard/google/kahlee/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/ioapic.h> #include <string.h> #include <stdint.h> diff --git a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c index 30fcc8c..69b9b40 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c +++ b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c @@ -21,7 +21,6 @@ #include <smbios.h> #include <variant/gpio.h> #include <device/mmio.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <drivers/generic/bayhub/bh720.h> diff --git a/src/mainboard/google/link/early_init.c b/src/mainboard/google/link/early_init.c index 8c58054..7e83412 100644 --- a/src/mainboard/google/link/early_init.c +++ b/src/mainboard/google/link/early_init.c @@ -17,7 +17,6 @@ #include <stdint.h> #include <string.h> #include <device/pci_ops.h> -#include <device/pci.h> #include <device/pci_def.h> #include <cpu/x86/lapic.h> #include <arch/acpi.h> diff --git a/src/mainboard/google/link/mainboard.c b/src/mainboard/google/link/mainboard.c index a91930b..58668dc 100644 --- a/src/mainboard/google/link/mainboard.c +++ b/src/mainboard/google/link/mainboard.c @@ -30,7 +30,6 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> #include <smbios.h> -#include <device/pci.h> #include <ec/google/chromeec/ec.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/parrot/acpi_tables.c b/src/mainboard/google/parrot/acpi_tables.c index 93d77da..e92734d 100644 --- a/src/mainboard/google/parrot/acpi_tables.c +++ b/src/mainboard/google/parrot/acpi_tables.c @@ -17,7 +17,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <vendorcode/google/chromeos/gnvs.h> #include <ec/compal/ene932/ec.h> #include "ec.h" diff --git a/src/mainboard/google/parrot/chromeos.c b/src/mainboard/google/parrot/chromeos.c index 4587a12..ae8da67 100644 --- a/src/mainboard/google/parrot/chromeos.c +++ b/src/mainboard/google/parrot/chromeos.c @@ -18,7 +18,6 @@ #include <boot/coreboot_tables.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> diff --git a/src/mainboard/google/parrot/mainboard.c b/src/mainboard/google/parrot/mainboard.c index 361215a..b1c1042 100644 --- a/src/mainboard/google/parrot/mainboard.c +++ b/src/mainboard/google/parrot/mainboard.c @@ -24,7 +24,6 @@ #include "ec.h" #include <southbridge/intel/bd82x6x/pch.h> #include <smbios.h> -#include <device/pci.h> #include <ec/compal/ene932/ec.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index b78ec82..8485507 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -17,7 +17,6 @@ #include <chip.h> #include <arch/io.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <smbios.h> #include <string.h> diff --git a/src/mainboard/google/rambi/acpi_tables.c b/src/mainboard/google/rambi/acpi_tables.c index 8e6db19..867b220 100644 --- a/src/mainboard/google/rambi/acpi_tables.c +++ b/src/mainboard/google/rambi/acpi_tables.c @@ -18,7 +18,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <soc/acpi.h> #include <soc/nvs.h> #include <soc/iomap.h> diff --git a/src/mainboard/google/rambi/variants/ninja/lan.c b/src/mainboard/google/rambi/variants/ninja/lan.c index edf2a62..5b220e0 100644 --- a/src/mainboard/google/rambi/variants/ninja/lan.c +++ b/src/mainboard/google/rambi/variants/ninja/lan.c @@ -19,7 +19,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <fmap.h> #include <variant/onboard.h> diff --git a/src/mainboard/google/rambi/variants/sumo/lan.c b/src/mainboard/google/rambi/variants/sumo/lan.c index 9ed2b04..d6cd580 100644 --- a/src/mainboard/google/rambi/variants/sumo/lan.c +++ b/src/mainboard/google/rambi/variants/sumo/lan.c @@ -19,7 +19,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <fmap.h> #include <variant/onboard.h> diff --git a/src/mainboard/google/slippy/acpi_tables.c b/src/mainboard/google/slippy/acpi_tables.c index 0b303ae..5838823 100644 --- a/src/mainboard/google/slippy/acpi_tables.c +++ b/src/mainboard/google/slippy/acpi_tables.c @@ -17,7 +17,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <vendorcode/google/chromeos/gnvs.h> #include <ec/google/chromeec/ec.h> #include <southbridge/intel/lynxpoint/pch.h> diff --git a/src/mainboard/google/stout/acpi_tables.c b/src/mainboard/google/stout/acpi_tables.c index 46aadaf..597cb8f 100644 --- a/src/mainboard/google/stout/acpi_tables.c +++ b/src/mainboard/google/stout/acpi_tables.c @@ -17,7 +17,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <vendorcode/google/chromeos/gnvs.h> #include <bootmode.h> #include <ec/quanta/it8518/ec.h> diff --git a/src/mainboard/google/stout/chromeos.c b/src/mainboard/google/stout/chromeos.c index dc3f3ab..fbb8190 100644 --- a/src/mainboard/google/stout/chromeos.c +++ b/src/mainboard/google/stout/chromeos.c @@ -18,7 +18,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> diff --git a/src/mainboard/google/stout/ec.c b/src/mainboard/google/stout/ec.c index 0ea32bc..3e91282 100644 --- a/src/mainboard/google/stout/ec.c +++ b/src/mainboard/google/stout/ec.c @@ -20,7 +20,6 @@ #include <cpu/x86/smm.h> #include <ec/quanta/it8518/ec.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/pmbase.h> #include <elog.h> diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c index 782546a..5de7362 100644 --- a/src/mainboard/google/stout/mainboard.c +++ b/src/mainboard/google/stout/mainboard.c @@ -21,7 +21,6 @@ #include <drivers/intel/gma/int15.h> #include <arch/acpi.h> #include <southbridge/intel/bd82x6x/pch.h> -#include <device/pci.h> #include <ec/quanta/it8518/ec.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/hp/abm/acpi_tables.c b/src/mainboard/hp/abm/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/hp/abm/acpi_tables.c +++ b/src/mainboard/hp/abm/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/hp/abm/irq_tables.c b/src/mainboard/hp/abm/irq_tables.c index e18e478..530c132 100644 --- a/src/mainboard/hp/abm/irq_tables.c +++ b/src/mainboard/hp/abm/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/hp/abm/mptable.c b/src/mainboard/hp/abm/mptable.c index 3054eff..52374f1 100644 --- a/src/mainboard/hp/abm/mptable.c +++ b/src/mainboard/hp/abm/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi_tables.c b/src/mainboard/hp/pavilion_m6_1035dx/acpi_tables.c index eba2d1d..fd59a3a 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi_tables.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c index 0d44397..f3c2f0a 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c @@ -17,7 +17,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <cpu/x86/lapic.h> -#include <device/pci.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/ibase/mb899/mptable.c b/src/mainboard/ibase/mb899/mptable.c index 14f93ec..b24d8bf 100644 --- a/src/mainboard/ibase/mb899/mptable.c +++ b/src/mainboard/ibase/mb899/mptable.c @@ -14,7 +14,6 @@ */ #include <device/device.h> -#include <device/pci.h> #include <console/console.h> #include <arch/smp/mpspec.h> #include <arch/ioapic.h> diff --git a/src/mainboard/intel/baskingridge/acpi_tables.c b/src/mainboard/intel/baskingridge/acpi_tables.c index 497b10b..60f9c46 100644 --- a/src/mainboard/intel/baskingridge/acpi_tables.c +++ b/src/mainboard/intel/baskingridge/acpi_tables.c @@ -17,7 +17,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/lynxpoint/pch.h> #include <southbridge/intel/lynxpoint/nvs.h> diff --git a/src/mainboard/intel/baskingridge/chromeos.c b/src/mainboard/intel/baskingridge/chromeos.c index 74eb788..cf89f0d 100644 --- a/src/mainboard/intel/baskingridge/chromeos.c +++ b/src/mainboard/intel/baskingridge/chromeos.c @@ -16,7 +16,6 @@ #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/lynxpoint/pch.h> #include <southbridge/intel/common/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/d510mo/mainboard.c b/src/mainboard/intel/d510mo/mainboard.c index cac5064..6e7b85b 100644 --- a/src/mainboard/intel/d510mo/mainboard.c +++ b/src/mainboard/intel/d510mo/mainboard.c @@ -15,7 +15,6 @@ #include <device/device.h> #include <device/pci_def.h> -#include <device/pci.h> #include <drivers/intel/gma/int15.h> static void mainboard_enable(struct device *dev) diff --git a/src/mainboard/intel/d945gclf/mptable.c b/src/mainboard/intel/d945gclf/mptable.c index c58cbf5..89df425 100644 --- a/src/mainboard/intel/d945gclf/mptable.c +++ b/src/mainboard/intel/d945gclf/mptable.c @@ -14,7 +14,6 @@ */ #include <device/device.h> -#include <device/pci.h> #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/intel/emeraldlake2/acpi_tables.c b/src/mainboard/intel/emeraldlake2/acpi_tables.c index 74edc38..9d15eb6 100644 --- a/src/mainboard/intel/emeraldlake2/acpi_tables.c +++ b/src/mainboard/intel/emeraldlake2/acpi_tables.c @@ -17,7 +17,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/bd82x6x/nvs.h> diff --git a/src/mainboard/intel/emeraldlake2/chromeos.c b/src/mainboard/intel/emeraldlake2/chromeos.c index 470688f..4b52a2c 100644 --- a/src/mainboard/intel/emeraldlake2/chromeos.c +++ b/src/mainboard/intel/emeraldlake2/chromeos.c @@ -16,7 +16,6 @@ #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index 43818ee..1f92419 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -19,7 +19,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <cpu/x86/msr.h> #include <intelblocks/acpi.h> diff --git a/src/mainboard/intel/kblrvp/chromeos.c b/src/mainboard/intel/kblrvp/chromeos.c index 29f05c9..9db4674 100644 --- a/src/mainboard/intel/kblrvp/chromeos.c +++ b/src/mainboard/intel/kblrvp/chromeos.c @@ -16,7 +16,6 @@ #include <boot/coreboot_tables.h> #include <device/device.h> -#include <device/pci.h> #include <gpio.h> #include <soc/gpio.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/intel/strago/acpi_tables.c b/src/mainboard/intel/strago/acpi_tables.c index 38ca9ff..518e0aa 100644 --- a/src/mainboard/intel/strago/acpi_tables.c +++ b/src/mainboard/intel/strago/acpi_tables.c @@ -18,7 +18,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <soc/acpi.h> #include <soc/iomap.h> #include <soc/nvs.h> diff --git a/src/mainboard/intel/wtm2/acpi_tables.c b/src/mainboard/intel/wtm2/acpi_tables.c index c94c7bf..8ceea46 100644 --- a/src/mainboard/intel/wtm2/acpi_tables.c +++ b/src/mainboard/intel/wtm2/acpi_tables.c @@ -18,7 +18,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <soc/acpi.h> #include <soc/nvs.h> #include "thermal.h" diff --git a/src/mainboard/intel/wtm2/chromeos.c b/src/mainboard/intel/wtm2/chromeos.c index 556677a..95664f1 100644 --- a/src/mainboard/intel/wtm2/chromeos.c +++ b/src/mainboard/intel/wtm2/chromeos.c @@ -16,7 +16,6 @@ #include <bootmode.h> #include <boot/coreboot_tables.h> #include <device/device.h> -#include <device/pci.h> #include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c b/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c +++ b/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/jetway/nf81-t56n-lf/mptable.c b/src/mainboard/jetway/nf81-t56n-lf/mptable.c index 8fbdc58..9a983b4 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/mptable.c +++ b/src/mainboard/jetway/nf81-t56n-lf/mptable.c @@ -17,7 +17,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <drivers/generic/ioapic/chip.h> #include <stdint.h> #include <southbridge/amd/common/amd_pci_util.h> diff --git a/src/mainboard/kontron/986lcd-m/mptable.c b/src/mainboard/kontron/986lcd-m/mptable.c index 1b5d45e..a5018f2 100644 --- a/src/mainboard/kontron/986lcd-m/mptable.c +++ b/src/mainboard/kontron/986lcd-m/mptable.c @@ -14,7 +14,6 @@ */ #include <device/device.h> -#include <device/pci.h> #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/lenovo/g505s/acpi_tables.c b/src/mainboard/lenovo/g505s/acpi_tables.c index eba2d1d..fd59a3a 100644 --- a/src/mainboard/lenovo/g505s/acpi_tables.c +++ b/src/mainboard/lenovo/g505s/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/lenovo/g505s/mptable.c b/src/mainboard/lenovo/g505s/mptable.c index 0d44397..f3c2f0a 100644 --- a/src/mainboard/lenovo/g505s/mptable.c +++ b/src/mainboard/lenovo/g505s/mptable.c @@ -17,7 +17,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <cpu/x86/lapic.h> -#include <device/pci.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/lenovo/t400/acpi_tables.c b/src/mainboard/lenovo/t400/acpi_tables.c index 8fb9056..953a2b8 100644 --- a/src/mainboard/lenovo/t400/acpi_tables.c +++ b/src/mainboard/lenovo/t400/acpi_tables.c @@ -19,7 +19,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/i82801ix/nvs.h> #include "thermal.h" diff --git a/src/mainboard/lenovo/t400/dock.c b/src/mainboard/lenovo/t400/dock.c index ccd6dcd..2eb9903 100644 --- a/src/mainboard/lenovo/t400/dock.c +++ b/src/mainboard/lenovo/t400/dock.c @@ -20,7 +20,6 @@ #include <arch/io.h> #include <device/pnp_ops.h> #include <device/device.h> -#include <device/pci.h> #include <device/pnp.h> #include <delay.h> #include "dock.h" diff --git a/src/mainboard/lenovo/t400/fadt.c b/src/mainboard/lenovo/t400/fadt.c index e335787..9f4ebf6 100644 --- a/src/mainboard/lenovo/t400/fadt.c +++ b/src/mainboard/lenovo/t400/fadt.c @@ -15,7 +15,6 @@ */ #include <string.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <arch/acpi.h> #include <cpu/x86/smm.h> diff --git a/src/mainboard/lenovo/t420/early_init.c b/src/mainboard/lenovo/t420/early_init.c index 8afd1501..2e39885 100644 --- a/src/mainboard/lenovo/t420/early_init.c +++ b/src/mainboard/lenovo/t420/early_init.c @@ -21,7 +21,6 @@ #include <drivers/lenovo/hybrid_graphics/hybrid_graphics.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <device/device.h> -#include <device/pci.h> static void hybrid_graphics_init(void) { diff --git a/src/mainboard/lenovo/t420s/early_init.c b/src/mainboard/lenovo/t420s/early_init.c index e2cdebf..276c66e 100644 --- a/src/mainboard/lenovo/t420s/early_init.c +++ b/src/mainboard/lenovo/t420s/early_init.c @@ -21,7 +21,6 @@ #include <drivers/lenovo/hybrid_graphics/hybrid_graphics.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <device/device.h> -#include <device/pci.h> static void hybrid_graphics_init(void) { diff --git a/src/mainboard/lenovo/t430/early_init.c b/src/mainboard/lenovo/t430/early_init.c index 74c8b60..27258a3 100644 --- a/src/mainboard/lenovo/t430/early_init.c +++ b/src/mainboard/lenovo/t430/early_init.c @@ -21,7 +21,6 @@ #include <drivers/lenovo/hybrid_graphics/hybrid_graphics.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <device/device.h> -#include <device/pci.h> static void hybrid_graphics_init(void) { diff --git a/src/mainboard/lenovo/t520/early_init.c b/src/mainboard/lenovo/t520/early_init.c index ad8e152..8e5bf2a 100644 --- a/src/mainboard/lenovo/t520/early_init.c +++ b/src/mainboard/lenovo/t520/early_init.c @@ -23,7 +23,6 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <drivers/lenovo/hybrid_graphics/hybrid_graphics.h> #include <device/device.h> -#include <device/pci.h> static void hybrid_graphics_init(void) { diff --git a/src/mainboard/lenovo/t530/early_init.c b/src/mainboard/lenovo/t530/early_init.c index aeb27a6..c6ff7e7 100644 --- a/src/mainboard/lenovo/t530/early_init.c +++ b/src/mainboard/lenovo/t530/early_init.c @@ -23,7 +23,6 @@ #include <northbridge/intel/sandybridge/sandybridge.h> #include <drivers/lenovo/hybrid_graphics/hybrid_graphics.h> #include <device/device.h> -#include <device/pci.h> static void hybrid_graphics_init(void) { diff --git a/src/mainboard/lenovo/t60/mptable.c b/src/mainboard/lenovo/t60/mptable.c index 165b725..85b569a 100644 --- a/src/mainboard/lenovo/t60/mptable.c +++ b/src/mainboard/lenovo/t60/mptable.c @@ -15,7 +15,6 @@ */ #include <device/device.h> -#include <device/pci.h> #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/lenovo/x200/acpi_tables.c b/src/mainboard/lenovo/x200/acpi_tables.c index 8fb9056..953a2b8 100644 --- a/src/mainboard/lenovo/x200/acpi_tables.c +++ b/src/mainboard/lenovo/x200/acpi_tables.c @@ -19,7 +19,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/i82801ix/nvs.h> #include "thermal.h" diff --git a/src/mainboard/lenovo/x200/fadt.c b/src/mainboard/lenovo/x200/fadt.c index e335787..9f4ebf6 100644 --- a/src/mainboard/lenovo/x200/fadt.c +++ b/src/mainboard/lenovo/x200/fadt.c @@ -15,7 +15,6 @@ */ #include <string.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <arch/acpi.h> #include <cpu/x86/smm.h> diff --git a/src/mainboard/lenovo/x60/mptable.c b/src/mainboard/lenovo/x60/mptable.c index 886f72d..22c5907 100644 --- a/src/mainboard/lenovo/x60/mptable.c +++ b/src/mainboard/lenovo/x60/mptable.c @@ -15,7 +15,6 @@ */ #include <device/device.h> -#include <device/pci.h> #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/lippert/frontrunner-af/acpi_tables.c b/src/mainboard/lippert/frontrunner-af/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/lippert/frontrunner-af/acpi_tables.c +++ b/src/mainboard/lippert/frontrunner-af/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/lippert/frontrunner-af/irq_tables.c b/src/mainboard/lippert/frontrunner-af/irq_tables.c index 9ebe58a..a066864 100644 --- a/src/mainboard/lippert/frontrunner-af/irq_tables.c +++ b/src/mainboard/lippert/frontrunner-af/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/lippert/frontrunner-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/mainboard.c index faad6dd..6980410 100644 --- a/src/mainboard/lippert/frontrunner-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/mainboard.c @@ -16,7 +16,6 @@ #include <amdblocks/acpimmio.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <arch/io.h> #include <device/mmio.h> #include <device/pci_ops.h> diff --git a/src/mainboard/lippert/frontrunner-af/mptable.c b/src/mainboard/lippert/frontrunner-af/mptable.c index 5e3a950..347b781 100644 --- a/src/mainboard/lippert/frontrunner-af/mptable.c +++ b/src/mainboard/lippert/frontrunner-af/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/lippert/toucan-af/acpi_tables.c b/src/mainboard/lippert/toucan-af/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/lippert/toucan-af/acpi_tables.c +++ b/src/mainboard/lippert/toucan-af/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/lippert/toucan-af/irq_tables.c b/src/mainboard/lippert/toucan-af/irq_tables.c index 9ebe58a..a066864 100644 --- a/src/mainboard/lippert/toucan-af/irq_tables.c +++ b/src/mainboard/lippert/toucan-af/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/lippert/toucan-af/mainboard.c b/src/mainboard/lippert/toucan-af/mainboard.c index 1e19278..a499358 100644 --- a/src/mainboard/lippert/toucan-af/mainboard.c +++ b/src/mainboard/lippert/toucan-af/mainboard.c @@ -16,7 +16,6 @@ #include <amdblocks/acpimmio.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/lippert/toucan-af/mptable.c b/src/mainboard/lippert/toucan-af/mptable.c index 5e3a950..347b781 100644 --- a/src/mainboard/lippert/toucan-af/mptable.c +++ b/src/mainboard/lippert/toucan-af/mptable.c @@ -14,7 +14,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <arch/io.h> #include <arch/ioapic.h> #include <string.h> diff --git a/src/mainboard/msi/ms7721/acpi_tables.c b/src/mainboard/msi/ms7721/acpi_tables.c index eba2d1d..fd59a3a 100644 --- a/src/mainboard/msi/ms7721/acpi_tables.c +++ b/src/mainboard/msi/ms7721/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/msi/ms7721/mptable.c b/src/mainboard/msi/ms7721/mptable.c index 8bfe4d5..303f3bf 100644 --- a/src/mainboard/msi/ms7721/mptable.c +++ b/src/mainboard/msi/ms7721/mptable.c @@ -17,7 +17,6 @@ #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <cpu/x86/lapic.h> -#include <device/pci.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index f64e9e3..e07d8ed 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -26,7 +26,6 @@ #include <drivers/intel/gma/int15.h> #include <pc80/keyboard.h> #include <cpu/x86/lapic.h> -#include <device/pci.h> #include <smbios.h> static void mainboard_enable(struct device *dev) diff --git a/src/mainboard/pcengines/apu1/acpi_tables.c b/src/mainboard/pcengines/apu1/acpi_tables.c index 787c432..97ea649 100644 --- a/src/mainboard/pcengines/apu1/acpi_tables.c +++ b/src/mainboard/pcengines/apu1/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/pcengines/apu1/irq_tables.c b/src/mainboard/pcengines/apu1/irq_tables.c index 9ebe58a..a066864 100644 --- a/src/mainboard/pcengines/apu1/irq_tables.c +++ b/src/mainboard/pcengines/apu1/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/pcengines/apu1/mainboard.c b/src/mainboard/pcengines/apu1/mainboard.c index 1c30291..854fb8a 100644 --- a/src/mainboard/pcengines/apu1/mainboard.c +++ b/src/mainboard/pcengines/apu1/mainboard.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/pcengines/apu1/mptable.c b/src/mainboard/pcengines/apu1/mptable.c index bb8d01e..89e5dfc 100644 --- a/src/mainboard/pcengines/apu1/mptable.c +++ b/src/mainboard/pcengines/apu1/mptable.c @@ -15,7 +15,6 @@ */ #include <arch/smp/mpspec.h> -#include <device/pci.h> #include <stdint.h> #include <southbridge/amd/cimx/sb800/SBPLATFORM.h> #include <southbridge/amd/common/amd_pci_util.h> diff --git a/src/mainboard/pcengines/apu2/acpi_tables.c b/src/mainboard/pcengines/apu2/acpi_tables.c index 08f6076..20509e9 100644 --- a/src/mainboard/pcengines/apu2/acpi_tables.c +++ b/src/mainboard/pcengines/apu2/acpi_tables.c @@ -15,7 +15,6 @@ #include <arch/acpi.h> #include <arch/ioapic.h> -#include <device/pci.h> unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/mainboard/pcengines/apu2/irq_tables.c b/src/mainboard/pcengines/apu2/irq_tables.c index f7302ba..3c8cfbe 100644 --- a/src/mainboard/pcengines/apu2/irq_tables.c +++ b/src/mainboard/pcengines/apu2/irq_tables.c @@ -14,7 +14,6 @@ */ #include <console/console.h> -#include <device/pci.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index d46361c..6cb504a 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -18,7 +18,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <southbridge/amd/pi/hudson/hudson.h> #include <southbridge/amd/pi/hudson/pci_devs.h> diff --git a/src/mainboard/roda/rk886ex/mptable.c b/src/mainboard/roda/rk886ex/mptable.c index 2db0f75..e17dcc2 100644 --- a/src/mainboard/roda/rk886ex/mptable.c +++ b/src/mainboard/roda/rk886ex/mptable.c @@ -15,7 +15,6 @@ */ #include <device/device.h> -#include <device/pci.h> #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/roda/rk9/acpi_tables.c b/src/mainboard/roda/rk9/acpi_tables.c index 0700ca0..3c76fac 100644 --- a/src/mainboard/roda/rk9/acpi_tables.c +++ b/src/mainboard/roda/rk9/acpi_tables.c @@ -19,7 +19,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/i82801ix/nvs.h> void acpi_create_gnvs(global_nvs_t *gnvs) diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c index e335787..9f4ebf6 100644 --- a/src/mainboard/roda/rk9/fadt.c +++ b/src/mainboard/roda/rk9/fadt.c @@ -15,7 +15,6 @@ */ #include <string.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <arch/acpi.h> #include <cpu/x86/smm.h> diff --git a/src/mainboard/roda/rv11/variants/rv11/early_init.c b/src/mainboard/roda/rv11/variants/rv11/early_init.c index 5081c00..daa14fd 100644 --- a/src/mainboard/roda/rv11/variants/rv11/early_init.c +++ b/src/mainboard/roda/rv11/variants/rv11/early_init.c @@ -14,7 +14,6 @@ */ #include <stdint.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <northbridge/intel/sandybridge/raminit.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/roda/rv11/variants/rw11/early_init.c b/src/mainboard/roda/rv11/variants/rw11/early_init.c index f3865fc..63fa6a9 100644 --- a/src/mainboard/roda/rv11/variants/rw11/early_init.c +++ b/src/mainboard/roda/rv11/variants/rw11/early_init.c @@ -15,7 +15,6 @@ #include <bootblock_common.h> #include <stdint.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <device/pnp_ops.h> #include <device/pnp.h> diff --git a/src/mainboard/samsung/lumpy/acpi_tables.c b/src/mainboard/samsung/lumpy/acpi_tables.c index 8038664..413841c 100644 --- a/src/mainboard/samsung/lumpy/acpi_tables.c +++ b/src/mainboard/samsung/lumpy/acpi_tables.c @@ -17,7 +17,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <ec/acpi/ec.h> #if CONFIG(CHROMEOS) #include <vendorcode/google/chromeos/gnvs.h> diff --git a/src/mainboard/samsung/lumpy/chromeos.c b/src/mainboard/samsung/lumpy/chromeos.c index c70ee1d..342f7a9 100644 --- a/src/mainboard/samsung/lumpy/chromeos.c +++ b/src/mainboard/samsung/lumpy/chromeos.c @@ -17,7 +17,6 @@ #include <boot/coreboot_tables.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> diff --git a/src/mainboard/samsung/stumpy/acpi_tables.c b/src/mainboard/samsung/stumpy/acpi_tables.c index 17d7e0e..b913bd6 100644 --- a/src/mainboard/samsung/stumpy/acpi_tables.c +++ b/src/mainboard/samsung/stumpy/acpi_tables.c @@ -17,7 +17,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <vendorcode/google/chromeos/gnvs.h> #include <southbridge/intel/bd82x6x/nvs.h> diff --git a/src/mainboard/samsung/stumpy/chromeos.c b/src/mainboard/samsung/stumpy/chromeos.c index 2cce8ad..955ba5a 100644 --- a/src/mainboard/samsung/stumpy/chromeos.c +++ b/src/mainboard/samsung/stumpy/chromeos.c @@ -17,7 +17,6 @@ #include <boot/coreboot_tables.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index 43818ee..1f92419 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -19,7 +19,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h> #include <cpu/x86/msr.h> #include <intelblocks/acpi.h> diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c index 22d37bf..784a08c 100644 --- a/src/mainboard/siemens/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/mainboard.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <device/mmio.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <device/pci_ids.h> #include <hwilib.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/37522 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5791fddec8b2387df5979adbb1a0fa64c5dd23ea Gerrit-Change-Number: 37522 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newchange

3 4

Change in coreboot[master]: mb/intel/tglrvp: Do initial mainboard commit
by Wonkyu Kim (Code Review) 20 Dec '19

20 Dec '19

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36091 ) Change subject: mb/intel/tglrvp: Do initial mainboard commit ...................................................................... Patch Set 17: (6 comments) https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… File src/mainboard/intel/tglrvp/Kconfig: https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… PS17, Line 100: config LPDDR4_MC0_DISABLE : bool "LPDDR4 WA" : default n Delete WA https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… File src/mainboard/intel/tglrvp/dsdt.asl: https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… PS17, Line 29: // Some generic macros Use C style comments https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… PS17, Line 32: // global NVS and variables Use C style comments https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… PS17, Line 35: // CPU Use C style comments https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… PS17, Line 49: // _HID: Hardware ID Delete https://review.coreboot.org/c/coreboot/+/36091/17/src/mainboard/intel/tglrv… PS17, Line 51: // _UID: Unique ID Delete -- To view, visit https://review.coreboot.org/c/coreboot/+/36091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79a05881d2ea50ff4113243bf5ae26207db63322 Gerrit-Change-Number: 36091 Gerrit-PatchSet: 17 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 20 Dec 2019 17:59:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard: Add missing include <device/pci_def.h>
by HAOUAS Elyes (Code Review) 20 Dec '19

20 Dec '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37843 ) Change subject: mainboard: Add missing include <device/pci_def.h> ...................................................................... mainboard: Add missing include <device/pci_def.h> Change-Id: I8a7c989540e8b62de7fd291f695adac849f4680c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/amd/gardenia/irq_tables.c M src/mainboard/aopen/dxplplusu/acpi_tables.c M src/mainboard/asrock/e350m1/irq_tables.c M src/mainboard/asrock/imb-a180/irq_tables.c M src/mainboard/emulation/qemu-i440fx/northbridge.c M src/mainboard/gizmosphere/gizmo/irq_tables.c M src/mainboard/pcengines/apu1/irq_tables.c M src/mainboard/pcengines/apu2/irq_tables.c 8 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37843/1 diff --git a/src/mainboard/amd/gardenia/irq_tables.c b/src/mainboard/amd/gardenia/irq_tables.c index bf1daec..3af2757 100644 --- a/src/mainboard/amd/gardenia/irq_tables.c +++ b/src/mainboard/amd/gardenia/irq_tables.c @@ -15,6 +15,7 @@ #include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/aopen/dxplplusu/acpi_tables.c b/src/mainboard/aopen/dxplplusu/acpi_tables.c index cc6835b..70bfa27 100644 --- a/src/mainboard/aopen/dxplplusu/acpi_tables.c +++ b/src/mainboard/aopen/dxplplusu/acpi_tables.c @@ -20,6 +20,7 @@ #include <arch/acpi.h> #include <device/pci.h> +#include <device/pci_def.h> #define IOAPIC_ICH4 2 #define IOAPIC_P64H2_BUS_B 3 /* IOAPIC 3 at 02:1c.0 */ diff --git a/src/mainboard/asrock/e350m1/irq_tables.c b/src/mainboard/asrock/e350m1/irq_tables.c index 9ebe58a..0bcb041 100644 --- a/src/mainboard/asrock/e350m1/irq_tables.c +++ b/src/mainboard/asrock/e350m1/irq_tables.c @@ -15,6 +15,7 @@ #include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/asrock/imb-a180/irq_tables.c b/src/mainboard/asrock/imb-a180/irq_tables.c index e18e478..be71dd4 100644 --- a/src/mainboard/asrock/imb-a180/irq_tables.c +++ b/src/mainboard/asrock/imb-a180/irq_tables.c @@ -15,6 +15,7 @@ #include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 0bff4d7..1c27a0f 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -15,6 +15,7 @@ #include <cpu/cpu.h> #include <cpu/x86/lapic_def.h> #include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <arch/ioapic.h> #include <stdint.h> diff --git a/src/mainboard/gizmosphere/gizmo/irq_tables.c b/src/mainboard/gizmosphere/gizmo/irq_tables.c index ca30cc7..bf2379c 100644 --- a/src/mainboard/gizmosphere/gizmo/irq_tables.c +++ b/src/mainboard/gizmosphere/gizmo/irq_tables.c @@ -16,6 +16,7 @@ #include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/pcengines/apu1/irq_tables.c b/src/mainboard/pcengines/apu1/irq_tables.c index 9ebe58a..0bcb041 100644 --- a/src/mainboard/pcengines/apu1/irq_tables.c +++ b/src/mainboard/pcengines/apu1/irq_tables.c @@ -15,6 +15,7 @@ #include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/pcengines/apu2/irq_tables.c b/src/mainboard/pcengines/apu2/irq_tables.c index f7302ba..2c93401 100644 --- a/src/mainboard/pcengines/apu2/irq_tables.c +++ b/src/mainboard/pcengines/apu2/irq_tables.c @@ -15,6 +15,7 @@ #include <console/console.h> #include <device/pci.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/37843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a7c989540e8b62de7fd291f695adac849f4680c Gerrit-Change-Number: 37843 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newchange

4 3

Change in coreboot[master]: security/vboot: Intruduce CONFIG_VBOOT_LIB to control vboot library.
by Bill XIE (Code Review) 20 Dec '19

20 Dec '19

Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37787 ) Change subject: security/vboot: Intruduce CONFIG_VBOOT_LIB to control vboot library. ...................................................................... security/vboot: Intruduce CONFIG_VBOOT_LIB to control vboot library. As discussed in CB:35077, since both measured boot and verified boot depends on vboot library, it had better build and link the vboot library less conditionally. Only the actual verification stuff should be conditional on CONFIG_VBOOT. Change-Id: Ia1907a11c851ee45a70582e02bdbe08fb18cc6a4 Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org> --- M src/security/vboot/Kconfig M src/security/vboot/Makefile.inc 2 files changed, 42 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/37787/1 diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index a829443..353c46c 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -15,9 +15,13 @@ menu "Verified Boot (vboot)" +config VBOOT_LIB + bool + config VBOOT bool "Verify firmware with vboot." default n + select VBOOT_LIB select VBOOT_MOCK_SECDATA if !TPM1 && !TPM2 depends on !MISSING_BOARD_RESET help diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 5292bd1..99cf08c 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -14,6 +14,43 @@ ## GNU General Public License for more details. ## +ifeq ($(CONFIG_VBOOT_LIB),y) + +vboot-fixup-includes = $(patsubst -I%,-I$(top)/%,\ + $(patsubst $(src)/%.h,$(top)/$(src)/%.h,\ + $(filter-out -I$(obj),$(1)))) + +# call with $1 = stage name to create rules for building the library +# for the stage and adding it to the stage's set of object files. +define vboot-for-stage +VBOOT_LIB_$(1) = $(obj)/external/vboot_reference-$(1)/vboot_fw.a +VBOOT_CFLAGS_$(1) += $$(call vboot-fixup-includes,$$(CPPFLAGS_$(1))) +VBOOT_CFLAGS_$(1) += $$(CFLAGS_$(1)) +VBOOT_CFLAGS_$(1) += $$(call vboot-fixup-includes,$$($(1)-c-ccopts)) +VBOOT_CFLAGS_$(1) += -I$(abspath $(obj)) -Wno-missing-prototypes +VBOOT_CFLAGS_$(1) += -DVBOOT_DEBUG + +$$(VBOOT_LIB_$(1)): $(obj)/config.h + printf " MAKE $(subst $(obj)/,,$(@))\n" + +FIRMWARE_ARCH=$$(ARCHDIR-$$(ARCH-$(1)-y)) \ + CC="$$(CC_$(1))" \ + CFLAGS="$$(VBOOT_CFLAGS_$(1))" VBOOT2="y" \ + $(MAKE) -C $(VBOOT_SOURCE) \ + BUILD=$$(abspath $$(dir $$(VBOOT_LIB_$(1)))) \ + V=$(V) \ + fwlib + +$(1)-srcs += $$(VBOOT_LIB_$(1)) + +endef # vboot-for-stage + +CFLAGS_common += -I3rdparty/vboot/firmware/2lib/include + +$(eval $(call vboot-for-stage,bootblock)) +$(eval $(call vboot-for-stage,romstage)) +$(eval $(call vboot-for-stage,ramstage)) +$(eval $(call vboot-for-stage,postcar)) + ifeq ($(CONFIG_VBOOT),y) bootblock-y += bootmode.c @@ -95,41 +132,6 @@ romstage-$(CONFIG_FSP2_0_USES_TPM_MRC_HASH) += mrc_cache_hash_tpm.c -vboot-fixup-includes = $(patsubst -I%,-I$(top)/%,\ - $(patsubst $(src)/%.h,$(top)/$(src)/%.h,\ - $(filter-out -I$(obj),$(1)))) - -# call with $1 = stage name to create rules for building the library -# for the stage and adding it to the stage's set of object files. -define vboot-for-stage -VBOOT_LIB_$(1) = $(obj)/external/vboot_reference-$(1)/vboot_fw.a -VBOOT_CFLAGS_$(1) += $$(call vboot-fixup-includes,$$(CPPFLAGS_$(1))) -VBOOT_CFLAGS_$(1) += $$(CFLAGS_$(1)) -VBOOT_CFLAGS_$(1) += $$(call vboot-fixup-includes,$$($(1)-c-ccopts)) -VBOOT_CFLAGS_$(1) += -I$(abspath $(obj)) -Wno-missing-prototypes -VBOOT_CFLAGS_$(1) += -DVBOOT_DEBUG - -$$(VBOOT_LIB_$(1)): $(obj)/config.h - printf " MAKE $(subst $(obj)/,,$(@))\n" - +FIRMWARE_ARCH=$$(ARCHDIR-$$(ARCH-$(1)-y)) \ - CC="$$(CC_$(1))" \ - CFLAGS="$$(VBOOT_CFLAGS_$(1))" VBOOT2="y" \ - $(MAKE) -C $(VBOOT_SOURCE) \ - BUILD=$$(abspath $$(dir $$(VBOOT_LIB_$(1)))) \ - V=$(V) \ - fwlib - -$(1)-srcs += $$(VBOOT_LIB_$(1)) - -endef # vboot-for-stage - -CFLAGS_common += -I3rdparty/vboot/firmware/2lib/include - -$(eval $(call vboot-for-stage,bootblock)) -$(eval $(call vboot-for-stage,romstage)) -$(eval $(call vboot-for-stage,ramstage)) -$(eval $(call vboot-for-stage,postcar)) - ifeq ($(CONFIG_VBOOT_SEPARATE_VERSTAGE),y) $(eval $(call vboot-for-stage,verstage)) @@ -328,3 +330,4 @@ endif endif # CONFIG_VBOOT +endif # CONFIG_VBOOT_LIB -- To view, visit https://review.coreboot.org/c/coreboot/+/37787 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1907a11c851ee45a70582e02bdbe08fb18cc6a4 Gerrit-Change-Number: 37787 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

5 17

Change in coreboot[master]: soc/intel/tigerlake: Update FSP stack and heap size
by Maulik V Vaghela (Code Review) 20 Dec '19

20 Dec '19

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37764 ) Change subject: soc/intel/tigerlake: Update FSP stack and heap size ...................................................................... soc/intel/tigerlake: Update FSP stack and heap size Tigerlake and Jasperlake fsp requires stack size to be minimum 192 KiB and heap size to be minimum 128 KiB. Updating both Kconfig to meet size requirements. Also updated required CAR region size during boot block due to increment in stack & heap requirement by fsp Change-Id: I38e93b5986811ff3e0a8df5f4f36af35f308cb6b Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/37764/1 diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 7bb533a..be4e26c 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -74,22 +74,22 @@ default 0xfef00000 config DCACHE_RAM_SIZE - default 0x40000 + default 0x80000 help The size of the cache-as-ram region required during bootblock and/or romstage. config DCACHE_BSP_STACK_SIZE hex - default 0x20400 + default 0x30400 help The amount of anticipated stack usage in CAR by bootblock and other stages. In the case of FSP_USES_CB_STACK default value will be - sum of FSP-M stack requirement (128KiB) and CB romstage stack requirement (~1KiB). + sum of FSP-M stack requirement (192KiB) and CB romstage stack requirement (~1KiB). config FSP_TEMP_RAM_SIZE hex - default 0x10000 + default 0x20000 help The amount of anticipated heap usage in CAR by FSP. Refer to Platform FSP integration guide document to know -- To view, visit https://review.coreboot.org/c/coreboot/+/37764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38e93b5986811ff3e0a8df5f4f36af35f308cb6b Gerrit-Change-Number: 37764 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: newchange

5 7

Change in coreboot[master]: soc/mediatek/mt8183: Tx delay cell should use ddr clock do compute
by huayang duan (Code Review) 20 Dec '19

20 Dec '19

huayang duan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36990 ) Change subject: soc/mediatek/mt8183: Tx delay cell should use ddr clock do compute ...................................................................... soc/mediatek/mt8183: Tx delay cell should use ddr clock do compute the delay cell result should using the ddr clock pll rate for compute, should not div 2 more. BUG=b:80501386,b:142358843 BRANCH=kukui TEST=Boots correctly on Kukui Signed-off-by: Huayang Duan <huayang.duan(a)mediatek.com> Change-Id: Idf5cce206e248bb327f9a7d27c4f364ef1c68aa1 --- M src/soc/mediatek/mt8183/dramc_pi_calibration_api.c 1 file changed, 14 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/36990/1 diff --git a/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c b/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c index 1dc1ca5..c61e237 100644 --- a/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c +++ b/src/soc/mediatek/mt8183/dramc_pi_calibration_api.c @@ -1588,18 +1588,24 @@ struct per_byte_dly center_dly[DQS_NUMBER]; u16 tune_diff, dq_delay_cell[DQ_DATA_WIDTH]; + + /* + * The clock rate should be (data rate/2 - 4), + * and the 4MHz is introduced to reduce interference from + * RF peripherals like modem, WiFi, BlueTooth. + */ switch (freq_group) { case LP4X_DDR1600: - clock_rate = 800; + clock_rate = 796; break; case LP4X_DDR2400: - clock_rate = 1200; + clock_rate = 1196; break; case LP4X_DDR3200: - clock_rate = 1600; + clock_rate = 1596; break; case LP4X_DDR3600: - clock_rate = 1866; + clock_rate = 1792; break; default: die("Invalid DDR frequency group %u\n", freq_group); @@ -1612,7 +1618,7 @@ use_delay_cell = 0; if (fast_calib && bypass_tx) { - dramc_dbg("bypass TX\n"); + dramc_dbg("bypass TX, clock_rate:%d\n", clock_rate); for (u8 byte = 0; byte < DQS_NUMBER; byte++) { center_dly[byte].min_center = params->tx_center_min[chn][rank][byte]; center_dly[byte].max_center = params->tx_center_max[chn][rank][byte]; @@ -1645,8 +1651,10 @@ tune_diff = vref_dly[index].win_center - center_dly[byte].min_center; dq_delay_cell[index] = ((tune_diff * 100000000) / - (clock_rate / 2 * 64)) / dly_cell_unit; + (clock_rate * 64)) / dly_cell_unit; byte_dly_cell[byte] |= (dq_delay_cell[index] << (bit * 4)); + dramc_show("u1DelayCellOfst[%d]=%d cells (%d PI)\n", + index, dq_delay_cell[index], tune_diff); } } } -- To view, visit https://review.coreboot.org/c/coreboot/+/36990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf5cce206e248bb327f9a7d27c4f364ef1c68aa1 Gerrit-Change-Number: 36990 Gerrit-PatchSet: 1 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: huayang duan <huayangduan(a)gmail.com> Gerrit-MessageType: newchange

5 30

Change in coreboot[master]: mb/goog/hatch/var/kindred: Tune i2c frequency to 400 KHz
by David Wu (Code Review) 20 Dec '19

20 Dec '19

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37831 ) Change subject: mb/goog/hatch/var/kindred: Tune i2c frequency to 400 KHz ...................................................................... mb/goog/hatch/var/kindred: Tune i2c frequency to 400 KHz Tuning i2c frequency for kindred: I2C0: 391.8 KHz I2C1: 396.4 KHz I2C4: 388.8 KHz BUG=b:146535585 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage Change-Id: I55d095efb60eba4e860b54bb90e8e0df62d88419 Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37831/1 diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 1122609..3bc5669 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -36,12 +36,18 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 25, }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 60, }, }" -- To view, visit https://review.coreboot.org/c/coreboot/+/37831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55d095efb60eba4e860b54bb90e8e0df62d88419 Gerrit-Change-Number: 37831 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

5 16

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2019