coreboot-gerrit December 2019

coreboot-gerrit@coreboot.org

1 participants
1761 discussions

Change in coreboot[master]: mainboard/google : Add initial Puff GPIO table
by Edward O'Callaghan (Code Review) 23 Dec '19

23 Dec '19

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37460 ) Change subject: mainboard/google : Add initial Puff GPIO table ...................................................................... Patch Set 1: (1 comment) This change is ready for review. https://review.coreboot.org/c/coreboot/+/37460/1/src/mainboard/google/hatch… File src/mainboard/google/hatch/variants/puff/gpio.c: https://review.coreboot.org/c/coreboot/+/37460/1/src/mainboard/google/hatch… PS1, Line 89: 0 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/37460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91ebd6bd3ba712ee8b48472c0d3b6a4f982fbb28 Gerrit-Change-Number: 37460 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 23 Dec 2019 09:06:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src: Add missing 'include <commonlib/helpers.h>'
by HAOUAS Elyes (Code Review) 23 Dec '19

23 Dec '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37415 ) Change subject: src: Add missing 'include <commonlib/helpers.h>' ...................................................................... src: Add missing 'include <commonlib/helpers.h>' Macro "check_member(structure, member, offset)" needs '<commonlib/helpers.h>'. Change-Id: I1ca717f4b980020e80ac39ea46b430b72848963d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/uart/pl011.h M src/soc/cavium/cn81xx/include/soc/soc.h M src/soc/cavium/cn81xx/spi.c M src/soc/cavium/cn81xx/timer.c M src/soc/cavium/cn81xx/uart.c M src/soc/mediatek/common/include/soc/ddp_common.h M src/soc/mediatek/common/include/soc/dsi_common.h M src/soc/mediatek/common/include/soc/gpio_common.h M src/soc/mediatek/common/include/soc/i2c_common.h M src/soc/mediatek/common/include/soc/timer.h M src/soc/mediatek/common/include/soc/usb_common.h M src/soc/mediatek/mt8173/include/soc/ddp.h M src/soc/mediatek/mt8173/include/soc/dramc_register.h M src/soc/mediatek/mt8173/include/soc/dsi.h M src/soc/mediatek/mt8173/include/soc/flash_controller.h M src/soc/mediatek/mt8173/include/soc/gpio.h M src/soc/mediatek/mt8173/include/soc/i2c.h M src/soc/mediatek/mt8173/include/soc/infracfg.h M src/soc/mediatek/mt8173/include/soc/mcucfg.h M src/soc/mediatek/mt8173/include/soc/mipi.h M src/soc/mediatek/mt8173/include/soc/pll.h M src/soc/mediatek/mt8173/include/soc/pmic_wrap.h M src/soc/mediatek/mt8173/include/soc/spi.h M src/soc/mediatek/mt8173/include/soc/spm.h M src/soc/mediatek/mt8173/include/soc/usb.h M src/soc/mediatek/mt8183/include/soc/ddp.h M src/soc/mediatek/mt8183/include/soc/dramc_register.h M src/soc/mediatek/mt8183/include/soc/dsi.h M src/soc/mediatek/mt8183/include/soc/efuse.h M src/soc/mediatek/mt8183/include/soc/gpio.h M src/soc/mediatek/mt8183/include/soc/i2c.h M src/soc/mediatek/mt8183/include/soc/infracfg.h M src/soc/mediatek/mt8183/include/soc/mcucfg.h M src/soc/mediatek/mt8183/include/soc/pll.h M src/soc/mediatek/mt8183/include/soc/pmic_wrap.h M src/soc/mediatek/mt8183/include/soc/smi.h M src/soc/mediatek/mt8183/include/soc/spi.h M src/soc/mediatek/mt8183/include/soc/spm.h M src/soc/mediatek/mt8183/include/soc/usb.h M src/soc/nvidia/tegra/dc.h M src/soc/nvidia/tegra/i2c.h M src/soc/nvidia/tegra/usb.c M src/soc/nvidia/tegra124/include/soc/clk_rst.h M src/soc/nvidia/tegra124/include/soc/dma.h M src/soc/nvidia/tegra124/include/soc/emc.h M src/soc/nvidia/tegra124/include/soc/flow.h M src/soc/nvidia/tegra124/include/soc/mc.h M src/soc/nvidia/tegra124/include/soc/pmc.h M src/soc/nvidia/tegra124/include/soc/sdram_param.h M src/soc/nvidia/tegra124/include/soc/spi.h M src/soc/nvidia/tegra124/include/soc/sysctr.h M src/soc/nvidia/tegra210/include/soc/clk_rst.h M src/soc/nvidia/tegra210/include/soc/clst_clk.h M src/soc/nvidia/tegra210/include/soc/dma.h M src/soc/nvidia/tegra210/include/soc/emc.h M src/soc/nvidia/tegra210/include/soc/flow.h M src/soc/nvidia/tegra210/include/soc/mc.h M src/soc/nvidia/tegra210/include/soc/pmc.h M src/soc/nvidia/tegra210/include/soc/sdram_param.h M src/soc/nvidia/tegra210/include/soc/spi.h M src/soc/nvidia/tegra210/include/soc/sysctr.h M src/soc/qualcomm/ipq806x/usb.c M src/soc/qualcomm/qcs405/usb.c M src/soc/qualcomm/sdm845/include/soc/clock.h M src/soc/qualcomm/sdm845/include/soc/efuse.h M src/soc/qualcomm/sdm845/include/soc/qspi.h M src/soc/qualcomm/sdm845/usb.c M src/soc/rockchip/common/include/soc/edp.h M src/soc/rockchip/common/include/soc/gpio.h M src/soc/rockchip/common/include/soc/spi.h M src/soc/rockchip/common/include/soc/vop.h M src/soc/rockchip/common/pwm.c M src/soc/rockchip/rk3288/clock.c M src/soc/rockchip/rk3288/crypto.c M src/soc/rockchip/rk3288/include/soc/grf.h M src/soc/rockchip/rk3288/include/soc/hdmi.h M src/soc/rockchip/rk3288/include/soc/pmu.h M src/soc/rockchip/rk3288/include/soc/sdram.h M src/soc/rockchip/rk3288/sdram.c M src/soc/rockchip/rk3288/tsadc.c M src/soc/rockchip/rk3399/include/soc/clock.h M src/soc/rockchip/rk3399/include/soc/grf.h M src/soc/rockchip/rk3399/include/soc/mipi.h M src/soc/rockchip/rk3399/include/soc/usb.h M src/soc/rockchip/rk3399/saradc.c M src/soc/rockchip/rk3399/tsadc.c M src/soc/samsung/exynos5250/include/soc/clk.h M src/soc/samsung/exynos5250/include/soc/dmc.h M src/soc/samsung/exynos5250/include/soc/dp.h M src/soc/samsung/exynos5250/include/soc/dsim.h M src/soc/samsung/exynos5250/include/soc/fimd.h M src/soc/samsung/exynos5250/include/soc/power.h M src/soc/samsung/exynos5250/include/soc/spi.h M src/soc/samsung/exynos5250/include/soc/sysreg.h M src/soc/samsung/exynos5250/include/soc/tmu.h M src/soc/samsung/exynos5250/include/soc/trustzone.h M src/soc/samsung/exynos5250/include/soc/uart.h M src/soc/samsung/exynos5250/include/soc/usb.h M src/soc/samsung/exynos5420/i2c.c M src/soc/samsung/exynos5420/include/soc/clk.h M src/soc/samsung/exynos5420/include/soc/dmc.h M src/soc/samsung/exynos5420/include/soc/dp.h M src/soc/samsung/exynos5420/include/soc/dsim.h M src/soc/samsung/exynos5420/include/soc/fimd.h M src/soc/samsung/exynos5420/include/soc/power.h M src/soc/samsung/exynos5420/include/soc/spi.h M src/soc/samsung/exynos5420/include/soc/sysreg.h M src/soc/samsung/exynos5420/include/soc/tmu.h M src/soc/samsung/exynos5420/include/soc/trustzone.h M src/soc/samsung/exynos5420/include/soc/uart.h M src/soc/samsung/exynos5420/include/soc/usb.h 111 files changed, 130 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37415/1 diff --git a/src/drivers/uart/pl011.h b/src/drivers/uart/pl011.h index 2568dbc..baf6c31 100644 --- a/src/drivers/uart/pl011.h +++ b/src/drivers/uart/pl011.h @@ -10,6 +10,7 @@ #ifndef __DRIVERS_UART_PL011_H #define __DRIVERS_UART_PL011_H +#include <commonlib/helpers.h> #include <stdint.h> #include <types.h> diff --git a/src/soc/cavium/cn81xx/include/soc/soc.h b/src/soc/cavium/cn81xx/include/soc/soc.h index 582cff3..256f722 100644 --- a/src/soc/cavium/cn81xx/include/soc/soc.h +++ b/src/soc/cavium/cn81xx/include/soc/soc.h @@ -16,6 +16,7 @@ #ifndef __SOC_CAVIUM_CN81XX_INCLUDE_SOC_SOC_H #define __SOC_CAVIUM_CN81XX_INCLUDE_SOC_SOC_H +#include <commonlib/helpers.h> #include <stdint.h> #include <types.h> diff --git a/src/soc/cavium/cn81xx/spi.c b/src/soc/cavium/cn81xx/spi.c index 6a5abb1..960f1be 100644 --- a/src/soc/cavium/cn81xx/spi.c +++ b/src/soc/cavium/cn81xx/spi.c @@ -18,6 +18,7 @@ #include <device/mmio.h> #include <assert.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <endian.h> #include <soc/addressmap.h> diff --git a/src/soc/cavium/cn81xx/timer.c b/src/soc/cavium/cn81xx/timer.c index bd67d8a..2f24c63 100644 --- a/src/soc/cavium/cn81xx/timer.c +++ b/src/soc/cavium/cn81xx/timer.c @@ -19,6 +19,7 @@ #include <delay.h> #include <device/mmio.h> #include <arch/lib_helpers.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <soc/clock.h> #include <soc/timer.h> diff --git a/src/soc/cavium/cn81xx/uart.c b/src/soc/cavium/cn81xx/uart.c index 8a21f00..5e286d2 100644 --- a/src/soc/cavium/cn81xx/uart.c +++ b/src/soc/cavium/cn81xx/uart.c @@ -17,6 +17,7 @@ */ #include <device/mmio.h> +#include <commonlib/helpers.h> #include <console/uart.h> #include <delay.h> #include <endian.h> diff --git a/src/soc/mediatek/common/include/soc/ddp_common.h b/src/soc/mediatek/common/include/soc/ddp_common.h index 6d00ea3..0bc85f6 100644 --- a/src/soc/mediatek/common/include/soc/ddp_common.h +++ b/src/soc/mediatek/common/include/soc/ddp_common.h @@ -17,6 +17,7 @@ #define _DDP_COMMON_H_ #include <soc/addressmap.h> +#include <commonlib/helpers.h> #include <types.h> diff --git a/src/soc/mediatek/common/include/soc/dsi_common.h b/src/soc/mediatek/common/include/soc/dsi_common.h index 3052689..8462912 100644 --- a/src/soc/mediatek/common/include/soc/dsi_common.h +++ b/src/soc/mediatek/common/include/soc/dsi_common.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_DSI_COMMON_H #define SOC_MEDIATEK_DSI_COMMON_H +#include <commonlib/helpers.h> #include <edid.h> #include <types.h> #include <soc/addressmap.h> diff --git a/src/soc/mediatek/common/include/soc/gpio_common.h b/src/soc/mediatek/common/include/soc/gpio_common.h index 374c810..4a58fe7 100644 --- a/src/soc/mediatek/common/include/soc/gpio_common.h +++ b/src/soc/mediatek/common/include/soc/gpio_common.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_COMMON_GPIO_H #define SOC_MEDIATEK_COMMON_GPIO_H +#include <commonlib/helpers.h> #include <soc/gpio_base.h> #include <stddef.h> #include <stdint.h> diff --git a/src/soc/mediatek/common/include/soc/i2c_common.h b/src/soc/mediatek/common/include/soc/i2c_common.h index c9dade4..0d9c81b 100644 --- a/src/soc/mediatek/common/include/soc/i2c_common.h +++ b/src/soc/mediatek/common/include/soc/i2c_common.h @@ -16,6 +16,8 @@ #ifndef MTK_COMMON_I2C_H #define MTK_COMMON_I2C_H +#include <commonlib/helpers.h> + /* I2C DMA Registers */ struct mt_i2c_dma_regs { uint32_t dma_int_flag; diff --git a/src/soc/mediatek/common/include/soc/timer.h b/src/soc/mediatek/common/include/soc/timer.h index b58d4d3..4d2fee8 100644 --- a/src/soc/mediatek/common/include/soc/timer.h +++ b/src/soc/mediatek/common/include/soc/timer.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_COMMON_TIMER_H #define SOC_MEDIATEK_COMMON_TIMER_H +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/mediatek/common/include/soc/usb_common.h b/src/soc/mediatek/common/include/soc/usb_common.h index 22704e7..ba5ee76 100644 --- a/src/soc/mediatek/common/include/soc/usb_common.h +++ b/src/soc/mediatek/common/include/soc/usb_common.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_USB_COMMON_H #define SOC_MEDIATEK_USB_COMMON_H +#include <commonlib/helpers.h> #include <stddef.h> /* ip_pw_ctrl0 */ diff --git a/src/soc/mediatek/mt8173/include/soc/ddp.h b/src/soc/mediatek/mt8173/include/soc/ddp.h index dbac5f7..adea710 100644 --- a/src/soc/mediatek/mt8173/include/soc/ddp.h +++ b/src/soc/mediatek/mt8173/include/soc/ddp.h @@ -16,6 +16,7 @@ #ifndef _MT8173_SOC_DDP_H_ #define _MT8173_SOC_DDP_H_ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <soc/ddp_common.h> #include <types.h> diff --git a/src/soc/mediatek/mt8173/include/soc/dramc_register.h b/src/soc/mediatek/mt8173/include/soc/dramc_register.h index ce65173..5e7d962 100644 --- a/src/soc/mediatek/mt8173/include/soc/dramc_register.h +++ b/src/soc/mediatek/mt8173/include/soc/dramc_register.h @@ -16,6 +16,7 @@ #ifndef _DRAMC_REGISTER_H_ #define _DRAMC_REGISTER_H_ +#include <commonlib/helpers.h> #include <stddef.h> #include <types.h> diff --git a/src/soc/mediatek/mt8173/include/soc/dsi.h b/src/soc/mediatek/mt8173/include/soc/dsi.h index e7c1d28..cb85397 100644 --- a/src/soc/mediatek/mt8173/include/soc/dsi.h +++ b/src/soc/mediatek/mt8173/include/soc/dsi.h @@ -16,6 +16,7 @@ #ifndef _DSI_REG_H_ #define _DSI_REG_H_ +#include <commonlib/helpers.h> #include <soc/dsi_common.h> /* DSI features */ diff --git a/src/soc/mediatek/mt8173/include/soc/flash_controller.h b/src/soc/mediatek/mt8173/include/soc/flash_controller.h index 8d7db8b..2b9e24b 100644 --- a/src/soc/mediatek/mt8173/include/soc/flash_controller.h +++ b/src/soc/mediatek/mt8173/include/soc/flash_controller.h @@ -16,6 +16,7 @@ #ifndef __SOC_MEDIATEK_MT8173_FLASH_CONTROLLER_H__ #define __SOC_MEDIATEK_MT8173_FLASH_CONTROLLER_H__ +#include <commonlib/helpers.h> #include <spi-generic.h> #include <stdint.h> #include <soc/addressmap.h> diff --git a/src/soc/mediatek/mt8173/include/soc/gpio.h b/src/soc/mediatek/mt8173/include/soc/gpio.h index 8a6e13a..d452194 100644 --- a/src/soc/mediatek/mt8173/include/soc/gpio.h +++ b/src/soc/mediatek/mt8173/include/soc/gpio.h @@ -15,6 +15,7 @@ #ifndef SOC_MEDIATEK_MT8173_GPIO_H #define SOC_MEDIATEK_MT8173_GPIO_H +#include <commonlib/helpers.h> #include <stdint.h> #include <soc/addressmap.h> #include <soc/gpio_common.h> diff --git a/src/soc/mediatek/mt8173/include/soc/i2c.h b/src/soc/mediatek/mt8173/include/soc/i2c.h index 6198934..6942440 100644 --- a/src/soc/mediatek/mt8173/include/soc/i2c.h +++ b/src/soc/mediatek/mt8173/include/soc/i2c.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8173_I2C_H #define SOC_MEDIATEK_MT8173_I2C_H +#include <commonlib/helpers.h> #include <soc/i2c_common.h> /* I2C Register */ diff --git a/src/soc/mediatek/mt8173/include/soc/infracfg.h b/src/soc/mediatek/mt8173/include/soc/infracfg.h index 60a5209..53e0b9e 100644 --- a/src/soc/mediatek/mt8173/include/soc/infracfg.h +++ b/src/soc/mediatek/mt8173/include/soc/infracfg.h @@ -16,6 +16,7 @@ #ifndef __SOC_MEDIATEK_MT8173_INFRACFG_H__ #define __SOC_MEDIATEK_MT8173_INFRACFG_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/mediatek/mt8173/include/soc/mcucfg.h b/src/soc/mediatek/mt8173/include/soc/mcucfg.h index 5c01150..273f8d0 100644 --- a/src/soc/mediatek/mt8173/include/soc/mcucfg.h +++ b/src/soc/mediatek/mt8173/include/soc/mcucfg.h @@ -16,6 +16,7 @@ #ifndef __SOC_MEDIATEK_MT8173_MCUCFG_H__ #define __SOC_MEDIATEK_MT8173_MCUCFG_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> struct mt8173_mcucfg_regs { diff --git a/src/soc/mediatek/mt8173/include/soc/mipi.h b/src/soc/mediatek/mt8173/include/soc/mipi.h index aec0b25..00e7749 100644 --- a/src/soc/mediatek/mt8173/include/soc/mipi.h +++ b/src/soc/mediatek/mt8173/include/soc/mipi.h @@ -16,6 +16,7 @@ #ifndef __SOC_MEDIATEK_MT8173_MIPI_H__ #define __SOC_MEDIATEK_MT8173_MIPI_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/mediatek/mt8173/include/soc/pll.h b/src/soc/mediatek/mt8173/include/soc/pll.h index 480ffbf..175a7b9 100644 --- a/src/soc/mediatek/mt8173/include/soc/pll.h +++ b/src/soc/mediatek/mt8173/include/soc/pll.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8173_PLL_H #define SOC_MEDIATEK_MT8173_PLL_H +#include <commonlib/helpers.h> #include <soc/emi.h> #include <soc/pll_common.h> diff --git a/src/soc/mediatek/mt8173/include/soc/pmic_wrap.h b/src/soc/mediatek/mt8173/include/soc/pmic_wrap.h index 3687a29..45d6148 100644 --- a/src/soc/mediatek/mt8173/include/soc/pmic_wrap.h +++ b/src/soc/mediatek/mt8173/include/soc/pmic_wrap.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8173_PMIC_WRAP_H #define SOC_MEDIATEK_MT8173_PMIC_WRAP_H +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <soc/pmic_wrap_common.h> #include <types.h> diff --git a/src/soc/mediatek/mt8173/include/soc/spi.h b/src/soc/mediatek/mt8173/include/soc/spi.h index 58bf517..169352d 100644 --- a/src/soc/mediatek/mt8173/include/soc/spi.h +++ b/src/soc/mediatek/mt8173/include/soc/spi.h @@ -16,6 +16,7 @@ #ifndef MTK_MT8173_SPI_H #define MTK_MT8173_SPI_H +#include <commonlib/helpers.h> #include <soc/spi_common.h> #define SPI_BUS_NUMBER 1 diff --git a/src/soc/mediatek/mt8173/include/soc/spm.h b/src/soc/mediatek/mt8173/include/soc/spm.h index 133c8a3..638a701 100644 --- a/src/soc/mediatek/mt8173/include/soc/spm.h +++ b/src/soc/mediatek/mt8173/include/soc/spm.h @@ -16,6 +16,7 @@ #ifndef __SOC_MEDIATEK_MT8173_SPM_H__ #define __SOC_MEDIATEK_MT8173_SPM_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <stddef.h> diff --git a/src/soc/mediatek/mt8173/include/soc/usb.h b/src/soc/mediatek/mt8173/include/soc/usb.h index 8e74436..f170695 100644 --- a/src/soc/mediatek/mt8173/include/soc/usb.h +++ b/src/soc/mediatek/mt8173/include/soc/usb.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8173_USB_H #define SOC_MEDIATEK_MT8173_USB_H +#include <commonlib/helpers.h> #include <soc/usb_common.h> struct ssusb_sif_port { diff --git a/src/soc/mediatek/mt8183/include/soc/ddp.h b/src/soc/mediatek/mt8183/include/soc/ddp.h index 479417c..8217217 100644 --- a/src/soc/mediatek/mt8183/include/soc/ddp.h +++ b/src/soc/mediatek/mt8183/include/soc/ddp.h @@ -16,6 +16,7 @@ #ifndef _MT8183_SOC_DDP_H_ #define _MT8183_SOC_DDP_H_ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <soc/ddp_common.h> #include <types.h> diff --git a/src/soc/mediatek/mt8183/include/soc/dramc_register.h b/src/soc/mediatek/mt8183/include/soc/dramc_register.h index b3ee6af..eb79201 100644 --- a/src/soc/mediatek/mt8183/include/soc/dramc_register.h +++ b/src/soc/mediatek/mt8183/include/soc/dramc_register.h @@ -16,6 +16,7 @@ #ifndef _DRAMC_REGISTER_H_ #define _DRAMC_REGISTER_H_ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <types.h> #include <soc/addressmap.h> diff --git a/src/soc/mediatek/mt8183/include/soc/dsi.h b/src/soc/mediatek/mt8183/include/soc/dsi.h index 8813f94..e3592e3 100644 --- a/src/soc/mediatek/mt8183/include/soc/dsi.h +++ b/src/soc/mediatek/mt8183/include/soc/dsi.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_DSI_H #define SOC_MEDIATEK_MT8183_DSI_H +#include <commonlib/helpers.h> #include <soc/dsi_common.h> /* DSI features */ diff --git a/src/soc/mediatek/mt8183/include/soc/efuse.h b/src/soc/mediatek/mt8183/include/soc/efuse.h index 32126ab..7ea0a02 100644 --- a/src/soc/mediatek/mt8183/include/soc/efuse.h +++ b/src/soc/mediatek/mt8183/include/soc/efuse.h @@ -16,6 +16,7 @@ #ifndef _MTK_EFUSE_H #define _MTK_EFUSE_H +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/mediatek/mt8183/include/soc/gpio.h b/src/soc/mediatek/mt8183/include/soc/gpio.h index a0d6262..cab7719 100644 --- a/src/soc/mediatek/mt8183/include/soc/gpio.h +++ b/src/soc/mediatek/mt8183/include/soc/gpio.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_GPIO_H #define SOC_MEDIATEK_MT8183_GPIO_H +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <soc/gpio_common.h> #include <types.h> diff --git a/src/soc/mediatek/mt8183/include/soc/i2c.h b/src/soc/mediatek/mt8183/include/soc/i2c.h index a75b6f0..0b8a7f6 100644 --- a/src/soc/mediatek/mt8183/include/soc/i2c.h +++ b/src/soc/mediatek/mt8183/include/soc/i2c.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_I2C_H #define SOC_MEDIATEK_MT8183_I2C_H +#include <commonlib/helpers.h> #include <soc/i2c_common.h> /* I2C Register */ diff --git a/src/soc/mediatek/mt8183/include/soc/infracfg.h b/src/soc/mediatek/mt8183/include/soc/infracfg.h index 922d977..cacaa4e 100644 --- a/src/soc/mediatek/mt8183/include/soc/infracfg.h +++ b/src/soc/mediatek/mt8183/include/soc/infracfg.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_INFRACFG_H #define SOC_MEDIATEK_MT8183_INFRACFG_H +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/mediatek/mt8183/include/soc/mcucfg.h b/src/soc/mediatek/mt8183/include/soc/mcucfg.h index 0a1232a..2d1f6ca 100644 --- a/src/soc/mediatek/mt8183/include/soc/mcucfg.h +++ b/src/soc/mediatek/mt8183/include/soc/mcucfg.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_MCUCFG_H #define SOC_MEDIATEK_MT8183_MCUCFG_H +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/mediatek/mt8183/include/soc/pll.h b/src/soc/mediatek/mt8183/include/soc/pll.h index 5a24e75..01d9a48 100644 --- a/src/soc/mediatek/mt8183/include/soc/pll.h +++ b/src/soc/mediatek/mt8183/include/soc/pll.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_PLL_H #define SOC_MEDIATEK_MT8183_PLL_H +#include <commonlib/helpers.h> #include <types.h> #include <soc/pll_common.h> diff --git a/src/soc/mediatek/mt8183/include/soc/pmic_wrap.h b/src/soc/mediatek/mt8183/include/soc/pmic_wrap.h index da94230..70ef502 100644 --- a/src/soc/mediatek/mt8183/include/soc/pmic_wrap.h +++ b/src/soc/mediatek/mt8183/include/soc/pmic_wrap.h @@ -16,6 +16,7 @@ #ifndef __SOC_MEDIATEK_MT8183_PMIC_WRAP_H__ #define __SOC_MEDIATEK_MT8183_PMIC_WRAP_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <soc/pmic_wrap_common.h> #include <types.h> diff --git a/src/soc/mediatek/mt8183/include/soc/smi.h b/src/soc/mediatek/mt8183/include/soc/smi.h index e9051c2..6f9d6a9 100644 --- a/src/soc/mediatek/mt8183/include/soc/smi.h +++ b/src/soc/mediatek/mt8183/include/soc/smi.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_SMI_H #define SOC_MEDIATEK_MT8183_SMI_H +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/mediatek/mt8183/include/soc/spi.h b/src/soc/mediatek/mt8183/include/soc/spi.h index f718081..6ad5ecf 100644 --- a/src/soc/mediatek/mt8183/include/soc/spi.h +++ b/src/soc/mediatek/mt8183/include/soc/spi.h @@ -16,6 +16,7 @@ #ifndef MTK_MT8183_SPI_H #define MTK_MT8183_SPI_H +#include <commonlib/helpers.h> #include <soc/spi_common.h> #define SPI_BUS_NUMBER 6 diff --git a/src/soc/mediatek/mt8183/include/soc/spm.h b/src/soc/mediatek/mt8183/include/soc/spm.h index d0a7aa7..86b4a59 100644 --- a/src/soc/mediatek/mt8183/include/soc/spm.h +++ b/src/soc/mediatek/mt8183/include/soc/spm.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_SPM_H #define SOC_MEDIATEK_MT8183_SPM_H +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <stdint.h> #include <types.h> diff --git a/src/soc/mediatek/mt8183/include/soc/usb.h b/src/soc/mediatek/mt8183/include/soc/usb.h index 57d4e78..233a55d 100644 --- a/src/soc/mediatek/mt8183/include/soc/usb.h +++ b/src/soc/mediatek/mt8183/include/soc/usb.h @@ -16,6 +16,7 @@ #ifndef SOC_MEDIATEK_MT8183_USB_H #define SOC_MEDIATEK_MT8183_USB_H +#include <commonlib/helpers.h> #include <soc/usb_common.h> struct ssusb_sif_port { diff --git a/src/soc/nvidia/tegra/dc.h b/src/soc/nvidia/tegra/dc.h index 56332e4..4a36616 100644 --- a/src/soc/nvidia/tegra/dc.h +++ b/src/soc/nvidia/tegra/dc.h @@ -16,6 +16,8 @@ #ifndef __SOC_NVIDIA_TEGRA_DC_H #define __SOC_NVIDIA_TEGRA_DC_H + +#include <commonlib/helpers.h> #include <device/device.h> #include <stddef.h> #include <types.h> diff --git a/src/soc/nvidia/tegra/i2c.h b/src/soc/nvidia/tegra/i2c.h index a2bf950..e1e2ae2 100644 --- a/src/soc/nvidia/tegra/i2c.h +++ b/src/soc/nvidia/tegra/i2c.h @@ -16,6 +16,7 @@ #ifndef __SOC_NVIDIA_TEGRA_I2C_H__ #define __SOC_NVIDIA_TEGRA_I2C_H__ +#include <commonlib/helpers.h> #include <stdint.h> void i2c_init(unsigned int bus); diff --git a/src/soc/nvidia/tegra/usb.c b/src/soc/nvidia/tegra/usb.c index 55d80ed..fe59b3d 100644 --- a/src/soc/nvidia/tegra/usb.c +++ b/src/soc/nvidia/tegra/usb.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <delay.h> #include <device/mmio.h> #include <console/console.h> diff --git a/src/soc/nvidia/tegra124/include/soc/clk_rst.h b/src/soc/nvidia/tegra124/include/soc/clk_rst.h index 07e710a..4c34cc7 100644 --- a/src/soc/nvidia/tegra124/include/soc/clk_rst.h +++ b/src/soc/nvidia/tegra124/include/soc/clk_rst.h @@ -16,6 +16,8 @@ #ifndef _TEGRA124_CLK_RST_H_ #define _TEGRA124_CLK_RST_H_ +#include <commonlib/helpers.h> + /* Clock/Reset Controller (CLK_RST_CONTROLLER_) regs */ struct __packed clk_rst_ctlr { u32 rst_src; /* _RST_SOURCE, 0x000 */ diff --git a/src/soc/nvidia/tegra124/include/soc/dma.h b/src/soc/nvidia/tegra124/include/soc/dma.h index 3d6d209..d06a659 100644 --- a/src/soc/nvidia/tegra124/include/soc/dma.h +++ b/src/soc/nvidia/tegra124/include/soc/dma.h @@ -18,6 +18,7 @@ #ifndef __NVIDIA_TEGRA124_DMA_H__ #define __NVIDIA_TEGRA124_DMA_H__ +#include <commonlib/helpers.h> #include <stdint.h> #include <soc/addressmap.h> diff --git a/src/soc/nvidia/tegra124/include/soc/emc.h b/src/soc/nvidia/tegra124/include/soc/emc.h index 8e190f9..661432d 100644 --- a/src/soc/nvidia/tegra124/include/soc/emc.h +++ b/src/soc/nvidia/tegra124/include/soc/emc.h @@ -17,6 +17,7 @@ #ifndef __SOC_NVIDIA_TEGRA124_EMC_H__ #define __SOC_NVIDIA_TEGRA124_EMC_H__ +#include <commonlib/helpers.h> #include <stddef.h> #include <stdint.h> diff --git a/src/soc/nvidia/tegra124/include/soc/flow.h b/src/soc/nvidia/tegra124/include/soc/flow.h index 84bf705..f2ee702 100644 --- a/src/soc/nvidia/tegra124/include/soc/flow.h +++ b/src/soc/nvidia/tegra124/include/soc/flow.h @@ -16,6 +16,8 @@ #ifndef _TEGRA124_FLOW_H_ #define _TEGRA124_FLOW_H_ +#include <commonlib/helpers.h> + struct flow_ctlr { u32 halt_cpu_events; /* offset 0x00 */ u32 halt_cop_events; /* offset 0x04 */ diff --git a/src/soc/nvidia/tegra124/include/soc/mc.h b/src/soc/nvidia/tegra124/include/soc/mc.h index f249ecc..042a068 100644 --- a/src/soc/nvidia/tegra124/include/soc/mc.h +++ b/src/soc/nvidia/tegra124/include/soc/mc.h @@ -17,6 +17,7 @@ #ifndef __SOC_NVIDIA_TEGRA124_MC_H__ #define __SOC_NVIDIA_TEGRA124_MC_H__ +#include <commonlib/helpers.h> #include <stddef.h> #include <stdint.h> diff --git a/src/soc/nvidia/tegra124/include/soc/pmc.h b/src/soc/nvidia/tegra124/include/soc/pmc.h index b6f60e8..60301a2 100644 --- a/src/soc/nvidia/tegra124/include/soc/pmc.h +++ b/src/soc/nvidia/tegra124/include/soc/pmc.h @@ -16,6 +16,7 @@ #ifndef _TEGRA124_PMC_H_ #define _TEGRA124_PMC_H_ +#include <commonlib/helpers.h> #include <stdint.h> enum { diff --git a/src/soc/nvidia/tegra124/include/soc/sdram_param.h b/src/soc/nvidia/tegra124/include/soc/sdram_param.h index 938d655c..91d853b 100644 --- a/src/soc/nvidia/tegra124/include/soc/sdram_param.h +++ b/src/soc/nvidia/tegra124/include/soc/sdram_param.h @@ -24,6 +24,7 @@ #ifndef __SOC_NVIDIA_TEGRA124_SDRAM_PARAM_H__ #define __SOC_NVIDIA_TEGRA124_SDRAM_PARAM_H__ +#include <commonlib/helpers.h> #include <stddef.h> #include <stdint.h> diff --git a/src/soc/nvidia/tegra124/include/soc/spi.h b/src/soc/nvidia/tegra124/include/soc/spi.h index 875e880..7c6c750 100644 --- a/src/soc/nvidia/tegra124/include/soc/spi.h +++ b/src/soc/nvidia/tegra124/include/soc/spi.h @@ -16,6 +16,7 @@ #ifndef __NVIDIA_TEGRA124_SPI_H__ #define __NVIDIA_TEGRA124_SPI_H__ +#include <commonlib/helpers.h> #include <spi-generic.h> #include <soc/dma.h> #include <stddef.h> diff --git a/src/soc/nvidia/tegra124/include/soc/sysctr.h b/src/soc/nvidia/tegra124/include/soc/sysctr.h index 5b5e4c6..5a4239c 100644 --- a/src/soc/nvidia/tegra124/include/soc/sysctr.h +++ b/src/soc/nvidia/tegra124/include/soc/sysctr.h @@ -16,6 +16,7 @@ #ifndef __SOC_NVIDIA_TEGRA124_SYSCTR_H__ #define __SOC_NVIDIA_TEGRA124_SYSCTR_H__ +#include <commonlib/helpers.h> #include <stdint.h> enum { diff --git a/src/soc/nvidia/tegra210/include/soc/clk_rst.h b/src/soc/nvidia/tegra210/include/soc/clk_rst.h index 42eebed..224c66f 100644 --- a/src/soc/nvidia/tegra210/include/soc/clk_rst.h +++ b/src/soc/nvidia/tegra210/include/soc/clk_rst.h @@ -15,6 +15,8 @@ #ifndef _TEGRA210_CLK_RST_H_ #define _TEGRA210_CLK_RST_H_ + +#include <commonlib/helpers.h> #include <stdint.h> #include <stddef.h> diff --git a/src/soc/nvidia/tegra210/include/soc/clst_clk.h b/src/soc/nvidia/tegra210/include/soc/clst_clk.h index 661fd1d..6dc0936 100644 --- a/src/soc/nvidia/tegra210/include/soc/clst_clk.h +++ b/src/soc/nvidia/tegra210/include/soc/clst_clk.h @@ -16,6 +16,8 @@ #ifndef _TEGRA210_CLST_CLK_H_ #define _TEGRA210_CLST_CLK_H_ +#include <commonlib/helpers.h> + /* Cluster Clock (CLUSTER_CLOCKS_PUBLIC_) regs */ struct __packed clst_clk_ctlr { u32 pllx_base; /* _PLLX_BASE, 0x000 */ diff --git a/src/soc/nvidia/tegra210/include/soc/dma.h b/src/soc/nvidia/tegra210/include/soc/dma.h index 6d93419..a1481ae 100644 --- a/src/soc/nvidia/tegra210/include/soc/dma.h +++ b/src/soc/nvidia/tegra210/include/soc/dma.h @@ -17,6 +17,7 @@ #ifndef __NVIDIA_TEGRA210_DMA_H__ #define __NVIDIA_TEGRA210_DMA_H__ +#include <commonlib/helpers.h> #include <stdint.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/nvidia/tegra210/include/soc/emc.h b/src/soc/nvidia/tegra210/include/soc/emc.h index 289aa72..2ff5afd 100644 --- a/src/soc/nvidia/tegra210/include/soc/emc.h +++ b/src/soc/nvidia/tegra210/include/soc/emc.h @@ -17,6 +17,7 @@ #ifndef __SOC_NVIDIA_TEGRA210_EMC_H__ #define __SOC_NVIDIA_TEGRA210_EMC_H__ +#include <commonlib/helpers.h> #include <stddef.h> #include <stdint.h> diff --git a/src/soc/nvidia/tegra210/include/soc/flow.h b/src/soc/nvidia/tegra210/include/soc/flow.h index c30175a..8fda656 100644 --- a/src/soc/nvidia/tegra210/include/soc/flow.h +++ b/src/soc/nvidia/tegra210/include/soc/flow.h @@ -16,6 +16,8 @@ #ifndef _TEGRA210_FLOW_H_ #define _TEGRA210_FLOW_H_ +#include <commonlib/helpers.h> + struct flow_ctlr { u32 halt_cpu_events; /* offset 0x00 */ u32 halt_cop_events; /* offset 0x04 */ diff --git a/src/soc/nvidia/tegra210/include/soc/mc.h b/src/soc/nvidia/tegra210/include/soc/mc.h index b78305a..6fa0b23 100644 --- a/src/soc/nvidia/tegra210/include/soc/mc.h +++ b/src/soc/nvidia/tegra210/include/soc/mc.h @@ -17,6 +17,7 @@ #ifndef __SOC_NVIDIA_TEGRA210_MC_H__ #define __SOC_NVIDIA_TEGRA210_MC_H__ +#include <commonlib/helpers.h> #include <stddef.h> #include <stdint.h> diff --git a/src/soc/nvidia/tegra210/include/soc/pmc.h b/src/soc/nvidia/tegra210/include/soc/pmc.h index ad0d170..a889d6d 100644 --- a/src/soc/nvidia/tegra210/include/soc/pmc.h +++ b/src/soc/nvidia/tegra210/include/soc/pmc.h @@ -16,6 +16,7 @@ #ifndef _TEGRA210_PMC_H_ #define _TEGRA210_PMC_H_ +#include <commonlib/helpers.h> #include <stdint.h> enum { diff --git a/src/soc/nvidia/tegra210/include/soc/sdram_param.h b/src/soc/nvidia/tegra210/include/soc/sdram_param.h index 0b6f7a0..c86227e 100644 --- a/src/soc/nvidia/tegra210/include/soc/sdram_param.h +++ b/src/soc/nvidia/tegra210/include/soc/sdram_param.h @@ -24,6 +24,7 @@ #ifndef __SOC_NVIDIA_TEGRA210_SDRAM_PARAM_H__ #define __SOC_NVIDIA_TEGRA210_SDRAM_PARAM_H__ +#include <commonlib/helpers.h> #include <stddef.h> #include <stdint.h> diff --git a/src/soc/nvidia/tegra210/include/soc/spi.h b/src/soc/nvidia/tegra210/include/soc/spi.h index 46c1c3c..2269fc2 100644 --- a/src/soc/nvidia/tegra210/include/soc/spi.h +++ b/src/soc/nvidia/tegra210/include/soc/spi.h @@ -17,6 +17,7 @@ #ifndef __NVIDIA_TEGRA210_SPI_H__ #define __NVIDIA_TEGRA210_SPI_H__ +#include <commonlib/helpers.h> #include <soc/dma.h> #include <spi-generic.h> #include <stddef.h> diff --git a/src/soc/nvidia/tegra210/include/soc/sysctr.h b/src/soc/nvidia/tegra210/include/soc/sysctr.h index f182c66..1c6caef 100644 --- a/src/soc/nvidia/tegra210/include/soc/sysctr.h +++ b/src/soc/nvidia/tegra210/include/soc/sysctr.h @@ -16,6 +16,7 @@ #ifndef __SOC_NVIDIA_TEGRA210_SYSCTR_H__ #define __SOC_NVIDIA_TEGRA210_SYSCTR_H__ +#include <commonlib/helpers.h> #include <stdint.h> enum { diff --git a/src/soc/qualcomm/ipq806x/usb.c b/src/soc/qualcomm/ipq806x/usb.c index 35285cd..412d0a5 100644 --- a/src/soc/qualcomm/ipq806x/usb.c +++ b/src/soc/qualcomm/ipq806x/usb.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <console/console.h> #include <delay.h> diff --git a/src/soc/qualcomm/qcs405/usb.c b/src/soc/qualcomm/qcs405/usb.c index 765755c..e01e3b1 100644 --- a/src/soc/qualcomm/qcs405/usb.c +++ b/src/soc/qualcomm/qcs405/usb.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <console/console.h> #include <delay.h> diff --git a/src/soc/qualcomm/sdm845/include/soc/clock.h b/src/soc/qualcomm/sdm845/include/soc/clock.h index 1f79d95..08bd7fa 100644 --- a/src/soc/qualcomm/sdm845/include/soc/clock.h +++ b/src/soc/qualcomm/sdm845/include/soc/clock.h @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/qualcomm/sdm845/include/soc/efuse.h b/src/soc/qualcomm/sdm845/include/soc/efuse.h index 309193c..52616ac 100644 --- a/src/soc/qualcomm/sdm845/include/soc/efuse.h +++ b/src/soc/qualcomm/sdm845/include/soc/efuse.h @@ -16,6 +16,8 @@ #ifndef __SOC_QUALCOMM_SDM845_EFUSE_ADDRESS_MAP_H__ #define __SOC_QUALCOMM_SDM845_EFUSE_ADDRESS_MAP_H__ +#include <commonlib/helpers.h> + /** * USB EFUSE registers */ diff --git a/src/soc/qualcomm/sdm845/include/soc/qspi.h b/src/soc/qualcomm/sdm845/include/soc/qspi.h index 3f83421..990be9e 100644 --- a/src/soc/qualcomm/sdm845/include/soc/qspi.h +++ b/src/soc/qualcomm/sdm845/include/soc/qspi.h @@ -12,6 +12,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ + +#include <commonlib/helpers.h> #include <types.h> #include <soc/addressmap.h> #include <spi-generic.h> diff --git a/src/soc/qualcomm/sdm845/usb.c b/src/soc/qualcomm/sdm845/usb.c index bb0509b..60e11ae 100644 --- a/src/soc/qualcomm/sdm845/usb.c +++ b/src/soc/qualcomm/sdm845/usb.c @@ -14,6 +14,7 @@ */ #include <arch/mmio.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <delay.h> #include <soc/usb.h> diff --git a/src/soc/rockchip/common/include/soc/edp.h b/src/soc/rockchip/common/include/soc/edp.h index 58986d1..817d632 100644 --- a/src/soc/rockchip/common/include/soc/edp.h +++ b/src/soc/rockchip/common/include/soc/edp.h @@ -16,6 +16,7 @@ #ifndef __RK_DP_H #define __RK_DP_H +#include <commonlib/helpers.h> #include <edid.h> struct rk_edp_regs { diff --git a/src/soc/rockchip/common/include/soc/gpio.h b/src/soc/rockchip/common/include/soc/gpio.h index 6660374..d3991aa 100644 --- a/src/soc/rockchip/common/include/soc/gpio.h +++ b/src/soc/rockchip/common/include/soc/gpio.h @@ -16,6 +16,7 @@ #ifndef __COREBOOT_SRC_SOC_ROCKCHIP_COMMON_INCLUDE_SOC_GPIO_H #define __COREBOOT_SRC_SOC_ROCKCHIP_COMMON_INCLUDE_SOC_GPIO_H +#include <commonlib/helpers.h> #include <types.h> #define GPIO(p, b, i) ((gpio_t){.port = p, .bank = GPIO_##b, .idx = i}) diff --git a/src/soc/rockchip/common/include/soc/spi.h b/src/soc/rockchip/common/include/soc/spi.h index ce5de83..dcb4996 100644 --- a/src/soc/rockchip/common/include/soc/spi.h +++ b/src/soc/rockchip/common/include/soc/spi.h @@ -17,6 +17,8 @@ #define __COREBOOT_SRC_SOC_ROCKCHIP_COMMON_INCLUDE_SOC_SPI_H /* This driver serves as a CBFS media source. */ + +#include <commonlib/helpers.h> #include <spi-generic.h> #include <stddef.h> diff --git a/src/soc/rockchip/common/include/soc/vop.h b/src/soc/rockchip/common/include/soc/vop.h index 69d1184..1ddc5ec 100644 --- a/src/soc/rockchip/common/include/soc/vop.h +++ b/src/soc/rockchip/common/include/soc/vop.h @@ -15,6 +15,8 @@ #ifndef _ROCKCHIP_LCD_H_ #define _ROCKCHIP_LCD_H_ + +#include <commonlib/helpers.h> #include <stdint.h> #include <edid.h> diff --git a/src/soc/rockchip/common/pwm.c b/src/soc/rockchip/common/pwm.c index 98ef21f..6029295 100644 --- a/src/soc/rockchip/common/pwm.c +++ b/src/soc/rockchip/common/pwm.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/grf.h> diff --git a/src/soc/rockchip/rk3288/clock.c b/src/soc/rockchip/rk3288/clock.c index 1c490b4..84bc188 100644 --- a/src/soc/rockchip/rk3288/clock.c +++ b/src/soc/rockchip/rk3288/clock.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <assert.h> #include <console/console.h> diff --git a/src/soc/rockchip/rk3288/crypto.c b/src/soc/rockchip/rk3288/crypto.c index 00885bc..a40630f 100644 --- a/src/soc/rockchip/rk3288/crypto.c +++ b/src/soc/rockchip/rk3288/crypto.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <assert.h> #include <console/console.h> diff --git a/src/soc/rockchip/rk3288/include/soc/grf.h b/src/soc/rockchip/rk3288/include/soc/grf.h index 4a546ea..d4a5884 100644 --- a/src/soc/rockchip/rk3288/include/soc/grf.h +++ b/src/soc/rockchip/rk3288/include/soc/grf.h @@ -16,6 +16,7 @@ #ifndef __SOC_ROCKCHIP_RK3288_GRF_H__ #define __SOC_ROCKCHIP_RK3288_GRF_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <soc/soc.h> #include <types.h> diff --git a/src/soc/rockchip/rk3288/include/soc/hdmi.h b/src/soc/rockchip/rk3288/include/soc/hdmi.h index 3089949..2a7041e 100644 --- a/src/soc/rockchip/rk3288/include/soc/hdmi.h +++ b/src/soc/rockchip/rk3288/include/soc/hdmi.h @@ -18,6 +18,7 @@ #ifndef __SOC_HDMI_H__ #define __SOC_HDMI_H__ +#include <commonlib/helpers.h> #include <types.h> #define HDMI_EDID_BLOCK_SIZE 128 diff --git a/src/soc/rockchip/rk3288/include/soc/pmu.h b/src/soc/rockchip/rk3288/include/soc/pmu.h index 5ef9544..a1cff54 100644 --- a/src/soc/rockchip/rk3288/include/soc/pmu.h +++ b/src/soc/rockchip/rk3288/include/soc/pmu.h @@ -16,6 +16,7 @@ #ifndef __SOC_ROCKCHIP_RK3288_PMU_H__ #define __SOC_ROCKCHIP_RK3288_PMU_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> struct rk3288_pmu_regs { diff --git a/src/soc/rockchip/rk3288/include/soc/sdram.h b/src/soc/rockchip/rk3288/include/soc/sdram.h index 3ad51b6..85b4e82 100644 --- a/src/soc/rockchip/rk3288/include/soc/sdram.h +++ b/src/soc/rockchip/rk3288/include/soc/sdram.h @@ -16,6 +16,7 @@ #ifndef __SOC_ROCKCHIP_RK3288_SDRAM_H__ #define __SOC_ROCKCHIP_RK3288_SDRAM_H__ +#include <commonlib/helpers.h> #include <types.h> enum { diff --git a/src/soc/rockchip/rk3288/sdram.c b/src/soc/rockchip/rk3288/sdram.c index 74038b0..f6a45dd 100644 --- a/src/soc/rockchip/rk3288/sdram.c +++ b/src/soc/rockchip/rk3288/sdram.c @@ -12,6 +12,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ + +#include <commonlib/helpers.h> #include <device/mmio.h> #include <console/console.h> #include <delay.h> diff --git a/src/soc/rockchip/rk3288/tsadc.c b/src/soc/rockchip/rk3288/tsadc.c index 7e5823c..f47ec26 100644 --- a/src/soc/rockchip/rk3288/tsadc.c +++ b/src/soc/rockchip/rk3288/tsadc.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <soc/clock.h> #include <soc/grf.h> diff --git a/src/soc/rockchip/rk3399/include/soc/clock.h b/src/soc/rockchip/rk3399/include/soc/clock.h index e2aeaea..c78765c 100644 --- a/src/soc/rockchip/rk3399/include/soc/clock.h +++ b/src/soc/rockchip/rk3399/include/soc/clock.h @@ -16,6 +16,7 @@ #ifndef __SOC_ROCKCHIP_RK3399_CLOCK_H__ #define __SOC_ROCKCHIP_RK3399_CLOCK_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <types.h> diff --git a/src/soc/rockchip/rk3399/include/soc/grf.h b/src/soc/rockchip/rk3399/include/soc/grf.h index 9bda967..af95c05 100644 --- a/src/soc/rockchip/rk3399/include/soc/grf.h +++ b/src/soc/rockchip/rk3399/include/soc/grf.h @@ -16,6 +16,7 @@ #ifndef __SOC_ROCKCHIP_RK3399_GRF_H__ #define __SOC_ROCKCHIP_RK3399_GRF_H__ +#include <commonlib/helpers.h> #include <soc/addressmap.h> #include <soc/soc.h> #include <types.h> diff --git a/src/soc/rockchip/rk3399/include/soc/mipi.h b/src/soc/rockchip/rk3399/include/soc/mipi.h index 469a052..40cf830 100644 --- a/src/soc/rockchip/rk3399/include/soc/mipi.h +++ b/src/soc/rockchip/rk3399/include/soc/mipi.h @@ -16,6 +16,7 @@ #ifndef __RK_MIPI_H #define __RK_MIPI_H +#include <commonlib/helpers.h> #include <types.h> struct rk_mipi_regs { diff --git a/src/soc/rockchip/rk3399/include/soc/usb.h b/src/soc/rockchip/rk3399/include/soc/usb.h index c2fa1a2..ddaaff3 100644 --- a/src/soc/rockchip/rk3399/include/soc/usb.h +++ b/src/soc/rockchip/rk3399/include/soc/usb.h @@ -16,6 +16,7 @@ #ifndef __SOC_ROCKCHIP_RK3399_USB_H_ #define __SOC_ROCKCHIP_RK3399_USB_H_ +#include <commonlib/helpers.h> #include <soc/addressmap.h> /* Global constants */ diff --git a/src/soc/rockchip/rk3399/saradc.c b/src/soc/rockchip/rk3399/saradc.c index 8dd3cb4..412d85a 100644 --- a/src/soc/rockchip/rk3399/saradc.c +++ b/src/soc/rockchip/rk3399/saradc.c @@ -14,6 +14,7 @@ * */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <assert.h> #include <delay.h> diff --git a/src/soc/rockchip/rk3399/tsadc.c b/src/soc/rockchip/rk3399/tsadc.c index b81aa93..ce6abc5 100644 --- a/src/soc/rockchip/rk3399/tsadc.c +++ b/src/soc/rockchip/rk3399/tsadc.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <delay.h> #include <soc/clock.h> diff --git a/src/soc/samsung/exynos5250/include/soc/clk.h b/src/soc/samsung/exynos5250/include/soc/clk.h index fab0444..0601112 100644 --- a/src/soc/samsung/exynos5250/include/soc/clk.h +++ b/src/soc/samsung/exynos5250/include/soc/clk.h @@ -17,6 +17,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_CLK_H #define CPU_SAMSUNG_EXYNOS5250_CLK_H +#include <commonlib/helpers.h> #include <soc/cpu.h> #include <soc/dmc.h> #include <soc/pinmux.h> diff --git a/src/soc/samsung/exynos5250/include/soc/dmc.h b/src/soc/samsung/exynos5250/include/soc/dmc.h index 993987f..b59f0e2 100644 --- a/src/soc/samsung/exynos5250/include/soc/dmc.h +++ b/src/soc/samsung/exynos5250/include/soc/dmc.h @@ -16,6 +16,7 @@ #ifndef __ASSEMBLER__ +#include <commonlib/helpers.h> #include <soc/cpu.h> struct exynos5_dmc { diff --git a/src/soc/samsung/exynos5250/include/soc/dp.h b/src/soc/samsung/exynos5250/include/soc/dp.h index b5e65fb..f5d3628 100644 --- a/src/soc/samsung/exynos5250/include/soc/dp.h +++ b/src/soc/samsung/exynos5250/include/soc/dp.h @@ -19,6 +19,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_DP_H #define CPU_SAMSUNG_EXYNOS5250_DP_H +#include <commonlib/helpers.h> #include <soc/cpu.h> /* DSIM register map */ diff --git a/src/soc/samsung/exynos5250/include/soc/dsim.h b/src/soc/samsung/exynos5250/include/soc/dsim.h index 301d0a9..8d7f6de 100644 --- a/src/soc/samsung/exynos5250/include/soc/dsim.h +++ b/src/soc/samsung/exynos5250/include/soc/dsim.h @@ -18,6 +18,8 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_DSIM_H #define CPU_SAMSUNG_EXYNOS5250_DSIM_H +#include <commonlib/helpers.h> + /* DSIM register map */ struct exynos5_dsim { unsigned int status; diff --git a/src/soc/samsung/exynos5250/include/soc/fimd.h b/src/soc/samsung/exynos5250/include/soc/fimd.h index e58891e..ee8a84a 100644 --- a/src/soc/samsung/exynos5250/include/soc/fimd.h +++ b/src/soc/samsung/exynos5250/include/soc/fimd.h @@ -18,6 +18,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_FIMD_H #define CPU_SAMSUNG_EXYNOS5250_FIMD_H +#include <commonlib/helpers.h> #include <soc/cpu.h> /* FIMD register map */ diff --git a/src/soc/samsung/exynos5250/include/soc/power.h b/src/soc/samsung/exynos5250/include/soc/power.h index 297ee19..7cb393f 100644 --- a/src/soc/samsung/exynos5250/include/soc/power.h +++ b/src/soc/samsung/exynos5250/include/soc/power.h @@ -18,6 +18,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_POWER_H #define CPU_SAMSUNG_EXYNOS5250_POWER_H +#include <commonlib/helpers.h> #include <soc/cpu.h> /* Enable HW thermal trip with PS_HOLD_CONTROL register ENABLE_HW_TRIP bit */ diff --git a/src/soc/samsung/exynos5250/include/soc/spi.h b/src/soc/samsung/exynos5250/include/soc/spi.h index 19ee7f8..9aa07ec 100644 --- a/src/soc/samsung/exynos5250/include/soc/spi.h +++ b/src/soc/samsung/exynos5250/include/soc/spi.h @@ -16,6 +16,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_SPI_H #define CPU_SAMSUNG_EXYNOS5250_SPI_H +#include <commonlib/helpers.h> #include <boot_device.h> /* SPI peripheral register map; padded to 64KB */ diff --git a/src/soc/samsung/exynos5250/include/soc/sysreg.h b/src/soc/samsung/exynos5250/include/soc/sysreg.h index 397cdb3..8e6032d 100644 --- a/src/soc/samsung/exynos5250/include/soc/sysreg.h +++ b/src/soc/samsung/exynos5250/include/soc/sysreg.h @@ -18,6 +18,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_SYSREG_H #define CPU_SAMSUNG_EXYNOS5250_SYSREG_H +#include <commonlib/helpers.h> #include <soc/cpu.h> /* sysreg map */ diff --git a/src/soc/samsung/exynos5250/include/soc/tmu.h b/src/soc/samsung/exynos5250/include/soc/tmu.h index cb92c16..f3c90af 100644 --- a/src/soc/samsung/exynos5250/include/soc/tmu.h +++ b/src/soc/samsung/exynos5250/include/soc/tmu.h @@ -18,6 +18,8 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_TMU_H #define CPU_SAMSUNG_EXYNOS5250_TMU_H +#include <commonlib/helpers.h> + struct tmu_reg { unsigned int triminfo; unsigned int rsvd1; diff --git a/src/soc/samsung/exynos5250/include/soc/trustzone.h b/src/soc/samsung/exynos5250/include/soc/trustzone.h index 9a4afbf..d2155ea 100644 --- a/src/soc/samsung/exynos5250/include/soc/trustzone.h +++ b/src/soc/samsung/exynos5250/include/soc/trustzone.h @@ -16,6 +16,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_TRUSTZONE_H #define CPU_SAMSUNG_EXYNOS5250_TRUSTZONE_H +#include <commonlib/helpers.h> #include <stdint.h> /* Distance between each Trust Zone PC register set */ diff --git a/src/soc/samsung/exynos5250/include/soc/uart.h b/src/soc/samsung/exynos5250/include/soc/uart.h index 0f63b01..1c4558f 100644 --- a/src/soc/samsung/exynos5250/include/soc/uart.h +++ b/src/soc/samsung/exynos5250/include/soc/uart.h @@ -17,6 +17,8 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_UART_H #define CPU_SAMSUNG_EXYNOS5250_UART_H +#include <commonlib/helpers.h> + struct s5p_uart { unsigned int ulcon; unsigned int ucon; diff --git a/src/soc/samsung/exynos5250/include/soc/usb.h b/src/soc/samsung/exynos5250/include/soc/usb.h index 4a92f28..12f8637 100644 --- a/src/soc/samsung/exynos5250/include/soc/usb.h +++ b/src/soc/samsung/exynos5250/include/soc/usb.h @@ -16,6 +16,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_USB_H #define CPU_SAMSUNG_EXYNOS5250_USB_H +#include <commonlib/helpers.h> #include <soc/cpu.h> #define CLK_24MHZ 5 diff --git a/src/soc/samsung/exynos5420/i2c.c b/src/soc/samsung/exynos5420/i2c.c index 4dd9caa..96aa5e6 100644 --- a/src/soc/samsung/exynos5420/i2c.c +++ b/src/soc/samsung/exynos5420/i2c.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */ +#include <commonlib/helpers.h> #include <device/mmio.h> #include <assert.h> #include <console/console.h> diff --git a/src/soc/samsung/exynos5420/include/soc/clk.h b/src/soc/samsung/exynos5420/include/soc/clk.h index 08663ff..7aa26c2 100644 --- a/src/soc/samsung/exynos5420/include/soc/clk.h +++ b/src/soc/samsung/exynos5420/include/soc/clk.h @@ -17,6 +17,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_CLK_H #define CPU_SAMSUNG_EXYNOS5420_CLK_H +#include <commonlib/helpers.h> #include <soc/cpu.h> #include <soc/dmc.h> #include <soc/pinmux.h> diff --git a/src/soc/samsung/exynos5420/include/soc/dmc.h b/src/soc/samsung/exynos5420/include/soc/dmc.h index e068255..096604c 100644 --- a/src/soc/samsung/exynos5420/include/soc/dmc.h +++ b/src/soc/samsung/exynos5420/include/soc/dmc.h @@ -14,6 +14,8 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_DMC_H #define CPU_SAMSUNG_EXYNOS5420_DMC_H +#include <commonlib/helpers.h> + #define DMC_INTERLEAVE_SIZE 0x1f #define PAD_RETENTION_DRAM_COREBLK_VAL 0x10000000 diff --git a/src/soc/samsung/exynos5420/include/soc/dp.h b/src/soc/samsung/exynos5420/include/soc/dp.h index 6b33a76..e3cc602 100644 --- a/src/soc/samsung/exynos5420/include/soc/dp.h +++ b/src/soc/samsung/exynos5420/include/soc/dp.h @@ -19,6 +19,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_DP_H #define CPU_SAMSUNG_EXYNOS5420_DP_H +#include <commonlib/helpers.h> #include <soc/cpu.h> /* DSIM register map */ diff --git a/src/soc/samsung/exynos5420/include/soc/dsim.h b/src/soc/samsung/exynos5420/include/soc/dsim.h index 2d6a0c5..8cf1d39 100644 --- a/src/soc/samsung/exynos5420/include/soc/dsim.h +++ b/src/soc/samsung/exynos5420/include/soc/dsim.h @@ -18,6 +18,8 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_DSIM_H #define CPU_SAMSUNG_EXYNOS5420_DSIM_H +#include <commonlib/helpers.h> + /* DSIM register map */ struct exynos5_dsim { unsigned int status; diff --git a/src/soc/samsung/exynos5420/include/soc/fimd.h b/src/soc/samsung/exynos5420/include/soc/fimd.h index 3e9d6a4..197c968 100644 --- a/src/soc/samsung/exynos5420/include/soc/fimd.h +++ b/src/soc/samsung/exynos5420/include/soc/fimd.h @@ -18,6 +18,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_FIMD_H #define CPU_SAMSUNG_EXYNOS5420_FIMD_H +#include <commonlib/helpers.h> #include <soc/cpu.h> /* FIMD register map */ diff --git a/src/soc/samsung/exynos5420/include/soc/power.h b/src/soc/samsung/exynos5420/include/soc/power.h index 9b56fe5..b5cc588 100644 --- a/src/soc/samsung/exynos5420/include/soc/power.h +++ b/src/soc/samsung/exynos5420/include/soc/power.h @@ -18,6 +18,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_POWER_H #define CPU_SAMSUNG_EXYNOS5420_POWER_H +#include <commonlib/helpers.h> #include <soc/cpu.h> /* Enable HW thermal trip with PS_HOLD_CONTROL register ENABLE_HW_TRIP bit */ diff --git a/src/soc/samsung/exynos5420/include/soc/spi.h b/src/soc/samsung/exynos5420/include/soc/spi.h index 9d51914..c8a7d4f 100644 --- a/src/soc/samsung/exynos5420/include/soc/spi.h +++ b/src/soc/samsung/exynos5420/include/soc/spi.h @@ -17,6 +17,7 @@ #define CPU_SAMSUNG_EXYNOS5420_SPI_H #include <boot_device.h> +#include <commonlib/helpers.h> /* SPI peripheral register map; padded to 64KB */ struct exynos_spi { diff --git a/src/soc/samsung/exynos5420/include/soc/sysreg.h b/src/soc/samsung/exynos5420/include/soc/sysreg.h index 6417dfb..f7022fa 100644 --- a/src/soc/samsung/exynos5420/include/soc/sysreg.h +++ b/src/soc/samsung/exynos5420/include/soc/sysreg.h @@ -18,6 +18,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_SYSREG_H #define CPU_SAMSUNG_EXYNOS5420_SYSREG_H +#include <commonlib/helpers.h> #include <soc/cpu.h> /* sysreg map */ diff --git a/src/soc/samsung/exynos5420/include/soc/tmu.h b/src/soc/samsung/exynos5420/include/soc/tmu.h index eade11f..5396a7f 100644 --- a/src/soc/samsung/exynos5420/include/soc/tmu.h +++ b/src/soc/samsung/exynos5420/include/soc/tmu.h @@ -18,6 +18,8 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_TMU_H #define CPU_SAMSUNG_EXYNOS5420_TMU_H +#include <commonlib/helpers.h> + struct tmu_reg { unsigned int triminfo; unsigned int rsvd1; diff --git a/src/soc/samsung/exynos5420/include/soc/trustzone.h b/src/soc/samsung/exynos5420/include/soc/trustzone.h index c195cb8..78da110 100644 --- a/src/soc/samsung/exynos5420/include/soc/trustzone.h +++ b/src/soc/samsung/exynos5420/include/soc/trustzone.h @@ -16,6 +16,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_TRUSTZONE_H #define CPU_SAMSUNG_EXYNOS5420_TRUSTZONE_H +#include <commonlib/helpers.h> #include <stdint.h> /* Distance between each Trust Zone PC register set */ diff --git a/src/soc/samsung/exynos5420/include/soc/uart.h b/src/soc/samsung/exynos5420/include/soc/uart.h index 647b1f1..c035af7 100644 --- a/src/soc/samsung/exynos5420/include/soc/uart.h +++ b/src/soc/samsung/exynos5420/include/soc/uart.h @@ -17,6 +17,8 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_UART_H #define CPU_SAMSUNG_EXYNOS5420_UART_H +#include <commonlib/helpers.h> + struct s5p_uart { unsigned int ulcon; unsigned int ucon; diff --git a/src/soc/samsung/exynos5420/include/soc/usb.h b/src/soc/samsung/exynos5420/include/soc/usb.h index d80857c..2ffe513 100644 --- a/src/soc/samsung/exynos5420/include/soc/usb.h +++ b/src/soc/samsung/exynos5420/include/soc/usb.h @@ -16,6 +16,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_USB_H #define CPU_SAMSUNG_EXYNOS5420_USB_H +#include <commonlib/helpers.h> #include <soc/cpu.h> #define CLK_24MHZ 5 -- To view, visit https://review.coreboot.org/c/coreboot/+/37415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ca717f4b980020e80ac39ea46b430b72848963d Gerrit-Change-Number: 37415 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 11

Change in vboot[master]: vboot/firmware/2lib/include: Add missing <stddef.h>
by HAOUAS Elyes (Code Review) 23 Dec '19

23 Dec '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/vboot/+/37908 ) Change subject: vboot/firmware/2lib/include: Add missing <stddef.h> ...................................................................... vboot/firmware/2lib/include: Add missing <stddef.h> Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Change-Id: Icb62bf6ca293b6212f3963dd298b03e5fa11a2b3 --- M firmware/2lib/include/2struct.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/vboot refs/changes/08/37908/1 diff --git a/firmware/2lib/include/2struct.h b/firmware/2lib/include/2struct.h index a5908d0..071d224 100644 --- a/firmware/2lib/include/2struct.h +++ b/firmware/2lib/include/2struct.h @@ -16,6 +16,8 @@ #ifndef VBOOT_REFERENCE_2STRUCT_H_ #define VBOOT_REFERENCE_2STRUCT_H_ +#include <stddef.h> + #include "2api.h" #include "2constants.h" #include "2crypto.h" -- To view, visit https://review.coreboot.org/c/vboot/+/37908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: vboot Gerrit-Branch: master Gerrit-Change-Id: Icb62bf6ca293b6212f3963dd298b03e5fa11a2b3 Gerrit-Change-Number: 37908 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: soc/intel/tigerlake: Update Kconfig
by Furquan Shaikh (Code Review) 22 Dec '19

22 Dec '19

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 ) Change subject: soc/intel/tigerlake: Update Kconfig ...................................................................... Patch Set 11: (5 comments) https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@11 PS11, Line 11: UART This is not updated. https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@11 PS11, Line 11: I2C This is not updated. https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@13 PS11, Line 13: PCH baseclock Reference? https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kc… File src/soc/intel/tigerlake/Kconfig: https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kc… PS9, Line 102: if SOC_INTEL_TIGERLAKE > Use default for Tigerlake which does not require condition. I think its easier to read https://review.coreboot.org/c/coreboot/+/37426/9/src/soc/intel/tigerlake/Kc… PS9, Line 149: if SOC_INTEL_TIGERLAKE > Use default for Tigerlake which does not require condition. FWIW, I think it is easier to read if SOC_INTEL_TIGERLAKE is still in there. It makes it clear what the value is for TGL v/s JSL. -- To view, visit https://review.coreboot.org/c/coreboot/+/37426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c Gerrit-Change-Number: 37426 Gerrit-PatchSet: 11 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Sun, 22 Dec 2019 16:29:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: superio/common: Add more ACPI methods
by Patrick Rudolph (Code Review) 22 Dec '19

22 Dec '19

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37640 ) Change subject: superio/common: Add more ACPI methods ...................................................................... superio/common: Add more ACPI methods * Make use of introduced SSDT config mode access. * Provide ACPI functions to safely access SIO config space * Use introduced functions to implement _DIS and _STA in the device Change-Id: I520b29de925f368cd71ff8f1f58d2d57d72eff8d Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/superio/common/generic.c M src/superio/common/ssdt.c 2 files changed, 104 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37640/1 diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index 429ee51..2e5bf88 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -153,6 +153,85 @@ acpigen_write_indexfield("INDX", "DATA", i, ARRAY_SIZE(i), FIELD_BYTEACC | FIELD_NOLOCK | FIELD_PRESERVE); + const char *mutex = "MTX0"; + + acpigen_write_mutex(mutex, 0); + /* Backup LDN */ + acpigen_write_name_integer("BLDN", 0); + + /* Acquire mutex - Enter config mode */ + acpigen_write_method("AMTX", 1); + { + acpigen_write_acquire(mutex, 0xffff); + + pnp_ssdt_enter_conf_mode(dev, "^INDX", "^DATA"); + + /* Backup LDN */ + acpigen_write_store(); + acpigen_emit_namestring("^LDN"); + acpigen_emit_namestring("^BLDN"); + } + acpigen_pop_len(); /* Method */ + + /* Release mutex - Exit config mode */ + acpigen_write_method("RMTX", 1); + { + /* Restore LDN */ + acpigen_write_store(); + acpigen_emit_namestring("^BLDN"); + acpigen_emit_namestring("^LDN"); + + pnp_ssdt_exit_conf_mode(dev, "^INDX", "^DATA"); + + acpigen_write_release(mutex); + } + acpigen_pop_len(); /* Method */ + + /* Select a LDN */ + acpigen_write_method("SLDN", 1); + { + acpigen_write_store(); + acpigen_emit_byte(ARG0_OP); + acpigen_emit_namestring("^LDN"); + } + acpigen_pop_len(); /* Method */ + + /* Disable a LDN */ + acpigen_write_method("DLDN", 1); + { + acpigen_emit_namestring("AMTX"); + + acpigen_emit_namestring("SLDN"); + acpigen_emit_byte(ARG0_OP); + + acpigen_write_store(); + acpigen_emit_byte(ZERO_OP); + acpigen_emit_namestring("^ACTR"); + + acpigen_emit_namestring("RMTX"); + } + acpigen_pop_len(); /* Method */ + + /* Query LDN enable state. Returns 1 if LDN is enabled. */ + acpigen_write_method("QLDN", 1); + { + acpigen_emit_namestring("AMTX"); + + acpigen_emit_namestring("SLDN"); + acpigen_emit_byte(ARG0_OP); + + acpigen_write_store(); + acpigen_emit_namestring("^ACTR"); + acpigen_emit_byte(LOCAL0_OP); + + acpigen_write_and(LOCAL0_OP, ONE_OP, LOCAL0_OP); + + acpigen_emit_namestring("RMTX"); + + acpigen_write_return_byte(LOCAL0_OP); + } + acpigen_pop_len(); /* Method */ + acpigen_pop_len(); /* Device */ acpigen_pop_len(); /* Scope */ } diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c index a919aa5..bc5d394 100644 --- a/src/superio/common/ssdt.c +++ b/src/superio/common/ssdt.c @@ -200,7 +200,24 @@ acpigen_write_name_byte("LDN", ldn); acpigen_write_name_byte("VLDN", vldn); - acpigen_write_STA(dev->enabled ? 0xf : 0); + acpigen_write_method("_STA", 0); + { + acpigen_write_store(); + acpigen_emit_namestring("^^QLDN"); + acpigen_write_integer(ldn); + acpigen_emit_byte(LOCAL0_OP); + + /* Multiply (Local0, 0xf, Local0) */ + acpigen_emit_byte(MULTIPLY_OP); + acpigen_emit_byte(LOCAL0_OP); + acpigen_write_integer(0xf); + acpigen_emit_byte(LOCAL0_OP); + + acpigen_emit_byte(RETURN_OP); + acpigen_emit_byte(LOCAL0_OP); + + } + acpigen_pop_len(); /* Method */ if (!dev->enabled) { acpigen_pop_len(); /* Device */ @@ -242,6 +259,13 @@ acpigen_write_name_string("_HID", hid); acpigen_write_name_string("_DDN", name_from_hid(hid)); + acpigen_write_method("_DIS", 0); + { + acpigen_emit_namestring("^^DLDN"); + acpigen_write_integer(ldn); + } + acpigen_pop_len(); /* Method */ + acpigen_pop_len(); /* Device */ acpigen_pop_len(); /* Scope */ } -- To view, visit https://review.coreboot.org/c/coreboot/+/37640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I520b29de925f368cd71ff8f1f58d2d57d72eff8d Gerrit-Change-Number: 37640 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

2 6

Change in coreboot[master]: superio/common/conf_mode: Add op to write SSDT
by Patrick Rudolph (Code Review) 22 Dec '19

22 Dec '19

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37639 ) Change subject: superio/common/conf_mode: Add op to write SSDT ...................................................................... superio/common/conf_mode: Add op to write SSDT Add functions to write ACPI SSDT code for entering and leaving the config mode. To be used by ACPI generators. Change-Id: I14b55b885f1c384536bafafed39ad399639868e4 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/device/pnp_device.c M src/include/device/pnp.h M src/superio/common/conf_mode.c 3 files changed, 153 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/37639/1 diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index 28a45d0..4216a0d 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -32,6 +32,17 @@ dev->ops->ops_pnp_mode->exit_conf_mode(dev); } +void pnp_ssdt_enter_conf_mode(struct device *dev, const char *idx, const char *data) +{ + if (dev->ops->ops_pnp_mode && dev->ops->ops_pnp_mode->ssdt_enter_conf_mode) + dev->ops->ops_pnp_mode->ssdt_enter_conf_mode(dev, idx, data); +} +void pnp_ssdt_exit_conf_mode(struct device *dev, const char *idx, const char *data) +{ + if (dev->ops->ops_pnp_mode && dev->ops->ops_pnp_mode->ssdt_exit_conf_mode) + dev->ops->ops_pnp_mode->ssdt_exit_conf_mode(dev, idx, data); +} + /* PNP fundamental operations */ void pnp_write_config(struct device *dev, u8 reg, u8 value) diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h index 69a06674..29e6195 100644 --- a/src/include/device/pnp.h +++ b/src/include/device/pnp.h @@ -66,12 +66,17 @@ void pnp_enable_devices(struct device *dev, struct device_operations *ops, unsigned int functions, struct pnp_info *info); + struct pnp_mode_ops { void (*enter_conf_mode)(struct device *dev); void (*exit_conf_mode)(struct device *dev); + void (*ssdt_enter_conf_mode)(struct device *dev, const char *idx, const char *data); + void (*ssdt_exit_conf_mode)(struct device *dev, const char *idx, const char *data); }; void pnp_enter_conf_mode(struct device *dev); void pnp_exit_conf_mode(struct device *dev); +void pnp_ssdt_enter_conf_mode(struct device *dev, const char *idx, const char *data); +void pnp_ssdt_exit_conf_mode(struct device *dev, const char *idx, const char *data); /* PNP indexed I/O operations */ diff --git a/src/superio/common/conf_mode.c b/src/superio/common/conf_mode.c index 8ba1cdd..ad69d22 100644 --- a/src/superio/common/conf_mode.c +++ b/src/superio/common/conf_mode.c @@ -17,6 +17,7 @@ #include <arch/io.h> #include <device/device.h> #include <superio/conf_mode.h> +#include <arch/acpigen.h> /* Common enter/exit implementations */ @@ -77,38 +78,174 @@ pnp_write_config(dev, 0x02, (1 << 1)); } +/* Functions for ACPI */ +#if CONFIG(HAVE_ACPI_TABLES) +static void pnp_ssdt_enter_conf_mode_55(struct device *dev, const char *idx, const char *data) +{ + acpigen_write_store(); + acpigen_write_byte(0x55); + acpigen_emit_namestring(idx); + +} + +static void pnp_ssdt_enter_conf_mode_6767(struct device *dev, const char *idx, const char *data) +{ + acpigen_write_store(); + acpigen_write_byte(0x67); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + acpigen_write_byte(0x67); + acpigen_emit_namestring(idx); +} + +static void pnp_ssdt_enter_conf_mode_7777(struct device *dev, const char *idx, const char *data) +{ + acpigen_write_store(); + acpigen_write_byte(0x77); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + acpigen_write_byte(0x77); + acpigen_emit_namestring(idx); +} + +static void pnp_ssdt_enter_conf_mode_8787(struct device *dev, const char *idx, const char *data) +{ + acpigen_write_store(); + acpigen_write_byte(0x87); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + acpigen_write_byte(0x87); + acpigen_emit_namestring(idx); +} + +static void pnp_ssdt_enter_conf_mode_a0a0(struct device *dev, const char *idx, const char *data) +{ + acpigen_write_store(); + acpigen_write_byte(0xa0); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + acpigen_write_byte(0xa0); + acpigen_emit_namestring(idx); + +} + +static void pnp_ssdt_enter_conf_mode_a5a5(struct device *dev, const char *idx, const char *data) +{ + acpigen_write_store(); + acpigen_write_byte(0xa5); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + acpigen_write_byte(0xa5); + acpigen_emit_namestring(idx); +} + +static void pnp_ssdt_enter_conf_mode_870155aa(struct device *dev, + const char *idx, const char *data) +{ + acpigen_write_store(); + acpigen_write_byte(0x87); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + acpigen_write_byte(0x01); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + acpigen_write_byte(0x55); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + if (dev->path.pnp.port == 0x4e) + acpigen_write_byte(0xaa); + else + acpigen_write_byte(0x55); + acpigen_emit_namestring(idx); +} + +static void pnp_ssdt_exit_conf_mode_aa(struct device *dev, const char *idx, const char *data) +{ + acpigen_write_store(); + acpigen_write_byte(0xaa); + acpigen_emit_namestring(idx); +} + +static void pnp_ssdt_exit_conf_mode_0202(struct device *dev, const char *idx, const char *data) +{ + + acpigen_write_store(); + acpigen_write_byte(2); + acpigen_emit_namestring(idx); + + acpigen_write_store(); + acpigen_write_byte(2); + acpigen_emit_namestring(data); +} +#endif const struct pnp_mode_ops pnp_conf_mode_55_aa = { .enter_conf_mode = pnp_enter_conf_mode_55, .exit_conf_mode = pnp_exit_conf_mode_aa, +#if CONFIG(HAVE_ACPI_TABLES) + .ssdt_enter_conf_mode = pnp_ssdt_enter_conf_mode_55, + .ssdt_exit_conf_mode = pnp_ssdt_exit_conf_mode_aa, +#endif }; const struct pnp_mode_ops pnp_conf_mode_6767_aa = { .enter_conf_mode = pnp_enter_conf_mode_6767, .exit_conf_mode = pnp_exit_conf_mode_aa, +#if CONFIG(HAVE_ACPI_TABLES) + .ssdt_enter_conf_mode = pnp_ssdt_enter_conf_mode_6767, + .ssdt_exit_conf_mode = pnp_ssdt_exit_conf_mode_aa, +#endif }; const struct pnp_mode_ops pnp_conf_mode_7777_aa = { .enter_conf_mode = pnp_enter_conf_mode_7777, .exit_conf_mode = pnp_exit_conf_mode_aa, +#if CONFIG(HAVE_ACPI_TABLES) + .ssdt_enter_conf_mode = pnp_ssdt_enter_conf_mode_7777, + .ssdt_exit_conf_mode = pnp_ssdt_exit_conf_mode_aa, +#endif }; const struct pnp_mode_ops pnp_conf_mode_8787_aa = { .enter_conf_mode = pnp_enter_conf_mode_8787, .exit_conf_mode = pnp_exit_conf_mode_aa, +#if CONFIG(HAVE_ACPI_TABLES) + .ssdt_enter_conf_mode = pnp_ssdt_enter_conf_mode_8787, + .ssdt_exit_conf_mode = pnp_ssdt_exit_conf_mode_aa, +#endif }; const struct pnp_mode_ops pnp_conf_mode_a0a0_aa = { .enter_conf_mode = pnp_enter_conf_mode_a0a0, .exit_conf_mode = pnp_exit_conf_mode_aa, +#if CONFIG(HAVE_ACPI_TABLES) + .ssdt_enter_conf_mode = pnp_ssdt_enter_conf_mode_a0a0, + .ssdt_exit_conf_mode = pnp_ssdt_exit_conf_mode_aa, +#endif }; const struct pnp_mode_ops pnp_conf_mode_a5a5_aa = { .enter_conf_mode = pnp_enter_conf_mode_a5a5, .exit_conf_mode = pnp_exit_conf_mode_aa, +#if CONFIG(HAVE_ACPI_TABLES) + .ssdt_enter_conf_mode = pnp_ssdt_enter_conf_mode_a5a5, + .ssdt_exit_conf_mode = pnp_ssdt_exit_conf_mode_aa, +#endif }; const struct pnp_mode_ops pnp_conf_mode_870155_aa = { .enter_conf_mode = pnp_enter_conf_mode_870155aa, .exit_conf_mode = pnp_exit_conf_mode_0202, +#if CONFIG(HAVE_ACPI_TABLES) + .ssdt_enter_conf_mode = pnp_ssdt_enter_conf_mode_870155aa, + .ssdt_exit_conf_mode = pnp_ssdt_exit_conf_mode_0202, +#endif }; -- To view, visit https://review.coreboot.org/c/coreboot/+/37639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14b55b885f1c384536bafafed39ad399639868e4 Gerrit-Change-Number: 37639 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

2 6

Change in coreboot[master]: mb/ibase/mb899: Remove defined and unused SERIAL_DEV
by HAOUAS Elyes (Code Review) 22 Dec '19

22 Dec '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37581 ) Change subject: mb/ibase/mb899: Remove defined and unused SERIAL_DEV ...................................................................... mb/ibase/mb899: Remove defined and unused SERIAL_DEV Change-Id: Ib1976e1cb18481e79901f844788912edee6d3fc7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/ibase/mb899/early_init.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/37581/1 diff --git a/src/mainboard/ibase/mb899/early_init.c b/src/mainboard/ibase/mb899/early_init.c index 0b00502..e99fd08 100644 --- a/src/mainboard/ibase/mb899/early_init.c +++ b/src/mainboard/ibase/mb899/early_init.c @@ -23,7 +23,6 @@ #include <superio/winbond/common/winbond.h> #include <superio/winbond/w83627ehg/w83627ehg.h> -#define SERIAL_DEV PNP_DEV(0x4e, W83627EHG_SP1) #define SUPERIO_DEV PNP_DEV(0x4e, 0) /* This box has one superio -- To view, visit https://review.coreboot.org/c/coreboot/+/37581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1976e1cb18481e79901f844788912edee6d3fc7 Gerrit-Change-Number: 37581 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 2

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Pavel Kovalenko (Code Review) 22 Dec '19

22 Dec '19

Pavel Kovalenko has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 9: > Thanks for the explanation. Now I understand also the bug which I have with the display. > My lid does not trigger suspend (I configured it this way). So when my lid is closed, the EN line must be low, but the display is on full brightness. I will try to desolder the sense pin. > > @nitrocaster I could imagine the firmware of the STM8 is not much. Do you thought about open sourcing it? There's also a compatibility mode which should disable any 'smart' logic inside STM8, making it a dumb translator. You can activate it by shorting OPT1 and OPT2 pads as shown here: https://nitrocaster.me/files/compat_mode.png The firmware I would be happy to make public too, but it looks so disgusting that I don't feel comfortable sharing it right now. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 9 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: Kilian Neuner <cb(a)9-r.net> Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-Comment-Date: Sun, 22 Dec 2019 10:56:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/drivers/i2c: add i2c driver for Realtek 1308
by Jairaj Arava (Code Review) 21 Dec '19

21 Dec '19

Jairaj Arava has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37882 ) Change subject: src/drivers/i2c: add i2c driver for Realtek 1308 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/37882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie44fc8199f2153e18537023dfd92e0ce6a3ecb9c Gerrit-Change-Number: 37882 Gerrit-PatchSet: 2 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Comment-Date: Sat, 21 Dec 2019 14:13:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/**/dsdt.asl: Remove "Some generic macros" comment
by Angel Pons (Code Review) 21 Dec '19

21 Dec '19

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37856 ) Change subject: mb/**/dsdt.asl: Remove "Some generic macros" comment ...................................................................... mb/**/dsdt.asl: Remove "Some generic macros" comment It provides no useful information, so it might as well vanish. Change-Id: I0df6f4639a16058486c2e2d40fe4067d65670731 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/apple/macbook21/dsdt.asl M src/mainboard/apple/macbookair4_2/dsdt.asl M src/mainboard/asrock/b75pro3-m/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/p5gc-mx/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl M src/mainboard/compulab/intense_pc/dsdt.asl M src/mainboard/facebook/fbg1701/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/getac/p470/dsdt.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl M src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/beltino/dsdt.asl M src/mainboard/google/butterfly/dsdt.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/google/dragonegg/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/google/link/dsdt.asl M src/mainboard/google/parrot/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/slippy/dsdt.asl M src/mainboard/google/stout/dsdt.asl M src/mainboard/hp/2570p/dsdt.asl M src/mainboard/hp/2760p/dsdt.asl M src/mainboard/hp/8460p/dsdt.asl M src/mainboard/hp/8470p/dsdt.asl M src/mainboard/hp/8770w/dsdt.asl M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl M src/mainboard/hp/folio_9470m/dsdt.asl M src/mainboard/hp/revolve_810_g1/dsdt.asl M src/mainboard/hp/z220_sff_workstation/dsdt.asl M src/mainboard/ibase/mb899/dsdt.asl M src/mainboard/intel/baskingridge/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/d945gclf/dsdt.asl M src/mainboard/intel/dcp847ske/dsdt.asl M src/mainboard/intel/emeraldlake2/dsdt.asl M src/mainboard/intel/harcuvar/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/kontron/986lcd-m/dsdt.asl M src/mainboard/kontron/ktqm77/dsdt.asl M src/mainboard/lenovo/l520/dsdt.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/x131e/dsdt.asl M src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl M src/mainboard/lenovo/x60/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/packardbell/ms2290/dsdt.asl M src/mainboard/portwell/m107/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/roda/rk886ex/dsdt.asl M src/mainboard/roda/rk9/dsdt.asl M src/mainboard/roda/rv11/dsdt.asl M src/mainboard/samsung/lumpy/dsdt.asl M src/mainboard/samsung/stumpy/dsdt.asl M src/mainboard/sapphire/pureplatinumh61/dsdt.asl M src/mainboard/scaleway/tagada/dsdt.asl M src/mainboard/siemens/mc_apl1/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl 86 files changed, 1 insertion(+), 86 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/37856/1 diff --git a/src/mainboard/apple/macbook21/dsdt.asl b/src/mainboard/apple/macbook21/dsdt.asl index 40af217..7968c6e 100644 --- a/src/mainboard/apple/macbook21/dsdt.asl +++ b/src/mainboard/apple/macbook21/dsdt.asl @@ -28,7 +28,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/apple/macbookair4_2/dsdt.asl b/src/mainboard/apple/macbookair4_2/dsdt.asl index 91e0b20..f48d0dd 100644 --- a/src/mainboard/apple/macbookair4_2/dsdt.asl +++ b/src/mainboard/apple/macbookair4_2/dsdt.asl @@ -24,7 +24,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/asrock/b75pro3-m/dsdt.asl b/src/mainboard/asrock/b75pro3-m/dsdt.asl index e1b28db..86b29d6 100644 --- a/src/mainboard/asrock/b75pro3-m/dsdt.asl +++ b/src/mainboard/asrock/b75pro3-m/dsdt.asl @@ -27,7 +27,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/asus/h61m-cs/dsdt.asl b/src/mainboard/asus/h61m-cs/dsdt.asl index dc7a367..8a052a3 100644 --- a/src/mainboard/asus/h61m-cs/dsdt.asl +++ b/src/mainboard/asus/h61m-cs/dsdt.asl @@ -24,7 +24,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/asus/p5gc-mx/dsdt.asl b/src/mainboard/asus/p5gc-mx/dsdt.asl index 66f0efe..1c360f9 100644 --- a/src/mainboard/asus/p5gc-mx/dsdt.asl +++ b/src/mainboard/asus/p5gc-mx/dsdt.asl @@ -23,7 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros /* #include "acpi/platform.asl" */ // global NVS and variables diff --git a/src/mainboard/asus/p8h61-m_pro/dsdt.asl b/src/mainboard/asus/p8h61-m_pro/dsdt.asl index c2b46f3..e8ff311 100644 --- a/src/mainboard/asus/p8h61-m_pro/dsdt.asl +++ b/src/mainboard/asus/p8h61-m_pro/dsdt.asl @@ -24,7 +24,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include "acpi/superio.asl" #include <cpu/intel/common/acpi/cpu.asl> diff --git a/src/mainboard/compulab/intense_pc/dsdt.asl b/src/mainboard/compulab/intense_pc/dsdt.asl index 4e43516..f769a0f 100644 --- a/src/mainboard/compulab/intense_pc/dsdt.asl +++ b/src/mainboard/compulab/intense_pc/dsdt.asl @@ -27,7 +27,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/facebook/fbg1701/dsdt.asl b/src/mainboard/facebook/fbg1701/dsdt.asl index 518e249..9b4dc81 100644 --- a/src/mainboard/facebook/fbg1701/dsdt.asl +++ b/src/mainboard/facebook/fbg1701/dsdt.asl @@ -29,7 +29,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/facebook/monolith/dsdt.asl b/src/mainboard/facebook/monolith/dsdt.asl index 2f00110..8fea1d5 100644 --- a/src/mainboard/facebook/monolith/dsdt.asl +++ b/src/mainboard/facebook/monolith/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/skylake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/getac/p470/dsdt.asl b/src/mainboard/getac/p470/dsdt.asl index 4e75968..9be21ad 100644 --- a/src/mainboard/getac/p470/dsdt.asl +++ b/src/mainboard/getac/p470/dsdt.asl @@ -29,7 +29,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl index afc5386..7d0ffe0 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl @@ -23,7 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl b/src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl index 8b81ebf..47b2725 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl +++ b/src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl @@ -23,7 +23,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/mainboard.asl" #include "acpi/platform.asl" #include "acpi/thermal.asl" diff --git a/src/mainboard/google/auron/dsdt.asl b/src/mainboard/google/auron/dsdt.asl index 9a5dcc7..b463214 100644 --- a/src/mainboard/google/auron/dsdt.asl +++ b/src/mainboard/google/auron/dsdt.asl @@ -24,7 +24,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/broadwell/acpi/platform.asl> // Thermal handler diff --git a/src/mainboard/google/beltino/dsdt.asl b/src/mainboard/google/beltino/dsdt.asl index 7b369d8..447ea02 100644 --- a/src/mainboard/google/beltino/dsdt.asl +++ b/src/mainboard/google/beltino/dsdt.asl @@ -24,7 +24,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // Thermal handler diff --git a/src/mainboard/google/butterfly/dsdt.asl b/src/mainboard/google/butterfly/dsdt.asl index 8a9d71b..ad9b77b 100644 --- a/src/mainboard/google/butterfly/dsdt.asl +++ b/src/mainboard/google/butterfly/dsdt.asl @@ -26,7 +26,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" #include "acpi/mainboard.asl" diff --git a/src/mainboard/google/cyan/dsdt.asl b/src/mainboard/google/cyan/dsdt.asl index 7aa62f8..53a92e0 100644 --- a/src/mainboard/google/cyan/dsdt.asl +++ b/src/mainboard/google/cyan/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/google/dragonegg/dsdt.asl b/src/mainboard/google/dragonegg/dsdt.asl index 4318dc3..cb2ce64 100644 --- a/src/mainboard/google/dragonegg/dsdt.asl +++ b/src/mainboard/google/dragonegg/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/icelake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/google/drallion/dsdt.asl b/src/mainboard/google/drallion/dsdt.asl index 0a092cf..92470a9 100644 --- a/src/mainboard/google/drallion/dsdt.asl +++ b/src/mainboard/google/drallion/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/cannonlake/acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/google/eve/dsdt.asl b/src/mainboard/google/eve/dsdt.asl index 3e9d570..90463c8 100644 --- a/src/mainboard/google/eve/dsdt.asl +++ b/src/mainboard/google/eve/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - /* Some generic macros */ #include <soc/intel/skylake/acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/google/fizz/dsdt.asl b/src/mainboard/google/fizz/dsdt.asl index 44d544c..613fe31 100644 --- a/src/mainboard/google/fizz/dsdt.asl +++ b/src/mainboard/google/fizz/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - /* Some generic macros */ #include <soc/intel/skylake/acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/google/glados/dsdt.asl b/src/mainboard/google/glados/dsdt.asl index 6dab56e..06209e4 100644 --- a/src/mainboard/google/glados/dsdt.asl +++ b/src/mainboard/google/glados/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/skylake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/google/hatch/dsdt.asl b/src/mainboard/google/hatch/dsdt.asl index 6247829..1e7f760 100644 --- a/src/mainboard/google/hatch/dsdt.asl +++ b/src/mainboard/google/hatch/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/cannonlake/acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/google/jecht/dsdt.asl b/src/mainboard/google/jecht/dsdt.asl index fb8abe7..1cd2bd3 100644 --- a/src/mainboard/google/jecht/dsdt.asl +++ b/src/mainboard/google/jecht/dsdt.asl @@ -24,7 +24,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <southbridge/intel/common/acpi/platform.asl> #include "acpi/platform.asl" diff --git a/src/mainboard/google/link/dsdt.asl b/src/mainboard/google/link/dsdt.asl index 4c23e7d..b396319 100644 --- a/src/mainboard/google/link/dsdt.asl +++ b/src/mainboard/google/link/dsdt.asl @@ -26,7 +26,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" #include "acpi/mainboard.asl" diff --git a/src/mainboard/google/parrot/dsdt.asl b/src/mainboard/google/parrot/dsdt.asl index 0465ced..a762326 100644 --- a/src/mainboard/google/parrot/dsdt.asl +++ b/src/mainboard/google/parrot/dsdt.asl @@ -26,7 +26,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // Thermal handler diff --git a/src/mainboard/google/poppy/dsdt.asl b/src/mainboard/google/poppy/dsdt.asl index 7e0eb9a..ce2f8fc 100644 --- a/src/mainboard/google/poppy/dsdt.asl +++ b/src/mainboard/google/poppy/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - /* Some generic macros */ #include <soc/intel/skylake/acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/google/rambi/dsdt.asl b/src/mainboard/google/rambi/dsdt.asl index 2393830..ed57e43 100644 --- a/src/mainboard/google/rambi/dsdt.asl +++ b/src/mainboard/google/rambi/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/baytrail/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/google/sarien/dsdt.asl b/src/mainboard/google/sarien/dsdt.asl index 9a5c787..99a8627 100644 --- a/src/mainboard/google/sarien/dsdt.asl +++ b/src/mainboard/google/sarien/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/cannonlake/acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/google/slippy/dsdt.asl b/src/mainboard/google/slippy/dsdt.asl index 6c45ea9..9881a5f 100644 --- a/src/mainboard/google/slippy/dsdt.asl +++ b/src/mainboard/google/slippy/dsdt.asl @@ -24,7 +24,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // Thermal handler diff --git a/src/mainboard/google/stout/dsdt.asl b/src/mainboard/google/stout/dsdt.asl index 580ca16..a62fed2 100644 --- a/src/mainboard/google/stout/dsdt.asl +++ b/src/mainboard/google/stout/dsdt.asl @@ -27,7 +27,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" #include "acpi/mainboard.asl" diff --git a/src/mainboard/hp/2570p/dsdt.asl b/src/mainboard/hp/2570p/dsdt.asl index 5730ea0..81f45c1 100644 --- a/src/mainboard/hp/2570p/dsdt.asl +++ b/src/mainboard/hp/2570p/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/hp/2760p/dsdt.asl b/src/mainboard/hp/2760p/dsdt.asl index 5730ea0..81f45c1 100644 --- a/src/mainboard/hp/2760p/dsdt.asl +++ b/src/mainboard/hp/2760p/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/hp/8460p/dsdt.asl b/src/mainboard/hp/8460p/dsdt.asl index 5730ea0..81f45c1 100644 --- a/src/mainboard/hp/8460p/dsdt.asl +++ b/src/mainboard/hp/8460p/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/hp/8470p/dsdt.asl b/src/mainboard/hp/8470p/dsdt.asl index 5730ea0..81f45c1 100644 --- a/src/mainboard/hp/8470p/dsdt.asl +++ b/src/mainboard/hp/8470p/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/hp/8770w/dsdt.asl b/src/mainboard/hp/8770w/dsdt.asl index 5730ea0..81f45c1 100644 --- a/src/mainboard/hp/8770w/dsdt.asl +++ b/src/mainboard/hp/8770w/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl b/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl index 3f249e3..9bb9614 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl +++ b/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/hp/folio_9470m/dsdt.asl b/src/mainboard/hp/folio_9470m/dsdt.asl index 5730ea0..81f45c1 100644 --- a/src/mainboard/hp/folio_9470m/dsdt.asl +++ b/src/mainboard/hp/folio_9470m/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/hp/revolve_810_g1/dsdt.asl b/src/mainboard/hp/revolve_810_g1/dsdt.asl index 5730ea0..81f45c1 100644 --- a/src/mainboard/hp/revolve_810_g1/dsdt.asl +++ b/src/mainboard/hp/revolve_810_g1/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/hp/z220_sff_workstation/dsdt.asl b/src/mainboard/hp/z220_sff_workstation/dsdt.asl index 3f249e3..9bb9614 100644 --- a/src/mainboard/hp/z220_sff_workstation/dsdt.asl +++ b/src/mainboard/hp/z220_sff_workstation/dsdt.asl @@ -26,7 +26,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/ibase/mb899/dsdt.asl b/src/mainboard/ibase/mb899/dsdt.asl index 31b67a7..45cc48f 100644 --- a/src/mainboard/ibase/mb899/dsdt.asl +++ b/src/mainboard/ibase/mb899/dsdt.asl @@ -23,7 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/intel/baskingridge/dsdt.asl b/src/mainboard/intel/baskingridge/dsdt.asl index 28d743e..066160d 100644 --- a/src/mainboard/intel/baskingridge/dsdt.asl +++ b/src/mainboard/intel/baskingridge/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/intel/cannonlake_rvp/dsdt.asl b/src/mainboard/intel/cannonlake_rvp/dsdt.asl index 9a519c0..4fe13d4 100644 --- a/src/mainboard/intel/cannonlake_rvp/dsdt.asl +++ b/src/mainboard/intel/cannonlake_rvp/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/cannonlake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/intel/coffeelake_rvp/dsdt.asl b/src/mainboard/intel/coffeelake_rvp/dsdt.asl index 1d7216a..10418c3 100644 --- a/src/mainboard/intel/coffeelake_rvp/dsdt.asl +++ b/src/mainboard/intel/coffeelake_rvp/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/cannonlake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/intel/d945gclf/dsdt.asl b/src/mainboard/intel/d945gclf/dsdt.asl index afc5386..7d0ffe0 100644 --- a/src/mainboard/intel/d945gclf/dsdt.asl +++ b/src/mainboard/intel/d945gclf/dsdt.asl @@ -23,7 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/intel/dcp847ske/dsdt.asl b/src/mainboard/intel/dcp847ske/dsdt.asl index 39e7008..3ef27eb 100644 --- a/src/mainboard/intel/dcp847ske/dsdt.asl +++ b/src/mainboard/intel/dcp847ske/dsdt.asl @@ -24,7 +24,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/intel/emeraldlake2/dsdt.asl b/src/mainboard/intel/emeraldlake2/dsdt.asl index 74268ef..a27f212 100644 --- a/src/mainboard/intel/emeraldlake2/dsdt.asl +++ b/src/mainboard/intel/emeraldlake2/dsdt.asl @@ -26,7 +26,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // Thermal handler diff --git a/src/mainboard/intel/harcuvar/dsdt.asl b/src/mainboard/intel/harcuvar/dsdt.asl index c7e7f7c..bd32687 100644 --- a/src/mainboard/intel/harcuvar/dsdt.asl +++ b/src/mainboard/intel/harcuvar/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <southbridge/intel/common/acpi/platform.asl> #include "acpi/platform.asl" #include "acpi/mainboard.asl" diff --git a/src/mainboard/intel/icelake_rvp/dsdt.asl b/src/mainboard/intel/icelake_rvp/dsdt.asl index f8fcd4d..3fd6fca 100644 --- a/src/mainboard/intel/icelake_rvp/dsdt.asl +++ b/src/mainboard/intel/icelake_rvp/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/icelake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/intel/kblrvp/dsdt.asl b/src/mainboard/intel/kblrvp/dsdt.asl index 059bcd5..84872cb 100644 --- a/src/mainboard/intel/kblrvp/dsdt.asl +++ b/src/mainboard/intel/kblrvp/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/skylake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/intel/kunimitsu/dsdt.asl b/src/mainboard/intel/kunimitsu/dsdt.asl index 6dab56e..06209e4 100644 --- a/src/mainboard/intel/kunimitsu/dsdt.asl +++ b/src/mainboard/intel/kunimitsu/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/skylake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/intel/saddlebrook/dsdt.asl b/src/mainboard/intel/saddlebrook/dsdt.asl index 86ea299..b88b1d2 100644 --- a/src/mainboard/intel/saddlebrook/dsdt.asl +++ b/src/mainboard/intel/saddlebrook/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/skylake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/intel/strago/dsdt.asl b/src/mainboard/intel/strago/dsdt.asl index e89b887..7bbe1e4 100644 --- a/src/mainboard/intel/strago/dsdt.asl +++ b/src/mainboard/intel/strago/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/intel/wtm2/dsdt.asl b/src/mainboard/intel/wtm2/dsdt.asl index d3febf5..7245983 100644 --- a/src/mainboard/intel/wtm2/dsdt.asl +++ b/src/mainboard/intel/wtm2/dsdt.asl @@ -27,7 +27,7 @@ ) { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros + #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/kontron/986lcd-m/dsdt.asl b/src/mainboard/kontron/986lcd-m/dsdt.asl index d4ffd7b..a6ae284 100644 --- a/src/mainboard/kontron/986lcd-m/dsdt.asl +++ b/src/mainboard/kontron/986lcd-m/dsdt.asl @@ -23,7 +23,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/kontron/ktqm77/dsdt.asl b/src/mainboard/kontron/ktqm77/dsdt.asl index 2d6ce79..da533b7 100644 --- a/src/mainboard/kontron/ktqm77/dsdt.asl +++ b/src/mainboard/kontron/ktqm77/dsdt.asl @@ -26,7 +26,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" #include "acpi/mainboard.asl" diff --git a/src/mainboard/lenovo/l520/dsdt.asl b/src/mainboard/lenovo/l520/dsdt.asl index 8b2c3e6..4fefb5e 100644 --- a/src/mainboard/lenovo/l520/dsdt.asl +++ b/src/mainboard/lenovo/l520/dsdt.asl @@ -27,7 +27,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/lenovo/t400/dsdt.asl b/src/mainboard/lenovo/t400/dsdt.asl index eb9c2ad..c3c7dda 100644 --- a/src/mainboard/lenovo/t400/dsdt.asl +++ b/src/mainboard/lenovo/t400/dsdt.asl @@ -30,7 +30,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/t410/dsdt.asl b/src/mainboard/lenovo/t410/dsdt.asl index 9d0204e..bf00489 100644 --- a/src/mainboard/lenovo/t410/dsdt.asl +++ b/src/mainboard/lenovo/t410/dsdt.asl @@ -32,7 +32,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - /* Some generic macros */ #include "acpi/platform.asl" /* global NVS and variables */ diff --git a/src/mainboard/lenovo/t420/dsdt.asl b/src/mainboard/lenovo/t420/dsdt.asl index a6a57e2..b841817 100644 --- a/src/mainboard/lenovo/t420/dsdt.asl +++ b/src/mainboard/lenovo/t420/dsdt.asl @@ -33,7 +33,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/t420s/dsdt.asl b/src/mainboard/lenovo/t420s/dsdt.asl index a6a57e2..b841817 100644 --- a/src/mainboard/lenovo/t420s/dsdt.asl +++ b/src/mainboard/lenovo/t420s/dsdt.asl @@ -33,7 +33,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/t430/dsdt.asl b/src/mainboard/lenovo/t430/dsdt.asl index 55781d6..68f91e9 100644 --- a/src/mainboard/lenovo/t430/dsdt.asl +++ b/src/mainboard/lenovo/t430/dsdt.asl @@ -31,7 +31,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/lenovo/t430s/dsdt.asl b/src/mainboard/lenovo/t430s/dsdt.asl index a6a57e2..b841817 100644 --- a/src/mainboard/lenovo/t430s/dsdt.asl +++ b/src/mainboard/lenovo/t430s/dsdt.asl @@ -33,7 +33,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/t520/dsdt.asl b/src/mainboard/lenovo/t520/dsdt.asl index a6a57e2..b841817 100644 --- a/src/mainboard/lenovo/t520/dsdt.asl +++ b/src/mainboard/lenovo/t520/dsdt.asl @@ -33,7 +33,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/t530/dsdt.asl b/src/mainboard/lenovo/t530/dsdt.asl index a6a57e2..b841817 100644 --- a/src/mainboard/lenovo/t530/dsdt.asl +++ b/src/mainboard/lenovo/t530/dsdt.asl @@ -33,7 +33,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl index 1292321..1374216 100644 --- a/src/mainboard/lenovo/t60/dsdt.asl +++ b/src/mainboard/lenovo/t60/dsdt.asl @@ -29,7 +29,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/x131e/dsdt.asl b/src/mainboard/lenovo/x131e/dsdt.asl index 95eb2db..842afff 100644 --- a/src/mainboard/lenovo/x131e/dsdt.asl +++ b/src/mainboard/lenovo/x131e/dsdt.asl @@ -32,7 +32,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl b/src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl index 3acc87d..96f7e35 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl +++ b/src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl @@ -33,7 +33,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/x200/dsdt.asl b/src/mainboard/lenovo/x200/dsdt.asl index e300234..9052a8f 100644 --- a/src/mainboard/lenovo/x200/dsdt.asl +++ b/src/mainboard/lenovo/x200/dsdt.asl @@ -29,7 +29,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/x201/dsdt.asl b/src/mainboard/lenovo/x201/dsdt.asl index 9d0204e..bf00489 100644 --- a/src/mainboard/lenovo/x201/dsdt.asl +++ b/src/mainboard/lenovo/x201/dsdt.asl @@ -32,7 +32,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - /* Some generic macros */ #include "acpi/platform.asl" /* global NVS and variables */ diff --git a/src/mainboard/lenovo/x220/dsdt.asl b/src/mainboard/lenovo/x220/dsdt.asl index a6a57e2..b841817 100644 --- a/src/mainboard/lenovo/x220/dsdt.asl +++ b/src/mainboard/lenovo/x220/dsdt.asl @@ -33,7 +33,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/x230/dsdt.asl b/src/mainboard/lenovo/x230/dsdt.asl index a6a57e2..b841817 100644 --- a/src/mainboard/lenovo/x230/dsdt.asl +++ b/src/mainboard/lenovo/x230/dsdt.asl @@ -33,7 +33,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/lenovo/x60/dsdt.asl b/src/mainboard/lenovo/x60/dsdt.asl index 00430bb..6f01f60 100644 --- a/src/mainboard/lenovo/x60/dsdt.asl +++ b/src/mainboard/lenovo/x60/dsdt.asl @@ -29,7 +29,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/msi/ms7707/dsdt.asl b/src/mainboard/msi/ms7707/dsdt.asl index 1aa87fe..553754d 100644 --- a/src/mainboard/msi/ms7707/dsdt.asl +++ b/src/mainboard/msi/ms7707/dsdt.asl @@ -24,7 +24,6 @@ 0x20141018 // OEM revision ) { - /* Some generic macros */ #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/packardbell/ms2290/dsdt.asl b/src/mainboard/packardbell/ms2290/dsdt.asl index 72b7d4c..cbfd3a7 100644 --- a/src/mainboard/packardbell/ms2290/dsdt.asl +++ b/src/mainboard/packardbell/ms2290/dsdt.asl @@ -26,7 +26,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - /* Some generic macros */ #include "acpi/platform.asl" /* global NVS and variables */ diff --git a/src/mainboard/portwell/m107/dsdt.asl b/src/mainboard/portwell/m107/dsdt.asl index 518e249..9b4dc81 100644 --- a/src/mainboard/portwell/m107/dsdt.asl +++ b/src/mainboard/portwell/m107/dsdt.asl @@ -29,7 +29,6 @@ 0x20110725 /* OEM revision */ ) { - /* Some generic macros */ #include <acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/purism/librem_bdw/dsdt.asl b/src/mainboard/purism/librem_bdw/dsdt.asl index 3cd4ef9..3a53a4d 100644 --- a/src/mainboard/purism/librem_bdw/dsdt.asl +++ b/src/mainboard/purism/librem_bdw/dsdt.asl @@ -23,7 +23,6 @@ 0x20160115 /* OEM revision */ ) { - /* Some generic macros */ #include <soc/intel/broadwell/acpi/platform.asl> /* Global NVS and variables */ diff --git a/src/mainboard/purism/librem_skl/dsdt.asl b/src/mainboard/purism/librem_skl/dsdt.asl index 1cd0531..b058204 100644 --- a/src/mainboard/purism/librem_skl/dsdt.asl +++ b/src/mainboard/purism/librem_skl/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/skylake/acpi/platform.asl> // global NVS and variables diff --git a/src/mainboard/roda/rk886ex/dsdt.asl b/src/mainboard/roda/rk886ex/dsdt.asl index f9a2abe..7011b44 100644 --- a/src/mainboard/roda/rk886ex/dsdt.asl +++ b/src/mainboard/roda/rk886ex/dsdt.asl @@ -24,7 +24,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/roda/rk9/dsdt.asl b/src/mainboard/roda/rk9/dsdt.asl index e8fb13d..0206926 100644 --- a/src/mainboard/roda/rk9/dsdt.asl +++ b/src/mainboard/roda/rk9/dsdt.asl @@ -24,7 +24,6 @@ 0x20090419 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" // global NVS and variables diff --git a/src/mainboard/roda/rv11/dsdt.asl b/src/mainboard/roda/rv11/dsdt.asl index 67f88d0..1784b54 100644 --- a/src/mainboard/roda/rv11/dsdt.asl +++ b/src/mainboard/roda/rv11/dsdt.asl @@ -25,7 +25,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" #include "acpi/mainboard.asl" diff --git a/src/mainboard/samsung/lumpy/dsdt.asl b/src/mainboard/samsung/lumpy/dsdt.asl index 7dd85b5..3ecabb5 100644 --- a/src/mainboard/samsung/lumpy/dsdt.asl +++ b/src/mainboard/samsung/lumpy/dsdt.asl @@ -26,7 +26,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" // Thermal handler diff --git a/src/mainboard/samsung/stumpy/dsdt.asl b/src/mainboard/samsung/stumpy/dsdt.asl index db8bfd4..9fc9e2f 100644 --- a/src/mainboard/samsung/stumpy/dsdt.asl +++ b/src/mainboard/samsung/stumpy/dsdt.asl @@ -26,7 +26,6 @@ { #include <southbridge/intel/common/acpi/platform.asl> - // Some generic macros #include "acpi/platform.asl" #include "acpi/mainboard.asl" diff --git a/src/mainboard/sapphire/pureplatinumh61/dsdt.asl b/src/mainboard/sapphire/pureplatinumh61/dsdt.asl index fee7e93..be30f63 100644 --- a/src/mainboard/sapphire/pureplatinumh61/dsdt.asl +++ b/src/mainboard/sapphire/pureplatinumh61/dsdt.asl @@ -27,7 +27,6 @@ 0x20141018 // OEM revision ) { - // Some generic macros #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> #include <southbridge/intel/common/acpi/platform.asl> diff --git a/src/mainboard/scaleway/tagada/dsdt.asl b/src/mainboard/scaleway/tagada/dsdt.asl index c7e7f7c..bd32687 100644 --- a/src/mainboard/scaleway/tagada/dsdt.asl +++ b/src/mainboard/scaleway/tagada/dsdt.asl @@ -26,7 +26,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <southbridge/intel/common/acpi/platform.asl> #include "acpi/platform.asl" #include "acpi/mainboard.asl" diff --git a/src/mainboard/siemens/mc_apl1/dsdt.asl b/src/mainboard/siemens/mc_apl1/dsdt.asl index 449bcf8..ae40f39 100644 --- a/src/mainboard/siemens/mc_apl1/dsdt.asl +++ b/src/mainboard/siemens/mc_apl1/dsdt.asl @@ -23,7 +23,6 @@ 0x20110725 // OEM revision ) { - /* generic macros */ #include <soc/intel/apollolake/acpi/platform.asl> /* global NVS and variables */ diff --git a/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl b/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl index 86ea299..b88b1d2 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl +++ b/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl @@ -25,7 +25,6 @@ 0x20110725 // OEM revision ) { - // Some generic macros #include <soc/intel/skylake/acpi/platform.asl> // global NVS and variables -- To view, visit https://review.coreboot.org/c/coreboot/+/37856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0df6f4639a16058486c2e2d40fe4067d65670731 Gerrit-Change-Number: 37856 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

5 4

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2019