Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 )
Change subject: arch/x86: Support x86_64 exceptions
......................................................................
Patch Set 28: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/30117
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48
Gerrit-Change-Number: 30117
Gerrit-PatchSet: 28
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 24 Dec 2019 09:09:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37923 )
Change subject: mb/google/octopus/variants/garg: update new SKU
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octop…
File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octop…
PS1, Line 30: SKU_38_2A2C_360_TS_no_stylues = 38,
> For naming convention, it looks to me we need capital letters here.
Done
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octop…
PS1, Line 31: };
> Could we move this enum definition to variant/sku.h? So it can be included by gpio.c and variant. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/37923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic74ce14db7060f3124c1a277eb3625ce0ff0b9f0
Gerrit-Change-Number: 37923
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Comment-Date: Tue, 24 Dec 2019 08:51:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen <marcochen(a)google.com>
Gerrit-MessageType: comment
Hello Karthik Ramasubramanian, Justin TerAvest, Marco Chen, Henry Sun,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37923
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants/garg: update new SKU
......................................................................
mb/google/octopus/variants/garg: update new SKU
add new SKU ID below:
19 - Garg PVT (HDMI DB, Touch)
20 - Garg PVT (2A2C DB, Touch)
38 - Garg360 EVT (2A2C DB, touch, no stylues, rear camera)
BUG=b:146260545
BRANCH=octopus
TEST=emerge-octopus coreboot chromeos-bootimage
Change-Id: Ic74ce14db7060f3124c1a277eb3625ce0ff0b9f0
Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
---
M src/mainboard/google/octopus/variants/garg/gpio.c
A src/mainboard/google/octopus/variants/garg/include/variant/sku.h
M src/mainboard/google/octopus/variants/garg/variant.c
3 files changed, 34 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/37923/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/37923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic74ce14db7060f3124c1a277eb3625ce0ff0b9f0
Gerrit-Change-Number: 37923
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-MessageType: newpatchset
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37907 )
Change subject: mainboard/google/hatch: Move da7219 drv into Kohaku
......................................................................
mainboard/google/hatch: Move da7219 drv into Kohaku
There is no need to declare this in the baseboard when only
one board uses this specific chip.
BUG=b:146519004
BRANCH=none
TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: I7d803b5cb53daea5bbd16818aaecaf8e0970c505
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/hatch/Kconfig.name
2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37907/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 992fa6c..ef96349 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -3,7 +3,6 @@
def_bool n
select DRIVERS_GENERIC_GPIO_KEYS
select DRIVERS_GENERIC_MAX98357A if !BOARD_GOOGLE_PUFF
- select DRIVERS_I2C_DA7219
select DRIVERS_I2C_GENERIC
select DRIVERS_I2C_HID
select DRIVERS_I2C_SX9310
diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name
index e216135..39b65a2 100644
--- a/src/mainboard/google/hatch/Kconfig.name
+++ b/src/mainboard/google/hatch/Kconfig.name
@@ -24,6 +24,7 @@
bool "-> Kohaku"
select BOARD_GOOGLE_BASEBOARD_HATCH
select BOARD_ROMSIZE_KB_16384
+ select DRIVERS_I2C_DA7219
config BOARD_GOOGLE_KINDRED
bool "-> Kindred"
--
To view, visit https://review.coreboot.org/c/coreboot/+/37907
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d803b5cb53daea5bbd16818aaecaf8e0970c505
Gerrit-Change-Number: 37907
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37822 )
Change subject: mainboard/google/puff: Don't en MAX98357A in dt
......................................................................
mainboard/google/puff: Don't en MAX98357A in dt
Puff doesn't have this packed. Don't enable MAX98357A in the devicetree
overrides so that the correct SSDT is generated.
BRANCH=none
BUG=b:146519004
TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: I8e437d9cd5c4bf66d39e290cc9153e08e32a3389
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M src/mainboard/google/hatch/variants/puff/overridetree.cb
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/37822/1
diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb
index d5e2e5a..1112495 100644
--- a/src/mainboard/google/hatch/variants/puff/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb
@@ -95,6 +95,7 @@
end
end #I2C #4
device pci 1e.3 off end # GSPI #1
+ device pci 1f.3 off end # no max98357a packed.
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/37822
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e437d9cd5c4bf66d39e290cc9153e08e32a3389
Gerrit-Change-Number: 37822
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
Hello Brandon Breitenstein, Raj Astekar, Srinidhi N Kaushik, Divya S Sasidharan, Wonkyu Kim, Ravishankar Sarawadi, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37867
to look at the new patch set (#2).
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC
......................................................................
src/ec/google/chromeec: Get Type-C Mux info from EC
BUG=None
BRANCH=None
TEST= Tested boots from USB-TypeC flash drive
on TGLRVP
Change-Id: I96bfb6036f4340ba42a078cfd7ecaae777a3ed00
Signed-off-by: Divya Sasidharan <divya.s.sasidharan(a)intel.com>
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
M src/ec/google/chromeec/ec_commands.h
3 files changed, 140 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/37867/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/37867
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96bfb6036f4340ba42a078cfd7ecaae777a3ed00
Gerrit-Change-Number: 37867
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Divya S Sasidharan <divya.s.sasidharan(a)intel.com>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37923 )
Change subject: mb/google/octopus/variants/garg: update new SKU
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octop…
File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octop…
PS1, Line 30: SKU_38_2A2C_360_TS_no_stylues = 38,
For naming convention, it looks to me we need capital letters here.
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octop…
PS1, Line 31: };
Could we move this enum definition to variant/sku.h? So it can be included by gpio.c and variant.c without double definition.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic74ce14db7060f3124c1a277eb3625ce0ff0b9f0
Gerrit-Change-Number: 37923
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Comment-Date: Tue, 24 Dec 2019 07:54:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37923 )
Change subject: mb/google/octopus/variants/garg: update new SKU
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/37923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic74ce14db7060f3124c1a277eb3625ce0ff0b9f0
Gerrit-Change-Number: 37923
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Comment-Date: Tue, 24 Dec 2019 05:31:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35429 )
Change subject: PDCurses: Remove unused code/directories
......................................................................
PDCurses: Remove unused code/directories
There are a number of directories that came in with pdcurses that we
don't need as a part of libpayload. Get rid of them.
Signed-off-by: Martin Roth <martin(a)coreboot.org>
Change-Id: I3b09104f64254d768d27a3d2e3fba8418e7ba2ca
---
D payloads/libpayload/curses/PDCurses/demos/README
D payloads/libpayload/curses/PDCurses/demos/firework.c
D payloads/libpayload/curses/PDCurses/demos/newdemo.c
D payloads/libpayload/curses/PDCurses/demos/ptest.c
D payloads/libpayload/curses/PDCurses/demos/rain.c
D payloads/libpayload/curses/PDCurses/demos/testcurs.c
D payloads/libpayload/curses/PDCurses/demos/tui.c
D payloads/libpayload/curses/PDCurses/demos/tui.h
D payloads/libpayload/curses/PDCurses/demos/tuidemo.c
D payloads/libpayload/curses/PDCurses/demos/worm.c
D payloads/libpayload/curses/PDCurses/demos/xmas.c
D payloads/libpayload/curses/PDCurses/dos/README
D payloads/libpayload/curses/PDCurses/dos/bccdos.lrf
D payloads/libpayload/curses/PDCurses/dos/bccdos.mak
D payloads/libpayload/curses/PDCurses/dos/gccdos.mak
D payloads/libpayload/curses/PDCurses/dos/mscdos.lrf
D payloads/libpayload/curses/PDCurses/dos/mscdos.mak
D payloads/libpayload/curses/PDCurses/dos/pdcclip.c
D payloads/libpayload/curses/PDCurses/dos/pdcdisp.c
D payloads/libpayload/curses/PDCurses/dos/pdcdos.h
D payloads/libpayload/curses/PDCurses/dos/pdcgetsc.c
D payloads/libpayload/curses/PDCurses/dos/pdckbd.c
D payloads/libpayload/curses/PDCurses/dos/pdcscrn.c
D payloads/libpayload/curses/PDCurses/dos/pdcsetsc.c
D payloads/libpayload/curses/PDCurses/dos/pdcutil.c
D payloads/libpayload/curses/PDCurses/dos/wccdos16.mak
D payloads/libpayload/curses/PDCurses/dos/wccdos4g.mak
D payloads/libpayload/curses/PDCurses/os2/README
D payloads/libpayload/curses/PDCurses/os2/bccos2.mak
D payloads/libpayload/curses/PDCurses/os2/gccos2.mak
D payloads/libpayload/curses/PDCurses/os2/iccos2.lrf
D payloads/libpayload/curses/PDCurses/os2/iccos2.mak
D payloads/libpayload/curses/PDCurses/os2/pdcclip.c
D payloads/libpayload/curses/PDCurses/os2/pdcdisp.c
D payloads/libpayload/curses/PDCurses/os2/pdcgetsc.c
D payloads/libpayload/curses/PDCurses/os2/pdckbd.c
D payloads/libpayload/curses/PDCurses/os2/pdcos2.h
D payloads/libpayload/curses/PDCurses/os2/pdcscrn.c
D payloads/libpayload/curses/PDCurses/os2/pdcsetsc.c
D payloads/libpayload/curses/PDCurses/os2/pdcutil.c
D payloads/libpayload/curses/PDCurses/os2/wccos2.mak
D payloads/libpayload/curses/PDCurses/sdl1/Makefile
D payloads/libpayload/curses/PDCurses/sdl1/Makefile.mng
D payloads/libpayload/curses/PDCurses/sdl1/README
D payloads/libpayload/curses/PDCurses/sdl1/deffont.h
D payloads/libpayload/curses/PDCurses/sdl1/deficon.h
D payloads/libpayload/curses/PDCurses/sdl1/pdcclip.c
D payloads/libpayload/curses/PDCurses/sdl1/pdcdisp.c
D payloads/libpayload/curses/PDCurses/sdl1/pdcgetsc.c
D payloads/libpayload/curses/PDCurses/sdl1/pdckbd.c
D payloads/libpayload/curses/PDCurses/sdl1/pdcscrn.c
D payloads/libpayload/curses/PDCurses/sdl1/pdcsdl.h
D payloads/libpayload/curses/PDCurses/sdl1/pdcsetsc.c
D payloads/libpayload/curses/PDCurses/sdl1/pdcutil.c
D payloads/libpayload/curses/PDCurses/sdl1/sdltest.c
D payloads/libpayload/curses/PDCurses/win32/README
D payloads/libpayload/curses/PDCurses/win32/bccwin32.mak
D payloads/libpayload/curses/PDCurses/win32/dmcwin32.mak
D payloads/libpayload/curses/PDCurses/win32/gccwin32.mak
D payloads/libpayload/curses/PDCurses/win32/lccwin32.mak
D payloads/libpayload/curses/PDCurses/win32/mingwin32.mak
D payloads/libpayload/curses/PDCurses/win32/pdcclip.c
D payloads/libpayload/curses/PDCurses/win32/pdcdisp.c
D payloads/libpayload/curses/PDCurses/win32/pdcgetsc.c
D payloads/libpayload/curses/PDCurses/win32/pdckbd.c
D payloads/libpayload/curses/PDCurses/win32/pdcscrn.c
D payloads/libpayload/curses/PDCurses/win32/pdcsetsc.c
D payloads/libpayload/curses/PDCurses/win32/pdcurses.ico
D payloads/libpayload/curses/PDCurses/win32/pdcurses.rc
D payloads/libpayload/curses/PDCurses/win32/pdcutil.c
D payloads/libpayload/curses/PDCurses/win32/pdcwin.h
D payloads/libpayload/curses/PDCurses/win32/vcwin32.mak
D payloads/libpayload/curses/PDCurses/win32/wccwin32.mak
D payloads/libpayload/curses/PDCurses/x11/Makefile.aix.in
D payloads/libpayload/curses/PDCurses/x11/Makefile.in
D payloads/libpayload/curses/PDCurses/x11/README
D payloads/libpayload/curses/PDCurses/x11/ScrollBox.c
D payloads/libpayload/curses/PDCurses/x11/ScrollBox.h
D payloads/libpayload/curses/PDCurses/x11/ScrollBoxP.h
D payloads/libpayload/curses/PDCurses/x11/big_icon.xbm
D payloads/libpayload/curses/PDCurses/x11/compose.h
D payloads/libpayload/curses/PDCurses/x11/little_icon.xbm
D payloads/libpayload/curses/PDCurses/x11/ncurses_cfg.h
D payloads/libpayload/curses/PDCurses/x11/pdcclip.c
D payloads/libpayload/curses/PDCurses/x11/pdcdisp.c
D payloads/libpayload/curses/PDCurses/x11/pdcgetsc.c
D payloads/libpayload/curses/PDCurses/x11/pdckbd.c
D payloads/libpayload/curses/PDCurses/x11/pdcscrn.c
D payloads/libpayload/curses/PDCurses/x11/pdcsetsc.c
D payloads/libpayload/curses/PDCurses/x11/pdcutil.c
D payloads/libpayload/curses/PDCurses/x11/pdcx11.c
D payloads/libpayload/curses/PDCurses/x11/pdcx11.h
D payloads/libpayload/curses/PDCurses/x11/sb.c
D payloads/libpayload/curses/PDCurses/x11/x11.c
D payloads/libpayload/curses/PDCurses/x11/xcurses-config.in
95 files changed, 0 insertions(+), 20,512 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/35429/1
--
To view, visit https://review.coreboot.org/c/coreboot/+/35429
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b09104f64254d768d27a3d2e3fba8418e7ba2ca
Gerrit-Change-Number: 35429
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newchange