Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37207 )
Change subject: google/eve: add libgfxinit support
......................................................................
google/eve: add libgfxinit support
Change-Id: Id9d9d804dfc2301b8d2186aff7be331d5ddbf18a
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/eve/Kconfig
M src/mainboard/google/eve/Makefile.inc
A src/mainboard/google/eve/gma-mainboard.ads
3 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37207/1
diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig
index c768ecc..31ff6e9 100644
--- a/src/mainboard/google/eve/Kconfig
+++ b/src/mainboard/google/eve/Kconfig
@@ -18,6 +18,7 @@
select INTEL_LPSS_UART_FOR_CONSOLE
select MAINBOARD_HAS_CHROMEOS
select MAINBOARD_HAS_I2C_TPM_CR50
+ select MAINBOARD_HAS_LIBGFXINIT
select MAINBOARD_HAS_TPM2
select SOC_INTEL_KABYLAKE
diff --git a/src/mainboard/google/eve/Makefile.inc b/src/mainboard/google/eve/Makefile.inc
index d137f92..ed1933e 100644
--- a/src/mainboard/google/eve/Makefile.inc
+++ b/src/mainboard/google/eve/Makefile.inc
@@ -25,4 +25,6 @@
ramstage-y += mainboard.c
ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
+ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
+
smm-y += smihandler.c
diff --git a/src/mainboard/google/eve/gma-mainboard.ads b/src/mainboard/google/eve/gma-mainboard.ads
new file mode 100644
index 0000000..87cdb5e
--- /dev/null
+++ b/src/mainboard/google/eve/gma-mainboard.ads
@@ -0,0 +1,31 @@
+--
+-- This file is part of the coreboot project.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+ ports : constant Port_List :=
+ (Internal,
+ DP1,
+ DP2,
+ HDMI1,
+ HDMI2,
+ others => Disabled);
+
+end GMA.Mainboard;
--
To view, visit https://review.coreboot.org/c/coreboot/+/37207
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9d9d804dfc2301b8d2186aff7be331d5ddbf18a
Gerrit-Change-Number: 37207
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37206 )
Change subject: google/fizz: add libgfxinit support
......................................................................
google/fizz: add libgfxinit support
Change-Id: Idd7bfa4a97770f525c3f25f04f90c4bf092e4ae1
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/fizz/Kconfig
M src/mainboard/google/fizz/Makefile.inc
A src/mainboard/google/fizz/gma-mainboard.ads
3 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/37206/1
diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig
index 44ac064..cafb855 100644
--- a/src/mainboard/google/fizz/Kconfig
+++ b/src/mainboard/google/fizz/Kconfig
@@ -17,6 +17,7 @@
select INTEL_GMA_HAVE_VBT
select INTEL_LPSS_UART_FOR_CONSOLE
select MAINBOARD_HAS_CHROMEOS
+ select MAINBOARD_HAS_LIBGFXINIT
select NO_FADT_8042
select SOC_INTEL_KABYLAKE
select MAINBOARD_HAS_SPI_TPM_CR50
diff --git a/src/mainboard/google/fizz/Makefile.inc b/src/mainboard/google/fizz/Makefile.inc
index 3e030c3..9721c45 100644
--- a/src/mainboard/google/fizz/Makefile.inc
+++ b/src/mainboard/google/fizz/Makefile.inc
@@ -24,6 +24,8 @@
ramstage-$(CONFIG_EC_GOOGLE_CHROMEEC) += ec.c
ramstage-y += mainboard.c
+ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
+
smm-y += smihandler.c
subdirs-y += variants/baseboard
diff --git a/src/mainboard/google/fizz/gma-mainboard.ads b/src/mainboard/google/fizz/gma-mainboard.ads
new file mode 100644
index 0000000..e47ea7e
--- /dev/null
+++ b/src/mainboard/google/fizz/gma-mainboard.ads
@@ -0,0 +1,30 @@
+--
+-- This file is part of the coreboot project.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+ ports : constant Port_List :=
+ (DP1,
+ DP2,
+ HDMI1,
+ HDMI2,
+ others => Disabled);
+
+end GMA.Mainboard;
--
To view, visit https://review.coreboot.org/c/coreboot/+/37206
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd7bfa4a97770f525c3f25f04f90c4bf092e4ae1
Gerrit-Change-Number: 37206
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37205 )
Change subject: google/glados: add libgfxinit support
......................................................................
google/glados: add libgfxinit support
Both linear framebuffer and vga text mode verified
on chell and caroline variants
Change-Id: I106e7bb761055581634176a112816be8447e6745
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/glados/Makefile.inc
A src/mainboard/google/glados/gma-mainboard.ads
3 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/37205/1
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index fe7359f..52907cc 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -19,6 +19,7 @@
select MAINBOARD_HAS_TPM1
select SOC_INTEL_SKYLAKE
select SYSTEM_TYPE_LAPTOP
+ select MAINBOARD_HAS_LIBGFXINIT
if BOARD_GOOGLE_BASEBOARD_GLADOS
diff --git a/src/mainboard/google/glados/Makefile.inc b/src/mainboard/google/glados/Makefile.inc
index 323e68b..af43f7c 100644
--- a/src/mainboard/google/glados/Makefile.inc
+++ b/src/mainboard/google/glados/Makefile.inc
@@ -30,6 +30,8 @@
smm-y += smihandler.c
+ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
+
subdirs-y += variants/$(VARIANT_DIR)
CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include
diff --git a/src/mainboard/google/glados/gma-mainboard.ads b/src/mainboard/google/glados/gma-mainboard.ads
new file mode 100644
index 0000000..87cdb5e
--- /dev/null
+++ b/src/mainboard/google/glados/gma-mainboard.ads
@@ -0,0 +1,31 @@
+--
+-- This file is part of the coreboot project.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+ ports : constant Port_List :=
+ (Internal,
+ DP1,
+ DP2,
+ HDMI1,
+ HDMI2,
+ others => Disabled);
+
+end GMA.Mainboard;
--
To view, visit https://review.coreboot.org/c/coreboot/+/37205
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I106e7bb761055581634176a112816be8447e6745
Gerrit-Change-Number: 37205
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35774 )
Change subject: crossgcc: Upgrade CMake to 3.15.4
......................................................................
crossgcc: Upgrade CMake to 3.15.4
3.15.4 change:
"In CMake 3.15.0 through 3.15.3, the EXCLUDE_FROM_ALL directory
property was regressed from pre-3.14 behavior and caused targets
within the directory to be excluded even from its own “all”.
This has been fixed. The bug also existed in 3.14.0 through 3.14.6
and is fixed in 3.14.7."
Change-Id: Ib564217c4fdcb609fd6dfd4cb71288dd54ffe4bf
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum
A util/crossgcc/sum/cmake-3.15.4.tar.gz.cksum
3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/35774/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 9c10c7d..260958c 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -60,7 +60,7 @@
# CLANG version number
CLANG_VERSION=8.0.0
MAKE_VERSION=4.2.1
-CMAKE_VERSION=3.15.3
+CMAKE_VERSION=3.15.4
NASM_VERSION=2.14.02
# GCC toolchain archive locations
diff --git a/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum b/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum
deleted file mode 100644
index c467676..0000000
--- a/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum
+++ /dev/null
@@ -1 +0,0 @@
-f467388ba336ea3652f5800918a72cfcc4f7f403 tarballs/cmake-3.15.3.tar.gz
diff --git a/util/crossgcc/sum/cmake-3.15.4.tar.gz.cksum b/util/crossgcc/sum/cmake-3.15.4.tar.gz.cksum
new file mode 100644
index 0000000..9a2571c
--- /dev/null
+++ b/util/crossgcc/sum/cmake-3.15.4.tar.gz.cksum
@@ -0,0 +1 @@
+0bef17d6067df2672edf63d20c8ec9289a82648d tarballs/cmake-3.15.4.tar.gz
--
To view, visit https://review.coreboot.org/c/coreboot/+/35774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib564217c4fdcb609fd6dfd4cb71288dd54ffe4bf
Gerrit-Change-Number: 35774
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37111 )
Change subject: util/ifdtool: Add Jasperlake platform support under IFDv2
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37111/5/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/37111/5/util/ifdtool/ifdtool.c@1641
PS5, Line 1641: } else if (!strcmp(optarg, "jsl")) {
: platform = PLATFORM_JSL;
What's the point in all these compatible IFD arguments? If no distinction is made just document which ones are compatible?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4963ab249a8e0b31c014e92edf1e0a4a4f638084
Gerrit-Change-Number: 37111
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 27 Nov 2019 13:10:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment