coreboot-gerrit November 2019

coreboot-gerrit@coreboot.org

1 participants
2418 discussions

Change in coreboot[master]: superio/nct5539d: include the missing acpi.h and ssdt.h
by Maxim Polyakov (Code Review) 01 Dec '19

01 Dec '19

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37274 ) Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h ...................................................................... superio/nct5539d: include the missing acpi.h and ssdt.h Change-Id: Idd80fae1c39f3c7c4bc66a42e9023fb7a727b024 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M src/superio/nuvoton/nct5539d/superio.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/37274/1 diff --git a/src/superio/nuvoton/nct5539d/superio.c b/src/superio/nuvoton/nct5539d/superio.c index 4f2a4a5..bdb50c7 100644 --- a/src/superio/nuvoton/nct5539d/superio.c +++ b/src/superio/nuvoton/nct5539d/superio.c @@ -24,7 +24,8 @@ #include <pc80/keyboard.h> #include <stdlib.h> #include <superio/conf_mode.h> - +#include <superio/common/ssdt.h> +#include <arch/acpi.h> #include "nct5539d.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/37274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd80fae1c39f3c7c4bc66a42e9023fb7a727b024 Gerrit-Change-Number: 37274 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-MessageType: newchange

3 5

Change in coreboot[master]: nb/intel/x4x: Factor out hiding PCI devs in pure fn
by Arthur Heymans (Code Review) 01 Dec '19

01 Dec '19

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37291 ) Change subject: nb/intel/x4x: Factor out hiding PCI devs in pure fn ...................................................................... nb/intel/x4x: Factor out hiding PCI devs in pure fn This increases readability. Also change the update expression. '--variable' does not make much sense there. Change-Id: I64db2460115f5fb35ca197b83440f8ee47470761 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/northbridge.c 1 file changed, 21 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/37291/1 diff --git a/src/northbridge/intel/x4x/northbridge.c b/src/northbridge/intel/x4x/northbridge.c index 39f24d3..efdaeef 100644 --- a/src/northbridge/intel/x4x/northbridge.c +++ b/src/northbridge/intel/x4x/northbridge.c @@ -206,44 +206,45 @@ dev->ops = &cpu_bus_ops; } +static void hide_pci_fn(const int dev_bit_base, const struct device *dev) +{ + if (!dev || dev->enabled) + return; + const unsigned int fn = PCI_FUNC(dev->path.pci.devfn); + const struct device *const d0f0 = pcidev_on_root(0, 0); + pci_update_config32(d0f0, D0F0_DEVEN, ~(1 << (dev_bit_base + fn)), 0); +} + +static void hide_pci_dev(const int dev, int functions, const int dev_bit_base) +{ + for (; functions >= 0; functions--) + hide_pci_fn(dev_bit_base, pcidev_on_root(dev, functions)); +} + static void x4x_init(void *const chip_info) { - int dev, fn, bit_base; - + int dev; struct device *const d0f0 = pcidev_on_root(0x0, 0); /* Hide internal functions based on devicetree info. */ - for (dev = 6; dev > 0; --dev) { + for (dev = 6; dev > 0; dev--) { switch (dev) { case 6: /* PEG1: only on P45 */ - fn = 0; - bit_base = 13; + hide_pci_dev(dev, 0, 13); break; case 3: /* ME */ - fn = 3; - bit_base = 6; + hide_pci_dev(dev, 3, 6); break; case 2: /* IGD */ - fn = 1; - bit_base = 3; + hide_pci_dev(dev, 1, 3); break; case 1: /* PEG0 */ - fn = 0; - bit_base = 1; + hide_pci_dev(dev, 0, 1); break; case 4: /* Nothing to do */ case 5: continue; } - for (; fn >= 0; --fn) { - const struct device *const d = - pcidev_on_root(dev, fn); - if (!d || d->enabled) - continue; - const u32 deven = pci_read_config32(d0f0, D0F0_DEVEN); - pci_write_config32(d0f0, D0F0_DEVEN, - deven & ~(1 << (bit_base + fn))); - } } const u32 deven = pci_read_config32(d0f0, D0F0_DEVEN); -- To view, visit https://review.coreboot.org/c/coreboot/+/37291 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64db2460115f5fb35ca197b83440f8ee47470761 Gerrit-Change-Number: 37291 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

4 10

Change in em100[master]: Add support for older EM100Pro
by Stefan Reinauer (Code Review) 01 Dec '19

01 Dec '19

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37344 ) Change subject: Add support for older EM100Pro ...................................................................... Add support for older EM100Pro These have hardware version 0xff but are otherwise version 4. Their serial numbers start with DP instead of EM. Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Change-Id: I18f19d83b515c4e740f1efec07d49c1ceb2373ec --- M em100.c M em100.h M firmware.c 3 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/44/37344/1 diff --git a/em100.c b/em100.c index 492af4b..578707d 100644 --- a/em100.c +++ b/em100.c @@ -256,7 +256,9 @@ /* Re-read serial number */ get_device_info(em100); if (em100->serialno != 0xffffffff) - printf("New serial number: EM%06d\n", em100->serialno); + printf("New serial number: %s%06d\n", + em100->hwversion == 0xff ? "DP" : "EM", + em100->serialno); else printf("New serial number: N.A.\n"); @@ -494,9 +496,10 @@ libusb_get_device_address(dev)); continue; } - printf(" Bus %03d Device %03d: EM100pro EM%06d\n", + printf(" Bus %03d Device %03d: EM100pro %s%06d\n", libusb_get_bus_number(dev), libusb_get_device_address(dev), + em100.hwversion == 0xff ? "DP" : "EM", em100.serialno); em100_detach(&em100); count++; @@ -924,7 +927,8 @@ printf("Hardware version: %u\n", em100.hwversion); if (em100.serialno != 0xffffffff) - printf("Serial number: EM%06d\n", em100.serialno); + printf("Serial number: %s%06d\n", + em100.hwversion == 0xff ? "DP" : "EM", em100.serialno); else printf("Serial number: N.A.\n"); printf("SPI flash database: %s\n", database_version); diff --git a/em100.h b/em100.h index 3d9cdc8..d48e52b 100644 --- a/em100.h +++ b/em100.h @@ -39,8 +39,9 @@ } chipdesc; /* Hardware versions */ -#define HWVERSION_EM100PRO 4 -#define HWVERSION_EM100PRO_G2 6 +#define HWVERSION_EM100PRO_EARLY 0xff +#define HWVERSION_EM100PRO 0x04 +#define HWVERSION_EM100PRO_G2 0x06 #define BULK_SEND_TIMEOUT 5000 /* sentinel value */ diff --git a/firmware.c b/firmware.c index 96e2565..384e3f3 100644 --- a/firmware.c +++ b/firmware.c @@ -37,7 +37,7 @@ * 0x0100100: mcu firmware * 0x01f0000: 4 bytes secret key, 00 padded * 0x01fff00: ff xx yy yy yy yy ff ff - * xx: HW version + * xx: HW version (0xff, 0x04, 0x06) * yy: 4 bytes serial number * * Notes @@ -133,6 +133,7 @@ unsigned char header[0x100]; switch (em100->hwversion) { + case HWVERSION_EM100PRO_EARLY: case HWVERSION_EM100PRO: hdrversion=1; break; @@ -220,6 +221,7 @@ mcu_version[MAX_VERSION_LENGTH + 1]; switch (em100->hwversion) { + case HWVERSION_EM100PRO_EARLY: case HWVERSION_EM100PRO: printf("Detected EM100Pro (original).\n"); break; @@ -263,6 +265,13 @@ } fclose(f); + if (em100->hwversion == HWVERSION_EM100PRO_EARLY && (memcmp(fw, "em100pro", 8) != 0 || + memcmp(fw + 0x28, "WFPD", 4) != 0)) { + printf("ERROR: Not an EM100Pro (original) firmware file.\n"); + free(fw); + return 0; + } + if (em100->hwversion == HWVERSION_EM100PRO && (memcmp(fw, "em100pro", 8) != 0 || memcmp(fw + 0x28, "WFPD", 4) != 0)) { printf("ERROR: Not an EM100Pro (original) firmware file.\n"); -- To view, visit https://review.coreboot.org/c/em100/+/37344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I18f19d83b515c4e740f1efec07d49c1ceb2373ec Gerrit-Change-Number: 37344 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

3 8

Change in em100[master]: Clean up license headers
by Stefan Reinauer (Code Review) 30 Nov '19

30 Nov '19

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37259 ) Change subject: Clean up license headers ...................................................................... Clean up license headers - Google Inc. became Google LLC in 2017 - Drop last paragraph of GPLv2 - Fix GPLv2 header in hexdump.c Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Change-Id: I81375366181d59d835db43b413ec51f041e25488 --- M Makefile M chips.c M curl.c M em100.c M em100.h M firmware.c M fpga.c M hexdump.c M makechips.sh M makedpfw.c M sdram.c M spi.c M system.c M tar.c M trace.c M usb.c 16 files changed, 5 insertions(+), 70 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/59/37259/1 diff --git a/Makefile b/Makefile index 3bdb103..93a2474 100644 --- a/Makefile +++ b/Makefile @@ -10,10 +10,6 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA -# # Make is silent per default, but 'make V=1' will show all compiler calls. Q:=@ diff --git a/chips.c b/chips.c index 7a776cc..52b01c9 100644 --- a/chips.c +++ b/chips.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <unistd.h> diff --git a/curl.c b/curl.c index 8a4f482..a4ee371 100644 --- a/curl.c +++ b/curl.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/em100.c b/em100.c index abd8415..fd6d002 100644 --- a/em100.c +++ b/em100.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/em100.h b/em100.h index 448e6bb..3d9cdc8 100644 --- a/em100.h +++ b/em100.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #ifndef __EM100_H__ diff --git a/firmware.c b/firmware.c index 0f1c1d0..8cf6091 100644 --- a/firmware.c +++ b/firmware.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/fpga.c b/fpga.c index 2fecc3b..301427c 100644 --- a/fpga.c +++ b/fpga.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/hexdump.c b/hexdump.c index b217123..1653a2b 100644 --- a/hexdump.c +++ b/hexdump.c @@ -1,19 +1,14 @@ /* * Copyright 2013-2015 Google Inc. * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. + ** This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. * * This program is distributed in the hope that it will be useful, - * but without any warranty; without even the implied warranty of + * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/makechips.sh b/makechips.sh index d216442..8c16ded 100755 --- a/makechips.sh +++ b/makechips.sh @@ -11,10 +11,6 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA -# URL="https://www.dediprog.com/download/save/78.msi" VURL="https://www.dediprog.com/download?productCategory=SPI+Flash+Solution&produc…" diff --git a/makedpfw.c b/makedpfw.c index 2b03138..5b3f1a2 100644 --- a/makedpfw.c +++ b/makedpfw.c @@ -1,5 +1,5 @@ /* - * Copyright 2017 Google Inc. + * Copyright 2017 Google LLC * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/sdram.c b/sdram.c index 6da1f14..408afd8 100644 --- a/sdram.c +++ b/sdram.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/spi.c b/spi.c index d24273f..a775ff8 100644 --- a/spi.c +++ b/spi.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/system.c b/system.c index a738144..9286118 100644 --- a/system.c +++ b/system.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/tar.c b/tar.c index 219efd4..ff103ce 100644 --- a/tar.c +++ b/tar.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #define _GNU_SOURCE diff --git a/trace.c b/trace.c index d7616b3..31b6e06 100644 --- a/trace.c +++ b/trace.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/usb.c b/usb.c index 77828bd..c7d52d8 100644 --- a/usb.c +++ b/usb.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> -- To view, visit https://review.coreboot.org/c/em100/+/37259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I81375366181d59d835db43b413ec51f041e25488 Gerrit-Change-Number: 37259 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

2 5

Change in coreboot[master]: lib/imd_cbmem: Remove indirection through cbmem_get_imd()
by Patrick Georgi (Code Review) 30 Nov '19

30 Nov '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37360 ) Change subject: lib/imd_cbmem: Remove indirection through cbmem_get_imd() ...................................................................... lib/imd_cbmem: Remove indirection through cbmem_get_imd() It always returns the same pointer so why not use the pointer directly? Change-Id: Ib5a13edc7f3ab05c3baf9956ab67031507bdddc1 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/lib/imd_cbmem.c 1 file changed, 4 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/37360/1 diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c index 6fd48d5..d7f7d20 100644 --- a/src/lib/imd_cbmem.c +++ b/src/lib/imd_cbmem.c @@ -43,11 +43,7 @@ } -static inline struct imd *cbmem_get_imd(void) -{ - static struct imd imd_cbmem; - return &imd_cbmem; -} +static struct imd imd_cbmem; static inline const struct cbmem_entry *imd_to_cbmem(const struct imd_entry *e) { @@ -75,7 +71,7 @@ { struct imd *imd; - imd = cbmem_get_imd(); + imd = &imd_cbmem; if (imd != NULL) return imd; @@ -288,7 +284,7 @@ void cbmem_get_region(void **baseptr, size_t *size) { - imd_region_used(cbmem_get_imd(), baseptr, size); + imd_region_used(&imd_cbmem, baseptr, size); } #if ENV_PAYLOAD_LOADER || (CONFIG(EARLY_CBMEM_LIST) \ @@ -314,7 +310,7 @@ struct imd_cursor cursor; struct imd *imd; - imd = cbmem_get_imd(); + imd = &imd_cbmem; if (imd_cursor_init(imd, &cursor)) return; -- To view, visit https://review.coreboot.org/c/coreboot/+/37360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5a13edc7f3ab05c3baf9956ab67031507bdddc1 Gerrit-Change-Number: 37360 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: util/pgtblgen: Fix typo
by Patrick Rudolph (Code Review) 30 Nov '19

30 Nov '19

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37369 ) Change subject: util/pgtblgen: Fix typo ...................................................................... util/pgtblgen: Fix typo Change-Id: I638eda3040c7225aa4a8b492c8dc78b0e2effba1 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M util/pgtblgen/pgtblgen.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/37369/1 diff --git a/util/pgtblgen/pgtblgen.c b/util/pgtblgen/pgtblgen.c index efbad55..e9ebd8b 100644 --- a/util/pgtblgen/pgtblgen.c +++ b/util/pgtblgen/pgtblgen.c @@ -28,7 +28,7 @@ printf("usage: %s -b <addr> -a <arch> -o <file>\n", argv[0]); printf(" -a\t architecure. Supported: x86_64\n"); printf(" -b\t base address\n"); - printf(" -b\t the file to write to\n"); + printf(" -o\t the file to write to\n"); printf(" -h\t show this help text\n"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/37369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I638eda3040c7225aa4a8b492c8dc78b0e2effba1 Gerrit-Change-Number: 37369 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: src/{drivers,device,ec}: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 30 Nov '19

30 Nov '19

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32822 to look at the new patch set (#5). Change subject: src/{drivers,device,ec}: Remove unused <stdlib.h> ...................................................................... src/{drivers,device,ec}: Remove unused <stdlib.h> Change-Id: I05422ee4b0aa5c02525ef0b4eccb4dc3ecf871e8 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/i2c_bus.c M src/device/oprom/realmode/x86.c M src/device/pci_class.c M src/device/pnp_device.c M src/drivers/aspeed/ast2050/ast2050.c M src/drivers/emulation/qemu/bochs.c M src/drivers/emulation/qemu/cirrus.c M src/drivers/i2c/rtd2132/rtd2132.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/gma/intel_ddi.c M src/drivers/net/ne2k.c M src/drivers/parade/ps8625/ps8625.c M src/drivers/sil/3114/sil_sata.c M src/drivers/smmstore/store.c M src/drivers/uart/uart8250io.c M src/drivers/vpd/vpd.c M src/drivers/vpd/vpd_cbmem.c M src/ec/google/chromeec/ec_lpc.c M src/ec/google/chromeec/vstore.c M src/ec/google/wilco/chip.c 20 files changed, 0 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/32822/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/32822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05422ee4b0aa5c02525ef0b4eccb4dc3ecf871e8 Gerrit-Change-Number: 32822 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/{drivers,device,ec}: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 30 Nov '19

30 Nov '19

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32822 to look at the new patch set (#4). Change subject: src/{drivers,device,ec}: Remove unused <stdlib.h> ...................................................................... src/{drivers,device,ec}: Remove unused <stdlib.h> Change-Id: I05422ee4b0aa5c02525ef0b4eccb4dc3ecf871e8 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/i2c_bus.c M src/device/oprom/realmode/x86.c M src/device/pci_class.c M src/device/pnp_device.c M src/drivers/aspeed/ast2050/ast2050.c M src/drivers/emulation/qemu/bochs.c M src/drivers/emulation/qemu/cirrus.c M src/drivers/i2c/rtd2132/rtd2132.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/gma/intel_ddi.c M src/drivers/net/ne2k.c M src/drivers/parade/ps8625/ps8625.c M src/drivers/sil/3114/sil_sata.c M src/drivers/smmstore/store.c M src/drivers/uart/uart8250io.c M src/drivers/vpd/vpd.c M src/drivers/vpd/vpd_cbmem.c M src/ec/google/chromeec/ec_lpc.c M src/ec/google/chromeec/vstore.c M src/ec/google/wilco/chip.c 20 files changed, 0 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/32822/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/32822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05422ee4b0aa5c02525ef0b4eccb4dc3ecf871e8 Gerrit-Change-Number: 32822 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: {commonlib,device,drivers}: Use 'include <stdlib.h>' when appropriate
by HAOUAS Elyes (Code Review) 30 Nov '19

30 Nov '19

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/32822 ) Change subject: {commonlib,device,drivers}: Use 'include <stdlib.h>' when appropriate ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/32822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05422ee4b0aa5c02525ef0b4eccb4dc3ecf871e8 Gerrit-Change-Number: 32822 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: restore

1 0

Change in coreboot[master]: arch/x86/car.ld: Drop CAR_GLOBAL region
by Arthur Heymans (Code Review) 30 Nov '19

30 Nov '19

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37327 ) Change subject: arch/x86/car.ld: Drop CAR_GLOBAL region ...................................................................... arch/x86/car.ld: Drop CAR_GLOBAL region Change-Id: Id66fd0528987fb3e464d400cf9ccac98752fb8f5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/x86/car.ld 1 file changed, 1 insertion(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37327/1 diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld index 483a908..d8ff4b3 100644 --- a/src/arch/x86/car.ld +++ b/src/arch/x86/car.ld @@ -71,7 +71,7 @@ /* _bss and _ebss provide symbols to per-stage * variables that are not shared like the timestamp and the pre-ram * cbmem console. This is useful for clearing this area on a per-stage - * basis when more than one stage uses cache-as-ram for CAR_GLOBALs. */ + * basis when more than one stage uses cache-as-ram. */ . = ALIGN(ARCH_POINTER_ALIGN_SIZE); _bss = .; @@ -81,10 +81,6 @@ *(.bss.*) *(.sbss) *(.sbss.*) -#else - _car_global_start = .; - *(.car.global_data); - _car_global_end = .; #endif . = ALIGN(ARCH_POINTER_ALIGN_SIZE); _ebss = .; @@ -106,15 +102,6 @@ .illegal_globals . : { *(EXCLUDE_FILE ("*/libagesa.*.a:" "*/romstage*/buildOpts.o" "*/romstage*/agesawrapper.o" "*/vendorcode/amd/agesa/*" "*/vendorcode/amd/cimx/*") .data) *(EXCLUDE_FILE ("*/libagesa.*.a:" "*/romstage*/buildOpts.o" "*/romstage*/agesawrapper.o" "*/vendorcode/amd/agesa/*" "*/vendorcode/amd/cimx/*") .data.*) -#if CONFIG(CAR_GLOBAL_MIGRATION) - *(.bss) - *(.bss.*) - *(.sbss) - *(.sbss.*) -#else - /* In case something sneaks through when it shouldn't. */ - *(.car.global_data); -#endif } _bogus = ASSERT((CONFIG_DCACHE_RAM_SIZE == 0) || (SIZEOF(.car.data) <= CONFIG_DCACHE_RAM_SIZE), "Cache as RAM area is too full"); -- To view, visit https://review.coreboot.org/c/coreboot/+/37327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66fd0528987fb3e464d400cf9ccac98752fb8f5 Gerrit-Change-Number: 37327 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

4 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2019