coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: soc/intel/denverton_ns: Enable Fast Strings
by Angel Pons (Code Review) 15 Jan '19

15 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25431 ) Change subject: soc/intel/denverton_ns: Enable Fast Strings ...................................................................... Patch Set 7: If I may ask, what does this option do? -- To view, visit https://review.coreboot.org/c/coreboot/+/25431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cee3c40299abf14a24128b1ac14f1823f87a0e1 Gerrit-Change-Number: 25431 Gerrit-PatchSet: 7 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shine Liu <shine.liu(a)intel.com> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 15 Jan 2019 18:40:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/denverton_ns: Use cpulib in cpu.c
by Angel Pons (Code Review) 15 Jan '19

15 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25432 ) Change subject: soc/intel/denverton_ns: Use cpulib in cpu.c ...................................................................... Patch Set 7: Code-Review+2 +1 +1 +1 +1... +2! -- To view, visit https://review.coreboot.org/c/coreboot/+/25432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I45da6363a35cf6f5855906bb97ed023681d36df7 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 7 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shine Liu <shine.liu(a)intel.com> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 18:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: asrock/imb-a180: Add comment about label on chip
by Angel Pons (Code Review) 15 Jan '19

15 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22227 ) Change subject: asrock/imb-a180: Add comment about label on chip ...................................................................... Patch Set 1: Is this label a sticker on the chip or what the chip says on it? -- To view, visit https://review.coreboot.org/c/coreboot/+/22227 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If54226cbca9ce7eb8927fc4dfd1cbe5e061c705d Gerrit-Change-Number: 22227 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 15 Jan 2019 18:22:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: buildgcc: Update Clang version to 4.0.1
by HAOUAS Elyes (Code Review) 15 Jan '19

15 Jan '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21017 ) Change subject: buildgcc: Update Clang version to 4.0.1 ...................................................................... Patch Set 2: maybe you can move this to "abandoned" ? coreboot is currently running CLANG_VERSION=7.0.1 and CMAKE_VERSION=3.13.2 -- To view, visit https://review.coreboot.org/c/coreboot/+/21017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7440840d861f55476c0e22a614bbd003474cea1b Gerrit-Change-Number: 21017 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 15 Jan 2019 18:11:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: asrock/imb-a180: Add comment about label on chip
by HAOUAS Elyes (Code Review) 15 Jan '19

15 Jan '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22227 ) Change subject: asrock/imb-a180: Add comment about label on chip ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/22227 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If54226cbca9ce7eb8927fc4dfd1cbe5e061c705d Gerrit-Change-Number: 22227 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 17:49:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/denverton_ns: Select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
by Vanny E (Code Review) 15 Jan '19

15 Jan '19

Hello Patrick Rudolph, David Guckian, Subrata Banik, build bot (Jenkins), Patrick Georgi, David Guckian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/26928 to look at the new patch set (#10). Change subject: soc/intel/denverton_ns: Select CPU_INTEL_FIRMWARE_INTERFACE_TABLE ...................................................................... soc/intel/denverton_ns: Select CPU_INTEL_FIRMWARE_INTERFACE_TABLE * Add CPU_INTEL_FIRMWARE_INTERFACE_TABLE Change-Id: I9d4901ea56d5bf5225a8f3a6015d2ea80a9e46b5 Signed-off-by: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> --- M src/soc/intel/denverton_ns/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/26928/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/26928 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d4901ea56d5bf5225a8f3a6015d2ea80a9e46b5 Gerrit-Change-Number: 26928 Gerrit-PatchSet: 10 Gerrit-Owner: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Update src/soc/intel/denverton_ns/soc/intel/denverton_ns: Select kcon...
by HAOUAS Elyes (Code Review) 15 Jan '19

15 Jan '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26928 ) Change subject: Update src/soc/intel/denverton_ns/soc/intel/denverton_ns: Select kconfig CPU_INTEL_FIRMWARE_INTERFACE_TABLE ...................................................................... Patch Set 9: (1 comment) https://review.coreboot.org/#/c/26928/9//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/26928/9//COMMIT_MSG@7 PS9, Line 7: Update src/soc/intel/denverton_ns/soc/intel/denverton_ns: Select kconfig CPU_INTEL_FIRMWARE_INTERFACE_TABLE maybe just: soc/intel/denverton_ns: Select CPU_INTEL_FIRMWARE_INTERFACE_TABLE -- To view, visit https://review.coreboot.org/c/coreboot/+/26928 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d4901ea56d5bf5225a8f3a6015d2ea80a9e46b5 Gerrit-Change-Number: 26928 Gerrit-PatchSet: 9 Gerrit-Owner: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 15 Jan 2019 17:38:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Update src/soc/intel/denverton_ns/soc/intel/denverton_ns: Select kcon...
by Vanny E (Code Review) 15 Jan '19

15 Jan '19

Vanny E has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26928 ) Change subject: Update src/soc/intel/denverton_ns/soc/intel/denverton_ns: Select kconfig CPU_INTEL_FIRMWARE_INTERFACE_TABLE ...................................................................... Patch Set 9: > Patch Set 5: > > > > Patch Set 5: > > > > > > will wait for verified -1 to go before giving +2 vote > > > > The error you see in patchset 5 could be issue with updated > > toolchain. > > Added Patrick if he can help. Subrata, can you please vote +2? Thank you. -- To view, visit https://review.coreboot.org/c/coreboot/+/26928 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d4901ea56d5bf5225a8f3a6015d2ea80a9e46b5 Gerrit-Change-Number: 26928 Gerrit-PatchSet: 9 Gerrit-Owner: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 15 Jan 2019 17:33:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/denverton_ns: Add ACPI T-States and P-States
by Vanny E (Code Review) 15 Jan '19

15 Jan '19

Vanny E has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25430 ) Change subject: soc/intel/denverton_ns: Add ACPI T-States and P-States ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/25430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9c7da474a81417a5cebd875023f7cd3d5a77796 Gerrit-Change-Number: 25430 Gerrit-PatchSet: 7 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shine Liu <shine.liu(a)intel.com> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 17:22:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 ) Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/29480/5/src/mainboard/kontron/bsl6/romstage… File src/mainboard/kontron/bsl6/romstage.c: https://review.coreboot.org/#/c/29480/5/src/mainboard/kontron/bsl6/romstage… PS5, Line 39: FSP_M_CONFIG *const memory_params = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/29480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5 Gerrit-Change-Number: 29480 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 16:27:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019