coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
by Thomas Heijligen (Code Review) 15 Jan '19

15 Jan '19

Thomas Heijligen has uploaded a new patch set (#5) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/29480 ) Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module ...................................................................... [WIP] mb/kontron/bsl6: Add new Skylake COMe module Add Kontron/bSL6 together with Siemens/Boxer26, a baseboard for the bSL6. Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- A src/mainboard/kontron/bsl6/Kconfig A src/mainboard/kontron/bsl6/Kconfig.name A src/mainboard/kontron/bsl6/Makefile.inc A src/mainboard/kontron/bsl6/acpi/ec.asl A src/mainboard/kontron/bsl6/acpi/mainboard.asl A src/mainboard/kontron/bsl6/acpi/superio.asl A src/mainboard/kontron/bsl6/acpi_tables.c A src/mainboard/kontron/bsl6/board_info.txt A src/mainboard/kontron/bsl6/bootblock.c A src/mainboard/kontron/bsl6/cmos.default A src/mainboard/kontron/bsl6/cmos.layout A src/mainboard/kontron/bsl6/dsdt.asl A src/mainboard/kontron/bsl6/gpio.h A src/mainboard/kontron/bsl6/ramstage.c A src/mainboard/kontron/bsl6/romstage.c A src/mainboard/kontron/bsl6/variant.h A src/mainboard/kontron/bsl6/variants/boxer26/boxer26_eeprom.h A src/mainboard/kontron/bsl6/variants/boxer26/devicetree.cb A src/mainboard/kontron/bsl6/variants/boxer26/gma-mainboard.ads A src/mainboard/kontron/bsl6/variants/boxer26/romstage.c A src/mainboard/kontron/bsl6/variants/boxer26/smbios.c A src/mainboard/kontron/bsl6/variants/bsl6/devicetree.cb A src/mainboard/kontron/bsl6/variants/bsl6/gma-mainboard.ads A src/mainboard/kontron/bsl6/variants/bsl6/romstage.c 24 files changed, 1,458 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/29480/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/29480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5 Gerrit-Change-Number: 29480 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: UPSTREAM: mb/google/atlas: Enable camera module NVM
by JasonX Z Chen (Code Review) 15 Jan '19

15 Jan '19

JasonX Z Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30795 Change subject: UPSTREAM: mb/google/atlas: Enable camera module NVM ...................................................................... UPSTREAM: mb/google/atlas: Enable camera module NVM Enable at24 EEPROM by adding ASL of nvm BUG=none BRANCH=master TEST=Build and run for basic camera functions Change-Id: Ifc2060c2ceb7d1a8ef490f36f484deb425a37c95 Signed-off-by: Chen, JasonX Z <jasonx.z.chen(a)intel.com> --- M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl 1 file changed, 67 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/30795/1 diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl index 7c85650..ce459e2 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl @@ -15,25 +15,23 @@ Scope (\_SB.PCI0.I2C3) { - Device (CAM0) - { - Name (_HID, "INT3478") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "SONY IMX208 Camera") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C3", - 0x00, ResourceConsumer, ,) - }) - + /* Power resource methods for Front Camera */ + PowerResource (FCPR, 0, 0) { Name (STA, 0) + Method (_ON, 0, Serialized) { + PMON () + } + Method (_OFF, 0, Serialized) { + PMOF () + } + Method (_STA, 0, Serialized) { + If (LGreater(STA,0)) { + Return (0x1) + } + Else { + Return (0x0) + } + } Method (PMON, 0, Serialized) { If (STA == 0) { CTXS (EN_CAM_PMIC_RST_L) @@ -57,27 +55,28 @@ CTXS (EN_PP3300_DX_CAM) } } + } + Device (CAM0) + { + Name (_HID, "INT3478") /* _HID: Hardware ID */ + Name (_UID, Zero) /* _UID: Unique ID */ + Name (_DDN, "SONY IMX208 Camera") /* _DDN: DOS Device Name */ + + Method (_STA, 0, NotSerialized) /* _STA: Status */ + { + Return (0x0F) + } + + Name (_CRS, ResourceTemplate () + { + I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, + AddressingMode7Bit, "\\_SB.PCI0.I2C3", + 0x00, ResourceConsumer, ,) + }) Name (_PR0, Package (0x01) { FCPR }) Name (_PR3, Package (0x01) { FCPR }) - /* Power resource methods for Front Camera */ - PowerResource (FCPR, 0, 0) { - Method (_ON, 0, Serialized) { - PMON () - } - Method (_OFF, 0, Serialized) { - PMOF () - } - Method (_STA, 0, Serialized) { - If (LGreater(STA,0)) { - Return (0x1) - } - Else { - Return (0x0) - } - } - } /* Port0 of CAM0 is connected to port0 of CIO2 device */ Name (_DSD, Package () { @@ -119,4 +118,37 @@ } }) } + Device (NVM0) + { + Name (_HID, "INT3499") /* _HID: Hardware ID */ + Name (_UID, Zero) /* _UID: Unique ID */ + Name (_DDN, "GT24C16S") /* _DDN: DOS Device Name */ + + Method (_STA, 0, NotSerialized) /* _STA: Status */ + { + Return (0x0F) + } + + Name (_CRS, ResourceTemplate () + { + I2cSerialBus (0x0050, ControllerInitiated, 0x00061A80, + AddressingMode7Bit, "\\_SB.PCI0.I2C3", + 0x00, ResourceConsumer, ,) + }) + + Name (_DEP, Package () { CAM0 }) + Name (_PR0, Package (0x01) { FCPR }) + Name (_PR3, Package (0x01) { FCPR }) + + Name (_DSD, Package () + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () { "size", 2048 }, + Package () { "pagesize", 1 }, + Package () { "read-only", 1 }, + Package () { "address-width", 16 }, + } + }) + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/30795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc2060c2ceb7d1a8ef490f36f484deb425a37c95 Gerrit-Change-Number: 30795 Gerrit-PatchSet: 1 Gerrit-Owner: JasonX Z Chen <jasonx.z.chen(a)intel.com> Gerrit-MessageType: newchange

4 5

Change in ...coreboot[master]: device/i2c_bus: Add i2c_dev_readb_at_word()
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29478 ) Change subject: device/i2c_bus: Add i2c_dev_readb_at_word() ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/29478/4/src/device/i2c_bus.c File src/device/i2c_bus.c: https://review.coreboot.org/#/c/29478/4/src/device/i2c_bus.c@189 PS4, Line 189: transfer(busdev, msg, ARRAY_SIZE(msg)); Avoid multiple line dereference - prefer 'busdev->ops->ops_i2c_bus->transfer' https://review.coreboot.org/#/c/29478/4/src/include/device/i2c_bus.h File src/include/device/i2c_bus.h: https://review.coreboot.org/#/c/29478/4/src/include/device/i2c_bus.h@98 PS4, Line 98: int i2c_dev_readb_at_word(struct device *, function definition argument 'struct device *' should also have an identifier name -- To view, visit https://review.coreboot.org/c/coreboot/+/29478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412 Gerrit-Change-Number: 29478 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 15:10:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: x86/smbios: Untangle system and board tables
by Thomas Heijligen (Code Review) 15 Jan '19

15 Jan '19

Thomas Heijligen has uploaded a new patch set (#4) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/29477 ) Change subject: x86/smbios: Untangle system and board tables ...................................................................... x86/smbios: Untangle system and board tables We were used to set the same values in the system and board tables. We'll keep the mainboard values as defaults for the system tables, so nothing changes unless somebody overrides the system table hooks. Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M src/Kconfig M src/arch/x86/smbios.c M src/drivers/i2c/at24rf08c/lenovo_serials.c M src/include/smbios.h M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/sarien/sku.c M src/mainboard/pcengines/apu1/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/scaleway/tagada/ramstage.c 16 files changed, 64 insertions(+), 53 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29477/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/29477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae Gerrit-Change-Number: 29477 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: string.h: Add isprint()
by Angel Pons (Code Review) 15 Jan '19

15 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29479 ) Change subject: string.h: Add isprint() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29479 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If179687f0a15cf5b16723ad18d8eb86a2d5fa48d Gerrit-Change-Number: 29479 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 14:38:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
by Angel Pons (Code Review) 15 Jan '19

15 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 ) Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/29480/3/src/mainboard/kontron/bsl6/dsdt.asl File src/mainboard/kontron/bsl6/dsdt.asl: https://review.coreboot.org/#/c/29480/3/src/mainboard/kontron/bsl6/dsdt.asl… PS3, Line 22: "COREv4", // OEM id : "COREBOOT", // OEM table id These should be replaced with the macros in arch/acpi.h (and said header included) -- To view, visit https://review.coreboot.org/c/coreboot/+/29480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5 Gerrit-Change-Number: 29480 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 14:25:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: drivers/i2c/nct7802y: Add new hardware-monitoring IC
by Nico Huber (Code Review) 15 Jan '19

15 Jan '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29475 ) Change subject: drivers/i2c/nct7802y: Add new hardware-monitoring IC ...................................................................... Patch Set 3: (1 comment) Felix, thanks for your feedback. We currently try to get the whole series build tested, first. I'll come back to your comments later. https://review.coreboot.org/#/c/29475/1/src/drivers/i2c/nct7802y/nct7802y.h File src/drivers/i2c/nct7802y/nct7802y.h: https://review.coreboot.org/#/c/29475/1/src/drivers/i2c/nct7802y/nct7802y.h… PS1, Line 39: << 0 > the << 0 isn't really needed here and in the 3 lines below. […] Just to align things and make it more visible that it's a bit mask. -- To view, visit https://review.coreboot.org/c/coreboot/+/29475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35ea79e12941804e398c6304a08170a776f4ca76 Gerrit-Change-Number: 29475 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 14:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: nb/intel/sandybridge: Remove the C native graphic init
by Angel Pons (Code Review) 15 Jan '19

15 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27532 ) Change subject: nb/intel/sandybridge: Remove the C native graphic init ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/27532 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6678d3455f1116e7e67a67b465a79df020b2399 Gerrit-Change-Number: 27532 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 14:08:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: x86/smbios: Untangle system and board tables
by Nico Huber (Code Review) 15 Jan '19

15 Jan '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29477 ) Change subject: x86/smbios: Untangle system and board tables ...................................................................... Patch Set 3: > what is the problem that this CL is addressing ? "We were used to set the same values in the system and board tables." There are two independent tables in SMBIOS, one for the whole system and one for the mainboard, but we filled them both with the same values. This behaviour is still maintained, unless a mainboard over- rides the new, weak functions. -- To view, visit https://review.coreboot.org/c/coreboot/+/29477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae Gerrit-Change-Number: 29477 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Tue, 15 Jan 2019 14:00:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: x86/smbios: Untangle system and board tables
by Subrata Banik (Code Review) 15 Jan '19

15 Jan '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29477 ) Change subject: x86/smbios: Untangle system and board tables ...................................................................... Patch Set 3: what is the problem that this CL is addressing ? -- To view, visit https://review.coreboot.org/c/coreboot/+/29477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae Gerrit-Change-Number: 29477 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:56:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019