coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 ) Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/29480/3/src/mainboard/kontron/bsl6/romstage… File src/mainboard/kontron/bsl6/romstage.c: https://review.coreboot.org/#/c/29480/3/src/mainboard/kontron/bsl6/romstage… PS3, Line 39: FSP_M_CONFIG *const memory_params = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/#/c/29480/3/src/mainboard/kontron/bsl6/variants… File src/mainboard/kontron/bsl6/variants/bsl6/devicetree.cb: https://review.coreboot.org/#/c/29480/3/src/mainboard/kontron/bsl6/variants… PS3, Line 16: trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/29480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5 Gerrit-Change-Number: 29480 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:47:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: device/i2c_bus: Add i2c_dev_readb_at_word()
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29478 ) Change subject: device/i2c_bus: Add i2c_dev_readb_at_word() ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/29478/3/src/device/i2c_bus.c File src/device/i2c_bus.c: https://review.coreboot.org/#/c/29478/3/src/device/i2c_bus.c@189 PS3, Line 189: transfer(busdev, msg, ARRAY_SIZE(msg)); Avoid multiple line dereference - prefer 'busdev->ops->ops_i2c_bus->transfer' https://review.coreboot.org/#/c/29478/3/src/include/device/i2c_bus.h File src/include/device/i2c_bus.h: https://review.coreboot.org/#/c/29478/3/src/include/device/i2c_bus.h@98 PS3, Line 98: int i2c_dev_readb_at_word(struct device *, function definition argument 'struct device *' should also have an identifier name -- To view, visit https://review.coreboot.org/c/coreboot/+/29478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412 Gerrit-Change-Number: 29478 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:47:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: drivers/i2c/nct7802y: Add new hardware-monitoring IC
by Thomas Heijligen (Code Review) 15 Jan '19

15 Jan '19

Thomas Heijligen has uploaded a new patch set (#3) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/29475 ) Change subject: drivers/i2c/nct7802y: Add new hardware-monitoring IC ...................................................................... drivers/i2c/nct7802y: Add new hardware-monitoring IC Just another hardware-monitoring chip. Only limited fan control and PECI configuration is implemented. Change-Id: I35ea79e12941804e398c6304a08170a776f4ca76 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- A src/drivers/i2c/nct7802y/Kconfig A src/drivers/i2c/nct7802y/Makefile.inc A src/drivers/i2c/nct7802y/chip.h A src/drivers/i2c/nct7802y/nct7802y.c A src/drivers/i2c/nct7802y/nct7802y.h A src/drivers/i2c/nct7802y/nct7802y_fan.c A src/drivers/i2c/nct7802y/nct7802y_peci.c 7 files changed, 445 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/29475/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/29475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35ea79e12941804e398c6304a08170a776f4ca76 Gerrit-Change-Number: 29475 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 ) Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/29480/2/src/mainboard/kontron/bsl6/romstage… File src/mainboard/kontron/bsl6/romstage.c: https://review.coreboot.org/#/c/29480/2/src/mainboard/kontron/bsl6/romstage… PS2, Line 39: FSP_M_CONFIG *const memory_params = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/#/c/29480/2/src/mainboard/kontron/bsl6/variants… File src/mainboard/kontron/bsl6/variants/bsl6/devicetree.cb: https://review.coreboot.org/#/c/29480/2/src/mainboard/kontron/bsl6/variants… PS2, Line 16: trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/29480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5 Gerrit-Change-Number: 29480 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:31:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: device/i2c_bus: Add i2c_dev_readb_at_word()
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29478 ) Change subject: device/i2c_bus: Add i2c_dev_readb_at_word() ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/29478/2/src/device/i2c_bus.c File src/device/i2c_bus.c: https://review.coreboot.org/#/c/29478/2/src/device/i2c_bus.c@189 PS2, Line 189: transfer(busdev, msg, ARRAY_SIZE(msg)); Avoid multiple line dereference - prefer 'busdev->ops->ops_i2c_bus->transfer' https://review.coreboot.org/#/c/29478/2/src/include/device/i2c_bus.h File src/include/device/i2c_bus.h: https://review.coreboot.org/#/c/29478/2/src/include/device/i2c_bus.h@98 PS2, Line 98: int i2c_dev_readb_at_word(struct device *, function definition argument 'struct device *' should also have an identifier name -- To view, visit https://review.coreboot.org/c/coreboot/+/29478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7516f3e5d9aca362c2b340aa5627d91510c09412 Gerrit-Change-Number: 29478 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:31:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/kontron: Add support for Kontron kempld
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29476 ) Change subject: ec/kontron: Add support for Kontron kempld ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/29476/2/src/ec/kontron/kempld/kempld_i2c.c File src/ec/kontron/kempld/kempld_i2c.c: https://review.coreboot.org/#/c/29476/2/src/ec/kontron/kempld/kempld_i2c.c@… PS2, Line 169: } else { else is not generally useful after a break or return https://review.coreboot.org/#/c/29476/2/src/ec/kontron/kempld/kempld_i2c.c@… PS2, Line 214: printk(BIOS_SPEW, "kempld_i2c: Processed %zu segments.\n", num); line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/29476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If9a0826c4a8f5c8cd573610c2d10561334258b36 Gerrit-Change-Number: 29476 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:31:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: drivers/i2c/lm96000: Add new hardware-monitoring IC
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21194 ) Change subject: drivers/i2c/lm96000: Add new hardware-monitoring IC ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/21194/5/src/drivers/i2c/lm96000/lm96000.c File src/drivers/i2c/lm96000/lm96000.c: https://review.coreboot.org/#/c/21194/5/src/drivers/i2c/lm96000/lm96000.c@1… PS5, Line 155: { 2, 3, 3, 4, 5, 7, 8, 10, 13, 16, 20, 27, 32, 40, 53, 80 }; that open brace { should be on the previous line -- To view, visit https://review.coreboot.org/c/coreboot/+/21194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7df3107bffb7f8e45e71c4c1fbe4eb0a9e3cd03 Gerrit-Change-Number: 21194 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:30:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: drivers/i2c/nct7802y: Add new hardware-monitoring IC
by build bot (Jenkins) (Code Review) 15 Jan '19

15 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29475 ) Change subject: drivers/i2c/nct7802y: Add new hardware-monitoring IC ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29475/2/src/drivers/i2c/nct7802y/nct7802y_f… File src/drivers/i2c/nct7802y/nct7802y_fan.c: https://review.coreboot.org/#/c/29475/2/src/drivers/i2c/nct7802y/nct7802y_f… PS2, Line 50: CLOSE_LOOP_FANx_EN(fan) | trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/29475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35ea79e12941804e398c6304a08170a776f4ca76 Gerrit-Change-Number: 29475 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Jan 2019 13:30:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
by Thomas Heijligen (Code Review) 15 Jan '19

15 Jan '19

Thomas Heijligen has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/29480 ) Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module ...................................................................... [WIP] mb/kontron/bsl6: Add new Skylake COMe module Add Kontron/bSL6 together with Siemens/Boxer26, a baseboard for the bSL6. Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- A src/mainboard/kontron/bsl6/Kconfig A src/mainboard/kontron/bsl6/Kconfig.name A src/mainboard/kontron/bsl6/Makefile.inc A src/mainboard/kontron/bsl6/acpi/ec.asl A src/mainboard/kontron/bsl6/acpi/mainboard.asl A src/mainboard/kontron/bsl6/acpi/superio.asl A src/mainboard/kontron/bsl6/acpi_tables.c A src/mainboard/kontron/bsl6/board_info.txt A src/mainboard/kontron/bsl6/bootblock.c A src/mainboard/kontron/bsl6/cmos.default A src/mainboard/kontron/bsl6/cmos.layout A src/mainboard/kontron/bsl6/dsdt.asl A src/mainboard/kontron/bsl6/gpio.h A src/mainboard/kontron/bsl6/ramstage.c A src/mainboard/kontron/bsl6/romstage.c A src/mainboard/kontron/bsl6/variant.h A src/mainboard/kontron/bsl6/variants/boxer26/boxer26_eeprom.h A src/mainboard/kontron/bsl6/variants/boxer26/devicetree.cb A src/mainboard/kontron/bsl6/variants/boxer26/gma-mainboard.ads A src/mainboard/kontron/bsl6/variants/boxer26/romstage.c A src/mainboard/kontron/bsl6/variants/boxer26/smbios.c A src/mainboard/kontron/bsl6/variants/bsl6/devicetree.cb A src/mainboard/kontron/bsl6/variants/bsl6/gma-mainboard.ads A src/mainboard/kontron/bsl6/variants/bsl6/romstage.c 24 files changed, 1,434 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/29480/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5 Gerrit-Change-Number: 29480 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: x86/smbios: Untangle system and board tables
by Thomas Heijligen (Code Review) 15 Jan '19

15 Jan '19

Thomas Heijligen has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/29477 ) Change subject: x86/smbios: Untangle system and board tables ...................................................................... x86/smbios: Untangle system and board tables We were used to set the same values in the system and board tables. We'll keep the mainboard values as defaults for the system tables, so nothing changes unless somebody overrides the system table hooks. Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M src/Kconfig M src/arch/x86/smbios.c M src/drivers/i2c/at24rf08c/lenovo_serials.c M src/include/smbios.h M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/pcengines/apu1/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c 14 files changed, 61 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29477/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae Gerrit-Change-Number: 29477 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019