coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: mb/lenovo/x220: Add x1 as a variant
by Angel Pons (Code Review) 17 Jan '19

17 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29434 ) Change subject: mb/lenovo/x220: Add x1 as a variant ...................................................................... Patch Set 12: > Patch Set 10: Code-Review-2 > > make sure we don't have to carry around a 400K PNG in coreboot's tree for all time. Noted, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/29434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1 Gerrit-Change-Number: 29434 Gerrit-PatchSet: 12 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Jan 2019 20:22:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: uart8250mem: Change the delay for uart (Don't merge)
by Marshall Dawson (Code Review) 17 Jan '19

17 Jan '19

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/12343 ) Change subject: uart8250mem: Change the delay for uart (Don't merge) ...................................................................... Patch Set 7: I believe we can abandon this. For CZ, we have this to prevent the problem https://review.coreboot.org/c/coreboot/+/17924 -- To view, visit https://review.coreboot.org/c/coreboot/+/12343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6131adbe24a0ee6dfd47d00265fd8583ef22ec0d Gerrit-Change-Number: 12343 Gerrit-PatchSet: 7 Gerrit-Owner: Zheng Bao <fishbaozi(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Zheng Bao <fishbaozi(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 17 Jan 2019 19:03:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Untangle CBFS microcode updates
by Aaron Durbin (Code Review) 17 Jan '19

17 Jan '19

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29934 ) Change subject: Untangle CBFS microcode updates ...................................................................... Patch Set 9: > Patch Set 9: > > > Patch Set 9: > > > > > This seems to have broken mb/googl/{sarien,arcada}. I'm not sure what's the root cause, but I just wanted to note this in here. We might need to flip a local config value in chromium. > > > > Hi Aaron, > > > > is it failing to build or to boot? > > boot > > > > > Is that Cannon Lake or Coffee Lake? In the former case, you > > still need an external microcode binary. The Kconfig symbol > > for that case was renamed from CPU_MICROCODE_CBFS_GENERATE > > to CPU_MICROCODE_CBFS_EXTERNAL_BINS. > > > > Might also still be needed for some Coffee Lake steppings. > > It's whiskey lake which is using one of those two. I can't remember which honestly. I suspect it's an issue w/ an uncoordinated flag setting change. Once hear exact root cause I'll update. At least one report was an unsynchronized setting change. So we're good so far there. -- To view, visit https://review.coreboot.org/c/coreboot/+/29934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib403402e240d3531640a62ce93b7a93b4ef6ca5e Gerrit-Change-Number: 29934 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 17 Jan 2019 18:14:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: NOTFORMERGE: libgfxinit: Hardcode 1027x768@60 on VGA in textmode
by Nico Huber (Code Review) 17 Jan '19

17 Jan '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/19681 ) Change subject: NOTFORMERGE: libgfxinit: Hardcode 1027x768@60 on VGA in textmode ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/19681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9095f6ce56e14aaed28346b4282232b3a9df9e30 Gerrit-Change-Number: 19681 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: NOTFORMERGE: libgfxinit: Test with state cleaning
by Nico Huber (Code Review) 17 Jan '19

17 Jan '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/18858 ) Change subject: NOTFORMERGE: libgfxinit: Test with state cleaning ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/18858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65ba4b1ea85183db8ce3fc0685ca7d423fbe2c2b Gerrit-Change-Number: 18858 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: Untangle CBFS microcode updates
by Aaron Durbin (Code Review) 17 Jan '19

17 Jan '19

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29934 ) Change subject: Untangle CBFS microcode updates ...................................................................... Patch Set 9: > Patch Set 9: > > > This seems to have broken mb/googl/{sarien,arcada}. I'm not sure what's the root cause, but I just wanted to note this in here. We might need to flip a local config value in chromium. > > Hi Aaron, > > is it failing to build or to boot? boot > > Is that Cannon Lake or Coffee Lake? In the former case, you > still need an external microcode binary. The Kconfig symbol > for that case was renamed from CPU_MICROCODE_CBFS_GENERATE > to CPU_MICROCODE_CBFS_EXTERNAL_BINS. > > Might also still be needed for some Coffee Lake steppings. It's whiskey lake which is using one of those two. I can't remember which honestly. I suspect it's an issue w/ an uncoordinated flag setting change. Once hear exact root cause I'll update. -- To view, visit https://review.coreboot.org/c/coreboot/+/29934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib403402e240d3531640a62ce93b7a93b4ef6ca5e Gerrit-Change-Number: 29934 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 17 Jan 2019 17:49:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Untangle CBFS microcode updates
by Nico Huber (Code Review) 17 Jan '19

17 Jan '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29934 ) Change subject: Untangle CBFS microcode updates ...................................................................... Patch Set 9: > This seems to have broken mb/googl/{sarien,arcada}. I'm not sure what's the root cause, but I just wanted to note this in here. We might need to flip a local config value in chromium. Hi Aaron, is it failing to build or to boot? Is that Cannon Lake or Coffee Lake? In the former case, you still need an external microcode binary. The Kconfig symbol for that case was renamed from CPU_MICROCODE_CBFS_GENERATE to CPU_MICROCODE_CBFS_EXTERNAL_BINS. Might also still be needed for some Coffee Lake steppings. -- To view, visit https://review.coreboot.org/c/coreboot/+/29934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib403402e240d3531640a62ce93b7a93b4ef6ca5e Gerrit-Change-Number: 29934 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 17 Jan 2019 17:47:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: NOTFORMERGE: libgfxinit: Hardcode 1027x768@60 on VGA in textmode
by HAOUAS Elyes (Code Review) 17 Jan '19

17 Jan '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/19681 ) Change subject: NOTFORMERGE: libgfxinit: Hardcode 1027x768@60 on VGA in textmode ...................................................................... Patch Set 1: keep for test or drop ? -- To view, visit https://review.coreboot.org/c/coreboot/+/19681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9095f6ce56e14aaed28346b4282232b3a9df9e30 Gerrit-Change-Number: 19681 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 17 Jan 2019 17:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: uart8250mem: Change the delay for uart (Don't merge)
by HAOUAS Elyes (Code Review) 17 Jan '19

17 Jan '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/12343 ) Change subject: uart8250mem: Change the delay for uart (Don't merge) ...................................................................... Patch Set 7: shall we keep this for test ? -- To view, visit https://review.coreboot.org/c/coreboot/+/12343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6131adbe24a0ee6dfd47d00265fd8583ef22ec0d Gerrit-Change-Number: 12343 Gerrit-PatchSet: 7 Gerrit-Owner: Zheng Bao <fishbaozi(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Zheng Bao <fishbaozi(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 17 Jan 2019 17:25:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src/vendorcode/amd/cimx: Unify all filenames
by HAOUAS Elyes (Code Review) 17 Jan '19

17 Jan '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/10602 ) Change subject: src/vendorcode/amd/cimx: Unify all filenames ...................................................................... Patch Set 2: I think you can drop. -- To view, visit https://review.coreboot.org/c/coreboot/+/10602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia890930661ae33281f2be99b896d1a576eed1d5c Gerrit-Change-Number: 10602 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: WANG Siyuan <wangsiyuanbuaa(a)gmail.com> Gerrit-Reviewer: Zheng Bao <fishbaozi(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 17 Jan 2019 17:21:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019