coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: riscv: save FDT pointer from mscratch to HLS
by Philipp Hug (Code Review) 24 Jan '19

24 Jan '19

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27545 ) Change subject: riscv: save FDT pointer from mscratch to HLS ...................................................................... Patch Set 27: (4 comments) Thanks! I like this change. Just some minor comments. Did you test it? https://review.coreboot.org/#/c/27545/27/src/arch/riscv/boot.c File src/arch/riscv/boot.c: https://review.coreboot.org/#/c/27545/27/src/arch/riscv/boot.c@36 PS27, Line 36: void (*fn)(uintptr_t a0, uintptr_t a1) = prog_entry(prog); can you change the type of doit instead of adding another variable? https://review.coreboot.org/#/c/27545/27/src/arch/riscv/boot.c@37 PS27, Line 37: uintptr_t a0 = read_csr(mhartid); please don't name those variables after the register. use e.g. hartid/fdt. https://review.coreboot.org/#/c/27545/27/src/arch/riscv/boot.c@47 PS27, Line 47: printk(BIOS_SPEW, "FDT is at %p\n", HLS()->fdt); use the variable a1/fdt https://review.coreboot.org/#/c/27545/27/src/arch/riscv/include/mcall.h File src/arch/riscv/include/mcall.h: https://review.coreboot.org/#/c/27545/27/src/arch/riscv/include/mcall.h@55 PS27, Line 55: void *fdt; name it rom_fdt, because its the fdt provided by the soc rom? -- To view, visit https://review.coreboot.org/c/coreboot/+/27545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24554528969e36c9e98c0ebd733e002e215a52e5 Gerrit-Change-Number: 27545 Gerrit-PatchSet: 27 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Shawn C <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 24 Jan 2019 11:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: nb/intel/sandybridge/acpi: Add RMRR entry for iGPU
by Nico Huber (Code Review) 24 Jan '19

24 Jan '19

Hello Patrick Rudolph, Angel Pons, Matt DeVillier, Stefan Reinauer, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29668 to look at the new patch set (#8). Change subject: nb/intel/sandybridge/acpi: Add RMRR entry for iGPU ...................................................................... nb/intel/sandybridge/acpi: Add RMRR entry for iGPU The iGPU always needs access to its stolen memory. For proper IOMMU support, we have to make the OS aware of that. Directly below TOLUD lies the data stolen memory (BDSM) followed by the GTT stolen memory (BGSM), the iGPU needs access to both. Change-Id: I391d0a5f1ea14bc90fbacabce41dddfa12b5bb0d Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/northbridge/intel/sandybridge/acpi.c 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/29668/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/29668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I391d0a5f1ea14bc90fbacabce41dddfa12b5bb0d Gerrit-Change-Number: 29668 Gerrit-PatchSet: 8 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: nb/intel/sandybridge/acpi: Add RMRR entry for iGPU
by Nico Huber (Code Review) 24 Jan '19

24 Jan '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29668 ) Change subject: nb/intel/sandybridge/acpi: Add RMRR entry for iGPU ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/29668/7/src/northbridge/intel/sandybridge/a… File src/northbridge/intel/sandybridge/acpi.c: https://review.coreboot.org/#/c/29668/7/src/northbridge/intel/sandybridge/a… PS7, Line 101: current += acpi_create_igfx_rmrr(current); > what happens on error if acpi_create_igfx_rmrr returns 0 ? […] Hmmm, no, it wouldn't (and shouldn't, too complex). If any of the errors in acpi_create_igfx_rmrr() happen, we are screwed anyway, but we should handle it more gracefully. -- To view, visit https://review.coreboot.org/c/coreboot/+/29668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I391d0a5f1ea14bc90fbacabce41dddfa12b5bb0d Gerrit-Change-Number: 29668 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Thu, 24 Jan 2019 09:43:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: riscv: add SMP support for exception handling
by Xiang Wang (Code Review) 24 Jan '19

24 Jan '19

Xiang Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/27441 ) Change subject: riscv: add SMP support for exception handling ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/27441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I053138c6d778413d125e91689da330b1ac857027 Gerrit-Change-Number: 27441 Gerrit-PatchSet: 6 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Shawn C <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: riscv: temporarily block multiple-threads
by Xiang Wang (Code Review) 24 Jan '19

24 Jan '19

Xiang Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/27358 ) Change subject: riscv: temporarily block multiple-threads ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/27358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0eeed51e0952c66a9a9f25a90105fe471ffa70e Gerrit-Change-Number: 27358 Gerrit-PatchSet: 30 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Shawn C <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: riscv: update delegate
by Xiang Wang (Code Review) 24 Jan '19

24 Jan '19

Xiang Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/28356 ) Change subject: riscv: update delegate ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/28356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If08220fdbb483ebf323f481ab0c7b012ac7a196c Gerrit-Change-Number: 28356 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn C <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Philipp Hug <philipp(a)hug.cx> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: riscv: fix smp_pause
by Xiang Wang (Code Review) 24 Jan '19

24 Jan '19

Xiang Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30032 ) Change subject: riscv: fix smp_pause ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/30032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5ab683bc4c96fd8a32768d49ad4ebf8cab1d1a6 Gerrit-Change-Number: 30032 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Shawn C <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: mb/ocp/wedge100s: Add SuperIO support
by Patrick Rudolph (Code Review) 24 Jan '19

24 Jan '19

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30961 Change subject: mb/ocp/wedge100s: Add SuperIO support ...................................................................... mb/ocp/wedge100s: Add SuperIO support * Enable COM1, COM2, PMC1 and PMC2 TODO: Look at additional configuration and EC space. Tested on wedge100s. The serial works without CONFIG_CONSOLE_SERIAL. Change-Id: Id139bf243c7e7ac3e51a0ddb19d2396452341e29 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/ocp/wedge100s/Kconfig M src/mainboard/ocp/wedge100s/devicetree.cb 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/30961/1 diff --git a/src/mainboard/ocp/wedge100s/Kconfig b/src/mainboard/ocp/wedge100s/Kconfig index ce9c097..6224340 100644 --- a/src/mainboard/ocp/wedge100s/Kconfig +++ b/src/mainboard/ocp/wedge100s/Kconfig @@ -16,6 +16,7 @@ select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 select DRIVERS_UART_8250IO + select SUPERIO_ITE_IT8528E config VBOOT select VBOOT_VBNV_CMOS diff --git a/src/mainboard/ocp/wedge100s/devicetree.cb b/src/mainboard/ocp/wedge100s/devicetree.cb index 3d66d0d..bbea89e 100644 --- a/src/mainboard/ocp/wedge100s/devicetree.cb +++ b/src/mainboard/ocp/wedge100s/devicetree.cb @@ -11,6 +11,39 @@ chip drivers/pc80/tpm device pnp 0c31.0 on end end + chip superio/ite/it8528e + # COM1, routed to COM-e header + device pnp 6e.1 on + io 0x60 = 0x3f8 + irq 0x70 = 4 + end + # COM2, routed to COM-e header + device pnp 6e.2 on + io 0x60 = 0x2f8 + irq 0x70 = 3 + end + device pnp 6e.4 off end + device pnp 6e.5 off end + device pnp 6e.6 off end + device pnp 6e.a off end + device pnp 6e.f off end + device pnp 6e.10 off end + device pnp 6e.11 on + io 0x60 = 0x62 + io 0x62 = 0x66 + irq 0x70 = 1 + end + device pnp 6e.12 on + io 0x60 = 0x68 + io 0x62 = 0x6c + irq 0x70 = 1 + end + device pnp 6e.13 off end + device pnp 6e.14 off end + device pnp 6e.17 off end + device pnp 6e.18 off end + device pnp 6e.19 off end + end #superio/ite/it8528e end # LPC Bridge device pci 1f.2 on end # SATA Controller device pci 1f.3 on end # SMBus Controller -- To view, visit https://review.coreboot.org/c/coreboot/+/30961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id139bf243c7e7ac3e51a0ddb19d2396452341e29 Gerrit-Change-Number: 30961 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

3 9

Change in ...coreboot[master]: google/kukui: Move some initialization from bootblock to verstage.
by Hung-Te Lin (Code Review) 24 Jan '19

24 Jan '19

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30331 ) Change subject: google/kukui: Move some initialization from bootblock to verstage. ...................................................................... Patch Set 11: Code-Review+1 @julius? -- To view, visit https://review.coreboot.org/c/coreboot/+/30331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9968d88c54283ef334d1ab975086d4adb3363bd6 Gerrit-Change-Number: 30331 Gerrit-PatchSet: 11 Gerrit-Owner: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: Chun-ta Lin <itspeter(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 24 Jan 2019 08:46:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: google/kukui: Move some initialization from bootblock to verstage.
by You-Cheng Syu (Code Review) 24 Jan '19

24 Jan '19

You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30331 ) Change subject: google/kukui: Move some initialization from bootblock to verstage. ...................................................................... Patch Set 11: (2 comments) https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/Makefil… File src/mainboard/google/kukui/Makefile.inc: https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/Makefil… PS10, Line 10: mainboard.c > Usually mainboard. […] Done https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/mainboa… File src/mainboard/google/kukui/mainboard.c: https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/mainboa… PS10, Line 70: /* Turn on real eMMC. */ : gpio_output(BOOTBLOCK_EN_L, 1); > Can we move this to before mt8183_early_init, or at least before setup_chromeos_gpios? And change th […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/30331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9968d88c54283ef334d1ab975086d4adb3363bd6 Gerrit-Change-Number: 30331 Gerrit-PatchSet: 11 Gerrit-Owner: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: Chun-ta Lin <itspeter(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: You-Cheng Syu <youcheng(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 24 Jan 2019 08:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019