coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: src/mb/google/hatch: disable HECI
by Furquan Shaikh (Code Review) 25 Jan '19

25 Jan '19

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31097 ) Change subject: src/mb/google/hatch: disable HECI ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/31097/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31097/1//COMMIT_MSG@7 PS1, Line 7: disable HECI Looks like there is bug currently which causes a boot hang if heci is disabled. Shelley just … [View More]

1 0

Change in ...coreboot[master]: src/soc/intel/cnl/chip.h: Fix preprocessor condition
by Furquan Shaikh (Code Review) 25 Jan '19

25 Jan '19

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31095 ) Change subject: src/soc/intel/cnl/chip.h: Fix preprocessor condition ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/31095/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31095/2//COMMIT_MSG@10 PS2, Line 10: conditional preprocessor directive, but its condition was incorrect. Can … [View More]

1 0

Change in ...coreboot[master]: lenovo/x230: introduce FHD variant
by Angel Pons (Code Review) 25 Jan '19

25 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 6: > Patch Set 6: > > > Patch Set 6: > > > > > Patch Set 6: > > > > > > > Patch Set 6: > > > > > > > > > Patch Set 6: > > > > > > > > > > > Patch Set 6: … [View More]-Code-Review > > > > > > > > > > > > > On the device with FHD-mod booting works as well, but graphical output of coreboot, seabios and grub is only visible if an additional external monitor is attached via VGA or DP. The internal FHD panel becomes active as soon as the linux kernel takes over. Right now I am unsure if this is due to misconfiguration on my part or if coreboot/libgfxinit needs to be told to use eDP1 for output on modded devices. Hints for further tests appreciated. > > > > > > > > > > > > Can you test revision 5 of the patch? I haven't looked into libgfxinit, so it might be that GFX_GMA_INTERNAL_IS_LVDS is used to determine which backlight interface to use > > > > > > > > > > I have tried reversion 5 without success > > > > > After reading Documentation/gfx/libgfxinit.md I also tried explicitly declaring FX_GMA_INTERNAL_IS_EDP (which should not be necessary since it is the default) > > > > > I also tried moving DP3 to the top of the list of ports to probe in src/mainboard/lenovo/x230/variants/x230_fhd/gma-mainboard.ads but that did not change anything either > > > > > > > > > > any other ideas? > > > > > > > > How did you download revision 5? > > > > > > git reset origin/master --hard > > > git pull > > > git fetch https://review.coreboot.org/coreboot refs/changes/50/28950/5 && git cherry-pick FETCH_HEAD > > > > Right, so this cherry-picks the change on top of current master, which isn't the same than "master patchset 5 was created on". Could you please repeat the test running this command before fetching and cherry-picking? > > > > git checkout 034e5e6f > > same result. LVDS is disabled and full functionality of FHD-panel in linux (as intended), but no coreboot console output on the FHD-panel during boot until kernel takes over. Could it be that the backlight is not lighting up? I am a bit out of ideas. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 6 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kilian Neuner <cb(a)9-r.net> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 19:27:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment [View Less]

1 0

Change in ...coreboot[master]: src/mb/google/hatch: disable HECI
by Angel Pons (Code Review) 25 Jan '19

25 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31097 ) Change subject: src/mb/google/hatch: disable HECI ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/31097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: … [View More]

1 0

Change in ...coreboot[master]: sdm845: Add USB support on cheza platform
by Julius Werner (Code Review) 25 Jan '19

25 Jan '19

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25213 ) Change subject: sdm845: Add USB support on cheza platform ...................................................................... Patch Set 65: (3 comments) https://review.coreboot.org/#/c/25213/64/src/mainboard/google/cheza/romstag… File src/mainboard/google/cheza/romstage.c: https://review.coreboot.org/#/c/25213/64/src/mainboard/google/cheza/romstag… PS64, Line 22: these resets … [View More] : * off early so they get > "these resets" here i mean is core+ PHYs resets which is plural here. […] Oh, right, okay, makes sense. https://review.coreboot.org/#/c/25213/64/src/soc/qualcomm/sdm845/usb.c File src/soc/qualcomm/sdm845/usb.c: https://review.coreboot.org/#/c/25213/64/src/soc/qualcomm/sdm845/usb.c@585 PS64, Line 585: int serdes_tbl_num; > we can not do this as we have differences in all the regsiter sets(serdes, tx,rx,pcs). […] Hmmm... okay, crap, I didn't see all those other differences. Then let's maybe follow a different strategy. Keep the lists separate as you have them right now, but also split up the usb_host_base array into two independent structures, and then write independent entry functions like this: static struct usb_dwc3_cfg usb_port0 = { .usb_host_dwc3 = (void *)USB_HOST0_DWC3_BASE, ... }; static struct usb_dwc3_cfg usb_port1 = { .usb_host_dwc3 = (void *)USB_HOST1_DWC3_BASE, ... }; void reset_usb0(void) { reset_usb(&usb_port0, 0); } void reset_usb0(void) { reset_usb(&usb_port1, 1); } void setup_usb0(void) { setup_usb(&usb_port0, 0); } void setup_usb0(void) { setup_usb(&usb_port1, 1); } The advantage of this is that it allows the linker to eliminate the port data (including all those tables) for ports that are not being used, so it will at least allow us to save all the port0 stuff on Cheza. https://review.coreboot.org/#/c/25213/64/src/soc/qualcomm/sdm845/usb.c@824 PS64, Line 824: USB3_PCS_PHYSTATUS)); > Yes, SW wait untill phystatus become 0. […] Okay, thanks, just wanted to double-check. ;) I (think I?) don't have access to your programming guide so I can't confirm these independently. -- To view, visit https://review.coreboot.org/c/coreboot/+/25213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I475a7757239acb8ef22a4d61afd59b304a7f0acc Gerrit-Change-Number: 25213 Gerrit-PatchSet: 65 Gerrit-Owner: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: Ciluveru chandana kishori <cchiluve(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Chandana Kishori Chiluveru <cchiluve(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 19:21:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Chandana Kishori Chiluveru <cchiluve(a)qualcomm.corp-partner.google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment [View Less]

1 0

Change in ...coreboot[master]: src/soc/intel/cnl/chip.h: Fix preprocessor condition
by Angel Pons (Code Review) 25 Jan '19

25 Jan '19

Hello Patrick Rudolph, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31095 to look at the new patch set (#2). Change subject: src/soc/intel/cnl/chip.h: Fix preprocessor condition ...................................................................... src/soc/intel/cnl/chip.h: Fix preprocessor condition Commit dc666f5 (soc/intel/cannonlake: Change in SaGv options) added a conditional preprocessor directive, but its condition … [View More]

1 0

Change in ...coreboot[master]: src/soc/intel/cnl/chip.h: Fix preprocessor condition
by Angel Pons (Code Review) 25 Jan '19

25 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31095 ) Change subject: src/soc/intel/cnl/chip.h: Fix preprocessor condition ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/31095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master … [View More]

1 0

Change in ...coreboot[master]: mb/google/sarien: Enable GPIO ACPI pin for Chrome OS
by Duncan Laurie (Code Review) 25 Jan '19

25 Jan '19

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31081 Change subject: mb/google/sarien: Enable GPIO ACPI pin for Chrome OS ...................................................................... mb/google/sarien: Enable GPIO ACPI pin for Chrome OS Enable the option to have the Chrome OS ACPI GPIO table use the GPIO ACPI pin number rather than the pad number. This is necessary because the OS GPIO driver does not have a contiguous number space due … [View More]

1 1

Change in ...coreboot[master]: mb/clevo/n130wu: Add mainboard
by build bot (Jenkins) (Code Review) 25 Jan '19

25 Jan '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28640 ) Change subject: mb/clevo/n130wu: Add mainboard ...................................................................... Patch Set 73: (2 comments) https://review.coreboot.org/#/c/28640/73/src/mainboard/clevo/n130wu/gpio.h File src/mainboard/clevo/n130wu/gpio.h: https://review.coreboot.org/#/c/28640/73/src/mainboard/clevo/n130wu/gpio.h@… PS73, Line 168: /* I2C5_SDA/ISH_I2C2_SDA */ … [View More]

1 0

Change in ...coreboot[master]: mb/clevo/n130wu: Add mainboard
by Felix Singer (Code Review) 25 Jan '19

25 Jan '19

Hello Paul Menzel, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/28640 to look at the new patch set (#73). Change subject: mb/clevo/n130wu: Add mainboard ...................................................................... mb/clevo/n130wu: Add mainboard Devices: - N130WU / N131WU Working: - Compiling - Seabios, iPXE - NVMe, SATA3, booting from SSD … [View More]into Arch Linux - USB2, USB3 - Graphics, mDP, HDMI - Sound - Webcam - WLAN, LAN, Bluetooth, LTE - Keyboard, touchpad - TPM - flashrom support; reading / flashing from Linux WIP: - Documentation Not working: - EC ACPI - Thunderbolt Untested: - Virtualization Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513 Signed-off-by: Felix Singer <migy(a)darmstadt.ccc.de> --- A Documentation/mainboard/clevo/index.md A Documentation/mainboard/clevo/n130wu/index.md A Documentation/mainboard/clevo/n130wu/n130wu_overview.jpg M Documentation/mainboard/index.md A src/mainboard/clevo/Kconfig A src/mainboard/clevo/Kconfig.name A src/mainboard/clevo/n130wu/Kconfig A src/mainboard/clevo/n130wu/Kconfig.name A src/mainboard/clevo/n130wu/Makefile.inc A src/mainboard/clevo/n130wu/acpi/ec.asl A src/mainboard/clevo/n130wu/acpi/superio.asl A src/mainboard/clevo/n130wu/acpi_tables.c A src/mainboard/clevo/n130wu/board_info.txt A src/mainboard/clevo/n130wu/dsdt.asl A src/mainboard/clevo/n130wu/gpio.h A src/mainboard/clevo/n130wu/hda_verb.c A src/mainboard/clevo/n130wu/pei_data.c A src/mainboard/clevo/n130wu/pei_data.h A src/mainboard/clevo/n130wu/ramstage.c A src/mainboard/clevo/n130wu/romstage.c A src/mainboard/clevo/n130wu/variants/n13xwu/data.vbt A src/mainboard/clevo/n130wu/variants/n13xwu/devicetree.cb 22 files changed, 926 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/28640/73 -- To view, visit https://review.coreboot.org/c/coreboot/+/28640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513 Gerrit-Change-Number: 28640 Gerrit-PatchSet: 73 Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Shaleen jain <shaleen(a)jain.sh> Gerrit-MessageType: newpatchset [View Less]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019