coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: poppy: switch to mipi_camera driver
by Matt Delco (Code Review) 30 Jan '19

30 Jan '19

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31168 Change subject: poppy: switch to mipi_camera driver ...................................................................... poppy: switch to mipi_camera driver Replaced asl files with use of devicetree configuration that utilizes the mipi_camera driver. BUG=None BRANCH=None TEST=Verified still compiles. Change-Id: I48ce695bab43b2ae50a8a52e4dad0ddc0171c7c2 Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/baseboard/devicetree.cb D src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl D src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl D src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl D src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl 7 files changed, 66 insertions(+), 373 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/31168/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index d57fa38..ff6929b 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -161,6 +161,7 @@ select DRIVERS_I2C_MAX98927 select NO_FADT_8042 select VARIANT_HAS_CAMERA_ACPI + select VARIANT_HAS_CAMERA_ACPI select MAINBOARD_HAS_I2C_TPM_CR50 config VARIANT_SPECIFIC_OPTIONS_NAMI diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index ad1e628..2aee70b 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -282,9 +282,22 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_IMGU" + device pci 05.0 on end + end device pci 14.0 on end # USB xHCI device pci 14.1 on end # USB xDCI (OTG) device pci 14.2 on end # Thermal Subsystem + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_CIO2" + register "cio2_num_ports" = "2" + register "cio2_lanes_used[0]" = "4" + register "cio2_lane_endpoint[0]" = ""\\_SB.PCI0.I2C2.CAM0"" + register "cio2_lanes_used[1]" = "2" + register "cio2_lane_endpoint[1]" = ""\\_SB.PCI0.I2C4.CAM1"" + device pci 14.3 on end + end device pci 15.0 on chip drivers/i2c/generic register "hid" = ""ELAN0001"" @@ -317,7 +330,43 @@ device i2c 50 on end end end # I2C #1 - device pci 15.2 on end # I2C #2 + device pci 15.2 on + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "acpi_hid" = ""OVTID858"" + register "chip_name" = ""OV 13858 Camera"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.OVTH"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.OVTH"" + register "vcm_address" = "0x0C" + register "rom_address" = "0x50" # original doesn't specify + register "ssdb.sensor_card_sku" = "0x50" # original doesn't specify + register "ssdb.rom_type" = "11" # 24c16, original uses 8 + register "ssdb.vcm_type" = "2" # dw9714, original uses 3 + register "num_freq_entries" = "2" + register "link_freq[0]" = "540000000" + register "link_freq[1]" = "270000000" + device i2c 0x10 on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + register "chip_name" = ""GT24C16S/CAT24C16"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" # use CAM0? + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.NVMP"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.NVMP"" + register "nvm_size" = "2048" + device i2c 0x50 on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_VCM" + register "chip_name" = ""Dongwoon AF DAC"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" # use CAM0? + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.VCMP"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.VCMP"" + register "vcm_compat" = ""dongwoon,dw9714"" + device i2c 0xc on end + end + end # I2C #2 device pci 15.3 on chip drivers/i2c/hid register "generic.hid" = ""WCOM50C1"" @@ -372,7 +421,21 @@ device i2c 13 on end end end # I2C #5 - device pci 19.2 on end # I2C #4 + device pci 19.2 on + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "acpi_hid" = ""INT3479"" + register "chip_name" = ""OV 5670 Camera"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.OVFI"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.OVFI"" + register "ssdb.sensor_card_sku" = "0x50" + register "ssdb.link_used" = "1" + register "num_freq_entries" = "1" + register "link_freq[0]" = "422400000" + device i2c 0x36 on end + end + end # I2C #4 device pci 1c.0 on chip drivers/intel/wifi register "wake" = "GPE0_DW0_00" diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl deleted file mode 100644 index 5bb8df5..0000000 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl +++ /dev/null @@ -1,169 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.I2C2) -{ - Device (CAM0) - { - Name (_HID, "OVTID858") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "OV 13858 Camera") /* _DDN: DOS Device Name */ - Name (CAMD, 0x02) - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_DEP, Package() { \_SB.PCI0.I2C2.PMIC }) - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C2", - 0x00, ResourceConsumer, , - ) - }) - - Name (_PR0, Package () { ^^I2C2.PMIC.OVTH }) - Name (_PR3, Package () { ^^I2C2.PMIC.OVTH }) - - /* Port0 of CAM0 is connected to port0 of CIO2 device */ - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - }, - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "clock-frequency", 19200000 }, - Package () { "lens-focus", - Package () { \_SB.PCI0.I2C2.VCM0 } - } - } - }) - - Name (PRT0, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", - Package () { 1, 2, 3, 4 } - }, - Package () { "link-frequencies", - Package() { 540000000, 270000000 } - }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.CIO2, 0, 0 } - }, - } - }) - - Method (SSDB, 0, Serialized) - { - Return (Buffer (0x5E) - { - /* 0000 */ 0x00, 0x50, 0x00, 0x00, 0x00, 0x00,0x00, 0x00, - /* 0008 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0010 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0018 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 0x00, 0x00, - /* 0020 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0028 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0030 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0038 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0040 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0048 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x08, 0x03, - /* 0050 */ 0x09, 0x00, 0x02, 0x01, 0x00, 0x01, 0x00, 0x36, - /* 0058 */ 0x6E, 0x01, 0x00, 0x00, 0x00, 0x00 - }) - } - } - - Device (VCM0) - { - Name (_HID, "PRP0001") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ - Name (CAMD, 0x03) - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_DEP, Package() { \_SB.PCI0.I2C2.PMIC }) - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x000C, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C2", - 0x00, ResourceConsumer, , - ) - }) - - Name (_DSD, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "compatible", "dongwoon,dw9714" }, - } - }) - - Name (_PR0, Package () { ^PMIC.VCMP }) - Name (_PR3, Package () { ^PMIC.VCMP }) - } - - Device (NVM0) - { - Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "GT24C16S/CAT24C16") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_DEP, Package() { \_SB.PCI0.I2C2.PMIC }) - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0050, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C2", - 0x00, ResourceConsumer, ,) - }) - - Name (_PR0, Package () { ^PMIC.NVMP }) - Name (_PR3, Package () { ^PMIC.NVMP }) - - Name (_DSD, Package () - { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "size", 2048 }, - Package () { "pagesize", 1 }, - Package () { "read-only", 1 }, - } - }) - } -} diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl deleted file mode 100644 index d7640b2..0000000 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl +++ /dev/null @@ -1,101 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.I2C4) -{ - Device (CAM1) - { - Name (_HID, "INT3479") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "OV 5670 Camera") /* _DDN: DOS Device Name */ - Name (CAMD, 0x02) - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_DEP, Package() { \_SB.PCI0.I2C2.PMIC }) - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0036, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C4", - 0x00, ResourceConsumer, , - ) - }) - - Name (_PR0, Package () { ^^I2C2.PMIC.OVFI }) - Name (_PR3, Package () { ^^I2C2.PMIC.OVFI }) - - /* Port0 of CAM1 is connected to port1 of CIO2 device */ - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - }, - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "clock-frequency", 19200000 }, - } - }) - - Name (PRT0, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", - Package () { 1, 2 } - }, - Package () { "link-frequencies", - Package() { 422400000 } - }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.CIO2, 1, 0 } - }, - } - }) - - Method (SSDB, 0, Serialized) - { - Return (Buffer (0x5E) - { - /* 0000 */ 0x00, 0x50, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0008 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0010 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0018 */ 0x00, 0x00, 0x00, 0x00, 0x01, 0x02, 0x00, 0x00, - /* 0020 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0028 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0030 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0038 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0040 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - /* 0048 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x08, 0x03, - /* 0050 */ 0x09, 0x00, 0x02, 0x01, 0x00, 0x01, 0x00, 0x36, - /* 0058 */ 0x6E, 0x01, 0x00, 0x00, 0x00, 0x00 - }) - } - } -} diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl index 5e34ba4..8bde813 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl @@ -13,8 +13,4 @@ * GNU General Public License for more details. */ -#include "ipu_mainboard.asl" -#include "ipu_endpoints.asl" #include "camera_pmic.asl" -#include "cam0.asl" -#include "cam1.asl" diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl deleted file mode 100644 index 9d6de60..0000000 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl +++ /dev/null @@ -1,46 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.CIO2) -{ - /* Define two endpoints for CIO2 device where endpoint of port0 - is connected to CAM0 and endpoint of port1 is connected to CAM1. - variant of this poppy baseboard can define their own endpoints (max 2) - with custom remote-endpoint */ - - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", Package () { 1, 2, 3, 4 } }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.I2C2.CAM0, 0, 0 } - }, - } - }) - - Name (EP10, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", Package () { 1, 2 } }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.I2C4.CAM1, 0, 0 } - }, - } - }) -} diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl deleted file mode 100644 index 6f4a87b..0000000 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl +++ /dev/null @@ -1,51 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2017 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.CIO2) -{ - /* Define two ports for CIO2 device where endpoint of port0 - is connected to CAM0 and endpoint of port1 is connected to CAM1 - Endpoints can be customized by the variants of the based board */ - - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - Package () { "port1", "PRT1" }, - } - }) - - Name (PRT0, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, /* csi 0 */ - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - - Name (PRT1, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 1 }, /* csi 1 */ - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP10" }, - } - }) -} -- To view, visit https://review.coreboot.org/c/coreboot/+/31168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48ce695bab43b2ae50a8a52e4dad0ddc0171c7c2 Gerrit-Change-Number: 31168 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: soraka: switch to mipi_camera driver
by Matt Delco (Code Review) 30 Jan '19

30 Jan '19

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31167 Change subject: soraka: switch to mipi_camera driver ...................................................................... soraka: switch to mipi_camera driver Replaced asl files with use of devicetree configuration that utilizes the mipi_camera driver. BUG=None BRANCH=None TEST=Verified still compiles. Change-Id: I15111972aa153c64fd96c213481eb79e3fda1ed9 Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/google/poppy/variants/soraka/include/variant/acpi/camera.asl 3 files changed, 67 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/31167/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 162f049..d57fa38 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -210,6 +210,7 @@ select DRIVERS_I2C_MAX98927 select NO_FADT_8042 select VARIANT_HAS_CAMERA_ACPI + select DRIVERS_INTEL_MIPI_CAMERA select MAINBOARD_HAS_I2C_TPM_CR50 config VBOOT diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index ddf74a1..db37066 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -283,9 +283,22 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_IMGU" + device pci 05.0 on end + end device pci 14.0 on end # USB xHCI device pci 14.1 on end # USB xDCI (OTG) device pci 14.2 on end # Thermal Subsystem + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_CIO2" + register "cio2_num_ports" = "2" + register "cio2_lanes_used[0]" = "4" + register "cio2_lane_endpoint[0]" = ""\\_SB.PCI0.I2C2.CAM0"" + register "cio2_lanes_used[1]" = "2" + register "cio2_lane_endpoint[1]" = ""\\_SB.PCI0.I2C4.CAM1"" + device pci 14.3 on end + end device pci 15.0 on chip drivers/i2c/hid register "generic.hid" = ""WCOMCOHO"" @@ -310,7 +323,43 @@ device i2c 50 on end end end # I2C #1 - device pci 15.2 on end # I2C #2 + device pci 15.2 on + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "acpi_hid" = ""OVTID858"" + register "chip_name" = ""OV 13858 Camera"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.OVTH"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.OVTH"" + register "vcm_address" = "0x0C" + register "rom_address" = "0x50" # original doesn't specify + register "ssdb.sensor_card_sku" = "0x50" # original doesn't specify + register "ssdb.rom_type" = "11" # 24c16, original uses 8 + register "ssdb.vcm_type" = "2" # dw9714, original uses 3 + register "num_freq_entries" = "2" + register "link_freq[0]" = "540000000" + register "link_freq[1]" = "270000000" + device i2c 0x10 on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + register "chip_name" = ""GT24C16S/CAT24C16"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" # use CAM0? + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.NVMP"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.NVMP"" + register "nvm_size" = "2048" + device i2c 0x50 on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_VCM" + register "chip_name" = ""Dongwoon AF DAC"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" # use CAM0? + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.VCMP"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.VCMP"" + register "vcm_compat" = ""dongwoon,dw9714"" + device i2c 0xc on end + end + end # I2C #2 device pci 15.3 off end # I2C #3 device pci 16.0 on end # Management Engine Interface 1 device pci 16.1 off end # Management Engine Interface 2 @@ -347,7 +396,21 @@ device i2c 13 on end end end # I2C #5 - device pci 19.2 on end # I2C #4 + device pci 19.2 on + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "acpi_hid" = ""INT3479"" + register "chip_name" = ""OV 5670 Camera"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.OVFI"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.OVFI"" + register "ssdb.sensor_card_sku" = "0x50" + register "ssdb.link_used" = "1" + register "num_freq_entries" = "1" + register "link_freq[0]" = "422400000" + device i2c 0x36 on end + end + end # I2C #4 device pci 1c.0 on chip drivers/intel/wifi register "wake" = "GPE0_PCI_EXP" diff --git a/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/camera.asl b/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/camera.asl index 45522f9..9ddb22d 100644 --- a/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/camera.asl +++ b/src/mainboard/google/poppy/variants/soraka/include/variant/acpi/camera.asl @@ -13,4 +13,4 @@ * GNU General Public License for more details. */ -#include <baseboard/acpi/camera.asl> +#include <baseboard/acpi/camera_pmic.asl> -- To view, visit https://review.coreboot.org/c/coreboot/+/31167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15111972aa153c64fd96c213481eb79e3fda1ed9 Gerrit-Change-Number: 31167 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: nocturne: switch to mipi_camera driver
by Matt Delco (Code Review) 30 Jan '19

30 Jan '19

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31166 Change subject: nocturne: switch to mipi_camera driver ...................................................................... nocturne: switch to mipi_camera driver Replaced asl files with use of devicetree configuration that utilizes the mipi_camera driver. BUG=None BRANCH=None TEST=Verified still compiles. Change-Id: Ic1b8aa435c27a9d1bf825158a02ba31d62472765 Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/nocturne/devicetree.cb D src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl D src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/camera.asl D src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/ipu_endpoints.asl D src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/ipu_mainboard.asl 7 files changed, 158 insertions(+), 432 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/31166/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 77a1b8e..162f049 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -193,6 +193,7 @@ select MAINBOARD_HAS_SPI_TPM_CR50 select NO_FADT_8042 select VARIANT_HAS_CAMERA_ACPI + select DRIVERS_INTEL_MIPI_CAMERA select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config VARIANT_SPECIFIC_OPTIONS_RAMMUS diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 76b9773..8471134 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -280,7 +280,10 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device - + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_IMGU" + device pci 05.0 on end + end device pci 14.0 on chip drivers/usb/acpi register "desc" = ""Root Hub"" @@ -312,6 +315,15 @@ end # USB xHCI device pci 14.1 on end # USB xDCI (OTG) device pci 14.2 on end # Thermal Subsystem + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_CIO2" + register "cio2_num_ports" = "2" + register "cio2_lanes_used[0]" = "4" + register "cio2_lane_endpoint[0]" = ""\\_SB.PCI0.I2C3.CAM0"" + register "cio2_lanes_used[1]" = "4" + register "cio2_lane_endpoint[1]" = ""\\_SB.PCI0.I2C5.CAM1"" + device pci 14.3 on end + end device pci 15.0 on chip drivers/i2c/hid register "generic.hid" = ""WCOM50C1"" @@ -362,7 +374,32 @@ end end # I2C #1 device pci 15.2 off end # I2C #2 - device pci 15.3 on end # I2C #3 - Camera + device pci 15.3 on + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "acpi_hid" = ""SONY319A"" + register "chip_name" = ""Sony IMX319 Camera"" + register "pr0" = ""FCPR"" + register "pr3" = ""FCPR"" + register "rom_address" = "0x50" + register "ssdb.sensor_card_sku" = "0x20" + register "ssdb.rom_type" = "9" # m24c64 + register "use_pld" = "1" + register "num_freq_entries" = "1" + register "link_freq[0]" = "360000000" + device i2c 0x10 on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + register "chip_name" = ""M24C64S"" + register "dep" = ""CAM0"" + register "pr0" = ""FCPR"" + register "pr3" = ""FCPR"" + register "nvm_size" = "8192" + register "nvm_width" = "16" + device i2c 0x50 on end + end + end # I2C #3 - Camera device pci 16.0 on end # Management Engine Interface 1 device pci 16.1 off end # Management Engine Interface 2 device pci 16.2 off end # Management Engine IDE-R @@ -401,6 +438,48 @@ register "reg_sar_ctrl2" = "0x3c" device i2c 28 on end end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "acpi_hid" = ""SONY355A"" + register "chip_name" = ""Sony IMX355A Camera"" + register "sensor_name" = ""50-704GVGEA8"" + register "pr0" = ""RCPR"" + register "pr3" = ""RCPR"" + register "vcm_address" = "0x0c" + register "rom_address" = "0x51" + register "ssdb.sensor_card_sku" = "0x20" + register "ssdb.link_used" = "1" + register "ssdb.rom_type" = "9" + register "ssdb.vcm_type" = "9" + register "use_pld" = "1" + register "pld.panel" = "PLD_PANEL_BACK" + register "pld.horizontal_position" = "PLD_HORIZONTAL_POSITION_RIGHT" + register "num_freq_entries" = "1" + register "link_freq[0]" = "360000000" + device i2c 0x1a on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + register "acpi_uid" = "1" + register "chip_name" = ""M24C64S"" + register "dep" = ""CAM1"" + register "pr0" = ""RCPR"" + register "pr3" = ""RCPR"" + register "nvm_size" = "8192" + register "nvm_width" = "16" + device i2c 0x51 on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_VCM" + register "acpi_uid" = "3" + register "acpi_name" = ""VCM1"" + register "chip_name" = ""AKM AF DAC"" + register "dep" = ""CAM1"" + register "pr0" = ""RCPR"" + register "pr3" = ""RCPR"" + register "vcm_compat" = ""asahi-kasei,ak7375"" + device i2c 0xc on end + end end # I2C #5 device pci 19.2 on chip drivers/i2c/max98373 diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl deleted file mode 100644 index 1213270..0000000 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl +++ /dev/null @@ -1,150 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.I2C3) -{ - PowerResource (FCPR, 0, 0) - { - Name (STA, 0) - Method (_ON, 0, Serialized) { - If (LEqual(STA, 0)) { - CTXS (GPIO_FCAM_RST_L) - STXS (GPIO_FCAM_PWR_EN) - STXS (GPIO_PCH_FCAM_CLK_EN) - Sleep (3) - STXS (GPIO_FCAM_RST_L) - - /* - * A delay of T7 (minimum of 5 ms) + T8 - * (max 5 ms + delay of coarse integration - * time value + 14 H, time for 14 horizontal - * lines) is needed to have the sensor ready - * for streaming, as soon as the power on - * sequence completes - */ - Sleep (11) - Store (1, STA) - } - } - Method (_OFF, 0, Serialized) { - If (LEqual(STA, 1)) { - CTXS (GPIO_PCH_FCAM_CLK_EN) - CTXS (GPIO_FCAM_RST_L) - CTXS (GPIO_FCAM_PWR_EN) - Store (0, STA) - } - } - Method (_STA, 0, NotSerialized) { - Return (STA) - } - } - - Device (CAM0) - { - Name (_HID, "SONY319A") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "Sony IMX319 Camera") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C3", - 0x00, ResourceConsumer, , - ) - }) - - Name (_PR0, Package () { FCPR }) - Name (_PR3, Package () { FCPR }) - - /* Port0 of CAM0 is connected to port0 of CIO2 device */ - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - }, - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "clock-frequency", 19200000 }, - } - }) - - Name (PRT0, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", - Package () { 1, 2, 3, 4 } - }, - Package () { "link-frequencies", - Package() { 482400000 } - }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.CIO2, 0, 0 } - }, - } - }) - } - - Device (NVM0) - { - Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0050, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C3", - 0x00, ResourceConsumer, ,) - }) - Name (_DEP, Package () { CAM0 }) - - Name (_PR0, Package () { FCPR }) - Name (_PR3, Package () { FCPR }) - - Name (_DSD, Package () - { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "size", 8192 }, - Package () { "pagesize", 1 }, - Package () { "read-only", 1 }, - Package () { "address-width", 16 }, - } - }) - } -} diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl deleted file mode 100644 index 19146dc..0000000 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl +++ /dev/null @@ -1,184 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.I2C5) -{ - PowerResource (RCPR, 0, 0) - { - Name (STA, 0) - Method (_ON, 0, Serialized) { - If (LEqual(STA, 0)) { - CTXS (GPIO_RCAM_RST_L) - STXS (GPIO_RCAM_PWR_EN) - STXS (GPIO_PCH_RCAM_CLK_EN) - Sleep (3) - STXS (GPIO_RCAM_RST_L) - - /* - * A delay of T7 (minimum of 10 ms) + T8 - * (max 1.4 ms + delay of coarse integration - * time value) is needed to have the sensor - * ready for streaming, as soon as the power - * on sequence completes - */ - Sleep (12) - Store (1, STA) - } - } - Method (_OFF, 0, Serialized) { - If (LEqual(STA, 1)) { - CTXS (GPIO_PCH_RCAM_CLK_EN) - CTXS (GPIO_RCAM_RST_L) - CTXS (GPIO_RCAM_PWR_EN) - Store (0, STA) - } - } - Method (_STA, 0, NotSerialized) { - Return (STA) - } - } - - Device (CAM1) - { - Name (_HID, "SONY355A") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "SONY IMX355A Camera") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x001A, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C5", - 0x00, ResourceConsumer, , - ) - }) - - Name (_PR0, Package () { RCPR }) - Name (_PR3, Package () { RCPR }) - - /* Port0 of CAM1 is connected to port1 of CIO2 device */ - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - }, - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "clock-frequency", 19200000 }, - Package () { "lens-focus", - Package () { \_SB.PCI0.I2C5.VCM1 } - } - } - }) - - Name (PRT0, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", - Package () { 1, 2, 3, 4 } - }, - Package () { "link-frequencies", - Package() { 360000000 } - }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.CIO2, 1, 0 } - }, - } - }) - } - - Device (VCM1) - { - Name (_HID, "PRP0001") /* _HID: Hardware ID */ - Name (_UID, 3) /* _UID: Unique ID */ - Name (_DDN, "AKM AF DAC") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x000C, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C5", - 0x00, ResourceConsumer, , - ) - }) - - Name (_DEP, Package() { CAM1 }) - - Name (_PR0, Package () { RCPR }) - Name (_PR3, Package () { RCPR }) - - Name (_DSD, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "compatible", "asahi-kasei,ak7375" }, - } - }) - } - - Device (NVM1) - { - Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, 1) /* _UID: Unique ID */ - Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0051, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C5", - 0x00, ResourceConsumer, ,) - }) - Name (_DEP, Package () { CAM1 }) - - Name (_PR0, Package () { RCPR }) - Name (_PR3, Package () { RCPR }) - - Name (_DSD, Package () - { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "size", 8192 }, - Package () { "pagesize", 1 }, - Package () { "read-only", 1 }, - Package () { "address-width", 16 }, - } - }) - } -} diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/camera.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/camera.asl index 7e63340..cbb086d 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/camera.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/camera.asl @@ -13,7 +13,79 @@ * GNU General Public License for more details. */ -#include "ipu_mainboard.asl" -#include "ipu_endpoints.asl" -#include "cam0.asl" -#include "cam1.asl" +Scope (\_SB.PCI0.I2C3) +{ + PowerResource (FCPR, 0, 0) + { + Name (STA, 0) + Method (_ON, 0, Serialized) { + If (LEqual(STA, 0)) { + CTXS (GPIO_FCAM_RST_L) + STXS (GPIO_FCAM_PWR_EN) + STXS (GPIO_PCH_FCAM_CLK_EN) + Sleep (3) + STXS (GPIO_FCAM_RST_L) + + /* + * A delay of T7 (minimum of 5 ms) + T8 + * (max 5 ms + delay of coarse integration + * time value + 14 H, time for 14 horizontal + * lines) is needed to have the sensor ready + * for streaming, as soon as the power on + * sequence completes + */ + Sleep (11) + Store (1, STA) + } + } + Method (_OFF, 0, Serialized) { + If (LEqual(STA, 1)) { + CTXS (GPIO_PCH_FCAM_CLK_EN) + CTXS (GPIO_FCAM_RST_L) + CTXS (GPIO_FCAM_PWR_EN) + Store (0, STA) + } + } + Method (_STA, 0, NotSerialized) { + Return (STA) + } + } +} + +Scope (\_SB.PCI0.I2C5) +{ + PowerResource (RCPR, 0, 0) + { + Name (STA, 0) + Method (_ON, 0, Serialized) { + If (LEqual(STA, 0)) { + CTXS (GPIO_RCAM_RST_L) + STXS (GPIO_RCAM_PWR_EN) + STXS (GPIO_PCH_RCAM_CLK_EN) + Sleep (3) + STXS (GPIO_RCAM_RST_L) + + /* + * A delay of T7 (minimum of 10 ms) + T8 + * (max 1.4 ms + delay of coarse integration + * time value) is needed to have the sensor + * ready for streaming, as soon as the power + * on sequence completes + */ + Sleep (12) + Store (1, STA) + } + } + Method (_OFF, 0, Serialized) { + If (LEqual(STA, 1)) { + CTXS (GPIO_PCH_RCAM_CLK_EN) + CTXS (GPIO_RCAM_RST_L) + CTXS (GPIO_RCAM_PWR_EN) + Store (0, STA) + } + } + Method (_STA, 0, NotSerialized) { + Return (STA) + } + } +} diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/ipu_endpoints.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/ipu_endpoints.asl deleted file mode 100644 index 7f6a4ef..0000000 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/ipu_endpoints.asl +++ /dev/null @@ -1,41 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.CIO2) -{ - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", Package () { 1, 2, 3, 4 } }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.I2C3.CAM0, 0, 0 } - }, - } - }) - - Name (EP10, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", Package () { 1, 2, 3, 4 } }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.I2C5.CAM1, 0, 0 } - }, - } - }) -} diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/ipu_mainboard.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/ipu_mainboard.asl deleted file mode 100644 index ec5347d..0000000 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/ipu_mainboard.asl +++ /dev/null @@ -1,51 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.CIO2) -{ - /* Define two ports for CIO2 device where endpoint of port0 - is connected to CAM0 and endpoint of port1 is connected to CAM1 */ - - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - Package () { "port1", "PRT1" }, - } - }) - - Name (PRT0, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, /* csi 0 */ - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - - Name (PRT1, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 1 }, /* csi 1 */ - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP10" }, - } - }) - -} -- To view, visit https://review.coreboot.org/c/coreboot/+/31166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1b8aa435c27a9d1bf825158a02ba31d62472765 Gerrit-Change-Number: 31166 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: nautilus: switch to mipi_camera driver
by Matt Delco (Code Review) 30 Jan '19

30 Jan '19

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31165 Change subject: nautilus: switch to mipi_camera driver ...................................................................... nautilus: switch to mipi_camera driver Replaced asl files with use of devicetree configuration that utilizes the mipi_camera driver. BUG=None BRANCH=None TEST=Verified still compiles. Change-Id: I01d382c7d87ea2f6967b03f86a91dce12b3c1f96 Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/nautilus/devicetree.cb D src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/camera.asl D src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_endpoints.asl D src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl 6 files changed, 48 insertions(+), 221 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31165/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index aa3f6e6..77a1b8e 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -178,6 +178,7 @@ select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 select VARIANT_HAS_CAMERA_ACPI + select DRIVERS_INTEL_MIPI_CAMERA select MAINBOARD_HAS_I2C_TPM_CR50 config VARIANT_SPECIFIC_OPTIONS_NOCTURNE diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index 37edd8a..20ac8bc 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -303,9 +303,20 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_IMGU" + device pci 05.0 on end + end device pci 14.0 on end # USB xHCI device pci 14.1 on end # USB xDCI (OTG) device pci 14.2 on end # Thermal Subsystem + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_CIO2" + register "cio2_num_ports" = "1" + register "cio2_lanes_used[0]" = "4" + register "cio2_lane_endpoint[0]" = ""\\_SB.PCI0.I2C2.CAM0"" + device pci 14.3 on end + end device pci 15.0 on chip drivers/i2c/hid register "generic.hid" = ""SYTS7813"" @@ -336,6 +347,42 @@ register "device_present_gpio" = "GPP_B20" device i2c 28 on end end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "acpi_hid" = ""SONY258A"" + register "chip_name" = ""SONY IMX258 Camera"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.OVTH"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.OVTH"" + register "vcm_address" = "0x0C" + register "rom_address" = "0x58" + register "ssdb.rom_type" = "10" # just a guess, needs non-zero + register "ssdb.vcm_type" = "6" # dw9807, just a guess, needs non-zero + register "ssdb.degree" = "1" # 180 rotation + register "num_freq_entries" = "2" + register "link_freq[0]" = "633600000" + register "link_freq[1]" = "320000000" + device i2c 0x1a on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + register "chip_name" = ""Dongwoon NVM"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" # instead use CAM0 that depends on PMIC? + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.VCMP"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.VCMP"" + register "nvm_size" = "8192" + register "nvm_width" = "16" + device i2c 0x58 on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_VCM" + register "chip_name" = ""Dongwoon AF DAC"" + register "dep" = ""\\_SB.PCI0.I2C2.PMIC"" # instead use CAM0 that depends on PMIC? + register "pr0" = ""\\_SB.PCI0.I2C2.PMIC.VCMP"" + register "pr3" = ""\\_SB.PCI0.I2C2.PMIC.VCMP"" + register "vcm_compat" = ""dongwoon,dw9807"" + device i2c 0xc on end + end end # I2C #2 device pci 15.3 on chip drivers/i2c/hid diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl deleted file mode 100644 index 92612cd..0000000 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl +++ /dev/null @@ -1,150 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.I2C2) -{ - Device (CAM0) - { - Name (_HID, "SONY258A") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "SONY IMX258 Camera") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_DEP, Package() { \_SB.PCI0.I2C2.PMIC }) - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x001A, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C2", - 0x00, ResourceConsumer, , - ) - }) - - Name (_PR0, Package () { ^^I2C2.PMIC.OVTH }) - Name (_PR3, Package () { ^^I2C2.PMIC.OVTH }) - - /* Port0 of CAM0 is connected to port0 of CIO2 device */ - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - }, - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "clock-frequency", 19200000 }, - Package () { "rotation", 180 }, - Package () { "lens-focus", - Package () { \_SB.PCI0.I2C2.VCM0 } - } - } - }) - - Name (PRT0, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", - Package () { 1, 2, 3, 4 } - }, - Package () { "link-frequencies", - Package() { 633600000, 320000000 } - }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.CIO2, 0, 0 } - }, - } - }) - } - - Device (VCM0) - { - Name (_HID, "PRP0001") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_DEP, Package() { \_SB.PCI0.I2C2.PMIC }) - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x000C, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C2", - 0x00, ResourceConsumer, , - ) - }) - - Name (_DSD, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "compatible", "dongwoon,dw9807" }, - } - }) - - Name (_PR0, Package () { ^PMIC.VCMP }) - Name (_PR3, Package () { ^PMIC.VCMP }) - } - - Device (NVM0) - { - Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "Dongwoon NVM") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_DEP, Package() { \_SB.PCI0.I2C2.PMIC }) - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0058, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C2", - 0x00, ResourceConsumer, ,) - }) - - Name (_PR0, Package () { ^PMIC.VCMP }) - Name (_PR3, Package () { ^PMIC.VCMP }) - - Name (_DSD, Package () - { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "size", 8192 }, - Package () { "pagesize", 1 }, - Package () { "read-only", 1 }, - Package () { "address-width", 16 }, - } - }) - } -} diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/camera.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/camera.asl index 7993a66..ff9c428 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/camera.asl +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/camera.asl @@ -13,7 +13,4 @@ * GNU General Public License for more details. */ -#include "ipu_mainboard.asl" -#include "ipu_endpoints.asl" #include <baseboard/acpi/camera_pmic.asl> -#include "cam0.asl" diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_endpoints.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_endpoints.asl deleted file mode 100644 index 933a831..0000000 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_endpoints.asl +++ /dev/null @@ -1,29 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.CIO2) -{ - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", Package () { 1, 2, 3, 4 } }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.I2C2.CAM0, 0, 0 } - }, - } - }) -} diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl deleted file mode 100644 index b21cdcf..0000000 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl +++ /dev/null @@ -1,39 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2017 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.CIO2) -{ - /* Define two ports for CIO2 device where endpoint of port0 - is connected to CAM0 and endpoint of port1 is connected to CAM1 - Endpoints can be customized by the variants of the based board */ - - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - } - }) - - Name (PRT0, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, /* csi 0 */ - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) -} -- To view, visit https://review.coreboot.org/c/coreboot/+/31165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01d382c7d87ea2f6967b03f86a91dce12b3c1f96 Gerrit-Change-Number: 31165 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: atlas: switch to mipi_camera driver
by Matt Delco (Code Review) 30 Jan '19

30 Jan '19

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31164 Change subject: atlas: switch to mipi_camera driver ...................................................................... atlas: switch to mipi_camera driver Replaced asl files with use of devicetree configuration that utilizes the mipi_camera driver. BUG=None BRANCH=None TEST=Compared before & after ACPI device and configuration. Observed that the data if interest to Linux drivers is still present and camera is still functional. Also noticed that data of interest to Windows drivers is now present (though I don't have a suitable driver to test to see if it works). Change-Id: Ia72fd8f0e4181be7d979900fcf54de26cc5eb4ba Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/atlas/devicetree.cb D src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/camera.asl D src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_endpoints.asl D src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl 6 files changed, 66 insertions(+), 228 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31164/1 diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 419b10e..aa3f6e6 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -154,6 +154,7 @@ select EXCLUDE_NATIVE_SD_INTERFACE select MAINBOARD_HAS_SPI_TPM_CR50 select VARIANT_HAS_CAMERA_ACPI + select DRIVERS_INTEL_MIPI_CAMERA config VARIANT_SPECIFIC_OPTIONS_POPPY def_bool n diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index f8a6e6d..2b4525e 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -267,10 +267,21 @@ device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_IMGU" + device pci 05.0 on end + end device pci 13.0 off end # Integrated Sensor Hub device pci 14.0 on end # USB xHCI device pci 14.1 on end # USB xDCI (OTG) device pci 14.2 on end # Thermal Subsystem + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_CIO2" + register "cio2_num_ports" = "1" + register "cio2_lanes_used[0]" = "2" + register "cio2_lane_endpoint[0]" = ""\\_SB.PCI0.I2C3.CAM0"" + device pci 14.3 on end + end device pci 15.0 on chip drivers/i2c/hid register "generic.hid" = ""ACPI0C50"" @@ -302,7 +313,33 @@ device i2c 0x15 on end end end # I2C #2 - Trackpad - device pci 15.3 on end # I2C #3 - Camera + device pci 15.3 on + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" + register "acpi_hid" = ""INT3478"" + register "chip_name" = ""SONY IMX208 Camera"" + register "pr0" = ""FCPR"" + register "pr3" = ""FCPR"" + register "rom_address" = "0x50" + register "ssdb.sensor_card_sku" = "0x20" + register "ssdb.rom_type" = "11" + register "use_pld" = "1" + register "num_freq_entries" = "2" + register "link_freq[0]" = "384000000" + register "link_freq[1]" = "96000000" + device i2c 0x10 on end + end + chip drivers/intel/mipi_camera + register "device_type" = "INTEL_ACPI_CAMERA_NVM" + register "chip_name" = ""GT24C16S"" + register "dep" = ""CAM0"" + register "pr0" = ""FCPR"" + register "pr3" = ""FCPR"" + register "nvm_size" = "2048" + register "nvm_width" = "8" + device i2c 0x50 on end + end + end # I2C #3 - Camera device pci 16.0 on end # Management Engine Interface 1 device pci 16.1 off end # Management Engine Interface 2 device pci 16.2 off end # Management Engine IDE-R diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl deleted file mode 100644 index 0a703d4..0000000 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl +++ /dev/null @@ -1,156 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.I2C3) -{ - /* Power resource methods for Front Camera */ - PowerResource (FCPR, 0, 0) { - Name (STA, 0) - Method (_ON, 0, Serialized) { - PMON () - } - Method (_OFF, 0, Serialized) { - PMOF () - } - Method (_STA, 0, Serialized) { - If (LGreater(STA,0)) { - Return (0x1) - } - Else { - Return (0x0) - } - } - Method (PMON, 0, Serialized) { - If (STA == 0) { - CTXS (EN_CAM_PMIC_RST_L) - STXS (EN_PP3300_DX_CAM) - Sleep(3) - STXS (EN_CAM_PMIC_RST_L) - STXS (EN_CAM_CLOCK) - Sleep(2); - } - STA++ - } - - Method (PMOF, 0, Serialized) { - If (STA == 0) { - Return - } - STA-- - If (STA == 0) { - CTXS (EN_CAM_CLOCK) - CTXS (EN_CAM_PMIC_RST_L) - CTXS (EN_PP3300_DX_CAM) - } - } - } - - Device (CAM0) - { - Name (_HID, "INT3478") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "SONY IMX208 Camera") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0010, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C3", - 0x00, ResourceConsumer, ,) - }) - - Name (_PR0, Package (0x01) { FCPR }) - Name (_PR3, Package (0x01) { FCPR }) - - - /* Port0 of CAM0 is connected to port0 of CIO2 device */ - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - }, - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "clock-frequency", 19200000 }, - } - }) - - Name (PRT0, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", - Package () { 1, 2 } - }, - Package () { "link-frequencies", - Package() { 384000000, 96000000 } - }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.CIO2, 0, 0 } - }, - } - }) - } - - Device (NVM0) - { - Name (_HID, "INT3499") /* _HID: Hardware ID */ - Name (_UID, Zero) /* _UID: Unique ID */ - Name (_DDN, "GT24C16S") /* _DDN: DOS Device Name */ - - Method (_STA, 0, NotSerialized) /* _STA: Status */ - { - Return (0x0F) - } - - Name (_CRS, ResourceTemplate () - { - I2cSerialBus (0x0050, ControllerInitiated, 0x00061A80, - AddressingMode7Bit, "\\_SB.PCI0.I2C3", - 0x00, ResourceConsumer, ,) - }) - - Name (_DEP, Package () { CAM0 }) - Name (_PR0, Package (0x01) { FCPR }) - Name (_PR3, Package (0x01) { FCPR }) - - Name (_DSD, Package () - { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "size", 2048 }, - Package () { "pagesize", 1 }, - Package () { "read-only", 1 }, - Package () { "address-width", 8 }, - } - }) - } -} diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/camera.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/camera.asl index d7ca972..a7d9afa 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/camera.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/camera.asl @@ -13,6 +13,30 @@ * GNU General Public License for more details. */ -#include "ipu_mainboard.asl" -#include "ipu_endpoints.asl" -#include "cam0.asl" +Scope (\_SB.PCI0.I2C3) +{ + /* Power resource methods for Front Camera */ + PowerResource (FCPR, 0, 0) { + Name (STA, 0) + Method (_ON, 0, Serialized) { + CTXS (EN_CAM_PMIC_RST_L) + STXS (EN_PP3300_DX_CAM) + Sleep(3) + STXS (EN_CAM_PMIC_RST_L) + STXS (EN_CAM_CLOCK) + Sleep(2); + Store (1, STA) + } + Method (_OFF, 0, Serialized) { + If (LEqual(STA, 1)) { + CTXS (EN_CAM_CLOCK) + CTXS (EN_CAM_PMIC_RST_L) + CTXS (EN_PP3300_DX_CAM) + Store (0, STA) + } + } + Method (_STA, 0, Serialized) { + Return (STA) + } + } +} diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_endpoints.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_endpoints.asl deleted file mode 100644 index 5dc747b..0000000 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_endpoints.asl +++ /dev/null @@ -1,29 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.CIO2) -{ - Name (EP00, Package() { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "endpoint", 0 }, - Package () { "clock-lanes", 0 }, - Package () { "data-lanes", Package () { 1, 2 } }, - Package () { "remote-endpoint", - Package() { \_SB.PCI0.I2C3.CAM0, 0, 0 } - }, - } - }) -} diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl deleted file mode 100644 index ec4eb1e..0000000 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl +++ /dev/null @@ -1,39 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -Scope (\_SB.PCI0.CIO2) -{ - /* Define the port for CIO2 device where endpoint of port0 - * is connected to CAM0 */ - - Name (_DSD, Package () { - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "port0", "PRT0" }, - } - }) - - Name (PRT0, Package () { - ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), - Package () { - Package () { "port", 0 }, /* csi 0 */ - }, - ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), - Package () { - Package () { "endpoint0", "EP00" }, - } - }) - -} -- To view, visit https://review.coreboot.org/c/coreboot/+/31164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia72fd8f0e4181be7d979900fcf54de26cc5eb4ba Gerrit-Change-Number: 31164 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/atlas: enable eist
by Matt Delco (Code Review) 30 Jan '19

30 Jan '19

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29664 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/atlas: enable eist ...................................................................... mb/google/poppy/variants/atlas: enable eist Enable Enhanced Intel SpeedStep (EIST) on Atlas. There's also a redundant dptf_enable line (the other instance is earlier in the file with a comment), so I just renamed the setting to kill two birds with one commit. Change-Id: I57dca346c43feebcddf88f38d4e9f3105775b398 Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/29664/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57dca346c43feebcddf88f38d4e9f3105775b398 Gerrit-Change-Number: 29664 Gerrit-PatchSet: 2 Gerrit-Owner: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: security/vboot: Add measured boot mode
by Julius Werner (Code Review) 30 Jan '19

30 Jan '19

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29547 ) Change subject: security/vboot: Add measured boot mode ...................................................................... Patch Set 43: Code-Review-1 (1 comment) Can you please respond to my comments from Patch Set 36 before pushing this in? Not saying you have to go for every vague idea, but most of them haven't been addressed at all yet, even simple fixes. https://review.coreboot.org/#/c/29547/43/src/lib/prog_ops.c File src/lib/prog_ops.c: https://review.coreboot.org/#/c/29547/43/src/lib/prog_ops.c@42 PS43, Line 42: if (!ENV_BOOTBLOCK && !ENV_DECOMPRESSOR && Note that ENV_BOOTBLOCK will be set if VBOOT_STARTS_IN_BOOTBLOCK and !VBOOT_SEPARATE_VERSTAGE, and then you won't measure the romstage. A better test might be if (IS_ENABLED(...) && vb2_logic_executed()) -- To view, visit https://review.coreboot.org/c/coreboot/+/29547 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I339a2f1051e44f36aba9f99828f130592a09355e Gerrit-Change-Number: 29547 Gerrit-PatchSet: 43 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Jan 2019 22:01:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: arch/x86/mmu: Port armv8 MMU to x86_64
by Patrick Rudolph (Code Review) 30 Jan '19

30 Jan '19

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30119 to look at the new patch set (#6). Change subject: arch/x86/mmu: Port armv8 MMU to x86_64 ...................................................................... arch/x86/mmu: Port armv8 MMU to x86_64 Add functions to setup page tables for long mode. Required to support x86_64, as the MMU is always active. Tested on qemu. Change-Id: I6e8b46e65925823a84b8ccd647c7d6848aa20992 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M Documentation/arch/x86/index.md M src/arch/x86/Kconfig A src/arch/x86/include/arch/mmu.h A src/arch/x86/mmu.c M src/commonlib/include/commonlib/cbmem_id.h 5 files changed, 493 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/30119/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/30119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e8b46e65925823a84b8ccd647c7d6848aa20992 Gerrit-Change-Number: 30119 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: cpu/x86/mtrr: Fix sign overflow
by Patrick Rudolph (Code Review) 30 Jan '19

30 Jan '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30502 ) Change subject: cpu/x86/mtrr: Fix sign overflow ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/30502/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30502/2//COMMIT_MSG@10 PS2, Line 10: Fixes wrong MTRRs settings on x86_64 romstage. > QEMU? No -- To view, visit https://review.coreboot.org/c/coreboot/+/30502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71b61a45becc17bf60a619e4131864c82a16b0d1 Gerrit-Change-Number: 30502 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Jan 2019 16:24:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/apollolake: Sync fsp upd structure update
by John Zhao (Code Review) 30 Jan '19

30 Jan '19

John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31131 Change subject: soc/intel/apollolake: Sync fsp upd structure update ...................................................................... soc/intel/apollolake: Sync fsp upd structure update FSP 2.0.9 provides UPD interface to adjust integrated filter value, usb3 LDO and pmic vdd2 voltage. Change coreboot upd structure to sync with fsp 2.0.9 release. BUG=b:123398358 CQ-DEPEND=CL:*817128 TEST=Verified yorp boots to kernel. Change-Id: I3d17dfbe58bdc5222378459723da8e9ac0573510 Signed-off-by: John Zhao <john.zhao(a)intel.com> --- M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h M src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h 3 files changed, 57 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/31131/1 diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index afbb45c..dcd5d93 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -623,6 +623,21 @@ * Options to disable XHCI Link Compliance Mode. */ silconfig->DisableComplianceMode = cfg->DisableComplianceMode; + + /* + * Options to change USB3 ModPhy setting for Integrated Filter value. + */ + silconfig->ModPhyIfValue = cfg->ModPhyIfValue; + + /* + * Options to bump USB3 LDO voltage with 40mv. + */ + silconfig->ModPhyVoltageBump = cfg->ModPhyVoltageBump; + + /* + * Options to adjust PMIC Vdd2 voltage. + */ + silconfig->PmicVdd2Voltage = cfg->PmicVdd2Voltage; #endif } diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h index b9c9dc5..5e9df67 100644 --- a/src/soc/intel/apollolake/chip.h +++ b/src/soc/intel/apollolake/chip.h @@ -168,6 +168,26 @@ * 0:FALSE(Default), 1:True. */ uint8_t DisableComplianceMode; + + /* Options to change USB3 ModPhy setting for the Integrated Filter (IF) + * value. Default is 0 to not changing IF value (default: 0x12). Set + * value to change IF value for successful Chrome OS installation. + */ + uint8_t ModPhyIfValue; + + /* Options to bump USB3 LDO voltage with 40mv. Default is FALSE to not + * increasing LDO voltage. Set TRUE to increase LDO voltage with 40mv. + * 0:FALSE (default), 1:True. + */ + uint8_t ModPhyVoltageBump; + + /* Options to adjust PMIC Vdd2 voltage (default 1.2v) . Default is 0 to + * not adjusting Vdd2 voltage. Set value for Vdd2 voltage with 1.24v. + * PMIC Buck 5 control register configuration - IPC Configuration + * Upd for changing Vdd2 voltage configuration : I2C_Slave_Address + * (31:24) + Register_Offset (23:16) + OR Value (15:8) + AND Value (7:0) + */ + uint32_t PmicVdd2Voltage; }; typedef struct soc_intel_apollolake_config config_t; diff --git a/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h b/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h index 18a43e2..97a40b6 100644 --- a/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h +++ b/src/vendorcode/intel/fsp/fsp2_0/glk/FspsUpd.h @@ -1,6 +1,6 @@ /** @file -Copyright (c) 2018, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: @@ -1721,7 +1721,25 @@ **/ UINT32 PmicPmcIpcCtrl; -/** Offset 0x03AF +/** Offset 0x03AF - ModPhyIfValue + Upd To modify the Integrated Filter (IF) value as 0x12(Default) for WIN and 0x16 + for Chrome +**/ + UINT8 ModPhyIfValue; + +/** Offset 0x03B0 - ModPhyVoltageBump + ModPhyVoltageBump. 1: enable, 0: disable + $EN_DIS +**/ + UINT8 ModPhyVoltageBump; + +/** Offset 0x03B1 - Vdd2 Voltage configuration + Upd for changing Vdd2 Voltage configuration : I2C_Slave_Address (31:23) + Register_Offset + (23:16) + OR Value (15:8) + AND Value (7:0) +**/ + UINT32 PmicVdd2Voltage; + +/** Offset 0x03B5 **/ UINT8 ReservedFspsUpd[1]; } FSP_S_CONFIG; @@ -1792,9 +1810,9 @@ **/ FSP_S_CONFIG FspsConfig; -/** Offset 0x03B0 +/** Offset 0x03B6 **/ - UINT8 UnusedUpdSpace7[16]; + UINT8 UnusedUpdSpace7[10]; /** Offset 0x03C0 **/ -- To view, visit https://review.coreboot.org/c/coreboot/+/31131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d17dfbe58bdc5222378459723da8e9ac0573510 Gerrit-Change-Number: 31131 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-MessageType: newchange

3 13

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019