coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: mb/google/poppy/variant/nami: Create TSR2 on DPTF
by TH Lin (Code Review) 10 Aug '18

10 Aug '18

TH Lin has uploaded this change for review. ( https://review.coreboot.org/27999 Change subject: mb/google/poppy/variant/nami: Create TSR2 on DPTF ...................................................................... mb/google/poppy/variant/nami: Create TSR2 on DPTF Add TSR2 DART/DTRT package BUG=b:110451144 BRANCH=nami TEST=emerge-nami coreboot chromeos-bootimage Test image with dptf.dv Change-Id: I3328e17328415f5ebdcf84263e5456e11e55f769 Signed-off-by: T.H. Lin <t.h_lin(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/27999/1 diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl index 614865a..4f2dda6 100644 --- a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl @@ -41,6 +41,16 @@ #define DPTF_TSR1_ACTIVE_AC3 42 #define DPTF_TSR1_ACTIVE_AC4 39 +#define DPTF_TSR2_SENSOR_ID 2 +#define DPTF_TSR2_SENSOR_NAME "Thermal_Sensor_Remote_CPU" +#define DPTF_TSR2_PASSIVE 75 +#define DPTF_TSR2_CRITICAL 125 +#define DPTF_TSR2_ACTIVE_AC0 50 +#define DPTF_TSR2_ACTIVE_AC1 47 +#define DPTF_TSR2_ACTIVE_AC2 45 +#define DPTF_TSR2_ACTIVE_AC3 42 +#define DPTF_TSR2_ACTIVE_AC4 39 + #define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL @@ -91,6 +101,10 @@ Package () { \_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 90, 69, 56, 46, 36, 0, 0, 0, 0, 0 + }, + Package () { + \_SB.DPTF.TFN1, \_SB.DPTF.TSR2, 100, 90, 69, 56, 46, 36, 0, 0, + 0, 0, 0 } }) #endif @@ -104,6 +118,9 @@ /* CPU Throttle Effect on TSR1 */ Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR1, 100, 1, 0, 0, 0, 0 }, + + /* CPU Throttle Effect on TSR2 */ + Package () { \_SB.PCI0.B0D4, \_SB.DPTF.TSR2, 100, 1, 0, 0, 0, 0 }, }) Name (MPPC, Package () -- To view, visit https://review.coreboot.org/27999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3328e17328415f5ebdcf84263e5456e11e55f769 Gerrit-Change-Number: 27999 Gerrit-PatchSet: 1 Gerrit-Owner: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) 10 Aug '18

10 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 ) Change subject: soc/intel/common/block: Move common uart function to block/uart ...................................................................... Patch Set 63: (1 comment) https://review.coreboot.org/#/c/26164/63/src/soc/intel/common/block/uart/ua… File src/soc/intel/common/block/uart/uart.c: https://review.coreboot.org/#/c/26164/63/src/soc/intel/common/block/uart/ua… PS63, Line 97: if (!IS_ENABLED(CONFIG_UART_DEBUG)) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/26164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 63 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Comment-Date: Fri, 10 Aug 2018 04:06:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: remove icc_max overrides
by Caveh Jalali (Code Review) 10 Aug '18

10 Aug '18

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/27996 ) Change subject: mb/google/poppy/variants/nocturne: remove icc_max overrides ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/27996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582 Gerrit-Change-Number: 27996 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Aug 2018 02:11:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku
by Caveh Jalali (Code Review) 10 Aug '18

10 Aug '18

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/27997 ) Change subject: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/27997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idfdc0c2434fdef56a7c25df05e640837a5096973 Gerrit-Change-Number: 27997 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Comment-Date: Fri, 10 Aug 2018 02:10:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku
by Nick Vaccaro (Code Review) 10 Aug '18

10 Aug '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27997 ) Change subject: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/27997/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/mainboard.c: https://review.coreboot.org/#/c/27997/1/src/mainboard/google/poppy/variants… PS1, Line 23: * PL2 limit in watts for AML and KBL */ : #define PL2_AML 18 > Better to add comment about 18 Watt and 15 Watt, or just change get_pl2 to get_pl2_in_watts for easi […] Done -- To view, visit https://review.coreboot.org/27997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idfdc0c2434fdef56a7c25df05e640837a5096973 Gerrit-Change-Number: 27997 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Comment-Date: Fri, 10 Aug 2018 02:08:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: remove icc_max overrides
by Nick Vaccaro (Code Review) 10 Aug '18

10 Aug '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27996 ) Change subject: mb/google/poppy/variants/nocturne: remove icc_max overrides ...................................................................... Patch Set 3: > this patch stack is technically in reverse order. Order fixed, thanks. -- To view, visit https://review.coreboot.org/27996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582 Gerrit-Change-Number: 27996 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Aug 2018 02:07:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku
by Nick Vaccaro (Code Review) 10 Aug '18

10 Aug '18

Hello Caveh Jalali, Gaggery Tsai, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27997 to look at the new patch set (#3). Change subject: mb/google/poppy/variant/nocturne: update PL2 based on CPU sku ...................................................................... mb/google/poppy/variant/nocturne: update PL2 based on CPU sku This patch adds a function to overwrite PL2 setting based on CPU sku. From doc #594883, PL2 is 18W for AML-Y. BUG=b:110890675 BRANCH=None TEST=emerge-nocturne coreboot chromeos-bootimage & test with AML-Y and KBL-Y skus. Change-Id: Idfdc0c2434fdef56a7c25df05e640837a5096973 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/poppy/variants/nocturne/Makefile.inc A src/mainboard/google/poppy/variants/nocturne/mainboard.c 2 files changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/27997/3 -- To view, visit https://review.coreboot.org/27997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idfdc0c2434fdef56a7c25df05e640837a5096973 Gerrit-Change-Number: 27997 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: mediatek/mt8183: Move common flow of romstage from mainboard to SoC
by Tristan Hsieh (Code Review) 10 Aug '18

10 Aug '18

Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/27998 Change subject: mediatek/mt8183: Move common flow of romstage from mainboard to SoC ...................................................................... mediatek/mt8183: Move common flow of romstage from mainboard to SoC Main flow of romstage should be pretty much the same among all MT8183 mainboards. Move it into SoC code such that any new mainboards do not need to duplicate it. BUG=b:80501386 TEST=Boots correctly on Kukui Change-Id: I6c9e056e464b88dc53f63c0d0388133ea8e6f59c Signed-off-by: Tristan Shieh <tristan.shieh(a)mediatek.com> --- M src/mainboard/google/kukui/Makefile.inc M src/soc/mediatek/mt8183/Makefile.inc R src/soc/mediatek/mt8183/romstage.c 3 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/27998/1 diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc index 290be4c..ee2ac12 100644 --- a/src/mainboard/google/kukui/Makefile.inc +++ b/src/mainboard/google/kukui/Makefile.inc @@ -7,7 +7,6 @@ romstage-y += chromeos.c romstage-y += memlayout.ld -romstage-y += romstage.c ramstage-y += chromeos.c ramstage-y += mainboard.c diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc index bd0e54f..6c9ef13 100644 --- a/src/soc/mediatek/mt8183/Makefile.inc +++ b/src/soc/mediatek/mt8183/Makefile.inc @@ -23,6 +23,7 @@ romstage-y += emi.c romstage-y += ../common/gpio.c gpio.c romstage-y += ../common/mmu_operations.c mmu_operations.c +romstage-y += romstage.c romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c romstage-y += ../common/timer.c romstage-$(CONFIG_DRIVERS_UART) += ../common/uart.c diff --git a/src/mainboard/google/kukui/romstage.c b/src/soc/mediatek/mt8183/romstage.c similarity index 100% rename from src/mainboard/google/kukui/romstage.c rename to src/soc/mediatek/mt8183/romstage.c -- To view, visit https://review.coreboot.org/27998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6c9e056e464b88dc53f63c0d0388133ea8e6f59c Gerrit-Change-Number: 27998 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: remove icc_max overrides
by Caveh Jalali (Code Review) 10 Aug '18

10 Aug '18

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/27996 ) Change subject: mb/google/poppy/variants/nocturne: remove icc_max overrides ...................................................................... Patch Set 1: Code-Review+1 this patch stack is technically in reverse order. -- To view, visit https://review.coreboot.org/27996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582 Gerrit-Change-Number: 27996 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Aug 2018 01:08:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: remove icc_max overrides
by Lijian Zhao (Code Review) 10 Aug '18

10 Aug '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/27996 ) Change subject: mb/google/poppy/variants/nocturne: remove icc_max overrides ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/27996 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582 Gerrit-Change-Number: 27996 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 10 Aug 2018 00:27:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018