Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28054
to look at the new patch set (#3).
Change subject: util/autoport: Adapt logmaker for newer ACPI versions
......................................................................
util/autoport: Adapt logmaker for newer ACPI versions
acpidump now creates dumps with 4 spaces instead of 2 in front of the hex dump,
so be a bit smarter about the input with regexp.
Change-Id: I8d48c09cdff9432f394b350540ea9765fc942781
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M util/autoport/log_reader.go
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/28054/3
--
To view, visit https://review.coreboot.org/28054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d48c09cdff9432f394b350540ea9765fc942781
Gerrit-Change-Number: 28054
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/28054 )
Change subject: util/autoport: Adapt logmaker for newer ACPI versions
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28054/2/util/autoport/log_reader.go
File util/autoport/log_reader.go:
https://review.coreboot.org/#/c/28054/2/util/autoport/log_reader.go@109
PS2, Line 109: var tmp_int uint
: _, is_err := fmt.Sscanf(line, "%X: ", &tmp_int)
: is_hexline := is_err == nil
there is probably a better way to do this...
--
To view, visit https://review.coreboot.org/28054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d48c09cdff9432f394b350540ea9765fc942781
Gerrit-Change-Number: 28054
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Sat, 11 Aug 2018 23:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28054
to look at the new patch set (#2).
Change subject: util/autoport: Adapt logmaker for newer ACPI versions
......................................................................
util/autoport: Adapt logmaker for newer ACPI versions
acpidump now creates dumps with 4 spaces instead of 2 in front of the hex dump.
Change-Id: I8d48c09cdff9432f394b350540ea9765fc942781
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M util/autoport/log_reader.go
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/28054/2
--
To view, visit https://review.coreboot.org/28054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d48c09cdff9432f394b350540ea9765fc942781
Gerrit-Change-Number: 28054
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/28054 )
Change subject: util/autoport: Adapt logmaker for newer ACPI versions
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28054/1/util/autoport/log_reader.go
File util/autoport/log_reader.go:
https://review.coreboot.org/#/c/28054/1/util/autoport/log_reader.go@117
PS1, Line 117: Tables[curTable] = l.AssignHexLine(line, Tables[curTable])
Is there no way to use scanf() or at least regular expressions?
--
To view, visit https://review.coreboot.org/28054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d48c09cdff9432f394b350540ea9765fc942781
Gerrit-Change-Number: 28054
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Sat, 11 Aug 2018 22:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28050
to look at the new patch set (#2).
Change subject: mb/asus/maximus_iv_gene-z: Add VBT
......................................................................
mb/asus/maximus_iv_gene-z: Add VBT
The file `data.vbt` matches the VBT in the latest version of the vendor
firmware (version 3603). Tested with Linux 4.9 and everything works as
expected.
Change-Id: I8e3b1d274ac0df63989d966f477013e780611fa1
Signed-off-by: Tristan Corrick <tristan(a)corrick.kiwi>
---
M src/mainboard/asus/maximus_iv_gene-z/Kconfig
A src/mainboard/asus/maximus_iv_gene-z/data.vbt
2 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28050/2
--
To view, visit https://review.coreboot.org/28050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e3b1d274ac0df63989d966f477013e780611fa1
Gerrit-Change-Number: 28050
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>