coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: nb/intel/pineview: Use i2c block read to fetch SPD
by Arthur Heymans (Code Review) 20 Aug '18

20 Aug '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/28229 Change subject: nb/intel/pineview: Use i2c block read to fetch SPD ...................................................................... nb/intel/pineview: Use i2c block read to fetch SPD With this the time spend during the raminit decreases from ~480ms to ~126ms. Change-Id: Ic23f39f1017010c89795e626f6a6f918f8bda17a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/pineview/raminit.c 1 file changed, 5 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/28229/1 diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c index 2a1e34c..f1e0767 100644 --- a/src/northbridge/intel/pineview/raminit.c +++ b/src/northbridge/intel/pineview/raminit.c @@ -271,20 +271,13 @@ static void sdram_read_spds(struct sysinfo *s) { - u8 i, j, chan; - int status = 0; + u8 i, chan; s->dt0mode = 0; FOR_EACH_DIMM(i) { - for (j = 0; j < 64; j++) { - status = spd_read_byte(s->spd_map[i], j); - if (status < 0) { - s->dimms[i].card_type = 0; - break; - } - s->dimms[i].spd_data[j] = (u8) status; - if (j == 62) - s->dimms[i].card_type = ((u8) status) & 0x1f; - } + if (i2c_block_read(s->spd_map[i], 0, 64, s->dimms[i].spd_data) != 64) + s->dimms[i].card_type = 0; + + s->dimms[i].card_type = s->dimms[i].spd_data[62] & 0x1f; hexdump(s->dimms[i].spd_data, 64); } -- To view, visit https://review.coreboot.org/28229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic23f39f1017010c89795e626f6a6f918f8bda17a Gerrit-Change-Number: 28229 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/foxconn/d41s: Add mainboard
by Arthur Heymans (Code Review) 20 Aug '18

20 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28227 to look at the new patch set (#4). Change subject: mb/foxconn/d41s: Add mainboard ...................................................................... mb/foxconn/d41s: Add mainboard This supports the Foxconn d41s, d42s, d51s, d52s. The following is tested (SeaBIOS 1.12 + Linux 4.9) and works: - COM1 - S3 resume (with SeaBIOS needs sercon disabled) - Native graphic init on VGA output - SATA - USB The base for this mainboard port was the Intel D510MO port. Change-Id: Ie4ec9cbf70adcdddbc2e5d805e4806825c320072 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- A src/mainboard/foxconn/d41s/Kconfig A src/mainboard/foxconn/d41s/Kconfig.name A src/mainboard/foxconn/d41s/Makefile.inc A src/mainboard/foxconn/d41s/acpi/ec.asl A src/mainboard/foxconn/d41s/acpi/ich7_pci_irqs.asl A src/mainboard/foxconn/d41s/acpi/platform.asl A src/mainboard/foxconn/d41s/acpi/superio.asl A src/mainboard/foxconn/d41s/acpi_tables.c A src/mainboard/foxconn/d41s/board_info.txt A src/mainboard/foxconn/d41s/cmos.default A src/mainboard/foxconn/d41s/cmos.layout A src/mainboard/foxconn/d41s/cstates.c A src/mainboard/foxconn/d41s/data.vbt A src/mainboard/foxconn/d41s/devicetree.cb A src/mainboard/foxconn/d41s/dsdt.asl A src/mainboard/foxconn/d41s/gpio.c A src/mainboard/foxconn/d41s/hda_verb.c A src/mainboard/foxconn/d41s/mainboard.c A src/mainboard/foxconn/d41s/romstage.c 19 files changed, 806 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/28227/4 -- To view, visit https://review.coreboot.org/28227 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie4ec9cbf70adcdddbc2e5d805e4806825c320072 Gerrit-Change-Number: 28227 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: configs: Build test verbose BDK and FIT payload support
by Patrick Rudolph (Code Review) 20 Aug '18

20 Aug '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/28228 Change subject: configs: Build test verbose BDK and FIT payload support ...................................................................... configs: Build test verbose BDK and FIT payload support Change-Id: I2075142a0b241222839899e707a1e3d264746432 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- A configs/config.cavium_cn8100_sff_evb_bdk_verbose_fit_payload_support 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/28228/1 diff --git a/configs/config.cavium_cn8100_sff_evb_bdk_verbose_fit_payload_support b/configs/config.cavium_cn8100_sff_evb_bdk_verbose_fit_payload_support new file mode 100644 index 0000000..951855e --- /dev/null +++ b/configs/config.cavium_cn8100_sff_evb_bdk_verbose_fit_payload_support @@ -0,0 +1,9 @@ +CONFIG_VENDOR_CAVIUM=y +CONFIG_CAVIUM_BDK_VERBOSE_INIT=y +CONFIG_CAVIUM_BDK_VERBOSE_DRAM=y +CONFIG_CAVIUM_BDK_VERBOSE_DRAM_TEST=y +CONFIG_CAVIUM_BDK_VERBOSE_QLM=y +CONFIG_CAVIUM_BDK_VERBOSE_PCIE_CONFIG=y +CONFIG_CAVIUM_BDK_VERBOSE_PCIE=y +CONFIG_CAVIUM_BDK_VERBOSE_PHY=y +CONFIG_PAYLOAD_FIT_SUPPORT=y -- To view, visit https://review.coreboot.org/28228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2075142a0b241222839899e707a1e3d264746432 Gerrit-Change-Number: 28228 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: superio/ite/it8721f: Add SuperIO ACPI declarations
by Felix Held (Code Review) 20 Aug '18

20 Aug '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28226 ) Change subject: superio/ite/it8721f: Add SuperIO ACPI declarations ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I074d57fa5b140b6946ae81beb210fefac48a66eb Gerrit-Change-Number: 28226 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 07:00:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/foxconn/d41s: Add mainboard
by build bot (Jenkins) (Code Review) 20 Aug '18

20 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28227 ) Change subject: mb/foxconn/d41s: Add mainboard ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28227/3/src/mainboard/foxconn/d41s/romstage… File src/mainboard/foxconn/d41s/romstage.c: https://review.coreboot.org/#/c/28227/3/src/mainboard/foxconn/d41s/romstage… PS3, Line 79: RCBA32(FD) = FD_PCIE6 | FD_PCIE5 | FD_PCIE4 | FD_PCIE3 | FD_ACMOD | FD_ACAUD line over 80 characters -- To view, visit https://review.coreboot.org/28227 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4ec9cbf70adcdddbc2e5d805e4806825c320072 Gerrit-Change-Number: 28227 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 06:55:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: superio/ite/it8721f: Add SuperIO ACPI declarations
by Arthur Heymans (Code Review) 20 Aug '18

20 Aug '18

Hello Felix Held, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28226 to look at the new patch set (#2). Change subject: superio/ite/it8721f: Add SuperIO ACPI declarations ...................................................................... superio/ite/it8721f: Add SuperIO ACPI declarations Change-Id: I074d57fa5b140b6946ae81beb210fefac48a66eb Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- A src/superio/ite/it8721f/acpi/superio.asl 1 file changed, 171 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/28226/2 -- To view, visit https://review.coreboot.org/28226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I074d57fa5b140b6946ae81beb210fefac48a66eb Gerrit-Change-Number: 28226 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: superio/ite/it8721f: Add SuperIO ACPI declarations
by Felix Held (Code Review) 20 Aug '18

20 Aug '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28226 ) Change subject: superio/ite/it8721f: Add SuperIO ACPI declarations ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/28226/1/src/superio/ite/it8721f/acpi/superi… File src/superio/ite/it8721f/acpi/superio.asl: https://review.coreboot.org/#/c/28226/1/src/superio/ite/it8721f/acpi/superi… PS1, Line 98: IO (Decode16, SUPERIO_PNP_BASE, SUPERIO_PNP_BASE, 0x01, 0x02) you could use fixed io instead of io here -- To view, visit https://review.coreboot.org/28226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I074d57fa5b140b6946ae81beb210fefac48a66eb Gerrit-Change-Number: 28226 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 06:44:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/pineview: Use a common MMCONF_BASE_ADDRESS
by Felix Held (Code Review) 20 Aug '18

20 Aug '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28224 ) Change subject: nb/intel/pineview: Use a common MMCONF_BASE_ADDRESS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa617e84af767f33a94f1ddfa7d4883c1a45198f Gerrit-Change-Number: 28224 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 06:38:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: superio/ite/it8721f: Add resources
by Felix Held (Code Review) 20 Aug '18

20 Aug '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28225 ) Change subject: superio/ite/it8721f: Add resources ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6715c68b3aa9aebf6e292975cbf64ce905b30e8b Gerrit-Change-Number: 28225 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 06:37:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/lint: Exclude util/superiotool from checkpatch
by Felix Held (Code Review) 20 Aug '18

20 Aug '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28214 ) Change subject: util/lint: Exclude util/superiotool from checkpatch ...................................................................... Patch Set 2: Code-Review+2 I've planned to rewrite superiotool for quite some time, but since I didn't have time yet to do so. Excluding the current superiotool from checkpatch sounds reasonable to me for now. -- To view, visit https://review.coreboot.org/28214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa33938a0fbac10577cbda10537f856f6f100233 Gerrit-Change-Number: 28214 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Aug 2018 06:16:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018