Marc Jones has uploaded this change for review. ( https://review.coreboot.org/28279
Change subject: lib/nhtl: Use common function to set NHTL version
......................................................................
lib/nhtl: Use common function to set NHTL version
Set NHLT version with get_acpi_revision(NHTL) to keep all table versions
in sync.
Change-Id: I4ea9d511142e4ea68e651e58c2c985e739c032d9
Signed-off-by: Marc Jones <marcj303(a)gmail.com>
---
M src/lib/nhlt.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/28279/1
diff --git a/src/lib/nhlt.c b/src/lib/nhlt.c
index f6135c7..5001c38 100644
--- a/src/lib/nhlt.c
+++ b/src/lib/nhlt.c
@@ -413,7 +413,7 @@
memset(header, 0, sizeof(acpi_header_t));
memcpy(header->signature, "NHLT", 4);
write_le32(&header->length, sz);
- write_le8(&header->revision, 5);
+ write_le8(&header->revision, get_acpi_table_revision(NHLT));
if (oem_id == NULL)
oem_id = OEM_ID;
--
To view, visit https://review.coreboot.org/28279
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ea9d511142e4ea68e651e58c2c985e739c032d9
Gerrit-Change-Number: 28279
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
Hello Marshall Dawson, Duncan Laurie, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/28256
to look at the new patch set (#2).
Change subject: x86/acpi: Update MADT table version
......................................................................
x86/acpi: Update MADT table version
Update the MADT table version to sync with the FADT table version.
All current coreboot FADT tables are set to ACPI_FADT_REV_ACPI_3_0
and the MADT should be set to match.
This error was found by running FWTS:
FAILED [MEDIUM] SPECMADTFADTRevisions: Test 2, MADT revision is not in sync with
the FADT revision; MADT 1 expects FADT 3.0 but found 4.0 instead.
BUG=b:112476331
TEST-Run FWTS
Change-Id: If5ef53794ff80dd21f13c247d17c2a0e9f9068f2
Signed-off-by: Marc Jones <marcj303(a)gmail.com>
---
M src/arch/x86/acpi.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/28256/2
--
To view, visit https://review.coreboot.org/28256
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5ef53794ff80dd21f13c247d17c2a0e9f9068f2
Gerrit-Change-Number: 28256
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/28274
Change subject: skylake,kabylake: Add support to set eMMC tuning param from dev tree
......................................................................
skylake,kabylake: Add support to set eMMC tuning param from dev tree
Add support to set eMMC tuning params from the device tree so that it
can be configured per board.
BUG=b:112718426,b:112690628
BRANCH=none
TEST=Build nocturne image and checked values passed in dev tree is set
by FSP.
Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385
Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com>
---
M src/soc/intel/skylake/chip.h
M src/soc/intel/skylake/chip_fsp20.c
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/28274/1
diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index ec8b461..101ac61 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -288,6 +288,9 @@
u8 ScsEmmcEnabled;
u8 ScsEmmcHs400Enabled;
u8 ScsSdCardEnabled;
+ u8 EmmcHs400DllNeed;
+ u8 ScsEmmcHs400RxStrobeDll1;
+ u8 ScsEmmcHs400TxDataDll;
u8 PttSwitch;
u8 HeciTimeouts;
diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c
index d5f5433..c2c0745 100644
--- a/src/soc/intel/skylake/chip_fsp20.c
+++ b/src/soc/intel/skylake/chip_fsp20.c
@@ -336,6 +336,15 @@
params->ScsEmmcHs400Enabled = config->ScsEmmcHs400Enabled;
params->ScsSdCardEnabled = config->ScsSdCardEnabled;
+ if (!!params->ScsEmmcHs400Enabled && !!config->EmmcHs400DllNeed) {
+ params->PchScsEmmcHs400DllDataValid =
+ !!config->EmmcHs400DllNeed;
+ params->PchScsEmmcHs400RxStrobeDll1 =
+ config->ScsEmmcHs400RxStrobeDll1;
+ params->PchScsEmmcHs400TxDataDll =
+ config->ScsEmmcHs400TxDataDll;
+ }
+
/* If ISH is enabled, enable ISH elements */
dev = dev_find_slot(0, PCH_DEVFN_ISH);
if (dev)
--
To view, visit https://review.coreboot.org/28274
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385
Gerrit-Change-Number: 28274
Gerrit-PatchSet: 1
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Martin Roth has posted comments on this change. ( https://review.coreboot.org/28256 )
Change subject: x86/acpi: Update MADT table version
......................................................................
Patch Set 1:
Did you want to just get this in and do that in a follow-on or update this patch?
--
To view, visit https://review.coreboot.org/28256
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ef53794ff80dd21f13c247d17c2a0e9f9068f2
Gerrit-Change-Number: 28256
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 22 Aug 2018 16:38:50 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Marc Jones has posted comments on this change. ( https://review.coreboot.org/28256 )
Change subject: x86/acpi: Update MADT table version
......................................................................
Patch Set 1:
> Patch Set 1:
>
> Is it worthwhile to do something to keep these in sync in the future? Maybe a function that both tables call to get their values?
>
> #define MADT 1
> #define FADT 2
>
> int get_fadt_madt_version (int table)
> {
> if (table == MADT)
> return 2; /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */
> if (table == FADT)
> return ACPI_FADT_REV_ACPI_3_0;
> return -1;
I guess we should expand it to every table type revision.
--
To view, visit https://review.coreboot.org/28256
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ef53794ff80dd21f13c247d17c2a0e9f9068f2
Gerrit-Change-Number: 28256
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 22 Aug 2018 16:18:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No