Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28286 )
Change subject: fsp/fsp2_0/coffeelake: Update CFL FSP headers
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28286/2/src/vendorcode/intel/fsp/fsp2_0/cof…
File src/vendorcode/intel/fsp/fsp2_0/coffeelake/CFLFspHeaderUpdate.sh:
PS2:
I wonder if it's possible to generalize the script a bit and put it in util/scripts?
eg. update-fsp-headers.sh CoffeeLake -> loads from $1FspBinPkg and stores in src/vendorcode/fsp/fsp2_0/$(echo $1 | tr '[A-Z]' '[a-z]')/
--
To view, visit https://review.coreboot.org/28286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656da83e9042642576b785643e423ba47da8dd73
Gerrit-Change-Number: 28286
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 23 Aug 2018 14:32:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/28285
Change subject: siemens/mc_apl1: Correct the Tx signal from SATA interface
......................................................................
siemens/mc_apl1: Correct the Tx signal from SATA interface
Because of an incorrect transmit voltage swing, the signal must be
adjusted. The factor of slices for full swing level can be corrected via
the High Speed I/O Transmit Control Register 3.
Change-Id: I116802cd2a944658fc3022e948eba43cebe52bb4
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/28285/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
index 540e322..773ca29 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
@@ -47,6 +47,12 @@
* INTA#->PIRQB#, INTB#->PIRQC#, INTC#->PIRQD#, INTD#-> PIRQA#
*/
pcr_write16(PID_ITSS, 0x314c, 0x0321);
+
+ /*
+ * Correct the SATA transmit signal via the High Speed I/O Transmit
+ * Control Register 3.
+ */
+ pcr_rmw32(0xa5, 0xa8c, (0x00 << 16), (0x4a << 16));
}
static void wait_for_legacy_dev(void *unused)
--
To view, visit https://review.coreboot.org/28285
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I116802cd2a944658fc3022e948eba43cebe52bb4
Gerrit-Change-Number: 28285
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/28283 )
Change subject: siemens/mc_apl1: Select DDR50 mode for eMMC
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/28283
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40658b44a99e6600ed00950a1a177961f0055e7a
Gerrit-Change-Number: 28283
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 23 Aug 2018 10:29:03 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/28283
Change subject: siemens/mc_apl1: Select DDR50 mode for eMMC
......................................................................
siemens/mc_apl1: Select DDR50 mode for eMMC
To increase the lifetime of the circuit, it is necessary to reduce the
eMMC speed to DDR50 mode.
Change-Id: I40658b44a99e6600ed00950a1a177961f0055e7a
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/28283/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb
index 4d9c655..a82fbfa 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb
@@ -43,6 +43,9 @@
# [6:0] steps of delay for HS200, each 125ps.
register "emmc_rx_cmd_data_cntl2" = "0x10008"
+ # 0:HS400(Default), 1:HS200, 2:DDR50
+ register "emmc_host_max_speed" = "2"
+
# Intel Common SoC Config
#+-------------------+---------------------------+
#| Field | Value |
--
To view, visit https://review.coreboot.org/28283
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40658b44a99e6600ed00950a1a177961f0055e7a
Gerrit-Change-Number: 28283
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/28282
Change subject: soc/intel/apollolake: Make eMMC max speed configurable
......................................................................
soc/intel/apollolake: Make eMMC max speed configurable
The eMMC maximum speed is set to HS400 mode per default. To increase the
lifetime of the circuit, it is necessary to reduce the eMMC speed.
Change-Id: I6fa5eb56a0593e24269ef143645c506232879889
Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com>
---
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/chip.h
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/28282/1
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 83a6baa..f6595ce 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -2,7 +2,7 @@
* This file is part of the coreboot project.
*
* Copyright (C) 2015 - 2017 Intel Corp.
- * Copyright (C) 2017 Siemens AG
+ * Copyright (C) 2017 - 2018 Siemens AG
* (Written by Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> for Intel Corp.)
* (Written by Andrey Petrov <andrey.petrov(a)intel.com> for Intel Corp.)
*
@@ -616,6 +616,8 @@
silconfig->EmmcRxStrobeCntl = cfg->emmc_rx_strobe_cntl;
if (cfg->emmc_rx_cmd_data_cntl2 != 0)
silconfig->EmmcRxCmdDataCntl2 = cfg->emmc_rx_cmd_data_cntl2;
+ if (cfg->emmc_host_max_speed != 0)
+ silconfig->eMMCHostMaxSpeed = cfg->emmc_host_max_speed;
silconfig->LPSS_S0ixEnable = cfg->lpss_s0ix_enable;
diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h
index 61ddeda..f1384ad 100644
--- a/src/soc/intel/apollolake/chip.h
+++ b/src/soc/intel/apollolake/chip.h
@@ -2,7 +2,7 @@
* This file is part of the coreboot project.
*
* Copyright (C) 2015 Intel Corp.
- * Copyright (C) 2017 Siemens AG
+ * Copyright (C) 2017 - 2018 Siemens AG
* (Written by Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> for Intel Corp.)
*
* This program is free software; you can redistribute it and/or modify
@@ -93,6 +93,9 @@
*/
uint32_t emmc_rx_cmd_data_cntl2;
+ /* Select the eMMC max Speed allowed. */
+ uint8_t emmc_host_max_speed;
+
/* Specifies on which IRQ the SCI will internally appear. */
uint8_t sci_irq;
--
To view, visit https://review.coreboot.org/28282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fa5eb56a0593e24269ef143645c506232879889
Gerrit-Change-Number: 28282
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/26116 )
Change subject: pcengines/apu2: enable IOMMU for all apu2 variants
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit https://review.coreboot.org/26116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dbfae78849248f3532caa78974c8f2ce61a530d
Gerrit-Change-Number: 26116
Gerrit-PatchSet: 12
Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Thu, 23 Aug 2018 08:27:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28266 )
Change subject: soc/cavium/cn81xx: Don't directly manipulate devicetree data
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/28266
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5081de020bb73c56aa8bdf7bb17fe6b2913d0ffe
Gerrit-Change-Number: 28266
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 23 Aug 2018 05:29:09 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes