coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: skylake, kabylake: Add support to set eMMC tuning param from dev tree
by Philipp Deppenwiese (Code Review) 23 Aug '18

23 Aug '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28274 ) Change subject: skylake,kabylake: Add support to set eMMC tuning param from dev tree ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/28274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385 Gerrit-Change-Number: 28274 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Aug 2018 05:27:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: device_tree/fit: Constify data structures
by Philipp Deppenwiese (Code Review) 23 Aug '18

23 Aug '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28267 ) Change subject: device_tree/fit: Constify data structures ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id27966427fb97457fe883be32685d1397fb0781f Gerrit-Change-Number: 28267 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Aug 2018 05:25:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Fix I2C bus 0 timing for Grunt
by Akshu Agrawal (Code Review) 23 Aug '18

23 Aug '18

Akshu Agrawal has uploaded this change for review. ( https://review.coreboot.org/28280 Change subject: mb/google/kahlee: Fix I2C bus 0 timing for Grunt ...................................................................... mb/google/kahlee: Fix I2C bus 0 timing for Grunt This commit fixes the values and thus fixes the issue of audio device not getting detected on random reboots. Change-Id: I34a4f62815d192005c3324d4f71b0aba377fe738 Signed-off-by: Akshu Agrawal <akshu.agrawal(a)amd.com> --- M src/mainboard/google/kahlee/variants/grunt/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/28280/1 diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb index 0a173ac..b749a94 100644 --- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb @@ -24,8 +24,8 @@ # Enable I2C0 for audio, USB3 hub at 400kHz register "i2c[0]" = "{ .speed = I2C_SPEED_FAST, - .rise_time_ns = 151, - .fall_time_ns = 50, + .rise_time_ns = 95, + .fall_time_ns = 3, }" # Enable I2C1 for H1 at 400kHz -- To view, visit https://review.coreboot.org/28280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I34a4f62815d192005c3324d4f71b0aba377fe738 Gerrit-Change-Number: 28280 Gerrit-PatchSet: 1 Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com>

1 0

Change in coreboot[master]: skylake, kabylake: Add support to set eMMC tuning param from dev tree
by Lijian Zhao (Code Review) 23 Aug '18

23 Aug '18

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28274 ) Change subject: skylake,kabylake: Add support to set eMMC tuning param from dev tree ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/28274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385 Gerrit-Change-Number: 28274 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Aug 2018 04:08:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: x86/acpi: Add ACPI table revision function
by Marc Jones (Code Review) 23 Aug '18

23 Aug '18

Hello Marshall Dawson, Duncan Laurie, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28276 to look at the new patch set (#3). Change subject: x86/acpi: Add ACPI table revision function ...................................................................... x86/acpi: Add ACPI table revision function Use a single function to set ACPI table versions. This allows us to keep revisions synced to the correct levels for coreboot. This is a partial fix for the bug: FAILED [MEDIUM] SPECMADTFADTRevisions: Test 2, MADT revision is not in sync with the FADT revision; MADT 1 expects FADT 3.0 but found 4.0 instead. BUG=b:112476331 TEST-Run FWTS Change-Id: Ie9a486380e72b1754677c3cdf8190e3ceff9412b Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/arch/x86/acpi.c M src/arch/x86/include/arch/acpi.h 2 files changed, 80 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/28276/3 -- To view, visit https://review.coreboot.org/28276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie9a486380e72b1754677c3cdf8190e3ceff9412b Gerrit-Change-Number: 28276 Gerrit-PatchSet: 3 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel: Use common HPET table revision function
by Marc Jones (Code Review) 23 Aug '18

23 Aug '18

Marc Jones has uploaded a new patch set (#2). ( https://review.coreboot.org/28278 ) Change subject: intel: Use common HPET table revision function ...................................................................... intel: Use common HPET table revision function Use get_acpi_table_revision(HPET) to keep all table versions in sync. Change-Id: Idb5e8ccd49ec27f87a290f33c62df3c177645669 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/soc/intel/baytrail/acpi.c M src/soc/intel/broadwell/acpi.c M src/soc/intel/fsp_baytrail/acpi.c M src/soc/intel/fsp_broadwell_de/acpi.c M src/southbridge/intel/lynxpoint/acpi.c 5 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/28278/2 -- To view, visit https://review.coreboot.org/28278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb5e8ccd49ec27f87a290f33c62df3c177645669 Gerrit-Change-Number: 28278 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: lib/nhtl: Use common function to set NHTL version
by Marc Jones (Code Review) 23 Aug '18

23 Aug '18

Marc Jones has uploaded a new patch set (#2). ( https://review.coreboot.org/28279 ) Change subject: lib/nhtl: Use common function to set NHTL version ...................................................................... lib/nhtl: Use common function to set NHTL version Set NHLT version with get_acpi_revision(NHTL) to keep all table versions in sync. Change-Id: I4ea9d511142e4ea68e651e58c2c985e739c032d9 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/lib/nhlt.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/28279/2 -- To view, visit https://review.coreboot.org/28279 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4ea9d511142e4ea68e651e58c2c985e739c032d9 Gerrit-Change-Number: 28279 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: x86/acpi: Update MADT table version
by Marc Jones (Code Review) 23 Aug '18

23 Aug '18

Hello Marshall Dawson, Duncan Laurie, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28256 to look at the new patch set (#3). Change subject: x86/acpi: Update MADT table version ...................................................................... x86/acpi: Update MADT table version Update the MADT table version to sync with the FADT table version. All current coreboot FADT tables are set to ACPI_FADT_REV_ACPI_3_0 and the MADT should be set to match. This error was found by running FWTS: FAILED [MEDIUM] SPECMADTFADTRevisions: Test 2, MADT revision is not in sync with the FADT revision; MADT 1 expects FADT 3.0 but found 4.0 instead. BUG=b:112476331 TEST-Run FWTS Change-Id: If5ef53794ff80dd21f13c247d17c2a0e9f9068f2 Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/arch/x86/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/28256/3 -- To view, visit https://review.coreboot.org/28256 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If5ef53794ff80dd21f13c247d17c2a0e9f9068f2 Gerrit-Change-Number: 28256 Gerrit-PatchSet: 3 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: update all FADT version 3.0 to use the get tables function
by Marc Jones (Code Review) 23 Aug '18

23 Aug '18

Marc Jones has uploaded a new patch set (#2). ( https://review.coreboot.org/28277 ) Change subject: update all FADT version 3.0 to use the get tables function ...................................................................... update all FADT version 3.0 to use the get tables function Most FADT report using ACPIv3 FADT table. Using the get revision function keeps the table versions in sync. Change-Id: Ie554faf1be65c7034dd0836f0029cdc79eae1aed Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/mainboard/aopen/dxplplusu/fadt.c M src/mainboard/google/auron/fadt.c M src/mainboard/google/beltino/fadt.c M src/mainboard/google/cyan/fadt.c M src/mainboard/google/jecht/fadt.c M src/mainboard/google/rambi/fadt.c M src/mainboard/google/slippy/fadt.c M src/mainboard/purism/librem_bdw/fadt.c M src/soc/amd/stoneyridge/acpi.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/fsp_baytrail/acpi.c M src/soc/intel/fsp_broadwell_de/acpi.c M src/soc/intel/skylake/acpi.c M src/southbridge/amd/agesa/hudson/fadt.c M src/southbridge/amd/cimx/sb800/fadt.c M src/southbridge/amd/pi/hudson/fadt.c M src/southbridge/intel/fsp_rangeley/acpi.c 17 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/28277/2 -- To view, visit https://review.coreboot.org/28277 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie554faf1be65c7034dd0836f0029cdc79eae1aed Gerrit-Change-Number: 28277 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: x86/acpi: Add ACPI table revision function
by Marc Jones (Code Review) 23 Aug '18

23 Aug '18

Marc Jones has uploaded a new patch set (#2). ( https://review.coreboot.org/28276 ) Change subject: x86/acpi: Add ACPI table revision function ...................................................................... x86/acpi: Add ACPI table revision function Use a single function to set ACPI table versions. This allows us to keep revisions synced to the correct levels for coreboot. This is a partial fix for the bug: FAILED [MEDIUM] SPECMADTFADTRevisions: Test 2, MADT revision is not in sync with the FADT revision; MADT 1 expects FADT 3.0 but found 4.0 instead. BUG=b:112476331 TEST-Run FWTS Change-Id: Ie9a486380e72b1754677c3cdf8190e3ceff9412b Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/arch/x86/acpi.c M src/arch/x86/include/arch/acpi.h 2 files changed, 80 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/28276/2 -- To view, visit https://review.coreboot.org/28276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie9a486380e72b1754677c3cdf8190e3ceff9412b Gerrit-Change-Number: 28276 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018