coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: mb/google/atlas: MIPI camera ASL files for Atlas
by Ping-chung Chen (Code Review) 10 Jul '18

10 Jul '18

Ping-chung Chen has posted comments on this change. ( https://review.coreboot.org/27350 ) Change subject: mb/google/atlas: MIPI camera ASL files for Atlas ...................................................................... Patch Set 6: (3 comments) https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/devicetree.cb: https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 43: > Please remove these comments Done https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 44: > Ditto Done https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl: https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 18: /* Define the port for CIO2 device where endpoint of port0 : is connected to CAM0 */ > Please fix these comments as Atlas uses a single camera. Done -- To view, visit https://review.coreboot.org/27350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d Gerrit-Change-Number: 27350 Gerrit-PatchSet: 6 Gerrit-Owner: Ping-chung Chen <ping-chung.chen(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen(a)intel.com> Gerrit-Reviewer: Ping-chung Chen <ping-chung.chen(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 10 Jul 2018 02:36:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/atlas: MIPI camera ASL files for Atlas
by Ping-chung Chen (Code Review) 10 Jul '18

10 Jul '18

Hello Rajmohan Mani, JasonX Z Chen, Andy Yeh, Hyungwoo Yang, Rizwan Qureshi, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27350 to look at the new patch set (#6). Change subject: mb/google/atlas: MIPI camera ASL files for Atlas ...................................................................... mb/google/atlas: MIPI camera ASL files for Atlas Atlas has one sensor, create a single endpoint to CIO2. create power resource for enabling/disabling camera. BUG=b:111141128 Branch=None TEST=Testing (WIP) on Atlas board Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d Signed-off-by: Ping-Chung Chen <ping-chung.chen(a)intel.com> Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/atlas/devicetree.cb A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/camera.asl A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_endpoints.asl A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl M src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h 7 files changed, 233 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/27350/6 -- To view, visit https://review.coreboot.org/27350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d Gerrit-Change-Number: 27350 Gerrit-PatchSet: 6 Gerrit-Owner: Ping-chung Chen <ping-chung.chen(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen(a)intel.com> Gerrit-Reviewer: Ping-chung Chen <ping-chung.chen(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/atlas: MIPI camera ASL files for Atlas
by Ping-chung Chen (Code Review) 10 Jul '18

10 Jul '18

Ping-chung Chen has posted comments on this change. ( https://review.coreboot.org/27350 ) Change subject: mb/google/atlas: MIPI camera ASL files for Atlas ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl: https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 20: INT3478 > Where does this ACPI id come from? It has been used for Windows IMX208 driver. -- To view, visit https://review.coreboot.org/27350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d Gerrit-Change-Number: 27350 Gerrit-PatchSet: 5 Gerrit-Owner: Ping-chung Chen <ping-chung.chen(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen(a)intel.com> Gerrit-Reviewer: Ping-chung Chen <ping-chung.chen(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 10 Jul 2018 02:24:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/atlas: MIPI camera ASL files for Atlas
by Rajmohan Mani (Code Review) 10 Jul '18

10 Jul '18

Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/27350 ) Change subject: mb/google/atlas: MIPI camera ASL files for Atlas ...................................................................... Patch Set 5: (8 comments) mipi_camera.asl - Please align this name with other variants (e.g cam0.asl) https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/devicetree.cb: https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 43: # FIXME: enable once MIPI is ready Please remove these comments https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 44: # FIXME: enable once MIPI is ready Ditto https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl: https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 18: /* Define two ports for CIO2 device where endpoint of port0 : is connected to CAM0 and endpoint of port1 is connected to CAM1 */ Please fix these comments as Atlas uses a single camera. https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl: https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 20: INT3478 Where does this ACPI id come from? https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 32: AddressingMode7Bit, "\\_SB.PCI0.I2C3", : 0x00, ResourceConsumer, , Tab needed https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 45: Sleep(11); I need to look into the data sheet to understand the timing requirements. Would be nice if you can add some details about this delay. https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 62: FCPR FCPR naming convention is used to refer that it'a front camera. In Atlas, is this a front or rear camera? Please update all comments about front / rear as needed. https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants… PS5, Line 123: SSDB I don't believe SSDB is currently used. Please remove. -- To view, visit https://review.coreboot.org/27350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d Gerrit-Change-Number: 27350 Gerrit-PatchSet: 5 Gerrit-Owner: Ping-chung Chen <ping-chung.chen(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 09 Jul 2018 23:53:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update existing SPD files
by Daniel Kurtz (Code Review) 10 Jul '18

10 Jul '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27423 ) Change subject: mainboard/google/kahlee: Update existing SPD files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If330dbf0c133f65aedddc58ecb351a80b0e45a05 Gerrit-Change-Number: 27423 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 09 Jul 2018 22:55:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add additional SPDs for variants
by Daniel Kurtz (Code Review) 10 Jul '18

10 Jul '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27422 ) Change subject: mainboard/google/kahlee: Add additional SPDs for variants ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/27422 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb03a3fa0842f7f89bb8c66dedbb8a0b293569be Gerrit-Change-Number: 27422 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 09 Jul 2018 22:54:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update existing SPD files
by Martin Roth (Code Review) 10 Jul '18

10 Jul '18

Hello Daniel Kurtz, build bot (Jenkins), Raul Rangel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27423 to look at the new patch set (#2). Change subject: mainboard/google/kahlee: Update existing SPD files ...................................................................... mainboard/google/kahlee: Update existing SPD files Add an extra space after 8th value on each line to make it easier to count the values. Update the empty spd to remove two random 0x80 values. BUG=None TEST=None Change-Id: If330dbf0c133f65aedddc58ecb351a80b0e45a05 Signed-off-by: Martin Roth <martinroth(a)chromium.org> --- M src/mainboard/google/kahlee/variants/baseboard/spd/empty.spd.hex M src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5AN8G6NAFR-UH.spd.hex M src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5ANAG6NAMR-UH.spd.hex M src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex M src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16JY-083E-B.spd.hex M src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4A8G165WB-BCRC.spd.hex M src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCRC.spd.hex 7 files changed, 225 insertions(+), 224 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/27423/2 -- To view, visit https://review.coreboot.org/27423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If330dbf0c133f65aedddc58ecb351a80b0e45a05 Gerrit-Change-Number: 27423 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add additional SPDs for variants
by Martin Roth (Code Review) 10 Jul '18

10 Jul '18

Hello Daniel Kurtz, build bot (Jenkins), Raul Rangel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27422 to look at the new patch set (#3). Change subject: mainboard/google/kahlee: Add additional SPDs for variants ...................................................................... mainboard/google/kahlee: Add additional SPDs for variants BUG=b:111079089, b:80375243 TEST=Build grunt, verify that SPDs are included. Change-Id: Idb03a3fa0842f7f89bb8c66dedbb8a0b293569be Signed-off-by: Martin Roth <martinroth(a)chromium.org> --- M src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.inc A src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16LY-075-E.spd.hex 3 files changed, 68 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/27422/3 -- To view, visit https://review.coreboot.org/27422 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb03a3fa0842f7f89bb8c66dedbb8a0b293569be Gerrit-Change-Number: 27422 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Update existing SPD files
by Daniel Kurtz (Code Review) 10 Jul '18

10 Jul '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27423 ) Change subject: mainboard/google/kahlee: Update existing SPD files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/27423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If330dbf0c133f65aedddc58ecb351a80b0e45a05 Gerrit-Change-Number: 27423 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 09 Jul 2018 22:49:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Add additional SPDs for variants
by Daniel Kurtz (Code Review) 10 Jul '18

10 Jul '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27422 ) Change subject: mainboard/google/kahlee: Add additional SPDs for variants ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27422/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27422/2//COMMIT_MSG@9 PS2, Line 9: b:111079089, b:111079089 was one of these supposed to be a different bug? -- To view, visit https://review.coreboot.org/27422 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb03a3fa0842f7f89bb8c66dedbb8a0b293569be Gerrit-Change-Number: 27422 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 09 Jul 2018 22:49:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

← Newer
1
...
63
64
65
66
67
68
69
...
88
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018