SolidHal has uploaded this change for review. ( https://review.coreboot.org/27426
Change subject: buildgcc: Actually verify checksums
......................................................................
buildgcc: Actually verify checksums
buildgcc doesn't verify the checksum of gcc downloaded using download(). This can be verified by modifying
the gcc checksum in coreboot/util/crossgcc/sum, which won't cause a failure without this patch
Change-Id: I132f5f86cd31a001372b19e0f81ad933916d2a83
Signed-off-by: SolidHal <SolidHal(a)users.noreply.github.com>
---
M util/crossgcc/buildgcc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/27426/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index a9d9057..5083773 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -320,6 +320,10 @@
cd tarballs
download_showing_percentage $archive
cd ..
+ if ! check_sum $FILE; then
+ printf "\n${RED}$FILE Failed Checksum Verification${NC}\n"
+ exit 1
+ fi
fi
if [ ! -f tarballs/$FILE ]; then
--
To view, visit https://review.coreboot.org/27426
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I132f5f86cd31a001372b19e0f81ad933916d2a83
Gerrit-Change-Number: 27426
Gerrit-PatchSet: 1
Gerrit-Owner: SolidHal (1002051)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27103 )
Change subject: soc/cavium: Enable DRAM test
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/27103/3/src/soc/cavium/cn81xx/sdram.c
File src/soc/cavium/cn81xx/sdram.c:
https://review.coreboot.org/#/c/27103/3/src/soc/cavium/cn81xx/sdram.c@93
PS3, Line 93: if (0 != bdk_numa_master())
Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/27103/3/src/soc/cavium/cn81xx/sdram.c@97
PS3, Line 97: if (0 == bdk_numa_master())
Comparisons should place the constant on the right side of the test
--
To view, visit https://review.coreboot.org/27103
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a375f3d4c5cea7c3c0cd4592287f3f85dc7d3cf
Gerrit-Change-Number: 27103
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Jul 2018 14:47:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27356 )
Change subject: riscv: add spin lock support
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/27356/12/src/arch/riscv/include/arch/smp/sp…
File src/arch/riscv/include/arch/smp/spinlock.h:
https://review.coreboot.org/#/c/27356/12/src/arch/riscv/include/arch/smp/sp…
PS12, Line 29: while (atomic_swap(&lock->lock, -1));
trailing statements should be on next line
--
To view, visit https://review.coreboot.org/27356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e93fb8b35c4452f0fe3f7f4bcc6f7aa4e042451
Gerrit-Change-Number: 27356
Gerrit-PatchSet: 12
Gerrit-Owner: Xiang Wang <wxjstz(a)126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 10 Jul 2018 13:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Ping-chung Chen has posted comments on this change. ( https://review.coreboot.org/27350 )
Change subject: mb/google/atlas: MIPI camera ASL files for Atlas
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants…
File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants…
PS5, Line 32:
:
> Tab needed
Done
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants…
PS5, Line 62:
> FCPR naming convention is used to refer that it'a front camera. […]
This is front camera.
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants…
PS5, Line 123:
> I don't believe SSDB is currently used. Please remove.
Done
--
To view, visit https://review.coreboot.org/27350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d
Gerrit-Change-Number: 27350
Gerrit-PatchSet: 7
Gerrit-Owner: Ping-chung Chen <ping-chung.chen(a)intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com>
Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen(a)intel.com>
Gerrit-Reviewer: Ping-chung Chen <ping-chung.chen(a)intel.com>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Jul 2018 03:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Rajmohan Mani, JasonX Z Chen, Andy Yeh, Hyungwoo Yang, Rizwan Qureshi, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27350
to look at the new patch set (#7).
Change subject: mb/google/atlas: MIPI camera ASL files for Atlas
......................................................................
mb/google/atlas: MIPI camera ASL files for Atlas
Atlas has one sensor, create a single endpoint to CIO2.
create power resource for enabling/disabling camera.
BUG=b:111141128
Branch=None
TEST=Testing (WIP) on Atlas board
Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d
Signed-off-by: Ping-Chung Chen <ping-chung.chen(a)intel.com>
Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl
A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/camera.asl
A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_endpoints.asl
A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl
M src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h
7 files changed, 214 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/27350/7
--
To view, visit https://review.coreboot.org/27350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d
Gerrit-Change-Number: 27350
Gerrit-PatchSet: 7
Gerrit-Owner: Ping-chung Chen <ping-chung.chen(a)intel.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com>
Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen(a)intel.com>
Gerrit-Reviewer: Ping-chung Chen <ping-chung.chen(a)intel.com>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>