coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: payloads/tianocore: ignore whitespace change when applying patches
by Piotr Król (Code Review) 24 Jul '18

24 Jul '18

Piotr Król has uploaded this change for review. ( https://review.coreboot.org/27616 Change subject: payloads/tianocore: ignore whitespace change when applying patches ...................................................................... payloads/tianocore: ignore whitespace change when applying patches This change is required to apply patch 06_CorebootPayloadPkg_keep_cb_table since conflict in white space between patch and target file in edk2 makes patch rejected while building under coreboot-sdk:1.52. Change-Id: I38f7d46925cc00a2b5c5400e3fbf3579990f3fa5 Signed-off-by: Piotr Król <piotr.krol(a)3mdeb.com> --- M payloads/external/tianocore/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/27616/1 diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 72293d8..757c9bb 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -66,7 +66,7 @@ for patch in $(CURDIR)/patches/*.patch; do \ echo "Applying $$patch"; \ cd $(project_dir); \ - git am --keep-cr $$patch || \ + git am --keep-cr --ignore-space-change $$patch || \ ( echo " Error when applying patches.\n"; git am --abort; exit 1; ); \ done; \ if ! [ "$(TAG-y)" = "origin/master" ] ; then \ -- To view, visit https://review.coreboot.org/27616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I38f7d46925cc00a2b5c5400e3fbf3579990f3fa5 Gerrit-Change-Number: 27616 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com>

1 0

Change in coreboot[master]: payloads/tianocore: rebase patches to UDK2018 release
by Piotr Król (Code Review) 24 Jul '18

24 Jul '18

Piotr Król has uploaded this change for review. ( https://review.coreboot.org/27615 Change subject: payloads/tianocore: rebase patches to UDK2018 release ...................................................................... payloads/tianocore: rebase patches to UDK2018 release Patches should be applied against edk2 release instead of arbitrary commit. This aims to simplify Tianocore payload support by other platforms. Change-Id: Ib409f6f93eb64d7a9a2f09a75f8e637ab8689410 Signed-off-by: Piotr Król <piotr.krol(a)3mdeb.com> --- M payloads/external/tianocore/Makefile M payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch M payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch M payloads/external/tianocore/patches/03_Library_EndofDXE.patch M payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch M payloads/external/tianocore/patches/05_CorebootPayloadPkg_noserial.patch M payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch M payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch M payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch D payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch 10 files changed, 56 insertions(+), 92 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/27615/1 diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 2f770d2..72293d8 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -16,7 +16,8 @@ # force the shell to bash - the edksetup.sh script doesn't work with dash export SHELL := env bash -STABLE_COMMIT_ID=315d9d08fd77db1024ccc5307823da8aaed85e2f +# STABLE_COMMIT_ID represent official edk2 release, currently UDK2018 +STABLE_COMMIT_ID=3e72ffe8afdd03f1f89eba65c921cbdcb004cfee TAG-$(CONFIG_TIANOCORE_MASTER)=origin/master TAG-$(CONFIG_TIANOCORE_STABLE)=$(STABLE_COMMIT_ID) TAG-$(CONFIG_TIANOCORE_REVISION)=$(CONFIG_TIANOCORE_REVISION_ID) diff --git a/payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch b/payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch index 448da4a..7036f36 100644 --- a/payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch +++ b/payloads/external/tianocore/patches/01_CorebootPayloadPkg_pcinoenum.patch @@ -1,4 +1,4 @@ -From 4f9d41e69356ce7486b0c74a754ff494256723de Mon Sep 17 00:00:00 2001 +From c3da734cd08117ce2d5cd48367f5a94848aa9321 Mon Sep 17 00:00:00 2001 From: CoolStar <coolstarorganization(a)gmail.com> Date: Sun, 4 Dec 2016 11:23:38 -0800 Subject: [PATCH] PCI: use Duet's PciNoEnumeration @@ -10,7 +10,7 @@ 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg/CorebootPayloadPkg.fdf -index 303e626842..a39e3999ba 100644 +index 7994f0c94928..d71b3ec55690 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf @@ -124,8 +124,8 @@ INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf @@ -25,7 +25,7 @@ # # ISA Support diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc -index cdfcb75b59..e838aca61d 100644 +index ace1bc0a3726..0f4e475187ee 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -450,11 +450,8 @@ @@ -43,7 +43,7 @@ # # SCSI/ATA/IDE/DISK Support diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc -index 6b16af63ba..c25d821fd4 100644 +index 2492142b972d..97bb0a8ae0a1 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -451,11 +451,8 @@ @@ -61,5 +61,5 @@ # # SCSI/ATA/IDE/DISK Support -- -2.13.2.725.g09c95d1e9-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch b/payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch index 8013ccd..9c61263 100644 --- a/payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch +++ b/payloads/external/tianocore/patches/02_CorebootPayloadPkg_bds.patch @@ -1,20 +1,20 @@ -From 5121087836c1ad2a08857d494c0d9ecb183f4f98 Mon Sep 17 00:00:00 2001 +From e72cac80c845429b042c7f9c36ede642cbe9e150 Mon Sep 17 00:00:00 2001 From: CoolStar <coolstarorganization(a)gmail.com> Date: Tue, 18 Jul 2017 15:50:38 -0600 Subject: [PATCH] Rebasing --- - CorebootModulePkg/CorebootModulePkg.dec | 8 + - .../Include/Guid/LdrMemoryDescriptor.h | 33 + - .../Include/Guid/PciExpressBaseAddress.h | 46 + - CorebootModulePkg/Include/Guid/PciOptionRomTable.h | 41 + - .../Library/CorebootBdsLib/BdsPlatform.c | 1731 ++++++++++++++++++++ - .../Library/CorebootBdsLib/BdsPlatform.h | 288 ++++ - .../Library/CorebootBdsLib/PlatformBds.inf | 65 + - .../Library/CorebootBdsLib/PlatformData.c | 161 ++ - CorebootPayloadPkg/CorebootPayloadPkg.fdf | 5 +- - CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 12 +- - CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 12 +- + CorebootModulePkg/CorebootModulePkg.dec | 8 + + .../Include/Guid/LdrMemoryDescriptor.h | 33 + + .../Include/Guid/PciExpressBaseAddress.h | 46 + + .../Include/Guid/PciOptionRomTable.h | 41 + + .../Library/CorebootBdsLib/BdsPlatform.c | 1731 +++++++++++++++++ + .../Library/CorebootBdsLib/BdsPlatform.h | 288 +++ + .../Library/CorebootBdsLib/PlatformBds.inf | 65 + + .../Library/CorebootBdsLib/PlatformData.c | 161 ++ + CorebootPayloadPkg/CorebootPayloadPkg.fdf | 5 +- + CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 12 +- + .../CorebootPayloadPkgIa32X64.dsc | 12 +- 11 files changed, 2388 insertions(+), 14 deletions(-) create mode 100644 CorebootModulePkg/Include/Guid/LdrMemoryDescriptor.h create mode 100644 CorebootModulePkg/Include/Guid/PciExpressBaseAddress.h @@ -25,7 +25,7 @@ create mode 100644 CorebootModulePkg/Library/CorebootBdsLib/PlatformData.c diff --git a/CorebootModulePkg/CorebootModulePkg.dec b/CorebootModulePkg/CorebootModulePkg.dec -index 7f1309bdae..20932a1d04 100644 +index 7f1309bdae61..20932a1d0467 100644 --- a/CorebootModulePkg/CorebootModulePkg.dec +++ b/CorebootModulePkg/CorebootModulePkg.dec @@ -33,8 +33,16 @@ @@ -47,7 +47,7 @@ diff --git a/CorebootModulePkg/Include/Guid/LdrMemoryDescriptor.h b/CorebootModulePkg/Include/Guid/LdrMemoryDescriptor.h new file mode 100644 -index 0000000000..38a997deea +index 000000000000..38a997deea0c --- /dev/null +++ b/CorebootModulePkg/Include/Guid/LdrMemoryDescriptor.h @@ -0,0 +1,33 @@ @@ -86,7 +86,7 @@ +#endif diff --git a/CorebootModulePkg/Include/Guid/PciExpressBaseAddress.h b/CorebootModulePkg/Include/Guid/PciExpressBaseAddress.h new file mode 100644 -index 0000000000..ff554383c1 +index 000000000000..ff554383c11b --- /dev/null +++ b/CorebootModulePkg/Include/Guid/PciExpressBaseAddress.h @@ -0,0 +1,46 @@ @@ -138,7 +138,7 @@ +#endif diff --git a/CorebootModulePkg/Include/Guid/PciOptionRomTable.h b/CorebootModulePkg/Include/Guid/PciOptionRomTable.h new file mode 100644 -index 0000000000..a2fb99710a +index 000000000000..a2fb99710a69 --- /dev/null +++ b/CorebootModulePkg/Include/Guid/PciOptionRomTable.h @@ -0,0 +1,41 @@ @@ -185,7 +185,7 @@ + diff --git a/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c new file mode 100644 -index 0000000000..b6253a17f8 +index 000000000000..b6253a17f8ea --- /dev/null +++ b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c @@ -0,0 +1,1731 @@ @@ -1922,7 +1922,7 @@ +} diff --git a/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.h b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.h new file mode 100644 -index 0000000000..d447f77747 +index 000000000000..d447f77747e3 --- /dev/null +++ b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.h @@ -0,0 +1,288 @@ @@ -2216,7 +2216,7 @@ +#endif // _PLATFORM_SPECIFIC_BDS_PLATFORM_H_ diff --git a/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf b/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf new file mode 100644 -index 0000000000..578c74afae +index 000000000000..578c74afae22 --- /dev/null +++ b/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf @@ -0,0 +1,65 @@ @@ -2287,7 +2287,7 @@ + diff --git a/CorebootModulePkg/Library/CorebootBdsLib/PlatformData.c b/CorebootModulePkg/Library/CorebootBdsLib/PlatformData.c new file mode 100644 -index 0000000000..fbdcc7de81 +index 000000000000..fbdcc7de8166 --- /dev/null +++ b/CorebootModulePkg/Library/CorebootBdsLib/PlatformData.c @@ -0,0 +1,161 @@ @@ -2453,7 +2453,7 @@ +EFI_DEVICE_PATH_PROTOCOL *gPlatformConnectSequence[] = { NULL }; + diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg/CorebootPayloadPkg.fdf -index a39e3999ba..623ff9c344 100644 +index d71b3ec55690..22987093da58 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf @@ -95,8 +95,9 @@ INF MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntime @@ -2469,7 +2469,7 @@ INF PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf !else diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc -index e838aca61d..a329b78f08 100644 +index 0f4e475187ee..053f380a8608 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -165,6 +165,7 @@ @@ -2508,7 +2508,7 @@ PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf !else diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc -index c25d821fd4..790efd7810 100644 +index 97bb0a8ae0a1..bb328349b44a 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -165,6 +165,7 @@ @@ -2547,5 +2547,5 @@ PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf !else -- -2.13.2.932.g7449e964c-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/03_Library_EndofDXE.patch b/payloads/external/tianocore/patches/03_Library_EndofDXE.patch index 02ba42b..cca3eea 100644 --- a/payloads/external/tianocore/patches/03_Library_EndofDXE.patch +++ b/payloads/external/tianocore/patches/03_Library_EndofDXE.patch @@ -1,16 +1,16 @@ -From 760f1cafdd689beedc8418ab89e856b54296389c Mon Sep 17 00:00:00 2001 +From 1e9c5c97a55f3ad3c0d6d5dde380b4d73bd15860 Mon Sep 17 00:00:00 2001 From: CoolStar <coolstarorganization(a)gmail.com> Date: Sun, 4 Dec 2016 12:07:30 -0800 Subject: [PATCH] CorebootBdsLib: Call End of DXE event to allow booting 3rd party efi binaries. --- - .../Library/CorebootBdsLib/BdsPlatform.c | 42 ++++++++++++++++++++++ - .../Library/CorebootBdsLib/PlatformBds.inf | 1 + + .../Library/CorebootBdsLib/BdsPlatform.c | 42 +++++++++++++++++++ + .../Library/CorebootBdsLib/PlatformBds.inf | 1 + 2 files changed, 43 insertions(+) diff --git a/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c -index b6253a17f8..cf3e5320cb 100644 +index b6253a17f8ea..cf3e5320cbe8 100644 --- a/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c +++ b/CorebootModulePkg/Library/CorebootBdsLib/BdsPlatform.c @@ -1129,6 +1129,46 @@ Returns: @@ -70,7 +70,7 @@ // Init the time out value // diff --git a/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf b/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf -index 578c74afae..992bd846bd 100644 +index 578c74afae22..992bd846bdc4 100644 --- a/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf +++ b/CorebootModulePkg/Library/CorebootBdsLib/PlatformBds.inf @@ -58,6 +58,7 @@ @@ -82,5 +82,5 @@ [Pcd] gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut -- -2.13.2.725.g09c95d1e9-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch b/payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch index e90b70e..2b7da9d 100644 --- a/payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch +++ b/payloads/external/tianocore/patches/04_CorebootPayloadPkg_addps2.patch @@ -1,4 +1,4 @@ -From 77c5dfcce842819215490fe63c481860fa7d752d Mon Sep 17 00:00:00 2001 +From e8d6ed35c15b92497cd3ede6cd35523b0e7366ac Mon Sep 17 00:00:00 2001 From: CoolStar <coolstarorganization(a)gmail.com> Date: Sun, 4 Dec 2016 11:50:00 -0800 Subject: [PATCH] CorebootPayloadPkg: Add PS/2 keyboard drivers. @@ -10,7 +10,7 @@ 3 files changed, 9 insertions(+) diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg/CorebootPayloadPkg.fdf -index 347e9c75ce..a347af0c9a 100644 +index 22987093da58..0961e96c250d 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf @@ -132,6 +132,9 @@ INF DuetPkg/PciBusNoEnumerationDxe/PciBusNoEnumeration.inf @@ -24,7 +24,7 @@ # # Console Support diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc -index 5ce823bb95..60ee064c59 100644 +index 053f380a8608..6ddd64faf7a5 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -492,6 +492,9 @@ @@ -38,7 +38,7 @@ # # Console Support diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc -index fea297a77a..167329c897 100644 +index bb328349b44a..19c203e6cbb6 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -493,6 +493,9 @@ @@ -52,5 +52,5 @@ # # Console Support -- -2.13.2.725.g09c95d1e9-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/05_CorebootPayloadPkg_noserial.patch b/payloads/external/tianocore/patches/05_CorebootPayloadPkg_noserial.patch index 0e84b7d..0e40ed9 100644 --- a/payloads/external/tianocore/patches/05_CorebootPayloadPkg_noserial.patch +++ b/payloads/external/tianocore/patches/05_CorebootPayloadPkg_noserial.patch @@ -1,4 +1,4 @@ -From 77f75370d6fbfefb04456f6e1c32c85d4bac8bf5 Mon Sep 17 00:00:00 2001 +From 7d758b06a47225fc54955acc8f70aa31f4cf7d32 Mon Sep 17 00:00:00 2001 From: Matt Devo <matt.devillier(a)gmail.com> Date: Thu, 23 Feb 2017 14:11:14 -0600 Subject: [PATCH] CorebootPayloadPkg: don't use serial output @@ -9,7 +9,7 @@ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc -index 1d80fc4f5c..ce360c9e9e 100644 +index 6ddd64faf7a5..ef83c28adf9b 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -261,7 +261,7 @@ @@ -22,7 +22,7 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc -index 52b26eb3d0..a27b0873a1 100644 +index 19c203e6cbb6..9b74e3a8f311 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -261,7 +261,7 @@ @@ -35,5 +35,5 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE -- -2.13.2.725.g09c95d1e9-goog +2.17.0 diff --git a/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch b/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch index da8fc7f..10024d8 100644 --- a/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch +++ b/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch @@ -1,4 +1,4 @@ -From 336ce69129206ea6cb5bea2a99c5f00e77850518 Mon Sep 17 00:00:00 2001 +From 9c28ac87eb2df7319d4f5a48124c837b8bf123b3 Mon Sep 17 00:00:00 2001 From: ReddestDream <reddestdream(a)gmail.com> Date: Wed, 3 May 2017 00:13:28 -0400 Subject: [PATCH] CbSupportPei: prevent lower coreboot table from being diff --git a/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch b/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch index 6370efc..9b2569a 100644 --- a/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch +++ b/payloads/external/tianocore/patches/07_CorebootPayloadPkg-Use-correct-BytesPerScanLine.patch @@ -1,4 +1,4 @@ -From 07dec11fe965e73cfef7df38af70c945b6ff21a2 Mon Sep 17 00:00:00 2001 +From 2e75f9ad6ef625575185dfc262c6803a89850dd5 Mon Sep 17 00:00:00 2001 From: Arthur Heymans <arthur(a)aheymans.xyz> Date: Wed, 24 Jan 2018 10:07:08 +0100 Subject: [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine @@ -12,9 +12,12 @@ Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> +--- + CorebootPayloadPkg/FbGop/FbGop.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CorebootPayloadPkg/FbGop/FbGop.c b/CorebootPayloadPkg/FbGop/FbGop.c -index 37d6def7f7..6790617033 100644 +index 37d6def7f780..679061703358 100644 --- a/CorebootPayloadPkg/FbGop/FbGop.c +++ b/CorebootPayloadPkg/FbGop/FbGop.c @@ -822,7 +822,7 @@ FbGopCheckForVbe ( @@ -27,5 +30,5 @@ ModeBuffer = (FB_VIDEO_MODE_DATA *) AllocatePool ( ModeNumber * sizeof (FB_VIDEO_MODE_DATA) -- -2.16.1 +2.17.0 diff --git a/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch b/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch index 06ddd56..4881fff 100644 --- a/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch +++ b/payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch @@ -1,4 +1,4 @@ -From b652262ed0dd554c44e7b1bf7134d3458f5edef1 Mon Sep 17 00:00:00 2001 +From 8cb365e9ec90420e3d04b77f6e7999a65d5983a6 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph <siro(a)das-labor.org> Date: Sun, 17 Jun 2018 08:44:51 +0200 Subject: [PATCH] BaseTools: Fix building with -Werror=stringop-truncation @@ -9,7 +9,7 @@ 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/GenVtf/GenVtf.c b/BaseTools/Source/C/GenVtf/GenVtf.c -index acc142a6d1..5d77016eba 100644 +index 65ae08eeceb8..d4200621457c 100644 --- a/BaseTools/Source/C/GenVtf/GenVtf.c +++ b/BaseTools/Source/C/GenVtf/GenVtf.c @@ -129,9 +129,9 @@ Returns: @@ -24,7 +24,7 @@ } sscanf ( -@@ -1529,7 +1529,7 @@ Returns: +@@ -1521,7 +1521,7 @@ Returns: // FitStartPtr = (FIT_TABLE *) RelativeAddress; diff --git a/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch b/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch deleted file mode 100644 index 7016759..0000000 --- a/payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch +++ /dev/null @@ -1,40 +0,0 @@ -From 5546ab29b2c0c2fc3a963bc71221918dc77b6152 Mon Sep 17 00:00:00 2001 -From: Patrick Rudolph <siro(a)das-labor.org> -Date: Sun, 17 Jun 2018 08:53:25 +0200 -Subject: [PATCH] gcc7: Fix building with -fpermissive - -Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> ---- - BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp | 2 +- - MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 2 +- - 2 files changed, 2 insertions(+), 2 deletions(-) - -diff --git a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp -index 3ca57ed741..4fa066dd9f 100644 ---- a/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp -+++ b/BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp -@@ -3372,7 +3372,7 @@ CVfrStringDB::GetVarStoreNameFormStringId ( - UINT8 BlockType; - EFI_HII_STRING_PACKAGE_HDR *PkgHeader; - -- if (mStringFileName == '\0' ) { -+ if (mStringFileName == NULL ) { - return NULL; - } - -diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c -index 857950118f..de0aa5f7bc 100644 ---- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c -+++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c -@@ -2181,7 +2181,7 @@ InternalHiiIfrValueAction ( - - StringPtr = ConfigAltResp; - -- while (StringPtr != L'\0') { -+ while (StringPtr != NULL) { - // - // 1. Find <ConfigHdr> GUID=...&NAME=...&PATH=... - // --- -2.17.0 - -- To view, visit https://review.coreboot.org/27615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib409f6f93eb64d7a9a2f09a75f8e637ab8689410 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com>

1 0

Change in coreboot[master]: payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep...
by build bot (Jenkins) (Code Review) 24 Jul '18

24 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27614 ) Change subject: payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep_cb_table ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/27614/1/payloads/external/tianocore/patches… File payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch: https://review.coreboot.org/#/c/27614/1/payloads/external/tianocore/patches… PS1, Line 26: trailing whitespace https://review.coreboot.org/#/c/27614/1/payloads/external/tianocore/patches… PS1, Line 27: trailing whitespace https://review.coreboot.org/#/c/27614/1/payloads/external/tianocore/patches… PS1, Line 28: -- trailing whitespace -- To view, visit https://review.coreboot.org/27614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130856520f91bcfbd9a62741b1d5abb6495a6eac Gerrit-Change-Number: 27614 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Jul 2018 23:58:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep...
by Piotr Król (Code Review) 24 Jul '18

24 Jul '18

Piotr Król has uploaded this change for review. ( https://review.coreboot.org/27614 Change subject: payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep_cb_table ...................................................................... payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep_cb_table Mentioned patch could not be applied in coreboot-sdk:1.52. With this fix patch apply correctly. Change-Id: I130856520f91bcfbd9a62741b1d5abb6495a6eac Signed-off-by: Piotr Król <piotr.krol(a)3mdeb.com> --- M payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/27614/1 diff --git a/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch b/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch index e75052b..da8fc7f 100644 --- a/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch +++ b/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch @@ -1,13 +1,16 @@ -From ef89b11ce6f93c96fbd1753a8006dd9c3da212e0 Mon Sep 17 00:00:00 2001 +From 336ce69129206ea6cb5bea2a99c5f00e77850518 Mon Sep 17 00:00:00 2001 From: ReddestDream <reddestdream(a)gmail.com> Date: Wed, 3 May 2017 00:13:28 -0400 Subject: [PATCH] CbSupportPei: prevent lower coreboot table from being overwritten Exclude the bottom 4kb from being included in System Memory HoB +--- + CorebootModulePkg/CbSupportPei/CbSupportPei.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CorebootModulePkg/CbSupportPei/CbSupportPei.c b/CorebootModulePkg/CbSupportPei/CbSupportPei.c -index 262e6b9..d3c5723 100755 +index 831de89b21d1..e84b9b55288a 100755 --- a/CorebootModulePkg/CbSupportPei/CbSupportPei.c +++ b/CorebootModulePkg/CbSupportPei/CbSupportPei.c @@ -261,8 +261,9 @@ CbPeiEntryPoint ( @@ -20,7 +23,8 @@ + (EFI_PHYSICAL_ADDRESS)(0 + 0x1000), + (UINT64)(0xA0000 - 0x1000) ); + + +-- +2.17.0 - --- -2.14.0 -- To view, visit https://review.coreboot.org/27614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I130856520f91bcfbd9a62741b1d5abb6495a6eac Gerrit-Change-Number: 27614 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com>

1 0

Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature
by Furquan Shaikh (Code Review) 24 Jul '18

24 Jul '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27613 ) Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27613/1/src/drivers/i2c/da7219/chip.h File src/drivers/i2c/da7219/chip.h: https://review.coreboot.org/#/c/27613/1/src/drivers/i2c/da7219/chip.h@5 PS1, Line 5: linux/Documentation/devicetree/bindings/sound/da7219.txt > As noted here, the parameters are documented in [0] which states that all of the da7219_aad child no […] Aah okay. -- To view, visit https://review.coreboot.org/27613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9 Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Jul 2018 23:43:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature
by Daniel Kurtz (Code Review) 24 Jul '18

24 Jul '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27613 ) Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27613/1/src/drivers/i2c/da7219/chip.h File src/drivers/i2c/da7219/chip.h: https://review.coreboot.org/#/c/27613/1/src/drivers/i2c/da7219/chip.h@5 PS1, Line 5: linux/Documentation/devicetree/bindings/sound/da7219.txt As noted here, the parameters are documented in [0] which states that all of the da7219_aad child node properties are optional. [0] https://www.kernel.org/doc/Documentation/devicetree/bindings/sound/da7219.t… -- To view, visit https://review.coreboot.org/27613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9 Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Jul 2018 23:37:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature
by Furquan Shaikh (Code Review) 24 Jul '18

24 Jul '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27613 ) Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27613/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27613/1//COMMIT_MSG@9 PS1, Line 9: optional Can you please add a comment here indicating that the params are optional: https://review.coreboot.org/cgit/coreboot.git/tree/src/drivers/i2c/da7219/c… -- To view, visit https://review.coreboot.org/27613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9 Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 23 Jul 2018 23:32:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature
by Furquan Shaikh (Code Review) 24 Jul '18

24 Jul '18

1 0

Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature
by Daniel Kurtz (Code Review) 24 Jul '18

24 Jul '18

Daniel Kurtz has uploaded this change for review. ( https://review.coreboot.org/27613 Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature ...................................................................... drivers/i2c/da7219: Allow disabling micbias-pulse feature These two da7219_aad properties are optional: - dlg,micbias-pulse-lvl : Mic bias higher voltage pulse level (mV). [<2800>, <2900>] - dlg,micbias-pulse-time : Mic bias higher voltage pulse duration (ms) When the Mic Bias Higher Voltage feature is not required, firmware should just not provide the dlg,micbias-pulse-lvl and dlg,micbias-pulse-time properties. Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> BUG=b:111700809 TEST=On grunt: No "Invalid micbias pulse level" in dmesg Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9 --- M src/drivers/i2c/da7219/da7219.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/27613/1 diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c index b8af689..43e6076 100644 --- a/src/drivers/i2c/da7219/da7219.c +++ b/src/drivers/i2c/da7219/da7219.c @@ -77,10 +77,12 @@ acpi_dp_add_integer(aad, "dlg,c-mic-btn-thr", config->c_mic_btn_thr); acpi_dp_add_integer(aad, "dlg,btn-avg", config->btn_avg); acpi_dp_add_integer(aad, "dlg,adc-1bit-rpt", config->adc_1bit_rpt); - acpi_dp_add_integer(aad, "dlg,micbias-pulse-lvl", - config->micbias_pulse_lvl); - acpi_dp_add_integer(aad, "dlg,micbias-pulse-time", - config->micbias_pulse_time); + if (config->micbias_pulse_lvl > 0) { + acpi_dp_add_integer(aad, "dlg,micbias-pulse-lvl", + config->micbias_pulse_lvl); + acpi_dp_add_integer(aad, "dlg,micbias-pulse-time", + config->micbias_pulse_time); + } /* DA7219 Properties */ dsd = acpi_dp_new_table("_DSD"); -- To view, visit https://review.coreboot.org/27613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9 Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Configure DA7219 VDDIO to 1.8 V
by Daniel Kurtz (Code Review) 24 Jul '18

24 Jul '18

Hello Daniel Kurtz, build bot (Jenkins), Martin Roth, Akshu Agrawal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27562 to look at the new patch set (#3). Change subject: mainboard/google/kahlee: Configure DA7219 VDDIO to 1.8 V ...................................................................... mainboard/google/kahlee: Configure DA7219 VDDIO to 1.8 V Set the da7219 vddio property, to specify that these boards use 1.8 V VDDIO. Signed-off-by: Daniel Kurtz <djkurtz(a)chromium.org> BUG=b:111268770 TEST=On grunt: grep 91 /sys/kernel/debug/regmap/i2c-DLGS7219:00/registers => 91: 01 Change-Id: Icdf99ac80bd11d8eecff7d3de781980ea78f23d4 --- M src/mainboard/google/kahlee/variants/aleena/devicetree.cb M src/mainboard/google/kahlee/variants/careena/devicetree.cb M src/mainboard/google/kahlee/variants/grunt/devicetree.cb M src/mainboard/google/kahlee/variants/liara/devicetree.cb 4 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/27562/3 -- To view, visit https://review.coreboot.org/27562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icdf99ac80bd11d8eecff7d3de781980ea78f23d4 Gerrit-Change-Number: 27562 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
28
29
30
31
32
33
34
...
88
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018