Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/27014 )
Change subject: nb/lenovo/t400: Enable libgfxinit
......................................................................
Patch Set 2:
Did you test it on T400 ?
--
To view, visit https://review.coreboot.org/27014
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I243c22c83a5575c2e1500cc869c41691c4fba415
Gerrit-Change-Number: 27014
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Mon, 11 Jun 2018 09:26:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27010 )
Change subject: src: Use of device_t is deprecated
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/27010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cebfc5c77187bd81094031c43ff6df094908417
Gerrit-Change-Number: 27010
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 11 Jun 2018 08:50:49 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27015 )
Change subject: src: Move constant to the right side of comparison
......................................................................
Patch Set 2:
`if (const == variable)` is a pattern to make accidental `=` a compile error: `if (const = variable)` is a compile time error, `if (variable = const)` is not.
So while we might or might not want to have this idiom in our tree, it's bound to pop up again...
--
To view, visit https://review.coreboot.org/27015
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7
Gerrit-Change-Number: 27015
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Comment-Date: Mon, 11 Jun 2018 08:48:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27015 )
Change subject: src: Move constant to the right side of comparison
......................................................................
Patch Set 2:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/74748/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/28847/ : SUCCESS
--
To view, visit https://review.coreboot.org/27015
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7
Gerrit-Change-Number: 27015
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 11 Jun 2018 08:47:19 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No