coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: cpu/amd: Remove duplicated includes
by Elyes HAOUAS (Code Review) 12 Jun '18

12 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/27018 Change subject: cpu/amd: Remove duplicated includes ...................................................................... cpu/amd: Remove duplicated includes Change-Id: I3544ce4a573b6996d64b140d8acdaeb3de430896 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/amd/agesa/family12/model_12_init.c M src/cpu/amd/agesa/family14/model_14_init.c M src/cpu/amd/agesa/family15tn/model_15_init.c M src/cpu/amd/agesa/family16kb/model_16_init.c M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c M src/cpu/amd/family_10h-family_15h/powernow_acpi.c M src/cpu/amd/pi/00630F01/model_15_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c 9 files changed, 0 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/27018/1 diff --git a/src/cpu/amd/agesa/family12/model_12_init.c b/src/cpu/amd/agesa/family12/model_12_init.c index f96ad9e..d4f5cc9 100644 --- a/src/cpu/amd/agesa/family12/model_12_init.c +++ b/src/cpu/amd/agesa/family12/model_12_init.c @@ -18,14 +18,11 @@ #include <cpu/amd/mtrr.h> #include <device/device.h> #include <string.h> -#include <cpu/x86/msr.h> #include <cpu/x86/pae.h> #include <pc80/mc146818rtc.h> #include <cpu/x86/lapic.h> - #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <cpu/x86/mtrr.h> #include <cpu/amd/multicore.h> #include <cpu/amd/amdfam12.h> diff --git a/src/cpu/amd/agesa/family14/model_14_init.c b/src/cpu/amd/agesa/family14/model_14_init.c index f497d93..1679080 100644 --- a/src/cpu/amd/agesa/family14/model_14_init.c +++ b/src/cpu/amd/agesa/family14/model_14_init.c @@ -18,14 +18,11 @@ #include <cpu/amd/mtrr.h> #include <device/device.h> #include <string.h> -#include <cpu/x86/msr.h> #include <cpu/x86/pae.h> #include <pc80/mc146818rtc.h> #include <cpu/x86/lapic.h> - #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <cpu/x86/mtrr.h> #include <cpu/amd/amdfam14.h> #include <arch/acpi.h> #include <northbridge/amd/agesa/agesa_helper.h> diff --git a/src/cpu/amd/agesa/family15tn/model_15_init.c b/src/cpu/amd/agesa/family15tn/model_15_init.c index 16b8ae3..a5e8acb 100644 --- a/src/cpu/amd/agesa/family15tn/model_15_init.c +++ b/src/cpu/amd/agesa/family15tn/model_15_init.c @@ -19,14 +19,11 @@ #include <cpu/amd/mtrr.h> #include <device/device.h> #include <string.h> -#include <cpu/x86/msr.h> #include <cpu/x86/pae.h> #include <pc80/mc146818rtc.h> #include <cpu/x86/lapic.h> - #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <cpu/x86/mtrr.h> #include <cpu/amd/amdfam15.h> #include <arch/acpi.h> #include <northbridge/amd/agesa/agesa_helper.h> diff --git a/src/cpu/amd/agesa/family16kb/model_16_init.c b/src/cpu/amd/agesa/family16kb/model_16_init.c index b19aa90..747dc76 100644 --- a/src/cpu/amd/agesa/family16kb/model_16_init.c +++ b/src/cpu/amd/agesa/family16kb/model_16_init.c @@ -18,14 +18,11 @@ #include <cpu/amd/mtrr.h> #include <device/device.h> #include <string.h> -#include <cpu/x86/msr.h> #include <cpu/x86/pae.h> #include <pc80/mc146818rtc.h> #include <cpu/x86/lapic.h> - #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <cpu/x86/mtrr.h> #include <cpu/amd/amdfam16.h> #include <arch/acpi.h> #include <northbridge/amd/agesa/agesa_helper.h> diff --git a/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c b/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c index 0b7ddc6..562a267 100644 --- a/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c +++ b/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c @@ -20,7 +20,6 @@ #include <device/device.h> #include <device/pci.h> #include <string.h> -#include <cpu/x86/msr.h> #include <cpu/x86/smm.h> #include <cpu/x86/pae.h> #include <pc80/mc146818rtc.h> diff --git a/src/cpu/amd/family_10h-family_15h/powernow_acpi.c b/src/cpu/amd/family_10h-family_15h/powernow_acpi.c index 2f1db20..35f7952 100644 --- a/src/cpu/amd/family_10h-family_15h/powernow_acpi.c +++ b/src/cpu/amd/family_10h-family_15h/powernow_acpi.c @@ -23,7 +23,6 @@ #include <cpu/amd/powernow.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <cpu/amd/amdfam10_sysconf.h> #include <arch/cpu.h> diff --git a/src/cpu/amd/pi/00630F01/model_15_init.c b/src/cpu/amd/pi/00630F01/model_15_init.c index 6c3e594..a75801c 100644 --- a/src/cpu/amd/pi/00630F01/model_15_init.c +++ b/src/cpu/amd/pi/00630F01/model_15_init.c @@ -20,14 +20,11 @@ #include <device/device.h> #include <device/pci.h> #include <string.h> -#include <cpu/x86/msr.h> #include <cpu/x86/pae.h> #include <pc80/mc146818rtc.h> #include <cpu/x86/lapic.h> - #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <cpu/x86/mtrr.h> #include <cpu/amd/amdfam15.h> #include <arch/acpi.h> diff --git a/src/cpu/amd/pi/00660F01/model_15_init.c b/src/cpu/amd/pi/00660F01/model_15_init.c index 8a8a0a7..6c94aba 100644 --- a/src/cpu/amd/pi/00660F01/model_15_init.c +++ b/src/cpu/amd/pi/00660F01/model_15_init.c @@ -19,14 +19,11 @@ #include <device/device.h> #include <device/pci.h> #include <string.h> -#include <cpu/x86/msr.h> #include <cpu/x86/pae.h> #include <pc80/mc146818rtc.h> #include <cpu/x86/lapic.h> - #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <cpu/x86/mtrr.h> #include <cpu/amd/amdfam15.h> #include <arch/acpi.h> diff --git a/src/cpu/amd/pi/00730F01/model_16_init.c b/src/cpu/amd/pi/00730F01/model_16_init.c index 25cb5dc..4e7948d 100644 --- a/src/cpu/amd/pi/00730F01/model_16_init.c +++ b/src/cpu/amd/pi/00730F01/model_16_init.c @@ -19,14 +19,11 @@ #include <device/device.h> #include <device/pci.h> #include <string.h> -#include <cpu/x86/msr.h> #include <cpu/x86/pae.h> #include <pc80/mc146818rtc.h> #include <cpu/x86/lapic.h> - #include <cpu/cpu.h> #include <cpu/x86/cache.h> -#include <cpu/x86/mtrr.h> #include <cpu/amd/amdfam16.h> #include <arch/acpi.h> -- To view, visit https://review.coreboot.org/27018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3544ce4a573b6996d64b140d8acdaeb3de430896 Gerrit-Change-Number: 27018 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: nb/intel/x4x: Fix a few things in set_enhanced_mode
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26565 ) Change subject: nb/intel/x4x: Fix a few things in set_enhanced_mode ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74758/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28860/ : SUCCESS -- To view, visit https://review.coreboot.org/26565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1afa637a16a083c3a945ba3e2a71292b005736fd Gerrit-Change-Number: 26565 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Jun 2018 14:48:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Work around a quirk
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26564 ) Change subject: nb/intel/x4x: Work around a quirk ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74757/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28859/ : SUCCESS -- To view, visit https://review.coreboot.org/26564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f37ce15a4e98a4cdbd6d893f22846a65c8be021 Gerrit-Change-Number: 26564 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Mon, 11 Jun 2018 14:26:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Prepare sconfig to allow parsing multiple trees
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27017 ) Change subject: util/sconfig: Prepare sconfig to allow parsing multiple trees ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74756/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28858/ : SUCCESS -- To view, visit https://review.coreboot.org/27017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I403a90c1ebf07ac66115ddfe137daf0980dc1a18 Gerrit-Change-Number: 27017 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Jun 2018 11:44:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Prepare sconfig to allow parsing multiple trees
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27017 ) Change subject: util/sconfig: Prepare sconfig to allow parsing multiple trees ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/27017/1/util/sconfig/main.c File util/sconfig/main.c: https://review.coreboot.org/#/c/27017/1/util/sconfig/main.c@47 PS1, Line 47: * | Root device | | Mainboard | line over 80 characters https://review.coreboot.org/#/c/27017/1/util/sconfig/main.c@48 PS1, Line 48: * +---------+ (base_root_dev) +--------------->+ instance + line over 80 characters -- To view, visit https://review.coreboot.org/27017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I403a90c1ebf07ac66115ddfe137daf0980dc1a18 Gerrit-Change-Number: 27017 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Jun 2018 11:44:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Prepare sconfig to allow parsing multiple trees
by Furquan Shaikh (Code Review) 11 Jun '18

11 Jun '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27017 Change subject: util/sconfig: Prepare sconfig to allow parsing multiple trees ...................................................................... util/sconfig: Prepare sconfig to allow parsing multiple trees In preparation to allow devicetree overrides, it will be necessary to use the same parsing functions to prepare two separate parse trees. This change does the following things: 1. Updates root device and bus names to add base_ prefix. 2. Adds a function parse_devicetree that sets the root_parent and linenum before calling yyparse(). 3. Updates all uses of root_dev to refer to the next base_root_dev. BUG=b:80081934 TEST=Verified that static.c generated for all boards built using abuild is the same with and without this change. Change-Id: I403a90c1ebf07ac66115ddfe137daf0980dc1a18 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c 1 file changed, 32 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/27017/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 2a7fa15..b293c5d 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -20,6 +20,7 @@ extern int linenum; +/* Maintains list of all the unique chip structures for the board. */ static struct chip chip_header; /* @@ -43,8 +44,8 @@ * * * +------------------------+ +----------------------+ - * | | | Mainboard | - * +---------+ Root device (root_dev) +--------------->+ instance + + * | Root device | | Mainboard | + * +---------+ (base_root_dev) +--------------->+ instance + * | | | chip_instance | (mainboard_instance)| * | +------------------------+ | | * | | +----------------------+ @@ -52,7 +53,7 @@ * | parent v | * | +-------------------+ | * | | Root bus | | - * +----------->+ (root_bus) | | + * +----------->+ (base_root_bus) | | * | | | * +-------------------+ | * | | @@ -74,23 +75,23 @@ * * */ -static struct device root_dev; +static struct device base_root_dev; static struct chip_instance mainboard_instance; -static struct bus root_bus = { +static struct bus base_root_bus = { .id = 0, - .dev = &root_dev, + .dev = &base_root_dev, }; -static struct device root_dev = { +static struct device base_root_dev = { .name = "dev_root", .id = 0, .chip_instance = &mainboard_instance, .path = " .type = DEVICE_PATH_ROOT ", .ops = "&default_dev_ops_root", - .parent = &root_bus, + .parent = &base_root_bus, .enabled = 1, - .bus = &root_bus, + .bus = &base_root_bus, }; static struct chip mainboard_chip = { @@ -105,7 +106,7 @@ }; /* This is the parent of all devices added by parsing the devicetree file. */ -struct bus *root_parent = &root_bus; +struct bus *root_parent; struct queue_entry { void *data; @@ -581,7 +582,7 @@ static void pass0(FILE *fil, struct device *ptr, struct device *next) { - if (ptr == &root_dev) { + if (ptr == &base_root_dev) { fprintf(fil, "DEVTREE_CONST struct bus %s_links[];\n", ptr->name); return; @@ -670,7 +671,7 @@ struct chip_instance *chip_ins = ptr->chip_instance; int has_children = dev_has_children(ptr); - if (ptr != &root_dev) + if (ptr != &base_root_dev) fprintf(fil, "static "); fprintf(fil, "DEVTREE_CONST struct device %s = {\n", ptr->name); fprintf(fil, "#if !DEVTREE_EARLY\n"); @@ -867,15 +868,9 @@ #define ARG_COUNT 3 -int main(int argc, char **argv) +static void parse_devicetree(const char *file, struct bus *parent) { - if (argc != ARG_COUNT) - usage(); - - char *devtree = argv[DEVICEFILE_ARG]; - char *outputc = argv[OUTPUTFILE_ARG]; - - FILE *filec = fopen(devtree, "r"); + FILE *filec = fopen(file, "r"); if (!filec) { perror(NULL); exit(1); @@ -883,9 +878,23 @@ yyrestart(filec); + root_parent = parent; + linenum = 0; + yyparse(); fclose(filec); +} + +int main(int argc, char **argv) +{ + if (argc != ARG_COUNT) + usage(); + + char *base_devtree = argv[DEVICEFILE_ARG]; + char *outputc = argv[OUTPUTFILE_ARG]; + + parse_devicetree(base_devtree, &base_root_bus); FILE *autogen = fopen(outputc, "w"); if (!autogen) { @@ -897,11 +906,11 @@ emit_chips(autogen); - walk_device_tree(autogen, &root_dev, inherit_subsystem_ids); + walk_device_tree(autogen, &base_root_dev, inherit_subsystem_ids); fprintf(autogen, "\n/* pass 0 */\n"); - walk_device_tree(autogen, &root_dev, pass0); + walk_device_tree(autogen, &base_root_dev, pass0); fprintf(autogen, "\n/* pass 1 */\n"); - walk_device_tree(autogen, &root_dev, pass1); + walk_device_tree(autogen, &base_root_dev, pass1); fclose(autogen); -- To view, visit https://review.coreboot.org/27017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I403a90c1ebf07ac66115ddfe137daf0980dc1a18 Gerrit-Change-Number: 27017 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: src: Move constant to the right side of comparison
by Elyes HAOUAS (Code Review) 11 Jun '18

11 Jun '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/27015 ) Change subject: src: Move constant to the right side of comparison ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/27015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Gerrit-Change-Number: 27015 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: lib/device_tree: Add method to get phandle
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26191 ) Change subject: lib/device_tree: Add method to get phandle ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74754/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28854/ : SUCCESS -- To view, visit https://review.coreboot.org/26191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I966151ad7e82fc678ab4f56cf9b5868ef39398e0 Gerrit-Change-Number: 26191 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Jun 2018 10:26:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: lib: Add FIT payload support
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25019 ) Change subject: lib: Add FIT payload support ...................................................................... Patch Set 34: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74753/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28853/ : SUCCESS -- To view, visit https://review.coreboot.org/25019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f27b92a5e074966f893399eb401eb97d784850d Gerrit-Change-Number: 25019 Gerrit-PatchSet: 34 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Rudolph Gerrit-Comment-Date: Mon, 11 Jun 2018 10:26:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/crossgcc: update to gcc 8.1.0 and binutils 2.30
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25997 ) Change subject: util/crossgcc: update to gcc 8.1.0 and binutils 2.30 ...................................................................... Patch Set 19: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-toolchain/439/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74752/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28852/ : SUCCESS -- To view, visit https://review.coreboot.org/25997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e8074954d5d7a4eff590abb7439e9be7d3762aa Gerrit-Change-Number: 25997 Gerrit-PatchSet: 19 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Comment-Date: Mon, 11 Jun 2018 10:21:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018