Nick Vaccaro has uploaded a new patch set (#2). ( https://review.coreboot.org/27023 )
Change subject: mb/google/poppy/variants/nocturne: config GPP_E2 for BT_DISABLE_L
......................................................................
mb/google/poppy/variants/nocturne: config GPP_E2 for BT_DISABLE_L
GPP_E2 will be used as a BT reset line, so configure GPP_E2 as an
output and initialize it high (high = out of reset).
BUG=b:80089559
BRANCH=none
TEST=none
Change-Id: If45ef3a592c389a0b80298c59eea849d07d9671e
Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com>
---
M src/mainboard/google/poppy/variants/nocturne/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/27023/2
--
To view, visit https://review.coreboot.org/27023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If45ef3a592c389a0b80298c59eea849d07d9671e
Gerrit-Change-Number: 27023
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Maulik V Vaghela has abandoned this change. ( https://review.coreboot.org/26943 )
Change subject: soc/intel/{skl,cnl,apl}: Move common UART code to common block
......................................................................
Abandoned
Abandoning this as changes has been incorporated in main patch
--
To view, visit https://review.coreboot.org/26943
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia583262d07e1c1ed2105fed25fbd5c8adb07c994
Gerrit-Change-Number: 26943
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27021
to look at the new patch set (#2).
Change subject: google/grunt: Enable keyboard backlight for careena specific SKU
......................................................................
google/grunt: Enable keyboard backlight for careena specific SKU
Enable keyboard backlight by Careena SKUID
BUG=none
BRANCH=master
TEST=emerge-grunt coreboot
Change-Id: I7d302c4f50528b0e6b7ef4d990f342a69cff34f5
Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
---
M src/mainboard/google/kahlee/variants/baseboard/romstage.c
1 file changed, 24 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/27021/2
--
To view, visit https://review.coreboot.org/27021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d302c4f50528b0e6b7ef4d990f342a69cff34f5
Gerrit-Change-Number: 27021
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27021 )
Change subject: google/grunt: Enable keyboard backlight for careena specific SKU
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/27021/1/src/mainboard/google/kahlee/variant…
File src/mainboard/google/kahlee/variants/baseboard/romstage.c:
https://review.coreboot.org/#/c/27021/1/src/mainboard/google/kahlee/variant…
PS1, Line 35: /* Based on SKU, turn on keyboard backlight to show system is booting */
line over 80 characters
https://review.coreboot.org/#/c/27021/1/src/mainboard/google/kahlee/variant…
PS1, Line 36: switch (sku) {
switch and case should be at the same indent
--
To view, visit https://review.coreboot.org/27021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d302c4f50528b0e6b7ef4d990f342a69cff34f5
Gerrit-Change-Number: 27021
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 12 Jun 2018 05:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No