coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: src: Move constant to the right side of comparison
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

1 0

Change in coreboot[master]: src: Move constant to the right side of comparison
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27015 ) Change subject: src: Move constant to the right side of comparison ...................................................................... Patch Set 5: (9 comments) https://review.coreboot.org/#/c/27015/5/util/msrtool/linux.c File util/msrtool/linux.c: https://review.coreboot.org/#/c/27015/5/util/msrtool/linux.c@71 PS5, Line 71: return ret ==0; spaces required around that '==' (ctx:WxV) https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c File util/msrtool/msrtool.c: https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@128 PS5, Line 128: if ((fin = fopen(streamfn, "r")) == NULL) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@136 PS5, Line 136: if ((fdout = mkstemp(tmpfn)) == -1) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@140 PS5, Line 140: if ((fout = fdopen(fdout, "w")) == NULL) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@145 PS5, Line 145: if ((fout = fopen(streamfn, "w")) == NULL) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@216 PS5, Line 216: else if ((fin = fopen(difffn, "r")) == NULL) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@226 PS5, Line 226: for (len = strlen(m1start) - 1; strchr("\r\n", m1start[len]) != NULL; --len) line over 80 characters https://review.coreboot.org/#/c/27015/5/util/msrtool/msrutils.c File util/msrtool/msrutils.c: https://review.coreboot.org/#/c/27015/5/util/msrtool/msrutils.c@325 PS5, Line 325: if (m= NULL) { spaces required around that '=' (ctx:VxW) https://review.coreboot.org/#/c/27015/5/util/msrtool/msrutils.c@325 PS5, Line 325: if (m= NULL) { do not use assignment in if condition -- To view, visit https://review.coreboot.org/27015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Gerrit-Change-Number: 27015 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Mon, 11 Jun 2018 10:05:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src: Move constant to the right side of comparison
by Elyes HAOUAS (Code Review) 11 Jun '18

11 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27015 to look at the new patch set (#6). Change subject: src: Move constant to the right side of comparison ...................................................................... src: Move constant to the right side of comparison Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/pci_rom.c M src/northbridge/amd/agesa/family16kb/state_machine.c M src/northbridge/amd/amdmct/mct/mctardk4.c M src/soc/mediatek/mt8173/pmic_wrap.c M src/southbridge/amd/cimx/sb800/late.c 5 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/27015/6 -- To view, visit https://review.coreboot.org/27015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Gerrit-Change-Number: 27015 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: src: Move constant to the right side of comparison
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

1 0

Change in coreboot[master]: src: Move constant to the right side of comparison
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

1 0

Change in coreboot[master]: src: Move constant to the right side of comparison
by Elyes HAOUAS (Code Review) 11 Jun '18

11 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27015 to look at the new patch set (#5). Change subject: src: Move constant to the right side of comparison ...................................................................... src: Move constant to the right side of comparison Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/pci_rom.c M src/northbridge/amd/agesa/family16kb/state_machine.c M src/northbridge/amd/amdmct/mct/mctardk4.c M src/soc/mediatek/mt8173/pmic_wrap.c M src/southbridge/amd/cimx/sb800/late.c M util/msrtool/freebsd.c M util/msrtool/geodegx2.c M util/msrtool/geodelx.c M util/msrtool/intel_atom.c M util/msrtool/intel_core1.c M util/msrtool/intel_core2_early.c M util/msrtool/intel_core2_later.c M util/msrtool/intel_nehalem.c M util/msrtool/intel_pentium3.c M util/msrtool/intel_pentium3_early.c M util/msrtool/intel_pentium4_early.c M util/msrtool/intel_pentium4_later.c M util/msrtool/intel_pentium_d.c M util/msrtool/k8.c M util/msrtool/linux.c M util/msrtool/msrtool.c M util/msrtool/msrutils.c M util/msrtool/sys.c M util/msrtool/via_c7.c 24 files changed, 89 insertions(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/27015/5 -- To view, visit https://review.coreboot.org/27015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Gerrit-Change-Number: 27015 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: {src, util}: Move constant to the right side of comparison
by build bot (Jenkins) (Code Review) 11 Jun '18

11 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27015 ) Change subject: {src,util}: Move constant to the right side of comparison ...................................................................... Patch Set 3: (9 comments) https://review.coreboot.org/#/c/27015/3/util/msrtool/linux.c File util/msrtool/linux.c: https://review.coreboot.org/#/c/27015/3/util/msrtool/linux.c@71 PS3, Line 71: return ret ==0; spaces required around that '==' (ctx:WxV) https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c File util/msrtool/msrtool.c: https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@128 PS3, Line 128: if ((fin = fopen(streamfn, "r")) == NULL) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@136 PS3, Line 136: if ((fdout = mkstemp(tmpfn)) == -1) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@140 PS3, Line 140: if ((fout = fdopen(fdout, "w")) == NULL) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@145 PS3, Line 145: if ((fout = fopen(streamfn, "w")) == NULL) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@216 PS3, Line 216: else if ((fin = fopen(difffn, "r")) == NULL) { do not use assignment in if condition https://review.coreboot.org/#/c/27015/3/util/msrtool/msrtool.c@226 PS3, Line 226: for (len = strlen(m1start) - 1; strchr("\r\n", m1start[len]) != NULL; --len) line over 80 characters https://review.coreboot.org/#/c/27015/3/util/msrtool/msrutils.c File util/msrtool/msrutils.c: https://review.coreboot.org/#/c/27015/3/util/msrtool/msrutils.c@325 PS3, Line 325: if (m= NULL) { spaces required around that '=' (ctx:VxW) https://review.coreboot.org/#/c/27015/3/util/msrtool/msrutils.c@325 PS3, Line 325: if (m= NULL) { do not use assignment in if condition -- To view, visit https://review.coreboot.org/27015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Gerrit-Change-Number: 27015 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Mon, 11 Jun 2018 09:54:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: {src, util}: Move constant to the right side of comparison
by Elyes HAOUAS (Code Review) 11 Jun '18

11 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27015 to look at the new patch set (#4). Change subject: {src,util}: Move constant to the right side of comparison ...................................................................... {src,util}: Move constant to the right side of comparison Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/pci_rom.c M src/northbridge/amd/agesa/family16kb/state_machine.c M src/northbridge/amd/amdmct/mct/mctardk4.c M src/southbridge/amd/cimx/sb800/late.c M util/msrtool/freebsd.c M util/msrtool/geodegx2.c M util/msrtool/geodelx.c M util/msrtool/intel_atom.c M util/msrtool/intel_core1.c M util/msrtool/intel_core2_early.c M util/msrtool/intel_core2_later.c M util/msrtool/intel_nehalem.c M util/msrtool/intel_pentium3.c M util/msrtool/intel_pentium3_early.c M util/msrtool/intel_pentium4_early.c M util/msrtool/intel_pentium4_later.c M util/msrtool/intel_pentium_d.c M util/msrtool/k8.c M util/msrtool/linux.c M util/msrtool/msrtool.c M util/msrtool/msrutils.c M util/msrtool/sys.c M util/msrtool/via_c7.c 23 files changed, 88 insertions(+), 88 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/27015/4 -- To view, visit https://review.coreboot.org/27015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Gerrit-Change-Number: 27015 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: src: Move constant to the right side of comparison
by Elyes HAOUAS (Code Review) 11 Jun '18

11 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27015 to look at the new patch set (#3). Change subject: src: Move constant to the right side of comparison ...................................................................... src: Move constant to the right side of comparison Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/pci_rom.c M src/northbridge/amd/agesa/family16kb/state_machine.c M src/northbridge/amd/amdmct/mct/mctardk4.c M src/southbridge/amd/cimx/sb800/late.c M util/msrtool/freebsd.c M util/msrtool/geodegx2.c M util/msrtool/geodelx.c M util/msrtool/intel_atom.c M util/msrtool/intel_core1.c M util/msrtool/intel_core2_early.c M util/msrtool/intel_core2_later.c M util/msrtool/intel_nehalem.c M util/msrtool/intel_pentium3.c M util/msrtool/intel_pentium3_early.c M util/msrtool/intel_pentium4_early.c M util/msrtool/intel_pentium4_later.c M util/msrtool/intel_pentium_d.c M util/msrtool/k8.c M util/msrtool/linux.c M util/msrtool/msrtool.c M util/msrtool/msrutils.c M util/msrtool/sys.c M util/msrtool/via_c7.c 23 files changed, 88 insertions(+), 88 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/27015/3 -- To view, visit https://review.coreboot.org/27015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Gerrit-Change-Number: 27015 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: nb/lenovo/t400: Enable libgfxinit
by Arthur Heymans (Code Review) 11 Jun '18

11 Jun '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27014 ) Change subject: nb/lenovo/t400: Enable libgfxinit ...................................................................... Patch Set 2: > Did you test it on T400 ? No. T400 only has lines to HDMI_C to the dock while T500 also has DP_B (and HDMI_B) to a DP connector. Using GMBUS over unused ports on the mb resulted in some problems with Thinkpad X200 so it might be better to test if it makes a difference on T400. -- To view, visit https://review.coreboot.org/27014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I243c22c83a5575c2e1500cc869c41691c4fba415 Gerrit-Change-Number: 27014 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Mon, 11 Jun 2018 09:30:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018