Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/27029
Change subject: mediatek: Move mtcmos code to a common directory.
......................................................................
mediatek: Move mtcmos code to a common directory.
This patch moves mtcmos code which can be reused into a common directory
under soc/mediatek.
BUG=b:80501386
BRANCH=none
TEST=the refactored code works fine on the new platform (with the rest
of the patches applied) and Elm platform
Change-Id: I92b138890424b4f4a68cdb00bf2326eef9cd87b7
Signed-off-by: Tristan Shieh <tristan.shieh(a)mediatek.com>
---
R src/soc/mediatek/common/include/soc/mtcmos.h
R src/soc/mediatek/common/mtcmos.c
M src/soc/mediatek/mt8173/Makefile.inc
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/27029/1
diff --git a/src/soc/mediatek/mt8173/include/soc/mtcmos.h b/src/soc/mediatek/common/include/soc/mtcmos.h
similarity index 95%
rename from src/soc/mediatek/mt8173/include/soc/mtcmos.h
rename to src/soc/mediatek/common/include/soc/mtcmos.h
index 1b2c489..76269e0 100644
--- a/src/soc/mediatek/mt8173/include/soc/mtcmos.h
+++ b/src/soc/mediatek/common/include/soc/mtcmos.h
@@ -1,7 +1,7 @@
/*
* This file is part of the coreboot project.
*
- * Copyright 2015 MediaTek Inc.
+ * Copyright 2018 MediaTek Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/src/soc/mediatek/mt8173/mtcmos.c b/src/soc/mediatek/common/mtcmos.c
similarity index 98%
rename from src/soc/mediatek/mt8173/mtcmos.c
rename to src/soc/mediatek/common/mtcmos.c
index f5b6e46..c7bb4ab 100644
--- a/src/soc/mediatek/mt8173/mtcmos.c
+++ b/src/soc/mediatek/common/mtcmos.c
@@ -1,7 +1,7 @@
/*
* This file is part of the coreboot project.
*
- * Copyright 2015 MediaTek Inc.
+ * Copyright 2018 MediaTek Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/src/soc/mediatek/mt8173/Makefile.inc b/src/soc/mediatek/mt8173/Makefile.inc
index 3bb0ae0..064f604 100644
--- a/src/soc/mediatek/mt8173/Makefile.inc
+++ b/src/soc/mediatek/mt8173/Makefile.inc
@@ -66,7 +66,7 @@
ramstage-y += ../common/cbmem.c emi.c
ramstage-y += spi.c
ramstage-$(CONFIG_SPI_FLASH) += flash_controller.c
-ramstage-y += soc.c mtcmos.c
+ramstage-y += soc.c ../common/mtcmos.c
ramstage-y += ../common/timer.c
ramstage-y += timer.c
ramstage-$(CONFIG_DRIVERS_UART) += ../common/uart.c
--
To view, visit https://review.coreboot.org/27029
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92b138890424b4f4a68cdb00bf2326eef9cd87b7
Gerrit-Change-Number: 27029
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com>
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/25043 )
Change subject: Documentation/Intel: Add build setup documentation for Intel RVP boards
......................................................................
Patch Set 3:
Any news on that ? We use a new documentation base which can be found here doc.coreboot.org
--
To view, visit https://review.coreboot.org/25043
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f31b12b03b8b0662fd4fda0afa7c1c634a39dfe
Gerrit-Change-Number: 25043
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 12 Jun 2018 12:03:08 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/26885 )
Change subject: Documentation/releases: Add W530 mainboard to 4.9 relnotes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/26885
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9651b24dd68f9a5e324a4532c3cebac32aacca7e
Gerrit-Change-Number: 26885
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 12 Jun 2018 12:00:44 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/27022 )
Change subject: mb/google/poppy/variants/nocturne: config GPP_B4 for FCAM_PWR_EN
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27022/1/src/mainboard/google/poppy/variants…
File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27022/1/src/mainboard/google/poppy/variants…
PS1, Line 180: /* D8 : ISH_I2C1_SCL ==> FCAM_PWR_EN */
: PAD_CFG_GPO(GPP_D8, 0, DEEP),
> Change this to NC?
@Nick: This pin is unused now so it should be NC.
--
To view, visit https://review.coreboot.org/27022
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie875ced45dfa2aa7069851004edde8f77329df34
Gerrit-Change-Number: 27022
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Naresh Solanki <naresh.solanki(a)intel.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 11:26:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No