build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26924 )
Change subject: arch/x86: include verstage.c only when verstage is a separate stage
......................................................................
Patch Set 3:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/28963/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/74861/ : SUCCESS
--
To view, visit https://review.coreboot.org/26924
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia75205001f2443cb8221a0762f182aae01ee615e
Gerrit-Change-Number: 26924
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 14:50:32 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26797 )
Change subject: cpu/intel/car: Align the stack to 16 bytes before romstage_main
......................................................................
Patch Set 6:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/28961/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/74859/ : SUCCESS
--
To view, visit https://review.coreboot.org/26797
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1415c18779bc481fdec5f72f83c06a58ce6d5c39
Gerrit-Change-Number: 26797
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 14:46:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27090 )
Change subject: cbfstool/fit.c: Fix for older CPUs without total_size in mcu_header
......................................................................
Patch Set 2: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/28962/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/74860/ : SUCCESS
--
To view, visit https://review.coreboot.org/27090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50c087af41b0df14b607ce3c3b4eabc602e8738
Gerrit-Change-Number: 27090
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 14:46:36 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27090 )
Change subject: cbfstool/fit.c: Fix for older CPUs without total_size in mcu_header
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/27090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50c087af41b0df14b607ce3c3b4eabc602e8738
Gerrit-Change-Number: 27090
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 14:45:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26835 )
Change subject: cpu/intel/haswell: Use the common intel romstage_main function
......................................................................
Patch Set 3: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/28960/ : SUCCESS
https://qa.coreboot.org/job/coreboot-gerrit/74858/ : SUCCESS
--
To view, visit https://review.coreboot.org/26835
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6453c40bf4ebe4695684c1bd3a403d6def82814f
Gerrit-Change-Number: 26835
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 14:42:38 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27091
to look at the new patch set (#2).
Change subject: [WIP]src/cpu/intel/car: Update microcode before setting up CARe
......................................................................
[WIP]src/cpu/intel/car: Update microcode before setting up CARe
This reuses cbfstool adding a FIT table with pointers to microcode
headers meant for later Intel CPUs.
Change-Id: I8bd192f3f345651db0010239f99293ae63b00652
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/intel/car/p4-netburst/cache_as_ram_bootblock.S
A src/cpu/intel/microcode/microcode.S
M src/cpu/intel/socket_LGA775/Kconfig
M src/cpu/intel/socket_LGA775/Makefile.inc
4 files changed, 157 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/27091/2
--
To view, visit https://review.coreboot.org/27091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bd192f3f345651db0010239f99293ae63b00652
Gerrit-Change-Number: 27091
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27090
to look at the new patch set (#2).
Change subject: cbfstool/fit.c: Fix for older CPUs without total_size in mcu_header
......................................................................
cbfstool/fit.c: Fix for older CPUs without total_size in mcu_header
Some older CPUs have a fixed size of 2048 bytes for microcode total size.
Change-Id: Ia50c087af41b0df14b607ce3c3b4eabc602e8738
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M util/cbfstool/fit.c
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/27090/2
--
To view, visit https://review.coreboot.org/27090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia50c087af41b0df14b607ce3c3b4eabc602e8738
Gerrit-Change-Number: 27090
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>