May 2018 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26730 ) Change subject: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73787/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/27904/ : SUCCESS -- To view, visit https://review.coreboot.org/26730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Gerrit-Change-Number: 26730 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:57:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode
by Aamir Bohra (Code Review) May 31, 2018

May 31, 2018

Hello Subrata Banik, Rizwan Qureshi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/26730 to look at the new patch set (#2). Change subject: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode ...................................................................... soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode GPIO configuration in IOAPIC mode is not limited to only LEVEL trigger mode. This implementation allows level/edge/ either/none trigger configuration to be set for a GPIO in IOAPIC mode with RX Invert configuration. Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/26730/2 -- To view, visit https://review.coreboot.org/26730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Gerrit-Change-Number: 26730 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/{google, intel}/*: Update IOAPIC GPIO pad configuration to include ...
by Aamir Bohra (Code Review) May 31, 2018

May 31, 2018

Hello Subrata Banik, Rizwan Qureshi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/26731 to look at the new patch set (#2). Change subject: mb/{google,intel}/*: Update IOAPIC GPIO pad configuration to include trigger mode ...................................................................... mb/{google,intel}/*: Update IOAPIC GPIO pad configuration to include trigger mode Update GPIO pad configuartion in IOAPIC invert mode to include RX level/edge Configuration. Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85dab Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bip/gpio.c M src/mainboard/google/reef/variants/baseboard/gpio.c M src/mainboard/google/reef/variants/coral/gpio.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c 6 files changed, 29 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/26731/2 -- To view, visit https://review.coreboot.org/26731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85dab Gerrit-Change-Number: 26731 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 ) Change subject: soc/intel/common/block: Move common uart function to block/uart ...................................................................... Patch Set 31: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73784/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27901/ : SUCCESS -- To view, visit https://review.coreboot.org/26164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6 Gerrit-Change-Number: 26164 Gerrit-PatchSet: 31 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:48:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Move cse common functions into block/cse
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26133 ) Change subject: soc/intel/common/block: Move cse common functions into block/cse ...................................................................... Patch Set 30: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73780/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27897/ : SUCCESS -- To view, visit https://review.coreboot.org/26133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22a4cc05d3967c7653d2abe2c829b4876516d179 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 30 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:42:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move tco common functions into block/smbus
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26166 ) Change subject: soc/intel/common/block: Move tco common functions into block/smbus ...................................................................... Patch Set 27: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73783/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27900/ : SUCCESS -- To view, visit https://review.coreboot.org/26166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34b33922cafee9f31702587e0f9c03b64f0781b8 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 27 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:41:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/intel/gma: Include mainboard data.vbt
by Nico Huber (Code Review) May 31, 2018

May 31, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26653 ) Change subject: drivers/intel/gma: Include mainboard data.vbt ...................................................................... Patch Set 3: >> Build tested on Lenovo T430 and Lenovo W520 with vbt added. > > Hmm w520 does not have a vbt file... Doesn't matter. With `default y`, Jenkins does the job ;) e.g. https://qa.coreboot.org/job/coreboot-gerrit/73490/testReport/(root)/board/L… -- To view, visit https://review.coreboot.org/26653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I730cb0737945631e2d5379a9e26b8c039ec6dc49 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:39:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/intel/gma: Include mainboard data.vbt
by Nico Huber (Code Review) May 31, 2018

May 31, 2018

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26653 ) Change subject: drivers/intel/gma: Include mainboard data.vbt ...................................................................... Patch Set 3: (2 comments) Looks good, but I don't like to scatter related Kconfig options around. https://review.coreboot.org/#/c/26653/3/src/device/Kconfig File src/device/Kconfig: https://review.coreboot.org/#/c/26653/3/src/device/Kconfig@614 PS3, Line 614: if INTEL_GMA_VBT_HAVE_SOURCE_FILE && VARIANT_DIR != "" Please indent further by another tab. https://review.coreboot.org/#/c/26653/3/src/drivers/intel/gma/Kconfig File src/drivers/intel/gma/Kconfig: https://review.coreboot.org/#/c/26653/3/src/drivers/intel/gma/Kconfig@16 PS3, Line 16: config INTEL_GMA_VBT_HAVE_SOURCE_FILE Why not place this in device/Kconfig together with the other VBT options? Or move the other options here (would move them into the drivers menu, though)? Also, why name it `SOURCE_FILE` when it's `DATA_FILE` in the other option? I would prefer to have neither suffix, just `INTEL_GMA_HAVE_VBT` / `INTEL_GMA_ADD_VBT`. -- To view, visit https://review.coreboot.org/26653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I730cb0737945631e2d5379a9e26b8c039ec6dc49 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:36:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 ) Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ...................................................................... Patch Set 34: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73782/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27899/ : SUCCESS -- To view, visit https://review.coreboot.org/26132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a Gerrit-Change-Number: 26132 Gerrit-PatchSet: 34 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:35:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move smihandler common functions into block/s...
by build bot (Jenkins) (Code Review) May 31, 2018

May 31, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26138 ) Change subject: soc/intel/common/block: Move smihandler common functions into block/smihandler ...................................................................... Patch Set 29: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73781/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27898/ : SUCCESS -- To view, visit https://review.coreboot.org/26138 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic082bc5d556dd19617d83ab86f93a53574b5bc03 Gerrit-Change-Number: 26138 Gerrit-PatchSet: 29 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:31:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0