coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: intel/common/pch/gspi: Move gspi functionality to common PCH
by Maulik V Vaghela (Code Review) 31 May '18

31 May '18

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/26728 Change subject: intel/common/pch/gspi: Move gspi functionality to common PCH ...................................................................... intel/common/pch/gspi: Move gspi functionality to common PCH GSPI functionality is common for platforms using common base PCH code. Thus moving this functionality from individual soc to common PCH base. BUG=none BRANCH=none TEST=check if patch builds and KBL, CNL boots with this patch. Change-Id: I2cf65d56451afac5258c7127854b5fc7f4d84bd1 Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/soc/intel/cannonlake/Makefile.inc M src/soc/intel/common/pch/Kconfig A src/soc/intel/common/pch/gspi/Kconfig A src/soc/intel/common/pch/gspi/Makefile.inc R src/soc/intel/common/pch/gspi/gspi.c M src/soc/intel/skylake/Makefile.inc D src/soc/intel/skylake/gspi.c 7 files changed, 13 insertions(+), 39 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/26728/1 diff --git a/src/soc/intel/cannonlake/Makefile.inc b/src/soc/intel/cannonlake/Makefile.inc index f8f9198..4cce5c3 100644 --- a/src/soc/intel/cannonlake/Makefile.inc +++ b/src/soc/intel/cannonlake/Makefile.inc @@ -14,7 +14,6 @@ bootblock-y += pmutil.c bootblock-y += bootblock/report_platform.c bootblock-y += gpio.c -bootblock-y += gspi.c bootblock-y += i2c.c bootblock-y += memmap.c bootblock-y += spi.c @@ -24,7 +23,6 @@ romstage-$(CONFIG_SOC_INTEL_CANNONLAKE_LPDDR4_INIT) += cnl_lpddr4_init.c romstage-y += gpio.c -romstage-y += gspi.c romstage-y += i2c.c romstage-y += lpc.c romstage-y += memmap.c @@ -39,7 +37,6 @@ ramstage-y += finalize.c ramstage-y += gpio.c ramstage-y += graphics.c -ramstage-y += gspi.c ramstage-y += gpio.c ramstage-y += i2c.c ramstage-y += lockdown.c @@ -67,7 +64,6 @@ postcar-y += pmutil.c postcar-$(CONFIG_UART_DEBUG) += uart.c -verstage-y += gspi.c verstage-y += i2c.c verstage-y += pmutil.c verstage-y += spi.c diff --git a/src/soc/intel/common/pch/Kconfig b/src/soc/intel/common/pch/Kconfig index ead0536..9014647 100644 --- a/src/soc/intel/common/pch/Kconfig +++ b/src/soc/intel/common/pch/Kconfig @@ -44,5 +44,5 @@ select SOC_INTEL_COMMON_BLOCK_XDCI select SOC_INTEL_COMMON_BLOCK_XHCI select SOC_INTEL_COMMON_PCH_LOCKDOWN - + select SOC_INTEL_COMMON_PCH_GSPI endif diff --git a/src/soc/intel/common/pch/gspi/Kconfig b/src/soc/intel/common/pch/gspi/Kconfig new file mode 100644 index 0000000..c07611b --- /dev/null +++ b/src/soc/intel/common/pch/gspi/Kconfig @@ -0,0 +1,5 @@ +config SOC_INTEL_COMMON_PCH_GSPI + bool + default n + help + This option allows to have gspi configuration for supported PCH. diff --git a/src/soc/intel/common/pch/gspi/Makefile.inc b/src/soc/intel/common/pch/gspi/Makefile.inc new file mode 100644 index 0000000..19ff891 --- /dev/null +++ b/src/soc/intel/common/pch/gspi/Makefile.inc @@ -0,0 +1,5 @@ +bootblock-$(CONFIG_SOC_INTEL_COMMON_PCH_GSPI) += gspi.c +verstage-$(CONFIG_SOC_INTEL_COMMON_PCH_GSPI) += gspi.c +romstage-$(CONFIG_SOC_INTEL_COMMON_PCH_GSPI) += gspi.c +ramstage-$(CONFIG_SOC_INTEL_COMMON_PCH_GSPI) += gspi.c +postcar-$(CONFIG_SOC_INTEL_COMMON_PCH_GSPI) += gspi.c diff --git a/src/soc/intel/cannonlake/gspi.c b/src/soc/intel/common/pch/gspi/gspi.c similarity index 92% rename from src/soc/intel/cannonlake/gspi.c rename to src/soc/intel/common/pch/gspi/gspi.c index c5998b5..99fd2b4 100644 --- a/src/soc/intel/cannonlake/gspi.c +++ b/src/soc/intel/common/pch/gspi/gspi.c @@ -13,7 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ - #include <intelblocks/gspi.h> #include <soc/pci_devs.h> @@ -24,8 +23,10 @@ return PCH_DEVFN_GSPI0; case 1: return PCH_DEVFN_GSPI1; +#if IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_VERSION_2) case 2: return PCH_DEVFN_GSPI2; +#endif } return -1; } diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc index 89e48f1..8f673c3 100644 --- a/src/soc/intel/skylake/Makefile.inc +++ b/src/soc/intel/skylake/Makefile.inc @@ -15,21 +15,18 @@ bootblock-y += bootblock/pch.c bootblock-y += bootblock/report_platform.c bootblock-y += gpio.c -bootblock-y += gspi.c bootblock-y += p2sb.c bootblock-y += pmutil.c bootblock-y += spi.c bootblock-y += lpc.c bootblock-$(CONFIG_UART_DEBUG) += uart.c -verstage-y += gspi.c verstage-y += pmutil.c verstage-y += i2c.c verstage-y += spi.c verstage-$(CONFIG_UART_DEBUG) += uart.c romstage-y += gpio.c -romstage-y += gspi.c romstage-y += i2c.c romstage-y += memmap.c romstage-y += me.c @@ -47,7 +44,6 @@ ramstage-y += elog.c ramstage-y += finalize.c ramstage-y += gpio.c -ramstage-y += gspi.c ramstage-y += i2c.c ramstage-y += graphics.c ramstage-y += irq.c @@ -76,7 +72,6 @@ smm-$(CONFIG_UART_DEBUG) += uart.c postcar-y += memmap.c -postcar-y += gspi.c postcar-y += spi.c postcar-$(CONFIG_UART_DEBUG) += uart.c diff --git a/src/soc/intel/skylake/gspi.c b/src/soc/intel/skylake/gspi.c deleted file mode 100644 index 3fb7c50..0000000 --- a/src/soc/intel/skylake/gspi.c +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright 2017 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ -#include <intelblocks/gspi.h> -#include <soc/pci_devs.h> - -int gspi_soc_bus_to_devfn(unsigned int gspi_bus) -{ - switch (gspi_bus) { - case 0: - return PCH_DEVFN_GSPI0; - case 1: - return PCH_DEVFN_GSPI1; - } - return -1; -} -- To view, visit https://review.coreboot.org/26728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2cf65d56451afac5258c7127854b5fc7f4d84bd1 Gerrit-Change-Number: 26728 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>

1 0

Change in coreboot[master]: drivers/intel/gma: Include mainboard data.vbt
by Arthur Heymans (Code Review) 31 May '18

31 May '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/26653 ) Change subject: drivers/intel/gma: Include mainboard data.vbt ...................................................................... Patch Set 3: > Build tested on Lenovo T430 and Lenovo W520 with vbt added. Hmm w520 does not have a vbt file... -- To view, visit https://review.coreboot.org/26653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I730cb0737945631e2d5379a9e26b8c039ec6dc49 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:46:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Move cse common functions into block/cse
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26133 ) Change subject: soc/intel/common/block: Move cse common functions into block/cse ...................................................................... Patch Set 29: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73773/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27890/ : SUCCESS -- To view, visit https://review.coreboot.org/26133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22a4cc05d3967c7653d2abe2c829b4876516d179 Gerrit-Change-Number: 26133 Gerrit-PatchSet: 29 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:39:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 ) Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ...................................................................... Patch Set 33: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73772/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27889/ : SUCCESS -- To view, visit https://review.coreboot.org/26132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a Gerrit-Change-Number: 26132 Gerrit-PatchSet: 33 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:35:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/*/*: Add a few VBT files
by Patrick Rudolph (Code Review) 31 May '18

31 May '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/26654 ) Change subject: mb/*/*: Add a few VBT files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/26654 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dea2843255e4a3e93fbb734dea284be029dbc45 Gerrit-Change-Number: 26654 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:27:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 ) Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ...................................................................... Patch Set 32: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73771/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27888/ : SUCCESS -- To view, visit https://review.coreboot.org/26132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a Gerrit-Change-Number: 26132 Gerrit-PatchSet: 32 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:25:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/kukui: Add new board
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26722 ) Change subject: google/kukui: Add new board ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73770/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27887/ : SUCCESS -- To view, visit https://review.coreboot.org/26722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08644892d34925574f791b000b0035d5afad7022 Gerrit-Change-Number: 26722 Gerrit-PatchSet: 4 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:21:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/intel/gma: Include mainboard data.vbt
by Patrick Rudolph (Code Review) 31 May '18

31 May '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/26653 ) Change subject: drivers/intel/gma: Include mainboard data.vbt ...................................................................... Patch Set 3: Code-Review+1 Build tested on Lenovo T430 and Lenovo W520 with vbt added. -- To view, visit https://review.coreboot.org/26653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I730cb0737945631e2d5379a9e26b8c039ec6dc49 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:20:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mediatek: refactor to sharing uart and timer code among similar SOCs
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26658 ) Change subject: mediatek: refactor to sharing uart and timer code among similar SOCs ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73768/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27885/ : SUCCESS -- To view, visit https://review.coreboot.org/26658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5210149b324947ee90f1a481b42f0e2e1f7cfc25 Gerrit-Change-Number: 26658 Gerrit-PatchSet: 5 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org> Gerrit-CC: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:16:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move p2sb common functions into block/p2sb
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26132 ) Change subject: soc/intel/common/block: Move p2sb common functions into block/p2sb ...................................................................... Patch Set 32: (1 comment) https://review.coreboot.org/#/c/26132/32/src/soc/intel/cannonlake/p2sb.c File src/soc/intel/cannonlake/p2sb.c: https://review.coreboot.org/#/c/26132/32/src/soc/intel/cannonlake/p2sb.c@37 PS32, Line 37: * access for Boardcast and Multicast. 'Boardcast' may be misspelled - perhaps 'Broadcast'? -- To view, visit https://review.coreboot.org/26132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fd933d155b3fcd0d616b41cdf042cefe2c649a Gerrit-Change-Number: 26132 Gerrit-PatchSet: 32 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 09:15:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018