coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode
by Aamir Bohra (Code Review) 31 May '18

31 May '18

Hello Subrata Banik, Rizwan Qureshi, Hannah Williams, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26730 to look at the new patch set (#4). Change subject: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode ...................................................................... soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode GPIO configuration in IOAPIC mode is not limited to only LEVEL trigger mode. This implementation allows level/edge/ either/none trigger configuration to be set for a GPIO in IOAPIC mode with RX Invert configuration. This patch also updates the corresponding references in mainboard code. Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bip/gpio.c M src/mainboard/google/reef/variants/baseboard/gpio.c M src/mainboard/google/reef/variants/coral/gpio.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 7 files changed, 31 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/26730/4 -- To view, visit https://review.coreboot.org/26730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Gerrit-Change-Number: 26730 Gerrit-PatchSet: 4 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cpu/x86/mtrr: Get rid of CACHE_ROM_SIZE_OVERRIDE
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26566 ) Change subject: cpu/x86/mtrr: Get rid of CACHE_ROM_SIZE_OVERRIDE ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73789/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27906/ : SUCCESS -- To view, visit https://review.coreboot.org/26566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d0096f14a9d343c2e646e48175fe2127198a822 Gerrit-Change-Number: 26566 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 11:16:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block: Move gspi common functions into block/gspi
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26048 ) Change subject: soc/intel/common/block: Move gspi common functions into block/gspi ...................................................................... Patch Set 35: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73793/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27910/ : SUCCESS -- To view, visit https://review.coreboot.org/26048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I877c7c48af928ca1e0399ec794d9400bc52edfcb Gerrit-Change-Number: 26048 Gerrit-PatchSet: 35 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 31 May 2018 11:13:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/{cannonlake, skylake}: Select Gen-6 PCH binding for SKL/CNL
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26349 ) Change subject: soc/intel/{cannonlake, skylake}: Select Gen-6 PCH binding for SKL/CNL ...................................................................... Patch Set 16: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73792/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27909/ : SUCCESS -- To view, visit https://review.coreboot.org/26349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85d99 Gerrit-Change-Number: 26349 Gerrit-PatchSet: 16 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 11:09:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/{google, intel}/*: Update IOAPIC GPIO pad configuration to include ...
by Aamir Bohra (Code Review) 31 May '18

31 May '18

Aamir Bohra has abandoned this change. ( https://review.coreboot.org/26731 ) Change subject: mb/{google,intel}/*: Update IOAPIC GPIO pad configuration to include trigger mode ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/26731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85dab Gerrit-Change-Number: 26731 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block: Add common chip config block
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26189 ) Change subject: soc/intel/common/block: Add common chip config block ...................................................................... Patch Set 24: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73791/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27908/ : SUCCESS -- To view, visit https://review.coreboot.org/26189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1671e064782397d3ace066a08bf1333192b21a Gerrit-Change-Number: 26189 Gerrit-PatchSet: 24 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Comment-Date: Thu, 31 May 2018 11:05:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26730 ) Change subject: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode ...................................................................... Patch Set 2: No Builds Executed -- To view, visit https://review.coreboot.org/26730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Gerrit-Change-Number: 26730 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 11:04:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode
by Aamir Bohra (Code Review) 31 May '18

31 May '18

Hello Subrata Banik, Rizwan Qureshi, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26730 to look at the new patch set (#3). Change subject: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode ...................................................................... soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode GPIO configuration in IOAPIC mode is not limited to only LEVEL trigger mode. This implementation allows level/edge/ either/none trigger configuration to be set for a GPIO in IOAPIC mode with RX Invert configuration. This patch also updates the corresponding reference in mainboard code. Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bip/gpio.c M src/mainboard/google/reef/variants/baseboard/gpio.c M src/mainboard/google/reef/variants/coral/gpio.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/gpio.c M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 7 files changed, 31 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/26730/3 -- To view, visit https://review.coreboot.org/26730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Gerrit-Change-Number: 26730 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/intel/gma: Include mainboard data.vbt
by Patrick Rudolph (Code Review) 31 May '18

31 May '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/26653 ) Change subject: drivers/intel/gma: Include mainboard data.vbt ...................................................................... Patch Set 3: > > Build tested on Lenovo T430 and Lenovo W520 with vbt added. > > Hmm w520 does not have a vbt file... Copied from t520 ;-) -- To view, visit https://review.coreboot.org/26653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I730cb0737945631e2d5379a9e26b8c039ec6dc49 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:57:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26730 ) Change subject: soc/intel/common: Allow RX level/edge configuartion for IOAPIC IRQ mode ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73787/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/27904/ : SUCCESS -- To view, visit https://review.coreboot.org/26730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e1f009489f2d8338ae94b78d7e9eb3f88a85daa Gerrit-Change-Number: 26730 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 10:57:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
370
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018