Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/25926 )
Change subject: lenovo: Add various vbt.bin
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25926/1/src/mainboard/lenovo/t400/vbt.bin
File src/mainboard/lenovo/t400/vbt.bin:
PS1:
> Lenovo shipped two different BIOS versions for the X200 (one for […]
I used the T500 one, which has 6 OPROMs, but only one with a valid VBT. It might be a good idea to skip T400 for now and add variant dirs first.
--
To view, visit https://review.coreboot.org/25926
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15573ddd37ee9738df1f7178f967131687a50f48
Gerrit-Change-Number: 25926
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 30 Apr 2018 14:16:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/25928
Change subject: lib/cbfs.c: fix typo
......................................................................
lib/cbfs.c: fix typo
Change-Id: I39c12ab3f28b5448fa4f46958cf23f2623a92378
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
---
M src/lib/cbfs.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/25928/1
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 2dcd429..87ab387 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -45,7 +45,7 @@
if (cbfs_boot_region_properties(&props))
return -1;
- /* All boot CBFS operations are performed using the RO devie. */
+ /* All boot CBFS operations are performed using the RO device. */
boot_dev = boot_device_ro();
if (boot_dev == NULL)
--
To view, visit https://review.coreboot.org/25928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39c12ab3f28b5448fa4f46958cf23f2623a92378
Gerrit-Change-Number: 25928
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>