Hello Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25852
to look at the new patch set (#2).
Change subject: mb/SuperIO: Change DUMMY_DEV to SUPERIO_DEV for global control device
......................................................................
mb/SuperIO: Change DUMMY_DEV to SUPERIO_DEV for global control device
Change-Id: If3555906d359695b2eae51209cd97fbaaace7e61
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/mainboard/google/beltino/onboard.h
M src/mainboard/google/beltino/romstage.c
M src/mainboard/google/jecht/onboard.h
M src/mainboard/google/jecht/romstage.c
M src/mainboard/ibase/mb899/romstage.c
M src/mainboard/samsung/stumpy/romstage.c
M src/mainboard/samsung/stumpy/smihandler.c
M src/mainboard/supermicro/h8dme/romstage.c
M src/mainboard/supermicro/h8dmr/romstage.c
M src/mainboard/supermicro/h8dmr_fam10/romstage.c
M src/mainboard/supermicro/h8qme_fam10/romstage.c
M src/mainboard/via/epia-m700/romstage.c
12 files changed, 26 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/25852/2
--
To view, visit https://review.coreboot.org/25852
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If3555906d359695b2eae51209cd97fbaaace7e61
Gerrit-Change-Number: 25852
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25822 )
Change subject: siemens/mc_apl1: Move board specific things to mc_apl1 variant
......................................................................
Patch Set 4:
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/24947/ : SUCCESS
--
To view, visit https://review.coreboot.org/25822
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c853e6caae6cc880ead436f232cabddeee6d09a
Gerrit-Change-Number: 25822
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 07:48:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25851 )
Change subject: cbfstool: Add region offset information to layout command
......................................................................
Patch Set 1:
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/70736/ : SUCCESS
--
To view, visit https://review.coreboot.org/25851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f945ba046bd2f1cb50a93e90eb887f60c6fde8a
Gerrit-Change-Number: 25851
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 07:38:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25851 )
Change subject: cbfstool: Add region offset information to layout command
......................................................................
Patch Set 1: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-checkpatch/24945/ : SUCCESS
--
To view, visit https://review.coreboot.org/25851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f945ba046bd2f1cb50a93e90eb887f60c6fde8a
Gerrit-Change-Number: 25851
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 26 Apr 2018 07:32:15 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/25851
Change subject: cbfstool: Add region offset information to layout command
......................................................................
cbfstool: Add region offset information to layout command
The layout command prints all FMAP regions in the final image among with
the region size. Extend this command to show the offset of each region
in the image.
Change-Id: I5f945ba046bd2f1cb50a93e90eb887f60c6fde8a
Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com>
---
M util/cbfstool/cbfstool.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/25851/1
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 7156e00..d4de409 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -930,7 +930,8 @@
qualifier = "read-only, ";
else if (region_is_modern_cbfs((const char *)current->name))
qualifier = "CBFS, ";
- printf(" (%ssize %u)\n", qualifier, current->size);
+ printf(" (%ssize %u, offset %u)\n", qualifier, current->size,
+ current->offset);
i += lookahead - 1;
}
--
To view, visit https://review.coreboot.org/25851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f945ba046bd2f1cb50a93e90eb887f60c6fde8a
Gerrit-Change-Number: 25851
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>