coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: drivers/usb: Add whitespace around '=='
by Elyes HAOUAS (Code Review) 26 Apr '18

26 Apr '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/25858 Change subject: drivers/usb: Add whitespace around '==' ...................................................................... drivers/usb: Add whitespace around '==' Change-Id: If72ce868cdd06183e5055deb94b9d0cf12ed8738 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/usb/gadget.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/25858/1 diff --git a/src/drivers/usb/gadget.c b/src/drivers/usb/gadget.c index ee18bd6..37e97a3 100644 --- a/src/drivers/usb/gadget.c +++ b/src/drivers/usb/gadget.c @@ -154,7 +154,7 @@ USB_REQ_GET_DESCRIPTOR, (USB_DT_DEBUG << 8), 0, &dbgp_desc, sizeof(dbgp_desc)); if (ret == sizeof(dbgp_desc)) { - if (dbgp_desc.bLength == sizeof(dbgp_desc) && dbgp_desc.bDescriptorType==USB_DT_DEBUG) + if (dbgp_desc.bLength == sizeof(dbgp_desc) && dbgp_desc.bDescriptorType == USB_DT_DEBUG) goto debug_dev_found; else dprintk(BIOS_INFO, "Invalid debug device descriptor.\n"); -- To view, visit https://review.coreboot.org/25858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If72ce868cdd06183e5055deb94b9d0cf12ed8738 Gerrit-Change-Number: 25858 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: payloads/libpayload: Add whitespace around '=='
by build bot (Jenkins) (Code Review) 26 Apr '18

26 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25856 ) Change subject: payloads/libpayload: Add whitespace around '==' ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70745/ : SUCCESS -- To view, visit https://review.coreboot.org/25856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1da925aceb01c2d21b472bf171000803004578f Gerrit-Change-Number: 25856 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 08:28:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/ati/ragexl: Add whitespace around '=='
by build bot (Jenkins) (Code Review) 26 Apr '18

26 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25857 ) Change subject: drivers/ati/ragexl: Add whitespace around '==' ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24954/ : SUCCESS -- To view, visit https://review.coreboot.org/25857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7920c334f6c5e0ed67a6899715cee3552227014 Gerrit-Change-Number: 25857 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 08:28:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/ati/ragexl: Add whitespace around '=='
by Elyes HAOUAS (Code Review) 26 Apr '18

26 Apr '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/25857 Change subject: drivers/ati/ragexl: Add whitespace around '==' ...................................................................... drivers/ati/ragexl: Add whitespace around '==' Change-Id: Ia7920c334f6c5e0ed67a6899715cee3552227014 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/ati/ragexl/atyfb.h M src/drivers/ati/ragexl/mach64_ct.c M src/drivers/ati/ragexl/xlinit.c 3 files changed, 28 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/25857/1 diff --git a/src/drivers/ati/ragexl/atyfb.h b/src/drivers/ati/ragexl/atyfb.h index df8dd3d..6ed6ac9 100644 --- a/src/drivers/ati/ragexl/atyfb.h +++ b/src/drivers/ati/ragexl/atyfb.h @@ -96,7 +96,7 @@ #endif struct fb_info_aty { #if CONFIG_CONSOLE_BTEXT -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 struct fb_info fb_info; #endif #endif @@ -119,7 +119,7 @@ struct { u8 red, green, blue, pad; } palette[256]; #endif struct atyfb_par default_par; -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 struct atyfb_par current_par; #endif diff --git a/src/drivers/ati/ragexl/mach64_ct.c b/src/drivers/ati/ragexl/mach64_ct.c index 9b45f2a..b5fd65c 100644 --- a/src/drivers/ati/ragexl/mach64_ct.c +++ b/src/drivers/ati/ragexl/mach64_ct.c @@ -14,7 +14,7 @@ struct pll_ct *pll); static int aty_var_to_pll_ct(const struct fb_info_aty *info, u32 vclk_per, u8 bpp, union aty_pll *pll); -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 static u32 aty_pll_ct_to_var(const struct fb_info_aty *info, const union aty_pll *pll); #endif @@ -31,7 +31,7 @@ u32 xclks_per_row, fifo_off, fifo_on, y, fifo_size; u32 memcntl, n, t_pfc, t_rp, t_ras, t_rcd, t_crd, t_rcc, t_lat; -#if DEBUG_PLL==1 +#if DEBUG_PLL == 1 printk(BIOS_DEBUG, "aty_dsp_gt : mclk_fb_mult=%d\n", pll->mclk_fb_mult); #endif @@ -121,7 +121,7 @@ static int aty_valid_pll_ct(const struct fb_info_aty *info, u32 vclk_per, struct pll_ct *pll) { -#if DEBUG_PLL==1 +#if DEBUG_PLL == 1 int pllmclk, pllsclk; #endif u32 q; @@ -145,7 +145,7 @@ pll->mclk_post_div_real = 1; pll->sclk_fb_div = q*pll->mclk_post_div_real/8; -#if DEBUG_PLL==1 +#if DEBUG_PLL == 1 pllsclk = (1000000 * 2 * pll->sclk_fb_div) / (info->ref_clk_per * pll->pll_ref_div); @@ -171,7 +171,7 @@ pll->xclk_post_div_real = 1; pll->mclk_fb_div = q*pll->xclk_post_div_real/8; -#if DEBUG_PLL==1 +#if DEBUG_PLL == 1 pllmclk = (1000000 * pll->mclk_fb_mult * pll->mclk_fb_div) / (info->ref_clk_per * pll->pll_ref_div); printk(BIOS_DEBUG, "aty_valid_pll_ct: pllmclk=%d MHz, xclk=%d MHz\n", @@ -285,7 +285,7 @@ return 0; } #if CONFIG_CONSOLE_BTEXT -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 u32 aty_pll_ct_to_var(const struct fb_info_aty *info, const union aty_pll *pll) { @@ -299,7 +299,7 @@ #endif void aty_set_pll_ct(const struct fb_info_aty *info, const union aty_pll *pll) { -#if DEBUG_PLL==1 +#if DEBUG_PLL == 1 printk(BIOS_DEBUG, "aty_set_pll_ct: about to program:\n" "refdiv=%d, extcntl=0x%02x, mfbdiv=%d\n" "spllcntl2=0x%02x, sfbdiv=%d, gencntl=0x%02x\n" diff --git a/src/drivers/ati/ragexl/xlinit.c b/src/drivers/ati/ragexl/xlinit.c index c5d4404..67293be 100644 --- a/src/drivers/ati/ragexl/xlinit.c +++ b/src/drivers/ati/ragexl/xlinit.c @@ -60,7 +60,7 @@ #define HAS_VICTORIA 0 enum { -#if HAS_VICTORIA==1 +#if HAS_VICTORIA == 1 VICTORIA = 0, XPERT98, #else @@ -88,7 +88,7 @@ u8 dll2_cntl; u8 pll_yclk_cntl; } card_cfg[NUM_XL_CARDS] = { -#if HAS_VICTORIA==1 +#if HAS_VICTORIA == 1 // VICTORIA { 2700, SDRAM, 0x800000, 0x10757A3B, 0x64000C81, 0x00110202, 0x7b33A040, @@ -399,7 +399,7 @@ static int aty_var_to_crtc(const struct fb_info_aty *info, const struct fb_var_screeninfo *var, struct crtc *crtc); -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 static int aty_crtc_to_var(const struct crtc *crtc, struct fb_var_screeninfo *var); #endif @@ -409,7 +409,7 @@ static int atyfb_decode_var(const struct fb_var_screeninfo *var, struct atyfb_par *par, const struct fb_info_aty *info); -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 static int atyfb_encode_var(struct fb_var_screeninfo *var, const struct atyfb_par *par, const struct fb_info_aty *info); @@ -517,7 +517,7 @@ u8 pll_ref_div; #endif -#endif /*CONFIG_CONSOLE_BTEXT==1 */ +#endif /*CONFIG_CONSOLE_BTEXT == 1 */ struct fb_info_aty *info; struct fb_info_aty info_t; @@ -536,7 +536,7 @@ info->frame_buffer = res->base; #endif /* CONFIG_CONSOLE_BTEXT */ -#if USE_AUX_REG==0 +#if USE_AUX_REG == 0 info->ati_regbase = res2mmio(res, 0x7ff000+0xc00, 0); #else /* Fix this to look for the correct index. */ @@ -752,7 +752,7 @@ } #endif -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 atyfb_set_var(&var, -1, &info->fb_info); #else atyfb_set_par(&info->default_par, info); @@ -760,7 +760,7 @@ do_install_cmap(-1, info); #endif -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 printk(BIOS_SPEW, "framebuffer=0x%08x, width=%d, height=%d, bpp=%d, pitch=%d\n",info->frame_buffer, (((info->current_par.crtc.h_tot_disp>>16) & 0xff)+1)*8, @@ -830,7 +830,7 @@ return 0; } -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 static int atyfb_encode_var(struct fb_var_screeninfo *var, const struct atyfb_par *par, const struct fb_info_aty *info) @@ -934,7 +934,7 @@ dp_pix_width = HOST_8BPP | SRC_8BPP | DST_8BPP | BYTE_ORDER_LSB_TO_MSB; dp_chain_mask = 0x8080; } -#if SUPPORT_8_BPP_ABOVE==1 +#if SUPPORT_8_BPP_ABOVE == 1 else if (bpp <= 16) { bpp = 16; pix_width = CRTC_PIX_WIDTH_15BPP; @@ -986,7 +986,7 @@ return 0; } -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 static int aty_crtc_to_var(const struct crtc *crtc, struct fb_var_screeninfo *var) { @@ -1049,7 +1049,7 @@ var->transp.offset = 0; var->transp.length = 0; break; -#if SUPPORT_8_BPP_ABOVE==1 +#if SUPPORT_8_BPP_ABOVE == 1 case CRTC_PIX_WIDTH_15BPP: /* RGB 555 */ bpp = 16; var->red.offset = 10; @@ -1168,7 +1168,7 @@ /* * Set the User Defined Part of the Display */ -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 static int atyfb_set_var(struct fb_var_screeninfo *var, int con, struct fb_info *fb) { @@ -1269,7 +1269,7 @@ accelmode = par->accel_flags; /* hack */ -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 info->current_par = *par; #endif @@ -1293,7 +1293,7 @@ case 8: i |= 0x02000000; break; -#if SUPPORT_8_BPP_ABOVE==1 +#if SUPPORT_8_BPP_ABOVE == 1 case 16: i |= 0x03000000; break; @@ -1309,12 +1309,12 @@ i |= info->mem_refresh_rate << 20; switch (par->crtc.bpp) { case 8: -#if SUPPORT_8_BPP_ABOVE==1 +#if SUPPORT_8_BPP_ABOVE == 1 case 24: #endif i |= 0x00000000; break; -#if SUPPORT_8_BPP_ABOVE==1 +#if SUPPORT_8_BPP_ABOVE == 1 case 16: i |= 0x04000000; break; @@ -1433,7 +1433,7 @@ i |= 0x2; /*DAC_CNTL|0x2 turns off the extra brightness for gt*/ aty_st_8(DAC_CNTL, i, info); aty_st_8(DAC_MASK, 0xff, info); -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 scale = (M64_HAS(INTEGRATED) && info->current_par.crtc.bpp == 16) ? 3 : 0; #else scale = (M64_HAS(INTEGRATED) && info->default_par.crtc.bpp == 16) ? 3 : 0; @@ -1493,7 +1493,7 @@ static void do_install_cmap(int con, struct fb_info_aty *info) { -#if PLL_CRTC_DECODE==1 +#if PLL_CRTC_DECODE == 1 int size = info->current_par.crtc.bpp == 16 ? 32 : 256; #else int size = 256; -- To view, visit https://review.coreboot.org/25857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7920c334f6c5e0ed67a6899715cee3552227014 Gerrit-Change-Number: 25857 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: payloads/libpayload: Add whitespace around '=='
by build bot (Jenkins) (Code Review) 26 Apr '18

26 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25856 ) Change subject: payloads/libpayload: Add whitespace around '==' ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24953/ : SUCCESS -- To view, visit https://review.coreboot.org/25856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1da925aceb01c2d21b472bf171000803004578f Gerrit-Change-Number: 25856 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 08:21:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads/libpayload: Add whitespace around '=='
by build bot (Jenkins) (Code Review) 26 Apr '18

26 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25856 ) Change subject: payloads/libpayload: Add whitespace around '==' ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/70744/ : ABORTED -- To view, visit https://review.coreboot.org/25856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1da925aceb01c2d21b472bf171000803004578f Gerrit-Change-Number: 25856 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 08:21:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads/libpayload: Add whitespace around '=='
by Elyes HAOUAS (Code Review) 26 Apr '18

26 Apr '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25856 to look at the new patch set (#2). Change subject: payloads/libpayload: Add whitespace around '==' ...................................................................... payloads/libpayload: Add whitespace around '==' Change-Id: Ie1da925aceb01c2d21b472bf171000803004578f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M payloads/libpayload/curses/form/fld_attr.c M payloads/libpayload/curses/form/frm_driver.c M payloads/libpayload/curses/menu/m_attribs.c M payloads/libpayload/curses/menu/m_driver.c M payloads/libpayload/curses/pdcurses-backend/pdckbd.c M payloads/libpayload/drivers/usb/ehci.c M payloads/libpayload/drivers/usb/ohci.c M payloads/libpayload/liblz4/lz4.c.inc 8 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/25856/2 -- To view, visit https://review.coreboot.org/25856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie1da925aceb01c2d21b472bf171000803004578f Gerrit-Change-Number: 25856 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: payloads/libpayload: Add whitespace around '=='
by build bot (Jenkins) (Code Review) 26 Apr '18

26 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25856 ) Change subject: payloads/libpayload: Add whitespace around '==' ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24952/ : SUCCESS -- To view, visit https://review.coreboot.org/25856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1da925aceb01c2d21b472bf171000803004578f Gerrit-Change-Number: 25856 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 08:16:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: payloads/libpayload: Add whitespace around '=='
by Elyes HAOUAS (Code Review) 26 Apr '18

26 Apr '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/25856 Change subject: payloads/libpayload: Add whitespace around '==' ...................................................................... payloads/libpayload: Add whitespace around '==' Change-Id: Ie1da925aceb01c2d21b472bf171000803004578f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M payloads/libpayload/curses/form/fld_attr.c M payloads/libpayload/curses/form/frm_driver.c M payloads/libpayload/curses/menu/m_attribs.c M payloads/libpayload/curses/menu/m_driver.c M payloads/libpayload/curses/pdcurses-backend/pdckbd.c M payloads/libpayload/drivers/usb/ehci.c M payloads/libpayload/drivers/usb/ohci.c M payloads/libpayload/liblz4/lz4.c.inc 8 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/25856/1 diff --git a/payloads/libpayload/curses/form/fld_attr.c b/payloads/libpayload/curses/form/fld_attr.c index 0112f00..2ba0786 100644 --- a/payloads/libpayload/curses/form/fld_attr.c +++ b/payloads/libpayload/curses/form/fld_attr.c @@ -43,7 +43,7 @@ {\ int res = E_BAD_ARGUMENT;\ T((T_CALLED("set_field_" #name "(%p,%s)"), field, _traceattr(attr)));\ - if ( attr==A_NORMAL || ((attr & A_ATTRIBUTES)==attr) )\ + if ( attr == A_NORMAL || ((attr & A_ATTRIBUTES)==attr) )\ {\ Normalize_Field( field );\ if (field != 0) \ diff --git a/payloads/libpayload/curses/form/frm_driver.c b/payloads/libpayload/curses/form/frm_driver.c index e0892bf..e058d19 100644 --- a/payloads/libpayload/curses/form/frm_driver.c +++ b/payloads/libpayload/curses/form/frm_driver.c @@ -200,7 +200,7 @@ /* Logic to determine whether or not we are on the first position in the current field */ #define First_Position_In_Current_Field(form) \ - (((form)->currow==0) && ((form)->curcol==0)) + (((form)->currow == 0) && ((form)->curcol == 0)) #define Minimum(a,b) (((a)<=(b)) ? (a) : (b)) #define Maximum(a,b) (((a)>=(b)) ? (a) : (b)) @@ -2586,7 +2586,7 @@ { if (Last_Row && !Field_Grown(field, 1)) { - /* N.B.: due to the logic in the 'if', LastRow==TRUE + /* N.B.: due to the logic in the 'if', LastRow == TRUE means here that the field is growable and not a single-line field */ returnCode(E_SYSTEM_ERROR); diff --git a/payloads/libpayload/curses/menu/m_attribs.c b/payloads/libpayload/curses/menu/m_attribs.c index 1ea5c7a..9e4398f 100644 --- a/payloads/libpayload/curses/menu/m_attribs.c +++ b/payloads/libpayload/curses/menu/m_attribs.c @@ -52,7 +52,7 @@ NCURSES_IMPEXP int NCURSES_API set_menu_ ## name (MENU* menu, chtype attr) \ {\ T((T_CALLED("set_menu_" #name "(%p,%s)"), menu, _traceattr(attr))); \ - if (!(attr==A_NORMAL || (attr & A_ATTRIBUTES)==attr))\ + if (!(attr == A_NORMAL || (attr & A_ATTRIBUTES)==attr))\ RETURN(E_BAD_ARGUMENT);\ if (menu && ( menu -> name != attr))\ {\ diff --git a/payloads/libpayload/curses/menu/m_driver.c b/payloads/libpayload/curses/menu/m_driver.c index deeff47..b2a7145 100644 --- a/payloads/libpayload/curses/menu/m_driver.c +++ b/payloads/libpayload/curses/menu/m_driver.c @@ -180,7 +180,7 @@ or PREV_PATTERN scan this means, that there was no additional match. If we searched with an expanded new pattern, we should never reach this point, because if the expanded pattern matches also the actual - item we will find it in the first attempt (passed==FALSE) and we + item we will find it in the first attempt (passed == FALSE) and we will never cycle through the whole item array. */ assert(ch == 0 || ch == BS); diff --git a/payloads/libpayload/curses/pdcurses-backend/pdckbd.c b/payloads/libpayload/curses/pdcurses-backend/pdckbd.c index c872262..6b5b7ea 100644 --- a/payloads/libpayload/curses/pdcurses-backend/pdckbd.c +++ b/payloads/libpayload/curses/pdcurses-backend/pdckbd.c @@ -149,14 +149,14 @@ #if IS_ENABLED(CONFIG_LP_PC_KEYBOARD) if ((curses_flags & F_ENABLE_CONSOLE) && - keyboard_havechar() && (c==0)) { + keyboard_havechar() && (c == 0)) { c = keyboard_getchar(); } #endif #if IS_ENABLED(CONFIG_LP_SERIAL_CONSOLE) if ((curses_flags & F_ENABLE_SERIAL) && - serial_havechar() && (c==0)) { + serial_havechar() && (c == 0)) { c = cook_serial(serial_getchar()); } #endif diff --git a/payloads/libpayload/drivers/usb/ehci.c b/payloads/libpayload/drivers/usb/ehci.c index 4636e7c..2df74ad 100644 --- a/payloads/libpayload/drivers/usb/ehci.c +++ b/payloads/libpayload/drivers/usb/ehci.c @@ -351,7 +351,7 @@ u8 *end = src + size; int remaining = size; int endp = ep->endpoint & 0xf; - int pid = (ep->direction==IN)?EHCI_IN:EHCI_OUT; + int pid = (ep->direction == IN)?EHCI_IN:EHCI_OUT; int hubaddr = 0, hubport = 0; if (ep->dev->speed < 2) { diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c index 1d7d830..0dfda17 100644 --- a/payloads/libpayload/drivers/usb/ohci.c +++ b/payloads/libpayload/drivers/usb/ohci.c @@ -373,7 +373,7 @@ int first_page = (unsigned long)data / 4096; int last_page = (unsigned long)(data+dalen-1)/4096; if (last_page < first_page) last_page = first_page; - int pages = (dalen==0)?0:(last_page - first_page + 1); + int pages = (dalen == 0)?0:(last_page - first_page + 1); /* First TD. */ td_t *const first_td = (td_t *)dma_memalign(sizeof(td_t), sizeof(td_t)); @@ -467,7 +467,7 @@ OHCI_INST(dev->controller)->opreg->HcCommandStatus = ControlListFilled; int result = wait_for_ed(dev, head, - (dalen==0)?0:(last_page - first_page + 1)); + (dalen == 0)?0:(last_page - first_page + 1)); /* Wait some frames before and one after disabling list access. */ mdelay(4); OHCI_INST(dev->controller)->opreg->HcControl &= ~ControlListEnable; @@ -509,7 +509,7 @@ int first_page = (unsigned long)data / 4096; int last_page = (unsigned long)(data+dalen-1)/4096; if (last_page < first_page) last_page = first_page; - int pages = (dalen==0)?0:(last_page - first_page + 1); + int pages = (dalen == 0)?0:(last_page - first_page + 1); int td_count = (pages+1)/2; if (finalize && ((dalen % ep->maxpacketsize) == 0)) { @@ -571,7 +571,7 @@ memset((void*)head, 0, sizeof(*head)); head->config = (ep->dev->address << ED_FUNC_SHIFT) | ((ep->endpoint & 0xf) << ED_EP_SHIFT) | - (((ep->direction==IN)?OHCI_IN:OHCI_OUT) << ED_DIR_SHIFT) | + (((ep->direction == IN)?OHCI_IN:OHCI_OUT) << ED_DIR_SHIFT) | (ep->dev->speed?ED_LOWSPEED:0) | (ep->maxpacketsize << ED_MPS_SHIFT); head->tail_pointer = virt_to_phys(cur); @@ -588,7 +588,7 @@ OHCI_INST(ep->dev->controller)->opreg->HcCommandStatus = BulkListFilled; int result = wait_for_ed(ep->dev, head, - (dalen==0)?0:(last_page - first_page + 1)); + (dalen == 0)?0:(last_page - first_page + 1)); /* Wait some frames before and one after disabling list access. */ mdelay(4); OHCI_INST(ep->dev->controller)->opreg->HcControl &= ~BulkListEnable; diff --git a/payloads/libpayload/liblz4/lz4.c.inc b/payloads/libpayload/liblz4/lz4.c.inc index baa9110..5ecc790 100644 --- a/payloads/libpayload/liblz4/lz4.c.inc +++ b/payloads/libpayload/liblz4/lz4.c.inc @@ -99,14 +99,14 @@ const char* const source, char* const dest, int inputSize, - int outputSize, /* If endOnInput==endOnInputSize, this value is the max size of Output Buffer. */ + int outputSize, /* If endOnInput == endOnInputSize, this value is the max size of Output Buffer. */ int endOnInput, /* endOnOutputSize, endOnInputSize */ int partialDecoding, /* full, partial */ - int targetOutputSize, /* only used if partialDecoding==partial */ + int targetOutputSize, /* only used if partialDecoding == partial */ int dict, /* noDict, withPrefix64k, usingExtDict */ const BYTE* const lowPrefix, /* == dest if dict == noDict */ - const BYTE* const dictStart, /* only if dict==usingExtDict */ + const BYTE* const dictStart, /* only if dict == usingExtDict */ const size_t dictSize /* note : = 0 if noDict */ ) { @@ -124,15 +124,15 @@ const unsigned dec32table[] = {4, 1, 2, 1, 4, 4, 4, 4}; const int dec64table[] = {0, 0, 0, -1, 0, 1, 2, 3}; - const int safeDecode = (endOnInput==endOnInputSize); + const int safeDecode = (endOnInput == endOnInputSize); const int checkOffset = ((safeDecode) && (dictSize < (int)(64 KB))); const int inPlaceDecode = ((ip >= op) && (ip < oend)); /* Special cases */ if ((partialDecoding) && (oexit> oend-MFLIMIT)) oexit = oend-MFLIMIT; /* targetOutputSize too high => decode everything */ - if ((endOnInput) && (unlikely(outputSize==0))) return ((inputSize==1) && (*ip==0)) ? 0 : -1; /* Empty output buffer */ - if ((!endOnInput) && (unlikely(outputSize==0))) return (*ip==0?1:-1); + if ((endOnInput) && (unlikely(outputSize == 0))) return ((inputSize == 1) && (*ip == 0)) ? 0 : -1; /* Empty output buffer */ + if ((!endOnInput) && (unlikely(outputSize == 0))) return (*ip == 0?1:-1); /* Main Loop */ @@ -155,7 +155,7 @@ s = *ip++; length += s; } - while ( likely(endOnInput ? ip<iend-RUN_MASK : 1) && (s==255) ); + while ( likely(endOnInput ? ip<iend-RUN_MASK : 1) && (s == 255) ); if ((safeDecode) && unlikely((size_t)(op+length)<(size_t)(op))) goto _output_error; /* overflow detection */ if ((safeDecode) && unlikely((size_t)(ip+length)<(size_t)(ip))) goto _output_error; /* overflow detection */ } @@ -198,13 +198,13 @@ if ((endOnInput) && (ip > iend-LASTLITERALS)) goto _output_error; s = *ip++; length += s; - } while (s==255); + } while (s == 255); if ((safeDecode) && unlikely((size_t)(op+length)<(size_t)op)) goto _output_error; /* overflow detection */ } length += MINMATCH; /* check external dictionary */ - if ((dict==usingExtDict) && (match < lowPrefix)) + if ((dict == usingExtDict) && (match < lowPrefix)) { if (unlikely(op+length > oend-LASTLITERALS)) goto _output_error; /* doesn't respect parsing restriction */ -- To view, visit https://review.coreboot.org/25856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie1da925aceb01c2d21b472bf171000803004578f Gerrit-Change-Number: 25856 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: src/console: Add whitespace around '=='
by build bot (Jenkins) (Code Review) 26 Apr '18

26 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25854 ) Change subject: src/console: Add whitespace around '==' ...................................................................... Patch Set 1: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70742/ : SUCCESS -- To view, visit https://review.coreboot.org/25854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61ff3adb573ffc99f37a1cdcbf5d0d83b2dec0ed Gerrit-Change-Number: 25854 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 08:11:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018