coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: atlas: enable trackpad as wake source
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25850 ) Change subject: atlas: enable trackpad as wake source ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24943/ : SUCCESS -- To view, visit https://review.coreboot.org/25850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If800464c8b2319d758b1823850571919f85bdc6c Gerrit-Change-Number: 25850 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 04:05:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: atlas: enable trackpad as wake source
by Caveh Jalali (Code Review) 25 Apr '18

25 Apr '18

Hello caveh jalali, I'd like you to do a code review. Please visit https://review.coreboot.org/25850 to review the following change. Change subject: atlas: enable trackpad as wake source ...................................................................... atlas: enable trackpad as wake source This configures GPP_A23 as a wake source for the trackpad. we also need set up GPP_A GPE0_DW0, thus evicting GPP_B. we don't have any interesting signals in GPP_B, so we won't be missing it. i don't have hardware with A23 wired up, so i just tested the wake source using A19 which is essentially identical to A23. BUG=b:78541883 TEST=verified we can trackpad can wake system from suspend Change-Id: If800464c8b2319d758b1823850571919f85bdc6c Signed-off-by: Caveh Jalali <caveh(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/atlas/gpio.c 2 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/25850/1 diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 4444549..8ae9b05 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -11,7 +11,7 @@ # Note that GPE events called out in ASL code rely on this # route. i.e. If this route changes then the affected GPE # offset bits also need to be changed. - register "gpe0_dw0" = "GPP_B" + register "gpe0_dw0" = "GPP_A" register "gpe0_dw1" = "GPP_D" register "gpe0_dw2" = "GPP_E" @@ -252,8 +252,7 @@ register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)" - # TODO(caveh): fix wake source - #register "wake" = "GPE0_DWx_19" not possible? + register "wake" = "GPE0_DW0_23" # GPP_A23 register "probed" = "1" # may not be present device i2c 0x15 on end end diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c index 58b709e..c1b3ccc 100644 --- a/src/mainboard/google/poppy/variants/atlas/gpio.c +++ b/src/mainboard/google/poppy/variants/atlas/gpio.c @@ -59,8 +59,8 @@ PAD_CFG_NC(GPP_A21), /* A22 : ISH_GP4 */ PAD_CFG_NC(GPP_A22), - /* A23 : ISH_GP5 */ - PAD_CFG_NC(GPP_A23), + /* A23 : ISH_GP5 ==> TRACKPAD_INT_L */ + PAD_CFG_GPI_ACPI_SCI(GPP_A23, NONE, DEEP, INVERT), /* B0 : CORE_VID0 ==> NC(TP42) */ PAD_CFG_NC(GPP_B0), -- To view, visit https://review.coreboot.org/25850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If800464c8b2319d758b1823850571919f85bdc6c Gerrit-Change-Number: 25850 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org>

1 0

Change in coreboot[master]: soc/intel/common: create lockdown folder for common lockdown file
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25688 ) Change subject: soc/intel/common: create lockdown folder for common lockdown file ...................................................................... Patch Set 28: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70732/ : SUCCESS -- To view, visit https://review.coreboot.org/25688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b81bbc54f737cb4e7120f44bbe705039b45ccb3 Gerrit-Change-Number: 25688 Gerrit-PatchSet: 28 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 03:59:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Move soc dependent function from lockdown.c
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25656 ) Change subject: soc/intel/cannonlake: Move soc dependent function from lockdown.c ...................................................................... Patch Set 30: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70731/ : SUCCESS -- To view, visit https://review.coreboot.org/25656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c69e3b1840c30b856b9a3a077302923b31681f Gerrit-Change-Number: 25656 Gerrit-PatchSet: 30 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 03:59:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common: Make infrastructure ready for Intel common non-ip code
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25734 ) Change subject: soc/intel/common: Make infrastructure ready for Intel common non-ip code ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70730/ : SUCCESS -- To view, visit https://review.coreboot.org/25734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac99b4346e8bf6e260b00be9fefede5ad7b3e778 Gerrit-Change-Number: 25734 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 26 Apr 2018 03:58:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy, soraka, nautilus: Enable xDCI
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25849 ) Change subject: mb/google/poppy,soraka,nautilus: Enable xDCI ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/70728/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/24941/ : SUCCESS -- To view, visit https://review.coreboot.org/25849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b0f81bda889b822479ead4d1acc2b613151a304 Gerrit-Change-Number: 25849 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 02:26:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/xdci: Use vboot_can_enable_udc in xdci_can_enable
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25848 ) Change subject: soc/intel/common/block/xdci: Use vboot_can_enable_udc in xdci_can_enable ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/70727/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/24940/ : SUCCESS -- To view, visit https://review.coreboot.org/25848 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia83b91ce17eec782faf5bb318ad8c00c09e2db05 Gerrit-Change-Number: 25848 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 02:26:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add function to check if UDC can be enabled
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25847 ) Change subject: security/vboot: Add function to check if UDC can be enabled ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/70726/ : UNSTABLE -- To view, visit https://review.coreboot.org/25847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id146ac1065f209865372aeb423f66ae734702954 Gerrit-Change-Number: 25847 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 02:21:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/vboot: Add function to read UDC enable flag
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25846 ) Change subject: security/vboot: Add function to read UDC enable flag ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/70725/ : SUCCESS -- To view, visit https://review.coreboot.org/25846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd1e9b0781ffee242d695b72287632bc944a50c7 Gerrit-Change-Number: 25846 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 02:20:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy, soraka, nautilus: Enable xDCI
by build bot (Jenkins) (Code Review) 25 Apr '18

25 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25849 ) Change subject: mb/google/poppy,soraka,nautilus: Enable xDCI ...................................................................... Patch Set 2: No Builds Executed -- To view, visit https://review.coreboot.org/25849 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b0f81bda889b822479ead4d1acc2b613151a304 Gerrit-Change-Number: 25849 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 02:15:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018