Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/25848 )
Change subject: soc/intel/common/block/xdci: Use vboot_can_enable_udc in xdci_can_enable
......................................................................
soc/intel/common/block/xdci: Use vboot_can_enable_udc in xdci_can_enable
This change uses the newly added vboot_can_enable_udc to decide if it
is okay to enable XDCI in vboot developer mode.
BUG=b:78577893
BRANCH=poppy
Change-Id: Ia83b91ce17eec782faf5bb318ad8c00c09e2db05
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/soc/intel/common/block/xdci/xdci.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/25848/2
--
To view, visit https://review.coreboot.org/25848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia83b91ce17eec782faf5bb318ad8c00c09e2db05
Gerrit-Change-Number: 25848
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Hello Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25847
to look at the new patch set (#2).
Change subject: security/vboot: Add function to check if UDC can be enabled
......................................................................
security/vboot: Add function to check if UDC can be enabled
Add a function that will check the various requirements to
enable UDC:
- developer mode enabled
- GBB flag set or VBNV flag set
BUG=b:78577893
BRANCH=poppy
Change-Id: Id146ac1065f209865372aeb423f66ae734702954
Signed-off-by: Duncan Laurie <dlaurie(a)google.com>
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/security/vboot/vboot_common.c
M src/security/vboot/vboot_common.h
2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/25847/2
--
To view, visit https://review.coreboot.org/25847
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id146ac1065f209865372aeb423f66ae734702954
Gerrit-Change-Number: 25847
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Hello Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25846
to look at the new patch set (#2).
Change subject: security/vboot: Add function to read UDC enable flag
......................................................................
security/vboot: Add function to read UDC enable flag
BUG=b:78577893
BRANCH=poppy
Change-Id: Ifd1e9b0781ffee242d695b72287632bc944a50c7
Signed-off-by: Duncan Laurie <dlaurie(a)google.com>
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/security/vboot/vbnv.c
M src/security/vboot/vbnv.h
M src/security/vboot/vbnv_layout.h
3 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/25846/2
--
To view, visit https://review.coreboot.org/25846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd1e9b0781ffee242d695b72287632bc944a50c7
Gerrit-Change-Number: 25846
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/25849
Change subject: mb/google/poppy,soraka,nautilus: Enable xDCI
......................................................................
mb/google/poppy,soraka,nautilus: Enable xDCI
This change enable xDCI controller on poppy, nautilus and soraka.
BUG=b:78577893
BRANCH=poppy
Change-Id: I9b0f81bda889b822479ead4d1acc2b613151a304
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/mainboard/google/poppy/variants/nautilus/devicetree.cb
M src/mainboard/google/poppy/variants/soraka/devicetree.cb
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/25849/1
diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
index 12c62a2..2c004c5 100644
--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
@@ -292,7 +292,7 @@
device pci 00.0 on end # Host Bridge
device pci 02.0 on end # Integrated Graphics Device
device pci 14.0 on end # USB xHCI
- device pci 14.1 off end # USB xDCI (OTG)
+ device pci 14.1 on end # USB xDCI (OTG)
device pci 14.2 on end # Thermal Subsystem
device pci 15.0 on
chip drivers/i2c/hid
diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb
index c0a19e9..8e6f952 100644
--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb
@@ -271,7 +271,7 @@
device pci 00.0 on end # Host Bridge
device pci 02.0 on end # Integrated Graphics Device
device pci 14.0 on end # USB xHCI
- device pci 14.1 off end # USB xDCI (OTG)
+ device pci 14.1 on end # USB xDCI (OTG)
device pci 14.2 on end # Thermal Subsystem
device pci 15.0 on
chip drivers/i2c/hid
--
To view, visit https://review.coreboot.org/25849
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b0f81bda889b822479ead4d1acc2b613151a304
Gerrit-Change-Number: 25849
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Hello Duncan Laurie,
I'd like you to do a code review. Please visit
https://review.coreboot.org/25847
to review the following change.
Change subject: vboot: Add function to check if UDC can be enabled
......................................................................
vboot: Add function to check if UDC can be enabled
Add a function that will check the various requirements to
enable UDC:
- developer mode enabled
- GBB flag set or VBNV flag set
BUG=b:78577893
BRANCH=poppy
Change-Id: Id146ac1065f209865372aeb423f66ae734702954
Signed-off-by: Duncan Laurie <dlaurie(a)google.com>
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
---
M src/security/vboot/vboot_common.c
M src/security/vboot/vboot_common.h
2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/25847/1
diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c
index 11320d2..e7ad376 100644
--- a/src/security/vboot/vboot_common.c
+++ b/src/security/vboot/vboot_common.c
@@ -20,11 +20,14 @@
#include <console/cbmem_console.h>
#include <console/console.h>
#include <fmap.h>
+#include <gbb_header.h>
#include <reset.h>
#include <rules.h>
#include <stddef.h>
#include <string.h>
+#include <security/vboot/gbb.h>
#include <security/vboot/vboot_common.h>
+#include <security/vboot/vbnv.h>
int vboot_named_region_device(const char *name, struct region_device *rdev)
{
@@ -36,6 +39,22 @@
return fmap_locate_area_as_rdev_rw(name, rdev);
}
+/* Read the UDC enable flag from VBNV. */
+int vboot_can_enable_udc(void)
+{
+ /* Always disable if not in developer mode */
+ if (!vboot_developer_mode_enabled())
+ return 0;
+ /* Enable if GBB flag is set */
+ if (gbb_is_flag_set(GBB_FLAG_ENABLE_UDC))
+ return 1;
+ /* Enable if VBNV flag is set */
+ if (vbnv_udc_enable_flag())
+ return 1;
+ /* Otherwise disable */
+ return 0;
+}
+
/* ========================== VBOOT HANDOFF APIs =========================== */
int vboot_get_handoff_info(void **addr, uint32_t *size)
{
diff --git a/src/security/vboot/vboot_common.h b/src/security/vboot/vboot_common.h
index 8c92f7f..53fed15 100644
--- a/src/security/vboot/vboot_common.h
+++ b/src/security/vboot/vboot_common.h
@@ -109,10 +109,12 @@
int vboot_developer_mode_enabled(void);
int vboot_recovery_mode_enabled(void);
int vboot_recovery_mode_memory_retrain(void);
+int vboot_can_enable_udc(void);
#else /* !CONFIG_VBOOT */
static inline int vboot_developer_mode_enabled(void) { return 0; }
static inline int vboot_recovery_mode_enabled(void) { return 0; }
static inline int vboot_recovery_mode_memory_retrain(void) { return 0; }
+static inline int vboot_can_enable_udc(void) { return 0; }
#endif
#endif /* __VBOOT_VBOOT_COMMON_H__ */
--
To view, visit https://review.coreboot.org/25847
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id146ac1065f209865372aeb423f66ae734702954
Gerrit-Change-Number: 25847
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>