coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: nb/intel/x4x: Fix programming CxDRB
by build bot (Jenkins) (Code Review) 05 Apr '18

05 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22911 ) Change subject: nb/intel/x4x: Fix programming CxDRB ...................................................................... Patch Set 12: No Builds Executed -- To view, visit https://review.coreboot.org/22911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ff3264824c843f84b9eb6c06a06aa3f151fe4b3 Gerrit-Change-Number: 22911 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 05 Apr 2018 23:43:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Change memory layout to improve MTRR
by build bot (Jenkins) (Code Review) 05 Apr '18

05 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21634 ) Change subject: nb/intel/x4x: Change memory layout to improve MTRR ...................................................................... Patch Set 14: No Builds Executed -- To view, visit https://review.coreboot.org/21634 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b5ea04d9b7d5494a30aa7156d8c17170e77b8ad Gerrit-Change-Number: 21634 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 05 Apr 2018 23:43:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Add a convenient macro to loop over bytelanes
by build bot (Jenkins) (Code Review) 05 Apr '18

05 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22347 ) Change subject: nb/intel/x4x: Add a convenient macro to loop over bytelanes ...................................................................... Patch Set 11: No Builds Executed -- To view, visit https://review.coreboot.org/22347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a30ffabaf5c845e962e3e79cf4a20faa1d9857 Gerrit-Change-Number: 22347 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 05 Apr 2018 23:43:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Clarify the raminit memory mapping
by build bot (Jenkins) (Code Review) 05 Apr '18

05 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22328 ) Change subject: nb/intel/x4x: Clarify the raminit memory mapping ...................................................................... Patch Set 14: No Builds Executed -- To view, visit https://review.coreboot.org/22328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58923e4a8a756f4ae65f759e7d46e03fad39fab7 Gerrit-Change-Number: 22328 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 05 Apr 2018 23:43:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Implement both read and write training
by build bot (Jenkins) (Code Review) 05 Apr '18

05 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22329 ) Change subject: nb/intel/x4x: Implement both read and write training ...................................................................... Patch Set 17: No Builds Executed -- To view, visit https://review.coreboot.org/22329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacdc63b91b4705d1a80437314bfe55385ea5b6c1 Gerrit-Change-Number: 22329 Gerrit-PatchSet: 17 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Apr 2018 23:43:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/spi/tpm: Add sleep delay after ready cmd.
by Justin TerAvest (Code Review) 05 Apr '18

05 Apr '18

Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/25543 Change subject: drivers/spi/tpm: Add sleep delay after ready cmd. ...................................................................... drivers/spi/tpm: Add sleep delay after ready cmd. This is analogous to a sleep done in the I2C TPM driver to ensure that cr50 has time to process the COMMAND_READY command before receiving any later traffic. This change made the TPM much more reliable (though not perfect). BUG=b:75306520 BRANCH=None TEST=Significantly improved reliability Signed-off-by: Justin TerAvest Change-Id: Ia25467dc60c968b3b3892e59f90f0393161375c8 --- M src/drivers/spi/tpm/tpm.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/25543/1 diff --git a/src/drivers/spi/tpm/tpm.c b/src/drivers/spi/tpm/tpm.c index c0fee46..a7900c6 100644 --- a/src/drivers/spi/tpm/tpm.c +++ b/src/drivers/spi/tpm/tpm.c @@ -38,6 +38,7 @@ #define TPM_FW_VER (TPM_LOCALITY_0_SPI_BASE + 0xf90) #define CR50_TIMEOUT_INIT_MS 30000 /* Very long timeout for TPM init */ +#define CR50_SLEEP_LONG 210 /* in usec */ /* SPI slave structure for TPM device. */ static struct spi_slave g_spi_slave CAR_GLOBAL; @@ -725,6 +726,8 @@ /* Move the TPM back to idle state. */ write_tpm_sts(TPM_STS_COMMAND_READY); + /* Add sleep after sending command ready so TPM has time to process */ + udelay(CR50_SLEEP_LONG); return payload_size; } -- To view, visit https://review.coreboot.org/25543 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia25467dc60c968b3b3892e59f90f0393161375c8 Gerrit-Change-Number: 25543 Gerrit-PatchSet: 1 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>

1 0

Change in coreboot[master]: ioapic: extend definition name to avoid collision
by build bot (Jenkins) (Code Review) 05 Apr '18

05 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25540 ) Change subject: ioapic: extend definition name to avoid collision ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69549/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23861/ : SUCCESS -- To view, visit https://review.coreboot.org/25540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b1c544d0f31340a09e18f4b36c1942ea0fa6ef Gerrit-Change-Number: 25540 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 05 Apr 2018 22:28:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/stoneyridge: Add GNB IOAPIC init
by build bot (Jenkins) (Code Review) 05 Apr '18

05 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25541 ) Change subject: amd/stoneyridge: Add GNB IOAPIC init ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69550/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23862/ : SUCCESS -- To view, visit https://review.coreboot.org/25541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ff8698419890df1459b1107f0861cf8277a99b0 Gerrit-Change-Number: 25541 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 05 Apr 2018 22:08:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/stoneyridge: Add GNB IOAPIC init
by Martin Roth (Code Review) 05 Apr '18

05 Apr '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/25541 ) Change subject: amd/stoneyridge: Add GNB IOAPIC init ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25541/1/src/soc/amd/stoneyridge/northbridge… File src/soc/amd/stoneyridge/northbridge.c: https://review.coreboot.org/#/c/25541/1/src/soc/amd/stoneyridge/northbridge… PS1, Line 82: extra space. -- To view, visit https://review.coreboot.org/25541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ff8698419890df1459b1107f0861cf8277a99b0 Gerrit-Change-Number: 25541 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 05 Apr 2018 22:07:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: ioapic: extend definition name to avoid collision
by Martin Roth (Code Review) 05 Apr '18

05 Apr '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/25540 ) Change subject: ioapic: extend definition name to avoid collision ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Looks good other than the minor issues in the commit message. https://review.coreboot.org/#/c/25540/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25540/1//COMMIT_MSG@7 PS1, Line 7: extra space https://review.coreboot.org/#/c/25540/1//COMMIT_MSG@9 PS1, Line 9: colission collision -- To view, visit https://review.coreboot.org/25540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b1c544d0f31340a09e18f4b36c1942ea0fa6ef Gerrit-Change-Number: 25540 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 05 Apr 2018 22:06:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018